Hello Daniel,
On Thu, 16 May 2024 15:22:01 +0200
Daniel Vetter wrote:
> Apologies for missing v1 ...
>
> On Fri, May 10, 2024 at 09:10:36AM +0200, Luca Ceresoli wrote:
> > DRM hotplug bridge driver
> > =
> >
> > DRM natively sup
Hello Rob,
On Fri, 10 May 2024 11:44:49 -0500
Rob Herring wrote:
> On Fri, May 10, 2024 at 09:10:36AM +0200, Luca Ceresoli wrote:
[...]
> > Overall approach
> >
> >
> > Device tree overlays appear as the most natural solution to support t
Hello Rob,
+cc Srinivas and Miquèl for the NVMEM cell discussion below
On Fri, 10 May 2024 11:36:25 -0500
Rob Herring wrote:
> On Fri, May 10, 2024 at 09:10:37AM +0200, Luca Ceresoli wrote:
> > Add bindings for the GE SUNH add-on connector. This is a physical,
> > hot-plug
Hi Greg, Arnd,
On Fri, 10 May 2024 12:57:24 +0200
"Arnd Bergmann" wrote:
> On Fri, May 10, 2024, at 12:54, Luca Ceresoli wrote:
> > On Fri, 10 May 2024 12:24:06 +0200 "Arnd Bergmann" wrote:
> >> On Fri, May 10, 2024, at 09:55, Greg Kroah-Hartman wrote:
Hello Rob,
On Fri, 10 May 2024 08:22:53 -0500
Rob Herring wrote:
> On Fri, May 10, 2024 at 5:37 AM Luca Ceresoli
> wrote:
> >
> > Hello Rob,
> >
> > On Fri, 10 May 2024 03:41:35 -0500
> > "Rob Herring (Arm)" wrote:
> >
> >
Hello Greg, Arnd,
On Fri, 10 May 2024 12:24:06 +0200
"Arnd Bergmann" wrote:
> On Fri, May 10, 2024, at 09:55, Greg Kroah-Hartman wrote:
> > On Fri, May 10, 2024 at 09:10:41AM +0200, Luca Ceresoli wrote:
> >>
> >> +config GE_SUNH_CONNECTOR
> >>
Hello Greg,
thanks for reviewing.
On Fri, 10 May 2024 08:55:29 +0100
Greg Kroah-Hartman wrote:
> On Fri, May 10, 2024 at 09:10:41AM +0200, Luca Ceresoli wrote:
> > Add a driver to support the runtime hot-pluggable add-on connector on the
> > GE SUNH device. This connector al
Hello Rob,
On Fri, 10 May 2024 03:41:35 -0500
"Rob Herring (Arm)" wrote:
> On Fri, 10 May 2024 09:10:37 +0200, Luca Ceresoli wrote:
> > Add bindings for the GE SUNH add-on connector. This is a physical,
> > hot-pluggable connector that allows to attach and detach at run
-on models can be connected, and each has an EEPROM with a
model identifier at a fixed address.
The add-on hardware is added and removed using device tree overlay loading
and unloading.
Co-developed-by: Herve Codina
Signed-off-by: Herve Codina
Signed-off-by: Luca Ceresoli
---
This commit is new
Supporting hardware whose final part of the DRM pipeline can be physically
removed requires the ability to detach all bridges from a given point to
the end of the pipeline.
Introduce a variant of drm_encoder_cleanup() for this.
Signed-off-by: Luca Ceresoli
---
Changed in v2:
- fix a typo
hoc lookup is
needed
The code handling these and other tricky aspects is accurately documented
by comments in the code.
Co-developed-by: Paul Kocialkowski
Signed-off-by: Paul Kocialkowski
Signed-off-by: Luca Ceresoli
---
Changed in v2:
- change to be a platform device instantiated from the conn
From: Paul Kocialkowski
In preparation for allowing bridges to be added to and removed from a DRM
card without destroying the whole card, add a DRM bridge notifier. Notified
events are addition and removal to/from the global bridge list.
Co-developed-by: Luca Ceresoli
Signed-off-by: Luca
Add bindings for the GE SUNH add-on connector. This is a physical,
hot-pluggable connector that allows to attach and detach at runtime an
add-on adding peripherals on non-discoverable busses.
Signed-off-by: Luca Ceresoli
---
NOTE: the second and third examples fail 'make dt_binding_check
no activity recently about this. Continuing this work in on my
todo list.
[1] https://lore.kernel.org/all/20240430083730.134918-1-herve.cod...@bootlin.com
That's all
==
Thanks for you patience in reading this!
Luca
Changes in v2:
- Added bindings and driver for ge,sunh-addon-connector
-
ore.kernel.org/all/15244220.uLZWGnKmhe@steina-w/
Fixes: 8a91b29f1f50 ("drm/bridge: ti-sn65dsi83: Fix enable error path")
Reviewed-by: Alexander Stein
Signed-off-by: Luca Ceresoli
---
Many thanks to Alexander for the discussion.
---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 1 -
1 file changed
Hi Maxime,
On Wed, 27 Mar 2024 17:08:49 +0100
Luca Ceresoli wrote:
[...]
> > There's several additional hurdles there:
> >
> > - You mentioned the connector in your ideal scenario. But as soon as
> >you remove the last bridge, the connector will probably go away
Hello Rob,
[+Cc Wolfram for the I2C discussion below]
thanks for your feedback.
On Wed, 27 Mar 2024 11:09:08 -0500
Rob Herring wrote:
> On Tue, Mar 26, 2024 at 05:28:11PM +0100, Luca Ceresoli wrote:
> > Add bindings for a physical, hot-pluggable connector allowing the far end
>
Hi Maxime,
On Wed, 27 Mar 2024 13:42:40 +0100
Maxime Ripard wrote:
> On Tue, Mar 26, 2024 at 05:28:14PM +0100, Luca Ceresoli wrote:
> > This driver implements the point of a DRM pipeline where a connector allows
> > removal of all the following bridges up to the panel.
&
hoc lookup is
needed
The code handling these and other tricky aspects is accurately documented
by comments in the code.
Co-developed-by: Paul Kocialkowski
Signed-off-by: Paul Kocialkowski
Signed-off-by: Luca Ceresoli
---
MAINTAINERS | 1 +
drivers/gpu/drm/bridge/Kconfi
Supporting hardware whose final part of the DRM pipeline can be physically
removed requires the ability to detach all bridges from a given point to
the end of the pipeline.
Introduce a variant of drm_encoder_cleanup() for this.
Signed-off-by: Luca Ceresoli
---
drivers/gpu/drm/drm_encoder.c
Add bindings for a physical, hot-pluggable connector allowing the far end
of a MIPI DSI bus to be connected and disconnected at runtime.
Signed-off-by: Luca Ceresoli
---
.../bridge/hotplug-video-connector-dsi.yaml| 87 ++
MAINTAINERS
From: Paul Kocialkowski
In preparation for allowing bridges to be added to and removed from a DRM
card without destroying the whole card, add a DRM bridge notifier. Notified
events are addition and removal to/from the global bridge list.
Co-developed-by: Luca Ceresoli
Signed-off-by: Luca
tested by other
means, even with a hardware that has no removable parts, "pretending" that
one or more bridges can be removed:
* remove and re-insert the driver module for the DRM bridge after the
hotplug-bridge
* unbind/bind the DRM bridge after the hotplug-bridge from its drive
inux-6.4/drivers/video/fbdev/core/fbcon.c
Apparently you are not using git to track your changes, so I recommend
using it to have all the git utilities available.
Best regards,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Hello Alexander,
On Fri, 01 Mar 2024 11:45:27 +0100
Alexander Stein wrote:
> Hi Luca,
>
> Am Freitag, 1. März 2024, 11:10:59 CET schrieb Luca Ceresoli:
> > Hello Alexander,
> >
> > On Fri, 01 Mar 2024 10:57:37 +0100
> > Alexander Stein wrote:
> >
&g
ore.kernel.org/all/15244220.uLZWGnKmhe@steina-w/
Fixes: 8a91b29f1f50 ("drm/bridge: ti-sn65dsi83: Fix enable error path")
Signed-off-by: Luca Ceresoli
---
Many thanks to Alexander for the discussion.
---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/dri
Hello Alexander,
On Fri, 01 Mar 2024 10:57:37 +0100
Alexander Stein wrote:
> Hi Luca,
>
> Am Freitag, 1. März 2024, 10:44:49 CET schrieb Luca Ceresoli:
> > Hello Alexander,
> >
> > On Thu, 29 Feb 2024 12:11:23 +0100
> > Alexander Stein wrote:
> >
&g
Hello Alexander,
On Thu, 29 Feb 2024 12:11:23 +0100
Alexander Stein wrote:
> Hi Luca,
>
> Am Donnerstag, 29. Februar 2024, 10:47:23 CET schrieb Luca Ceresoli:
> > Hello Alexander,
> >
> > On Wed, 28 Feb 2024 09:15:46 +0100
> > Alexander Stein wrote:
>
On Thu, 29 Feb 2024 11:48:27 +0100
Frieder Schrempf wrote:
> On 29.02.24 10:47, Luca Ceresoli wrote:
> > Hello Alexander,
> >
> > On Wed, 28 Feb 2024 09:15:46 +0100
> > Alexander Stein wrote:
> >
> >
> > [...]
> >
> >&
regulator_disable(ctx->vcc);
> return;
> }
> --->8---
>
> So my patch indeed did fix an actual problem. On the other hand it seems
> sn65dsi83_atomic_disable is not called in my case for some reason.
So you remove the module and atomic_disable is not called, after
having called atomic_pre_enable?
I'm very possibly missing something, but this looks like a bug in the
DRM bridge code at first sight.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Hi Alexander,
thanks for your feedback!
On Tue, 27 Feb 2024 13:05:46 +0100
Alexander Stein wrote:
> Hi Luca,
>
> Am Donnerstag, 22. Februar 2024, 16:36:37 CET schrieb Luca Ceresoli:
> > Hello Alexander,
> >
> > On Thu, 4 May 2023 08:53:16 +0200
_atomic_pre_enable()
locally and it worked fine. Then I did some git log and found you added this
line on
purpose (even though it was in sn65dsi83_atomic_enable() initially), so my
question
is whether you can explain exactly what was wrong before your patch. I have been
working for a few weeks with
wed-by: Laurent Pinchart
> Tested-by: Marek Vasut
> Tested-by: Adam Ford #imx8mp-beacon
> Tested-by: Richard Leitner
> Tested-by: Frieder Schrempf
> Tested-by: Luca Ceresoli
> Signed-off-by: Adam Ford
Reviewed-by: Luca Ceresoli
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
i_tx_from_pvi: endpoint {
> + remote-endpoint = <_to_hdmi_tx>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + hdmi_tx_out: endpoint {
Two excess indenting spaces on this line (port@0 is correct).
Also, I think there should an empty line between properties and nodes.
With these fixed:
Reviewed-by: Luca Ceresoli
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Ford
Reviewed-by: Luca Ceresoli
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
n");
> +
> + ret = of_clk_add_provider(np, of_clk_src_simple_get, phyclk);
Ouch:
> This function is *deprecated*. Use of_clk_add_hw_provider() instead.
Appears as an easy replacement though.
Otherwise looks good.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
On Sat, 3 Feb 2024 10:52:41 -0600
Adam Ford wrote:
> From: Lucas Stach
>
> Add a DT binding for the HDMI PHY found on the i.MX8MP SoC.
>
> Signed-off-by: Lucas Stach
> Signed-off-by: Adam Ford
> Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Luca Ceresoli
--
L
ce is the LCDIF. The block
> just needs to be powered up and told about the polarity of the video
> sync signals to act in bypass mode.
>
> Signed-off-by: Lucas Stach
> Reviewed-by: Luca Ceresoli (v2)
> Tested-by: Marek Vasut (v1)
> Tested-by: Luca Ceresoli (v2)
> Tested-by: Ric
however I also tested this
version which works as well, on v6.8-rc1, custom hardware based on the
Avnet i.MX8MP SMARC SoM.
Tested-by: Luca Ceresoli
Generally speaking, as there are several small patch series around which
together implement HDMI on iMX8MP and similar, I think it would be much
easier fore
r this function would probably be
of_graph_get_next_port_endpoint() I guess, to clearly differentiate from
of_graph_get_next_device_endpoint().
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
ase and upstream the rest.
I agree as well, "release early, release often". These patches are
around since a long time and lots of people are using them already, and
tracking all of them from different threads is time-consuming. I will
happily test them early as soon as they are sent.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
/
Suggested-by: Rob Herring
Signed-off-by: Luca Ceresoli
---
Documentation/devicetree/bindings/display/ilitek,ili9486.yaml | 4
Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml | 4
Documentation/devicetree/bindings/display/sitronix,st7735r.yaml | 5 -
3 files
> +#include
> +
> +display-bridge@32fc4000 {
> +compatible = "fsl,imx8mp-hdmi-pvi";
> +reg = <0x32fc4000 0x40>;
The device has up to register 0x40, thus I guess the second value should
be 0x44 here. Or maybe 0x100, just to be comfortable. :)
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
ck
> just needs to be powered up and told about the polarity of the video
> sync signals to act in bypass mode.
>
> Signed-off-by: Lucas Stach
> Reviewed-by: Luca Ceresoli (v2)
I was in Cc on your v3 but not on this v4. Maybe the " (v2)" on these
lines confuses get_maintai
fg.flags;
> +
> + if (bus_flags & DRM_BUS_FLAG_DE_HIGH)
> + val |= PVI_CTL_OP_DE_POL | PVI_CTL_INP_DE_POL;
> +
> + writel(val, pvi->regs + HTX_PVI_CTL);
> + val |= PVI_CTL_EN;
> + writel(val, pvi->regs + HTX_PVI_CTL);
I guess I'm missing something here: why can't one just write the
register once, with the enable bit set? I tried removing the first
writel() and everything seems to work just the same.
With these fixed:
Reviewed-by: Luca Ceresoli
And definitely:
[Tested on a custom board using modetest on v6.5-rc6]
Tested-by: Luca Ceresoli
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Pinchart
> Tested-by: Marek Vasut
I realized I had sent my Tested-by to v1 when v2 was already out. So,
in case you still need some encouragement for keeping on with this
series:
[Tested on a custom board using modetest on v6.5-rc6]
Tested-by: Luca Ceresoli
--
Luca Ceresoli, Bootlin
Embe
ally works
with the intended 70.93 MHz clock and even lower frequencies so the
flickering is likely caused either by a defective unit or by other
different components such as the bridge.
Fixes: eae7488814b5 ("drm/panel-simple: Add Innolux G156HCE-L01 panel entry")
Signed-off-by: Luca Ceresoli
Te
Hello Neil,
On Mon, 14 Aug 2023 14:38:51 +0200
Neil Armstrong wrote:
> On 04/08/2023 17:10, Luca Ceresoli wrote:
> > This panel has been implemented in commit 225213f24c79 ("drm/panel-simple:
> > Add Innolux G156HCE-L01 panel entry") with a higher clock than the
Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller
connected over SPI and the "ShenZhen New Display Co NDS040480800-V3"
480x800 panel based on it.
Signed-off-by: Luca Ceresoli
---
Changes in v2:
- remove T: line form MAINTAINERS entry
- reference spi-
Add a driver for the ILITEK ILI9806E 480x864 RGB LCD controller connected
over SPI, and implement the ShenZhen New Display Co NDS040480800-V3 480x800
panel.
Signed-off-by: Luca Ceresoli
---
Changes in v2:
- add ILI9806E_P1_DISCTRL1 bit description
---
MAINTAINERS
ShenZhen New Display Co., Limited is the manufacturer of the
NDS040480800-V3 LCD panel according the datasheet.
Signed-off-by: Luca Ceresoli
---
Changes in v2: none
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation
el")
Signed-off-by: Luca Ceresoli
---
drivers/gpu/drm/panel/panel-simple.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c
b/drivers/gpu/drm/panel/panel-simple.c
index 701013b3ad13..56854f78441e 100644
-
ally works
with the intended 70.93 MHz clock and even lower frequencies so the
flickering is likely caused either by a defective unit or by other
different components such as the bridge.
Fixes: 225213f24c79 ("drm/panel-simple: Add Innolux G156HCE-L01 panel entry")
Signed-off-by: Luca Ceresoli
Hi Marek, Neil,
On Fri, 4 Aug 2023 10:19:12 +0200
Luca Ceresoli wrote:
> Hi Marek,
>
> On Thu, 3 Aug 2023 19:10:35 +0200
> Marek Vasut wrote:
>
> > On 8/3/23 17:06, Luca Ceresoli wrote:
> > > Hi Marek,
> > >
> > > On Thu, 3
Hi Marek,
On Thu, 3 Aug 2023 19:10:35 +0200
Marek Vasut wrote:
> On 8/3/23 17:06, Luca Ceresoli wrote:
> > Hi Marek,
> >
> > On Thu, 3 Aug 2023 16:25:37 +0200
> > Marek Vasut wrote:
> >
> >> On 8/3/23 16:23, Luca Ceresoli wrote:
> >>>
Hi Marek,
On Thu, 3 Aug 2023 16:25:37 +0200
Marek Vasut wrote:
> On 8/3/23 16:23, Luca Ceresoli wrote:
> > Hi Marek,
>
> Hi,
>
> > On Mon, 31 Jul 2023 23:02:58 +0200
> > Marek Vasut wrote:
> >
> >> Add support for Innolux G156HCE-L01 15.6&q
the 144 MHz clock is kept, I'd add a comment here to clarify
the reason for diverging from the datasheet without the need for git
log.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Hello Rob,
thanks for reviewing.
On Wed, 19 Jul 2023 13:02:54 -0600
Rob Herring wrote:
> On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote:
> > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller
> > connected over SPI and the "She
Hello Krzysztof,
thanks for reviewing.
On Wed, 19 Jul 2023 21:12:14 +0200
Krzysztof Kozlowski wrote:
> On 19/07/2023 17:21, Luca Ceresoli wrote:
> > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller
> > connected over SPI and the "ShenZhen New Displa
Hello Conor,
thanks for reviewing.
On Wed, 19 Jul 2023 17:44:45 +0100
Conor Dooley wrote:
> Hey Luca,
>
> On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote:
> > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller
> > connected over SPI
Add a driver for the ILITEK ILI9806E 480x864 RGB LCD controller connected
over SPI, and implement the ShenZhen New Display Co NDS040480800-V3 480x800
panel.
Signed-off-by: Luca Ceresoli
---
MAINTAINERS | 1 +
drivers/gpu/drm/panel/Kconfig
ShenZhen New Display Co., Limited is the manufacturer of the
NDS040480800-V3 LCD panel according the datasheet.
Signed-off-by: Luca Ceresoli
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor
Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller
connected over SPI and the "ShenZhen New Display Co NDS040480800-V3"
480x800 panel based on it.
Signed-off-by: Luca Ceresoli
---
.../display/panel/ilitek,ili9806e.yaml| 69 +++
M
These variables are never referenced in the code.
Signed-off-by: Luca Ceresoli
---
drivers/gpu/drm/panel/panel-samsung-db7430.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-samsung-db7430.c
b/drivers/gpu/drm/panel/panel-samsung-db7430.c
index 117b26845083
Hi Hans,
On Fri, 14 Apr 2023 17:51:34 +0200
Hans Verkuil wrote:
> Hi Luca,
>
> I just encountered an error in this patch, so I have rejected the PR I made.
>
> See below for the details:
>
> On 07/04/2023 15:38, Luca Ceresoli wrote:
> > The CSI module does n
from a vendor kernel based on Linux 3.1 and
massively adapted to fit into the tegra-video driver. Parts of this code is
definitely non-optimal to say the least (especially tegra20_vi_enable() and
the single-frame capture logic), but it was impossible to improve it.
Signed-off-by: Luca Ceresoli
rt offsets
- an optional per-soc VI operation to compute those values on queue setup
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra-video
implementation that simply sets two flags in the
channel struct. The Tegra20 implementation will enable flipping at stream
start based on those flags.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
Changed in v5:
- Fixed typo in comment
Changed in v4:
- Added
In preparation to implement Tegra20 parallel video capture, add a variable
to hold the required syncpt and document all the syncpt variables.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
No changes in v5
Changed in v4:
- Added review tags
Changed in v3
`struct tegra_vi_ops` .
No functional changes.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra-video/tegra210.c | 52
The Tegra20 VI needs an additional operation to enable the VI, add an
operation for that.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra
it.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
Changed in v6:
- Fix unlock imbalance on Tegra210 (thanks Hans for reporting!)
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra-video/csi.c | 44
.
No functional changes. The format pointed to is the same that used to be in
vi.c.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
Changed in v5:
- Minor update after removal of "staging: media: tegra-video: fix
.vidioc_enum_fmt_vid_cap to return all formats&q
There is only a pointer reference to struct tegra_vi in video.h, thus vi.h
is not needed.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra
to tegra210.c the T210-specific defines used in the moved code.
No functional changes.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra-video
We are about to add support for the Tegra20 parallel video capture, which
has no TPG. In preparation for that, limit the VIDEO_TEGRA_TPG option to
Tegra210 which is the only implementation currently provided by this
driver.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
struct tegra_vi_graph_entity is an internal implementation detail of the VI
module. Move its declaration from vi.h to vi.c.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
This declaration is used only in csi.c, no need to export it elsewhere.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
No changes in v5
Changed in v4:
- Added review tags
This patch was added in v3.
---
drivers/staging/media/tegra-video/csi.c | 4
Add "skip" in "so we can *skip* the current channel" or it doesn't make
sense.
Also add articles where appropriate to fix English grammar.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
No changes in v5
Changed in v4:
- Added review ta
of_node_put(node) does nothing if node == NULL, so it can be moved to the
cleanup section at the bottom.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging
print
two messages, and in case 1 we only print a generic message.
Remove the generic message and add a specific message when case 1 happens,
so that we always have one specific message without even increasing the
number of dev_dbg*() calls.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenk
Some fields are irrelevant for Tegra20/VIP. Add a note to clarify that.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra-video/vi.h | 6
Clarify what this function does.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v6
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra-video/vi.c | 3 +++
1 file changed, 3 insertions(+)
diff
The Tegra20 VI peripheral can receive parallel input from the VIP parallel
input module. Add it to the allowed properties and augment the existing
nvidia,tegra20-vi example to show a 'vip' property.
Signed-off-by: Luca Ceresoli
Reviewed-by: Rob Herring
---
No changes in v6
No changes in v5
VIP is the parallel video capture component within the video input
subsystem of Tegra20 (and other Tegra chips, apparently).
Signed-off-by: Luca Ceresoli
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Dmitry Osipenko
---
No changes in v6
No changes in v5
Changed in v4:
- Added review tags
ore.kernel.org/linux-media/20221229133205.981397-1-luca.ceres...@bootlin.com/
[v2] https://lore.kernel.org/linux-tegra/20221222100328.6e341874@booty/T/#t
[v1] https://lore.kernel.org/linux-tegra/20221124155634.5bc2a423@booty/T/#t
Luca
Luca Ceresoli (20):
dt-bindings: display: tegra: add Tegra
Hello Hans,
On Fri, 7 Apr 2023 15:38:32 +0200
Luca Ceresoli wrote:
> New in v5: dropped the patch that was removing lots of the logic behind
> enum_format, after discussion with Hans. The rest is unmodified except for
> rebasing and fixing a couple typos in comments.
>
> Full
from a vendor kernel based on Linux 3.1 and
massively adapted to fit into the tegra-video driver. Parts of this code is
definitely non-optimal to say the least (especially tegra20_vi_enable() and
the single-frame capture logic), but it was impossible to improve it.
Signed-off-by: Luca Ceresoli
implementation that simply sets two flags in the
channel struct. The Tegra20 implementation will enable flipping at stream
start based on those flags.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
Changed in v5:
- Fixed typo in comment
Changed in v4:
- Added review tags
No changes
rt offsets
- an optional per-soc VI operation to compute those values on queue setup
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra-video/vi.c | 4
drive
In preparation to implement Tegra20 parallel video capture, add a variable
to hold the required syncpt and document all the syncpt variables.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v5
Changed in v4:
- Added review tags
Changed in v3:
- recycle
`struct tegra_vi_ops` .
No functional changes.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra-video/tegra210.c | 52
drivers/staging/media
it.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra-video/csi.c | 44
drivers/staging/media/tegra-video/vi.c | 54
The Tegra20 VI needs an additional operation to enable the VI, add an
operation for that.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra-video/vi.c | 7
.
No functional changes. The format pointed to is the same that used to be in
vi.c.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
Changed in v5:
- Minor update after removal of "staging: media: tegra-video: fix
.vidioc_enum_fmt_vid_cap to return all formats" patch
Cha
to tegra210.c the T210-specific defines used in the moved code.
No functional changes.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra-video/tegra210.c | 36
We are about to add support for the Tegra20 parallel video capture, which
has no TPG. In preparation for that, limit the VIDEO_TEGRA_TPG option to
Tegra210 which is the only implementation currently provided by this
driver.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
There is only a pointer reference to struct tegra_vi in video.h, thus vi.h
is not needed.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers/staging/media/tegra-video/video.h | 1
struct tegra_vi_graph_entity is an internal implementation detail of the VI
module. Move its declaration from vi.h to vi.c.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v5
Changed in v4:
- Added review tags
No changes in v3
No changes in v2
---
drivers
This declaration is used only in csi.c, no need to export it elsewhere.
Signed-off-by: Luca Ceresoli
Reviewed-by: Dmitry Osipenko
---
No changes in v5
Changed in v4:
- Added review tags
This patch was added in v3.
---
drivers/staging/media/tegra-video/csi.c | 4
drivers/staging/media
1 - 100 of 246 matches
Mail list logo
