Re: [PATCH v4 05/16] SoC: mediatek: mt8365: support audio clock control

2024-04-29 Thread Mark Brown
On Fri, Apr 26, 2024 at 07:22:34PM +0200, Alexandre Mergnat wrote: > Add audio clock wrapper and audio tuner control. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in

Re: [PATCH v3 07/13] drm: Make drivers depends on DRM_DW_HDMI

2024-04-22 Thread Mark Brown
On Tue, Apr 02, 2024 at 04:43:46PM +0100, Mark Brown wrote: > On Wed, Mar 27, 2024 at 11:57:02AM +0100, Maxime Ripard wrote: > > > DRM_DW_HDMI has a number of dependencies that might not be enabled. > > However, drivers were used to selecting it while not enforcing t

Re: [PATCH 0/7] drm/display: Fix display helpers depends on fallouts

2024-04-15 Thread Mark Brown
On Mon, Apr 15, 2024 at 01:21:47PM +0200, Maxime Ripard wrote: > On Wed, Apr 10, 2024 at 07:06:39PM +0100, Mark Brown wrote: > > Is there any news on getting the rest of this merged? It's been more > > than a week now and the Designware display controllers are all still >

Re: [PATCH 0/7] drm/display: Fix display helpers depends on fallouts

2024-04-10 Thread Mark Brown
On Wed, Apr 03, 2024 at 12:56:18PM +0200, Maxime Ripard wrote: > Hi, > > Here's a series addressing the various regressions that were reported > after the Kconfig rework for the DRM display helpers. > > Let me know what you think, > Maxime Is there any news on getting the rest of this merged?

Re: [PATCH 0/7] drm/display: Fix display helpers depends on fallouts

2024-04-03 Thread Mark Brown
so Reviewed-by: Mark Brown Between the arm64 defconfig update not applying on -next and unrelated breakage on arm I didn't actually do a proper test. signature.asc Description: PGP signature

Re: [PATCH v3 07/13] drm: Make drivers depends on DRM_DW_HDMI

2024-04-02 Thread Mark Brown
On Wed, Mar 27, 2024 at 11:57:02AM +0100, Maxime Ripard wrote: > DRM_DW_HDMI has a number of dependencies that might not be enabled. > However, drivers were used to selecting it while not enforcing the > DRM_DW_HDMI dependencies. > > This could result in Kconfig warnings (and further build

Re: (subset) [PATCH v2 0/4] drm: xlnx: zynqmp: Add DP audio support

2024-03-26 Thread Mark Brown
On Tue, 19 Mar 2024 10:22:35 +0200, Tomi Valkeinen wrote: > Add DisplayPort audio support for Xilinx ZynqMP platforms. > > This depends on patch adding cyclic DMA mode for DPDMA driver: > > https://lore.kernel.org/all/20240228042124.3074044-3-vishal.sa...@amd.com/ > > If that patch is missing,

Re: (subset) [PATCH 0/4] drm: xlnx: zynqmp: Add DP audio support

2024-03-26 Thread Mark Brown
On Tue, 12 Mar 2024 11:41:01 +0200, Tomi Valkeinen wrote: > Add DisplayPort audio support for Xilinx ZynqMP platforms. > > This depends on patch adding cyclic DMA mode for DPDMA driver: > > https://lore.kernel.org/all/20240228042124.3074044-3-vishal.sa...@amd.com/ > > If that patch is missing,

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Mark Brown
On Fri, Mar 15, 2024 at 06:36:19PM +0100, Alexandre Mergnat wrote: > On 15/03/2024 16:15, Mark Brown wrote: > > On Fri, Mar 15, 2024 at 04:05:21PM +0100, Alexandre Mergnat wrote: > > > > In the register. You only need to reset the gain to -40dB at the start > > &g

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Mark Brown
On Fri, Mar 15, 2024 at 04:05:21PM +0100, Alexandre Mergnat wrote: > On 15/03/2024 15:30, Mark Brown wrote: > > > Let me know, when you change de gain to do a ramp down (start from user > > > gain > > > to gain=-40db), next time for the ramp up, how/where d

Re: [PATCH 00/18] Add audio support for the MediaTek Genio 350-evk board

2024-03-15 Thread Mark Brown
On Tue, Mar 12, 2024 at 09:58:05AM +0100, Alexandre Mergnat wrote: > I'm a bit lost for mixer-test and pcm-test. > Currently, I cross-compile the alsa lib project to be able to build the > tests and put it on my board. > I can execute it, but I still have 2 issues: > 1) I've a lot of missing

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Mark Brown
On Fri, Mar 15, 2024 at 12:01:12PM +0100, Alexandre Mergnat wrote: > On 13/03/2024 18:23, Mark Brown wrote: > > On Tue, Mar 12, 2024 at 07:03:25PM +0100, Alexandre Mergnat wrote: > > > Actually you must save the values because the gain selected by the user > > > w

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-13 Thread Mark Brown
On Wed, Mar 13, 2024 at 06:11:50PM +0100, Alexandre Mergnat wrote: > On 26/02/2024 17:09, Mark Brown wrote: > > > index ..13e95c227114 > > > --- /dev/null > > > +++ b/sound/soc/codecs/mt6357.c > > > @@ -0,0 +1,1805 @@ >

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-13 Thread Mark Brown
On Tue, Mar 12, 2024 at 07:03:25PM +0100, Alexandre Mergnat wrote: > On 26/02/2024 17:09, Mark Brown wrote: > > > + case MT6357_ZCD_CON2: > > > + regmap_read(priv->regmap, MT6357_ZCD_CON2, ); > > > + priv->ana_gain[ANALOG_VOLUME_HP

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-01 Thread Mark Brown
On Fri, Mar 01, 2024 at 12:27:13PM +0200, Nikolai Kondrashov wrote: > On 2/29/24 10:21 PM, Linus Torvalds wrote: > > We already have the situation that the drm people have their own ci > > model. II'm ok with that, partly because then at least the maintainers > > of that subsystem can agree on

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Mark Brown
On Thu, Feb 29, 2024 at 01:19:19PM +0200, Laurent Pinchart wrote: > On Thu, Feb 29, 2024 at 01:10:16PM +0200, Nikolai Kondrashov wrote: > > Of course. You're also welcome to join the #kernelci channel on libera.chat. > Isn't that a bit pointless if it's no the main IM channel ? It *was* the

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Mark Brown
On Thu, Feb 29, 2024 at 09:39:01AM +, Sakari Ailus wrote: > On Thu, Feb 29, 2024 at 01:07:25AM +0200, Laurent Pinchart wrote: > > > We have a Slack channel, #gitlab-ci, on the KernelCI Slack instance > > > https://kernelci.slack.com/ . > > > Feel free to join and contribute to the

Re: [PATCH v5 7/8] ASoC: dt-bindings: xmos, xvf3500: add XMOS XVF3500 voice processor

2024-02-28 Thread Mark Brown
On Wed, Feb 28, 2024 at 02:51:34PM +0100, Javier Carrasco wrote: > The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit > multicore controller for voice processing. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 00/18] Add audio support for the MediaTek Genio 350-evk board

2024-02-27 Thread Mark Brown
On Mon, Feb 26, 2024 at 03:01:38PM +0100, Alexandre Mergnat wrote: > This serie aim to add the following audio support for the Genio 350-evk: > - Playback > - 2ch Headset Jack (Earphone) > - 1ch Line-out Jack (Speaker) > - 8ch HDMI Tx > - Capture > - 1ch DMIC (On-board Digital Microphone)

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-02-26 Thread Mark Brown
On Mon, Feb 26, 2024 at 03:01:50PM +0100, amerg...@baylibre.com wrote: > index ..13e95c227114 > --- /dev/null > +++ b/sound/soc/codecs/mt6357.c > @@ -0,0 +1,1805 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * MT6357 ALSA SoC audio codec driver > + * Please use a C++ comment

Re: (subset) [PATCH v2 00/33] spi: get rid of some legacy macros

2024-02-12 Thread Mark Brown
On Mon, 22 Jan 2024 19:06:55 +0100, Uwe Kleine-König wrote: > this is v2 of this patch set. > > Changes since (implicit) v1, sent with Message-Id: > cover.1705348269.git.u.kleine-koe...@pengutronix.de: > > - Rebase to v6.8-rc1 > - Fix a build failure on sh > - Added the tags received in

Re: [PATCH v3 00/32] spi: get rid of some legacy macros

2024-02-08 Thread Mark Brown
On Wed, 07 Feb 2024 19:40:14 +0100, Uwe Kleine-König wrote: > Changes since v2 > (https://lore.kernel.org/linux-spi/cover.1705944943.git.u.kleine-koe...@pengutronix.de): > > - Drop patch "mtd: rawnand: fsl_elbc: Let .probe retry if local bus is >missing" which doesn't belong into this

Re: [PATCH v2 00/33] spi: get rid of some legacy macros

2024-01-24 Thread Mark Brown
On Wed, Jan 24, 2024 at 09:13:49AM -0800, Greg Kroah-Hartman wrote: > On Mon, Jan 22, 2024 at 07:06:55PM +0100, Uwe Kleine-König wrote: > > Note that Jonathan Cameron has already applied patch 3 to his tree, it > > didn't appear in a public tree though yet. I still included it here to > > make

Re: [PATCH v2 00/33] spi: get rid of some legacy macros

2024-01-22 Thread Mark Brown
On Mon, Jan 22, 2024 at 07:06:55PM +0100, Uwe Kleine-König wrote: > Note that Jonathan Cameron has already applied patch 3 to his tree, it > didn't appear in a public tree though yet. I still included it here to > make the kernel build bots happy. It's also going to be needed for buildability of

Re: [PATCH 00/33] spi: get rid of some legacy macros

2024-01-16 Thread Mark Brown
On Mon, Jan 15, 2024 at 09:12:46PM +0100, Uwe Kleine-König wrote: > In commit 8caab75fd2c2 ("spi: Generalize SPI "master" to "controller"") > some functions were renamed. Further some compat defines were introduced > to map the old names to the new ones. > Patch #18 and #19 touch the same

Re: [PATCH v8 1/6] pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()

2023-12-12 Thread Mark Brown
an alternative would be to split the patch. > > Missing Acks so far: > > - Jean Delvare / Guenter Roeck for drivers/hwmon/pwm-fan.c > > - Javier Martinez Canillas for drivers/gpu/drm/solomon/ssd130x.c > > - Liam Girdwood / Mark Brown for drivers/regulator/pwm-regul

Re: [PATCH RESEND v2 1/3] drm/encoder: register per-encoder debugfs dir

2023-12-05 Thread Mark Brown
On Sun, Dec 03, 2023 at 02:53:13PM +0300, Dmitry Baryshkov wrote: > Each of connectors and CRTCs used by the DRM device provides debugfs > directory, which is used by several standard debugfs files and can > further be extended by the driver. Add such generic debugfs directories > for encoder.

Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes

2023-11-24 Thread Mark Brown
On Wed, Nov 08, 2023 at 01:58:36PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The VDSO functions are defined as globals in the kernel sources but intended > to be called from userspace, so there is no need to declare them in a kernel > side header. This is in -next as commit

Re: [PATCH 11/17] ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC

2023-11-08 Thread Mark Brown
ocumentation/devicetree/bindings/writing-bindings.rst state that: Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH] drm/bridge: adv7511: Convert to use maple tree register cache

2023-10-01 Thread Mark Brown
On Sat, Sep 30, 2023 at 12:38:17AM +0300, Laurent Pinchart wrote: > Out of curiosity, is this part of an effort to drop the rbtree cache ? Probably, yes - there's probably some drivers where it will make sense. signature.asc Description: PGP signature

[PATCH] drm/bridge: sn65dsi83: Convert to use maple tree register cache

2023-10-01 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2

[PATCH] drm/bridge: lt9211: Convert to use maple tree register cache

2023-10-01 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/bridge/lontium-lt9211.c | 2

[PATCH 2/2] drm/panel: ili9322: Convert to use maple tree register cache

2023-10-01 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/panel/panel-ilitek-ili9322.c

[PATCH 0/2] drm/panel: ili9322: Minor regmap improvements

2023-10-01 Thread Mark Brown
These two patches provide some minor improvements to the ili9322 regmap API usage. Signed-off-by: Mark Brown --- Mark Brown (2): drm/panel: ili9322: Remove redundant volatle_reg() operation drm/panel: ili9322: Convert to use maple tree register cache drivers/gpu/drm/panel/panel

[PATCH 1/2] drm/panel: ili9322: Remove redundant volatle_reg() operation

2023-10-01 Thread Mark Brown
The ili9322 driver has a volatile_reg() operation in it's regmap which always returns false. This is redundant since it is the default in the regmap core, remove the operation for a trivial code size and performance improvement. Signed-off-by: Mark Brown --- drivers/gpu/drm/panel/panel-ilitek

[PATCH] drm/bridge: icn6211: Convert to use maple tree register cache

2023-09-30 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/bridge/chipone-icn6211.c | 2

[PATCH] drm/bridge: tc358767: Convert to use maple tree register cache

2023-09-30 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1

[PATCH] drm/rockchip: vop2: Convert to use maple tree register cache

2023-09-30 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c

[PATCH] drm/bridge: dpc3433: Convert to use maple tree register cache

2023-09-30 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/bridge/ti-dlpc3433.c | 2

[PATCH] drm/bridge: adv7511: Convert to use maple tree register cache

2023-09-29 Thread Mark Brown
The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

Re: (subset) [PATCH 00/31] Fix and improve Rockchip RK3128 support

2023-09-26 Thread Mark Brown
On Tue, 29 Aug 2023 19:16:16 +0200, Alex Bee wrote: > this series fixes some issues I found when testing my "new" RK3128 board > with the mainline kernel and adds some core functionality like SMP bringup, > usb and networking. > > The propably most distinctive change is the split up of the DTs

Re: [PATCH] spi: tegra: Fix missing IRQ check in tegra_slink_probe()

2023-09-12 Thread Mark Brown
On Sat, 26 Aug 2023 18:02:54 +0800, Zhang Shurong wrote: > This func misses checking for platform_get_irq()'s call and may passes the > negative error codes to request_irq(), which takes unsigned IRQ #, > causing it to fail with -EINVAL, overriding an original error code. > > Fix this by stop

Re: (subset) [PATCH 00/11] add missing of_node_put

2023-09-11 Thread Mark Brown
On Thu, 07 Sep 2023 11:55:10 +0200, Julia Lawall wrote: > Add of_node_put on a break out of an of_node loop. > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [10/11] ASoC: rsnd: add missing of_node_put commit:

Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()

2023-08-18 Thread Mark Brown
On Fri, Aug 18, 2023 at 06:32:28PM -0300, Jason Gunthorpe wrote: > It turns out several drivers are calling of_dma_configure() outside the > expected bus_type.dma_configure op. This ends up being mis-locked and > triggers a lockdep assertion, or instance: Acked-by: Mark Brown sign

Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets

2023-08-03 Thread Mark Brown
On Thu, Aug 03, 2023 at 07:20:15AM +, Jiaxin Yu (俞家鑫) wrote: > I agree with you, in fact the speaker is indeed doing this way. But > about the hdmi that on the board, I did not find a defination link > snd_soc_dapm_hdmi, so I use snd_soc_dapm_line to replace. The purpose > is to control it

Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets

2023-08-02 Thread Mark Brown
On Wed, Aug 02, 2023 at 02:52:57PM +, Jiaxin Yu (俞家鑫) wrote: > On Mon, 2023-07-31 at 12:50 +0100, Mark Brown wrote: > > On Mon, Jul 31, 2023 at 02:08:02AM +0800, Jiaxin Yu wrote: > > > Use SND_SOC_DAPM_LINE instead of SND_SOC_DAPM_OUTPUT to trigger > > > DAP

Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets

2023-07-31 Thread Mark Brown
On Mon, Jul 31, 2023 at 02:08:02AM +0800, Jiaxin Yu wrote: > Use SND_SOC_DAPM_LINE instead of SND_SOC_DAPM_OUTPUT to trigger > DAPM events to hdmi-codec when userspace control the DPAM pin. Why? signature.asc Description: PGP signature

Re: (subset) [PATCH v3 0/4] Qualcomm REFGEN regulator

2023-07-12 Thread Mark Brown
On Mon, 03 Jul 2023 20:15:53 +0200, Konrad Dybcio wrote: > Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator > responsible for providing a reference voltage to some on-SoC IPs (like DSI > or PHYs). It can be turned off when unused to save power. > > This series introduces

Re: [PATCH v3 0/4] Qualcomm REFGEN regulator

2023-07-03 Thread Mark Brown
On Mon, Jul 03, 2023 at 08:15:53PM +0200, Konrad Dybcio wrote: > Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator > responsible for providing a reference voltage to some on-SoC IPs (like DSI > or PHYs). It can be turned off when unused to save power. > > This series

Re: [PATCH v2 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-06-30 Thread Mark Brown
On Thu, Jun 29, 2023 at 10:44:34PM +0200, Konrad Dybcio wrote: > On 29.06.2023 22:35, Konrad Dybcio wrote: > > Modern Qualcomm SoCs have a REFGEN (reference voltage generator) > > regulator, providing reference voltage to on-chip IP, like PHYs. > > > > Add a driver to support toggling that

Re: [PATCH 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-06-28 Thread Mark Brown
On Wed, Jun 28, 2023 at 06:29:46PM +0200, Konrad Dybcio wrote: > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2017, 2019-2020, The Linux Foundation. All rights reserved. > + * Copyright (c) 2023, Linaro Limited > + */ Please use a C++ comment for the whole thing for

Re: linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-18 Thread Mark Brown
On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > Note there was a ppc compile fail, which is why we pushed the ttm revert. > That /should/ be fixed now, but would be good if you can confirm? According to Nathan (CCed) there's still issues with the interaction with the PowerPC

Re: linux-next: manual merge of the drm tree with the powerpc tree

2023-04-18 Thread Mark Brown
On Tue, Apr 18, 2023 at 11:21:45AM -0700, Nathan Chancellor wrote: > On Fri, Apr 14, 2023 at 05:55:10PM +0100, Mark Brown wrote: > > Done. > Thanks a lot, sorry for not saying it sooner! It looks like this > regressed in next-20230417 and next-20230418 though. Someone sen

Re: linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-17 Thread Mark Brown
On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > Note there was a ppc compile fail, which is why we pushed the ttm revert. > That /should/ be fixed now, but would be good if you can confirm? I don't have any PowerPC toolchains set up - I guess one of the community builders might

Re: linux-next: manual merge of the drm tree with the powerpc tree

2023-04-14 Thread Mark Brown
On Thu, Apr 13, 2023 at 11:47:25AM -0700, Nathan Chancellor wrote: > On Wed, Apr 12, 2023 at 11:22:13AM +1000, Stephen Rothwell wrote: > select SND_HDA_COMPONENT if SND_HDA_CORE > # !CC_IS_CLANG: https://github.com/ClangBuiltLinux/linux/issues/1752 > - select DRM_AMD_DC_DCN if

Re: [PATCH v3 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2023-04-05 Thread Mark Brown
On Wed, Apr 05, 2023 at 05:17:21PM +0200, Maxime Ripard wrote: > On Tue, Apr 04, 2023 at 04:26:18PM +0100, Mark Brown wrote: > > To be honest it's surprising that we'd have to manually specify this, I > > would expect to be able to reparent. I suspect it'd be better to go the >

Re: [PATCH v3 64/65] ASoC: tlv320aic32x4: div: Switch to determine_rate

2023-04-05 Thread Mark Brown
On Tue, Apr 04, 2023 at 12:11:54PM +0200, Maxime Ripard wrote: > The driver does implement round_rate() though, which means that we can > change the rate of the clock, but we will never get to change the > parent. > However, It's hard to tell whether it's been done on purpose or not. > Since

Re: [PATCH v3 63/65] ASoC: tlv320aic32x4: pll: Switch to determine_rate

2023-04-05 Thread Mark Brown
On Tue, Apr 04, 2023 at 12:11:53PM +0200, Maxime Ripard wrote: > The driver does implement round_rate() though, which means that we can > change the rate of the clock, but we will never get to change the > parent. > However, It's hard to tell whether it's been done on purpose or not. > Since

Re: [PATCH v3 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2023-04-04 Thread Mark Brown
On Tue, Apr 04, 2023 at 12:11:33PM +0200, Maxime Ripard wrote: > The tlv320aic32x4 clkin clock implements a mux with a set_parent hook, > but doesn't provide a determine_rate implementation. > This is a bit odd, since set_parent() is there to, as its name implies, > change the parent of a clock.

Re: [PATCH v3] ASoC: dt-bindings: maxim,max98371: Convert to DT schema

2023-04-03 Thread Mark Brown
On Sat, 01 Apr 2023 15:19:29 -0300, André Morishita wrote: > Convert the Maxim Integrated MAX98371 audio codec bindings to DT schema. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: dt-bindings: maxim,max98371: Convert to DT

Re: stable-rc/linux-5.10.y bisection: baseline.login on hp-x360-14-G1-sona

2023-03-21 Thread Mark Brown
On Tue, Mar 21, 2023 at 05:18:03AM -0700, KernelCI bot wrote: The KernelCI bisection bot found a boot bisection on one of the HP ChromeBooks in v5.10.175 triggered by b5005605013d ("drm/i915: Don't use BAR mappings for ring buffers with LLC"). The system appears to die very early in boot with no

Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'

2023-03-04 Thread Mark Brown
#'. A couple of cases with comments which were not intended to be > comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and > brcm,bcmgenet.yaml. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-02-28 Thread Mark Brown
hese > cases. Mostly scripted with the following commands: Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH] tree-wide: trivial: s/ a SPI/ an SPI/

2023-02-03 Thread Mark Brown
On Fri, Feb 03, 2023 at 11:28:03AM +0100, Geert Uytterhoeven wrote: > On Fri, Feb 3, 2023 at 11:17 AM Tudor Ambarus > wrote: > > The deciding factor for when a/an should be used is the sound > > that begins the word which follows these indefinite articles, > > rather than the letter which does.

Re: (subset) [PATCH v2 00/13] spi: Add support for stacked/parallel memories

2023-02-01 Thread Mark Brown
On Fri, 20 Jan 2023 00:23:29 +0530, Amit Kumar Mahapatra wrote: > This patch is in the continuation to the discussions which happened on > 'commit f89504300e94 ("spi: Stacked/parallel memories bindings")' for > adding dt-binding support for stacked/parallel memories. > > This patch series updated

Re: [PATCH v2 02/13] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-02-01 Thread Mark Brown
On Fri, Jan 20, 2023 at 12:23:31AM +0530, Amit Kumar Mahapatra wrote: > Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod > members of struct spi_device to be an array. But changing the type of these > members to array would break the spi driver functionality. To make the

Re: (subset) [PATCH 00/35] Documentation: correct lots of spelling errors (series 1)

2023-01-28 Thread Mark Brown
On Thu, 26 Jan 2023 22:39:30 -0800, Randy Dunlap wrote: > Correct many spelling errors in Documentation/ as reported by codespell. > > Maintainers of specific kernel subsystems are only Cc-ed on their > respective patches, not the entire series. [if all goes well] > > These patches are based on

Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

2023-01-25 Thread Mark Brown
nt. > > Add unevaluatedProperties or additionalProperties as appropriate, and > then add any missing properties flagged by the addition. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

2023-01-25 Thread Mark Brown
nt. > > Add unevaluatedProperties or additionalProperties as appropriate, and > then add any missing properties flagged by the addition. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: (subset) [PATCH v2 00/27] ARM: pxa: remove all unused boards

2023-01-12 Thread Mark Brown
On Thu, 05 Jan 2023 14:45:55 +0100, Arnd Bergmann wrote: > Most of the legacy PXA board files were marked as unused in linux-5.19 and > can get removed in linux-6.3. There is support for pxa250/pxa270/pxa300 > using devicetree already, which supports a number of boards, but progress > on

Re: next-20230110: arm64: defconfig+kselftest config boot failed - Unable to handle kernel paging request at virtual address fffffffffffffff8

2023-01-11 Thread Mark Brown
On Wed, Jan 11, 2023 at 12:29:04PM +, Mark Brown wrote: > We're seeing issues in all configs on meson-gxl-s905x-libretech-cc > today, not just with the kselftest fragment. The initial failuire seems > to be: > [ 17.337253] WARNING: CPU: 3 PID: 123 at drivers/gpu/drm/drm_b

Re: next-20230110: arm64: defconfig+kselftest config boot failed - Unable to handle kernel paging request at virtual address fffffffffffffff8

2023-01-11 Thread Mark Brown
On Wed, Jan 11, 2023 at 11:34:41AM +0100, Neil Armstrong wrote: > I merged a fix that could be related: > https://lore.kernel.org/all/20230109220033.31202-1-m.szyprow...@samsung.com/ > This could make the driver to return from probe while not totally probed, and > explain such error. We're

Re: next-20230110: arm64: defconfig+kselftest config boot failed - Unable to handle kernel paging request at virtual address fffffffffffffff8

2023-01-10 Thread Mark Brown
On Tue, Jan 10, 2023 at 04:32:59PM +, Will Deacon wrote: > On Tue, Jan 10, 2023 at 09:44:40PM +0530, Naresh Kamboju wrote: > > GOOD: next-20230109 (defconfig + kselftests configs) > > BAD: next-20230110 (defconfig + kselftests configs) > I couldn't find a kselftests .config in the tree

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-14 Thread Mark Brown
On Wed, Dec 14, 2022 at 03:27:56PM +0100, Guillaume Tucker wrote: > On 14/12/2022 14:50, Mark Brown wrote: > > As a developer I tend to find this unhelpful, it makes it much more > > likely that the mail will get missed. As a reporter it means there's > > more information to

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-14 Thread Mark Brown
On Wed, Dec 14, 2022 at 03:16:33PM +0100, Guillaume Tucker wrote: > Mark, how did you get the list of recipients? > There's a command for this btw, which was used when the reports > were automatically sent to the recipients before we reverted to > manual filtering to reduce the noise: My

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-14 Thread Mark Brown
On Wed, Dec 14, 2022 at 01:55:03PM +0100, Guillaume Tucker wrote: > Maybe you could retrieve the original thread and rely to it with > the report? That's the ideal way of following up on a patch I > think. You can get the mbox file this way: > ./kci_bisect get_mbox \ > --commit

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-13 Thread Mark Brown
On Tue, Dec 13, 2022 at 05:56:30AM -0800, KernelCI bot wrote: The KernelCI bisection bot found regressions in at least two KMS tests in the Renesas tree on rk3399-gru-kevin just after the Renesas tree merged up mainline: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-13 Thread Mark Brown
On Tue, Dec 13, 2022 at 02:23:32PM +, Jiaxin Yu (俞家鑫) wrote: > On Mon, 2022-12-05 at 12:07 +0000, Mark Brown wrote: > > On Mon, Dec 05, 2022 at 09:34:17AM +, Jiaxin Yu (俞家鑫) wrote: > > No, I mean that if you want to control the enable and disable of the > > o

Re: [PATCH 1/3] ASoC: dt-bindings: Extend name-prefix.yaml into common DAI properties

2022-12-05 Thread Mark Brown
On Sat, 3 Dec 2022 17:04:40 +0100, Krzysztof Kozlowski wrote: > Rename name-prefix.yaml into common DAI schema and document > '#sound-dai-cells' for completeness. The '#sound-dai-cells' cannot be > really constrained, as there are users with value of 0, 1 and 2, but at > least it brings

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-05 Thread Mark Brown
On Mon, Dec 05, 2022 at 09:34:17AM +, Jiaxin Yu (俞家鑫) wrote: > 1. I have added a DAPM widget that is "SDB", when we open or close HDMI > PIN_SWITCH, the callback 'hdmi_tx_event' registered in the widget will > be triggered. Maybe you mean I shouldn't use SNDRV_PCM_TRIGGER_START > and

Re: [PATCH v1 0/2] ASoC/tda998x: Fix reporting of nonexistent capture streams

2022-12-04 Thread Mark Brown
On Wed, 30 Nov 2022 18:46:42 +, Mark Brown wrote: > The recently added pcm-test selftest has pointed out that systems with > the tda998x driver end up advertising that they support capture when in > reality as far as I can see the tda998x devices are transmit only. The > DAI

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-01 Thread Mark Brown
On Thu, Dec 01, 2022 at 03:06:04PM +, Jiaxin Yu (俞家鑫) wrote: > On Tue, 2022-11-29 at 17:22 +0000, Mark Brown wrote: > > static const struct snd_kcontrol_new > > mt8186_mt6366_rt1019_rt5682s_controls[] = { > > SOC_DAPM_PIN_SWITCH("Speakers"), &

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Mark Brown
On Thu, Dec 01, 2022 at 03:27:32PM +0100, Vlastimil Babka wrote: > I usually do that with git send-email and a custom --cc-cmd script, but > additionally it sends the cover letter also to everyone that's on any > individual patch's Cc, so everyone gets at least the cover letter + their > specific

[PATCH v1 2/2] drm: tda99x: Don't advertise non-existent capture support

2022-11-30 Thread Mark Brown
As far as I can tell none of the tda998x devices support audio capture so don't advertise support for it, ensuring that we don't confuse userspace. Signed-off-by: Mark Brown --- drivers/gpu/drm/i2c/tda998x_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i2c

[PATCH v1 1/2] ASoC: hdmi-codec: Allow playback and capture to be disabled

2022-11-30 Thread Mark Brown
to userspace that we can't actually support. In order to avoid breaking existing users the flags in platform data are a bit awkward and specify what should be disabled rather than doing the perhaps more expected thing and defaulting to not supporting capture. Signed-off-by: Mark Brown --- include

[PATCH v1 0/2] ASoC/tda998x: Fix reporting of nonexistent capture streams

2022-11-30 Thread Mark Brown
for example due to pinmux management. This is happening due to the hdmi-codec helpers not providing any mechanism for indicating unidirectional audio so add one and use it in the tda998x driver. It is likely other hdmi-codec users are also affected but I don't have those systems to hand. Mark Brown

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-11-29 Thread Mark Brown
On Mon, Nov 28, 2022 at 03:07:22PM +, Jiaxin Yu (俞家鑫) wrote: > On Fri, 2022-11-25 at 12:18 +0000, Mark Brown wrote: > > On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote: > > I'm a little unclear why this is being implemented as a DAPM > > operation > > ra

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-11-25 Thread Mark Brown
On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote: > + /* > + * PCM trigger callback. > + * Mandatory > + */ > + int (*trigger)(struct device *dev, int cmd); > + Making this mandatory would break all existing users, though... > + switch (event) { > + case

Re: [PATCH 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-18 Thread Mark Brown
On Fri, Nov 18, 2022 at 11:36:27AM +0100, Carlo Caione wrote: > On 17/11/2022 15:59, Mark Brown wrote: > > So this is an issue in the MIPI DBI code where the interpretation of the > > buffer passed in depends on both the a caller parameter and the > > capabilities of the unde

Re: [PATCH 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-17 Thread Mark Brown
On Thu, Nov 17, 2022 at 02:40:05PM +0100, Carlo Caione wrote: > On 17/11/2022 12:09, Mark Brown wrote: > > I don't understand what the commit log is saying here. The meson-spicc > > driver advertises support for 8 bit words, if the driver is sending data > > formatted as a b

Re: [PATCH 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-17 Thread Mark Brown
On Thu, Nov 17, 2022 at 09:47:40AM +0100, Carlo Caione wrote: > The ILI9486 driver is wrongly assuming that the SPI panel is interfaced > only with 8-bit SPI controllers and consequently that the pixel data > passed by the MIPI DBI subsystem are already swapped before being sent > over SPI using 8

Re: [PATCH 3/3] spi: meson-spicc: Lower CS between bursts

2022-11-17 Thread Mark Brown
On Thu, Nov 17, 2022 at 09:47:41AM +0100, Carlo Caione wrote: > On some hardware (reproduced on S905X) when a large payload is > transmitted over SPI in bursts at the end of each burst, the clock line > briefly fluctuates creating spurious clock transitions that are being > recognised by the

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2022-11-07 Thread Mark Brown
On Mon, Nov 07, 2022 at 04:26:03PM +0100, Maxime Ripard wrote: > On Mon, Nov 07, 2022 at 12:06:07PM +0000, Mark Brown wrote: > > On Mon, Nov 07, 2022 at 09:43:22AM +0100, Maxime Ripard wrote: > > The series does fill in __clk_mux_determine_rate for everything though - > > i

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2022-11-07 Thread Mark Brown
On Mon, Nov 07, 2022 at 09:43:22AM +0100, Maxime Ripard wrote: > On Fri, Nov 04, 2022 at 03:59:53PM +0000, Mark Brown wrote: > > Well, hopefully everyone for whom it's an issue currently will be > > objecting to this version of the change anyway so we'll either know > >

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2022-11-04 Thread Mark Brown
On Fri, Nov 04, 2022 at 04:51:23PM +0100, Maxime Ripard wrote: > Just filling determine_rate if it's missing with > __clk_mux_determine_rate will possibly pick different parents, and I'm > fairly certain that this have never been tested on most platforms, and > will be completely broken. And I

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2022-11-04 Thread Mark Brown
On Fri, Nov 04, 2022 at 02:18:00PM +0100, Maxime Ripard wrote: > So, the set_parent hook is effectively unused, possibly because of an > oversight. However, it could also be an explicit decision by the > original author to avoid any reparenting but through an explicit call to > clk_set_parent().

Re: [PATCH 1/2] component: Add helper for device nodes

2022-11-03 Thread Mark Brown
it adding the helper from updating to use the helper - it makes things easier to merge. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: linux-next: build failure after merge of the drm tree

2022-10-04 Thread Mark Brown
On Tue, Oct 04, 2022 at 02:05:58PM +1100, Stephen Rothwell wrote: > On Tue, 4 Oct 2022 12:24:37 +1000 David Airlie wrote: > > On Tue, Oct 4, 2022 at 12:21 PM Stephen Rothwell > > wrote: > > I'm not seeing it here, what gcc is this with? > I am using an x86_64 cross compiler hosted on ppc64le

Re: (subset) [PATCH v1 00/11] Get rid of [devm_]gpiod_get_from_of_node() public APIs

2022-09-05 Thread Mark Brown
On Sun, 4 Sep 2022 23:30:52 -0700, Dmitry Torokhov wrote: > I would like to stop exporting OF-specific [devm_]gpiod_get_from_of_node() > so that gpiolib can be cleaned a bit. We can do that by switching drivers > to use generic fwnode API ([devm_]fwnode_gpiod_get()). By doing so we open > the door

Re: (subset) [PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-24 Thread Mark Brown
On Fri, 12 Aug 2022 13:08:17 +0300, Matti Vaittinen wrote: > Devm helpers for regulator get and enable > > First patch in the series is actually just a simple documentation fix > which could be taken in as it is now. > > A few* drivers seem to use pattern demonstrated by pseudocode: > > [...]

  1   2   3   4   5   6   7   8   >