Hi Neil,
On Wed, Apr 3, 2024 at 9:46 AM Neil Armstrong wrote:
>
> Disable the px_clk when setting the rate to recover a fully
> configured and correctly reset VCLK clock tree after the rate
> is set.
>
> Fixes: 77d9e1e6b846 ("drm/meson: add support for MIPI-DSI transceiver")
> Signed-off-by:
On Mon, Apr 8, 2024 at 7:05 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> Allow meson to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
>
> Cc: Neil Armstrong
> Cc: linux-amlo...@lists.infradead.org
> Signed-off-by: Ville Syrjälä
Thank you for
straight forward to read and makes the error
prints within those functions consistent (by logging all -EPROBE_DEFER
with dev_dbg(), while actual errors are logged with dev_err() and get
the error value printed).
Signed-off-by: Martin Blumenstingl
---
This is meant to be applied on top of my other patch
on Meson8b boards with the CVBS outputs enabled.
Fixes: 09847723c12f ("drm/meson: remove drm bridges at aggregate driver unbind
time")
Fixes: 42dcf15f901c ("drm/meson: add DSI encoder")
Cc: sta...@vger.kernel.org
Reported-by: Steve Morvai
Signed-off-by: Martin Blumenst
Hi Neil,
On Tue, May 30, 2023 at 5:57 PM Neil Armstrong
wrote:
[...]
> >> The mipi_dsi_pxclk_div is set as RO in order to use the same GP0
> >> for mipi_dsi_pxclk and vclk2_input.
> >
> > I don't think notifiers is the appropriate approach here.
> > Whenever there is clock change the motifiers
returning zero in the
> remove callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König
Reviewed-by: Martin Blumenstingl
in their defining file so should be static
>
> Signed-off-by: Tom Rix
With above typo fixed (or with a comment from the maintainers that
they can fix it while applying):
Acked-by: Martin Blumenstingl
d "preceding"
[...]
> drivers/gpu/drm/meson/meson_drv.c | 2 +-
for the meson driver:
Acked-by: Martin Blumenstingl
Thank you and best regards,
Martin
Hi Johan,
thanks for your patch!
On Mon, Mar 6, 2023 at 11:35 AM Johan Hovold wrote:
[...]
> @@ -325,23 +325,23 @@ static int meson_drv_bind_master(struct device *dev,
> bool has_components)
>
> ret = meson_encoder_hdmi_init(priv);
I'm wondering if component_bind_all() can be moved
is not present.
>
> Reported-by: Ricardo Cañuelo
> Fixes: 67d0a30128c9 ("drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*()
> conversion")
> Signed-off-by: Marek Szyprowski
Acked-by: Martin Blumenstingl
On Wed, Mar 1, 2023 at 4:31 PM Thomas Zimmermann wrote:
>
> Use the fbdev emulation that is optimized for DMA helpers. Avoids
> possible shadow buffering and makes the code simpler.
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Martin Blumenstingl
port for Amlogic Meson Graphic Controller")
> Suggested-by: Martin Blumenstingl
> Signed-off-by: Christian Hewitt
Acked-by: Martin Blumenstingl
> ---
> Change since v1:
> This time I sent the right patch from the correct branch; the wording in
> v1 is incorrect and the change to m
On Tue, Feb 14, 2023 at 10:35 PM Ville Syrjälä
wrote:
[...]
> > > We should perhaps just get rid of HDMI_VENDOR_INFOFRAME_SIZE
> > > entirely.
> > My thought was to make it the correct size for
> > drm_hdmi_vendor_infoframe_from_display_mode(). Then developers using
> > this "common" vendor
On Mon, Feb 13, 2023 at 12:11 PM Ville Syrjälä
wrote:
[...]
> > One could use HDMI_VENDOR_INFOFRAME_SIZE with this as well:
> > u8 buffer[HDMI_INFOFRAME_SIZE(VENDOR)];
> > But it would only result in an 8 byte wide buffer.
> > Nobody uses it like this yet.
>
> Not sure that would make any sense
Hello Ville.
On Mon, Feb 6, 2023 at 10:58 AM Ville Syrjälä
wrote:
[...]
> > Change HDMI_VENDOR_INFOFRAME_SIZE to 6 bytes so
> > hdmi_vendor_infoframe_pack_only() can properly check the passed buffer
> > size and avoid an out of bounds write to ptr[8] or ptr[9].
>
> The function should return
Hello Jani, Hello Ville,
On Tue, Jan 10, 2023 at 7:20 PM Jani Nikula wrote:
[...]
> > I'm not an expert on this topic and I'm not sure if the size still
> > depends on that if condition from long time ago. So please share your
> > thoughts.
>
> I tried to look at this quickly, but it makes my
n properly check the passed buffer
size and avoid an out of bounds write to ptr[8] or ptr[9].
Fixes: c5e69ab35c0d ("video/hdmi: Constify infoframe passed to the pack
functions")
Fixes: d43be2554b58 ("drivers: video: hdmi: cleanup coding style in video a
bit")
Signed-
ly for
> SoCs using AFBC, leaving the default value for all the others.
That was also my approach (for a not-yet-upstream patch).
Since it's affecting already supported SoCs I suggest adding
"Fixed-by: 24e0d4058eff ..." (maybe Neil can do so when he agrees and
is applying the patch).
Acked-by: Martin Blumenstingl
ugh only in this one function, which makes it a bit
pointless).
This is minor enough. So with or without that change this gets my:
Acked-by: Martin Blumenstingl
erence returned by
> of_graph_get_remote_port() when it is not used anymore.
>
> Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller")
> Signed-off-by: Liang He
Acked-by: Martin Blumenstingl
It's easy for me to miss patches if the linux-amlogic list is not part
of the r
strong
> Reviewed-by: Jagan Teki
Acked-by: Martin Blumenstingl
Hi Neil,
On Fri, Jun 17, 2022 at 9:27 AM Neil Armstrong wrote:
> +/* [31:16] RW intr_stat/clr. Default 0.
> + * For each bit, read as this interrupt level status,
> + * write 1 to clear.
Do you know if an interrupt line from GIC is routed to the MIPI-DSI
transceiver? If
k.
>
> Fixes: e67f6037ae1b ("drm/meson: split out encoder from meson_dw_hdmi")
> Signed-off-by: Miaoqian Lin
Reviewed-by: Martin Blumenstingl
Note to self: at first I thought the following code needs to be changed as well:
notifier = cec_notifier_conn_register(>dev, NULL, _
k.
>
> Fixes: 318ba02cd8a8 ("drm/meson: encoder_cvbs: switch to bridge with
> ATTACH_NO_CONNECTOR")
> Signed-off-by: Miaoqian Lin
As far as I can tell this patch is identical to the one from v1.
Please keep my Reviewed-by from the previous version in case nothing
has changed for this s
Hello,
first of all: thank you for spotting this and sending a patch!
On Tue, May 31, 2022 at 4:49 PM Miaoqian Lin wrote:
[...]
> diff --git a/drivers/gpu/drm/meson/meson_encoder_hdmi.c
> b/drivers/gpu/drm/meson/meson_encoder_hdmi.c
> index 5e306de6f485..f3341458f8b7 100644
> ---
drm/meson: encoder_cvbs: switch to bridge with
> ATTACH_NO_CONNECTOR")
> Signed-off-by: Miaoqian Lin
Reviewed-by: Martin Blumenstingl
eson: encoder_hdmi: switch to bridge
> DRM_BRIDGE_ATTACH_NO_CONNECTOR")
> Signed-off-by: Miaoqian Lin
Reviewed-by: Martin Blumenstingl
Thanks for sending this patch!
Neil, while reviewing this I noticed that on module unload we're also
not calling put_device().
This note doesn't affect this
m/bridge/nwl-dsi.c | 2 +-
> drivers/gpu/drm/meson/meson_drv.c | 2 +-
for drivers/gpu/drm/meson/meson_drv.c:
Acked-by: Martin Blumenstingl
Best regards,
Martin
Hi Neil,
some high-level comments from me below.
On Fri, Jan 7, 2022 at 3:58 PM Neil Armstrong wrote:
[...]
> +/* MIPI DSI Relative REGISTERs Definitions */
> +/* For MIPI_DSI_TOP_CNTL */
> +#define BIT_DPI_COLOR_MODE20
> +#define BIT_IN_COLOR_MODE 16
> +#define
Hi Neil,
On Fri, Jan 7, 2022 at 3:57 PM Neil Armstrong wrote:
[...]
> + writel_bits_relaxed(BIT(3), BIT(3), priv->io_base +
> _REG(ENCL_VIDEO_MODE_ADV));
see my comment on patch #3 from this series for BIT(3)
Best regards,
Martin
Hi Neil,
On Fri, Jan 7, 2022 at 3:57 PM Neil Armstrong wrote:
>
> This adds supports for the ENCL encoder connected to a MIPI-DSI transceiver
> on the
> Amlogic AXG SoCs.
Should this be "AXG and newer SoCs" or is this really AXG specific?
[...]
> +#define GAMMA_VCOM_POL7 /* RW */
>
On Fri, Jan 7, 2022 at 3:56 PM Neil Armstrong wrote:
>
> Add third port corresponding to the ENCL DPI encoder used to connect
> to DSI or LVDS transceivers.
>
> Signed-off-by: Neil Armstrong
Reviewed-by: Martin Blumenstingl
When afbcd.ops->init fails we need to free the struct drm_device. Also
all errors which come after afbcd.ops->init was successful need to exit
the AFBCD, just like meson_drv_unbind() does.
Fixes: d1b5e41e13a7e9 ("drm/meson: Add AFBCD module driver")
Signed-off-by: Mar
Use this to simplify the driver shutdown. It will also come handy when
fixing the error handling in meson_drv_bind_master().
Signed-off-by: Martin Blumenstingl
---
drivers/gpu/drm/meson/meson_drv.c | 6 ++--
drivers/gpu/drm/meson/meson_osd_afbcd.c | 41 -
drivers
-stable.
Best regards,
Martin
Martin Blumenstingl (2):
drm/meson: osd_afbcd: Add an exit callback to struct meson_afbcd_ops
drm/meson: Fix error handling when afbcd.ops->init fails
drivers/gpu/drm/meson/meson_drv.c | 25 +++
drivers/gpu/drm/meson/meson_osd_afbcd.c |
Hi Neil, Hi Sam,
On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote:
[...]
> +static const struct drm_bridge_funcs meson_encoder_cvbs_bridge_funcs = {
> + .attach = meson_encoder_cvbs_attach,
> + .enable = meson_encoder_cvbs_enable,
> + .disable = meson_encoder_cvbs_disable,
Amlogic SoC based boards.
>
> Signed-off-by: Neil Armstrong
> Acked-by: Sam Ravnborg
Acked-by: Martin Blumenstingl
On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote:
>
> Rename the cvbs encoder to match the newly introduced meson_encoder_hdmi.
>
> Signed-off-by: Neil Armstrong
> Acked-by: Sam Ravnborg
Acked-by: Martin Blumenstingl
RM_BRIDGE_ATTACH_NO_CONNECTOR working.
>
> Signed-off-by: Neil Armstrong
> Acked-by: Sam Ravnborg
another great piece which helps a lot with HDMI support for the 32-bit SoCs!
I have one question below - but regardless of the answer there this gets my:
Acked-by: Martin Blumenstingl
[...]
>
n the same driver.
>
> Signed-off-by: Neil Armstrong
apart from that typo (please fix it up when applying the patch) this
is some great work!
it helps me a lot with HDMI support on the 32-bit SoCs
with that said:
Acked-by: Martin Blumenstingl
rse the
> first endpoints instead of recursing.
>
> Signed-off-by: Neil Armstrong
> Acked-by: Sam Ravnborg
Acked-by: Martin Blumenstingl
Tested-by: Martin Blumenstingl
and also (although I am no drm subsystem expert):
Reviewed-by: Martin Blumenstingl
[...]
> - ret = drm_irq_install(drm, priv->vsync_irq);
> + ret = request_irq(priv->vsync_irq, meson_irq, 0, drm->driver->name,
> drm);
I'd like to u
Hello,
first of all: thanks for your patch and sorry for being late with my
review question.
On Fri, Jun 18, 2021 at 7:28 AM Jiajun Cao wrote:
>
> Fix a potential NULL pointer exception when meson_drv_unbind()
> attempts to operate on the driver_data priv which may be NULL.
> Add a null pointer
P Linux Team
> Cc: Philipp Zabel
> Cc: Paul Cercueil
> Cc: Chun-Kuang Hu
> Cc: Matthias Brugger
> Cc: Neil Armstrong
> Cc: Kevin Hilman
> Cc: Jerome Brunet
> Cc: Martin Blumenstingl
> Cc: Marek Vasut
> Cc: Stefan Agner
> Cc: Sandy Huang
> Cc: "
sense to me (as non-drm person), as
platform_set_drvdata comes near the end of meson_drv_bind_master (so
any errors would cause the drvdata to be NULL).
with this I can also give me:
Reviewed-by: Martin Blumenstingl
in addition to my:
Tested-by: Martin Blumenstingl
Can you please queue this up for -fixes or do we need to ask someone to do it?
Best regards,
Martin
_restart+0x18/0x68
> __do_sys_reboot+0x224/0x250
> __arm64_sys_reboot+0x24/0x30
> ...
>
> Simply check if the priv struct has been allocated before using it.
>
> Fixes: fa0c16caf3d7 ("drm: meson_drv add shutdown function")
> Reported
Hi Neil,
On Mon, Jan 4, 2021 at 2:29 PM Neil Armstrong wrote:
>
> Hi,
>
> Sorry for the delay...
>
> On 31/12/2020 00:24, Martin Blumenstingl wrote:
> > Hi Neil and all interested people,
> >
> > in the past there were concerns about how some of the compone
and 64 at least) and thus incorrectly set
the burst size to 24.
Fixes: 147ae1cbaa1842 ("drm: meson: viu: use proper macros instead of magic
constants")
Signed-off-by: Martin Blumenstingl
---
re-send of v1 [0] with no changes as I still noticed that this is
sitting in my tree and I wa
Hi Neil,
On Tue, Apr 28, 2020 at 10:38 AM Neil Armstrong wrote:
[...]
> > @@ -444,9 +437,9 @@ void meson_viu_init(struct meson_drm *priv)
> > VIU_OSD_FIFO_LIMITS(2); /* fifo_lim: 2*16=32 */
> >
> > if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_G12A))
> > -
e, we limit to HDMI 1.3a max HDMI PHY clock frequency.
for my own education: 1.65GHz from the PLL will be divided down to 165MHz
isn't this more like the limit of HDMI 1.2a?
> Changes sinces v1:
> - Moved frequency check in the vclk code, and also checks DMT modes
>
> Signed-off-
and 64 at least) and thus incorrectly set
the burst size to 24.
Fixes: 147ae1cbaa1842 ("drm: meson: viu: use proper macros instead of magic
constants")
Signed-off-by: Martin Blumenstingl
---
drivers/gpu/drm/meson/meson_registers.h | 6 ++
drivers/gpu/drm/meson/meson_viu.c
Hi Neil,
On Tue, Apr 21, 2020 at 3:44 PM Neil Armstrong wrote:
[...]
> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> index e8c94915a4fc..dc3d5122475a 100644
> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> +++
The GPU can be one of the big heat sources on a SoC. Allow the
"#cooling-cells" property to be specified for ARM Mali Utgard GPUs so
the GPU clock speeds (and voltages) can be reduced to prevent a SoC from
overheating.
Reviewed-by: Qiang Yu
Signed-off-by: Martin Blumenstingl
---
Cha
On Thu, Apr 2, 2020 at 9:46 AM Thomas Zimmermann wrote:
>
> Hi Martin
>
> Am 02.04.20 um 09:39 schrieb Martin Blumenstingl:
> > Hi Thomas,
> >
> > On Thu, Apr 2, 2020 at 9:26 AM Thomas Zimmermann
> > wrote:
> >>
> >> Hi,
> >>
> &
u please try building again with the attached patch?
> Seems related to
>
> commit 1996970773a323533e1cc1b6b97f00a95d675f32
> Author: Martin Blumenstingl
> Date: Thu Mar 19 21:34:27 2020 +0100
>
> drm/lima: Add optional devfreq and cooling device support
>
> https:
Use two spaces for indentation instead of one to be consistent with the
rest of the file. No functional changes.
Fixes: 6b9ebf1e0e678b ("dt-bindings: display: amlogic, meson-vpu: convert to
yaml")
Signed-off-by: Martin Blumenstingl
---
.../devicetree/bindings/display/amlogic,meso
On Sat, Mar 28, 2020 at 9:40 AM Qiang Yu wrote:
>
> Applied to drm-misc-next.
thank you!
regarding patch #1 - can you apply this as well?
patch #1 just takes this midgard change [0] and ports it to utgard
Thank you!
Martin
[0]
because I don't know where
to put the result. any suggestion is welcome though!
[0] https://patchwork.freedesktop.org/series/70967/
[1] https://patchwork.kernel.org/cover/11311293/
[2] https://patchwork.kernel.org/cover/11398365/
Martin Blumenstingl (2):
dt-bindings: gpu: mali-utgard: Add
locking when reading or writing the devfreq statistics because (unlike
than panfrost) we have multiple PP and GP IRQs which may finish jobs
concurrently.
Signed-off-by: Martin Blumenstingl
---
drivers/gpu/drm/lima/Kconfig| 2 +
drivers/gpu/drm/lima/Makefile | 3 +-
drivers/gpu/drm
The GPU can be one of the big heat sources on a SoC. Allow the
"#cooling-cells" property to be specified for ARM Mali Utgard GPUs so
the GPU clock speeds (and voltages) can be reduced to prevent a SoC from
overheating.
Signed-off-by: Martin Blumenstingl
---
Documentation/devicetree/bi
The GPU can be one of the big heat sources on a SoC. Allow the
"#cooling-cells" property to be specified for ARM Mali Utgard GPUs so
the GPU clock speeds (and voltages) can be reduced to prevent a SoC from
overheating.
Signed-off-by: Martin Blumenstingl
---
Documentation/devicetree/bi
locking when reading or writing the devfreq statistics because (unlike
than panfrost) we have multiple PP and GP IRQs which may finish jobs
concurrently.
Signed-off-by: Martin Blumenstingl
---
drivers/gpu/drm/lima/Kconfig| 1 +
drivers/gpu/drm/lima/Makefile | 3 +-
drivers/gpu/drm
Hi Steven,
On Sun, Jan 12, 2020 at 1:16 AM Martin Blumenstingl
wrote:
>
> These are a bunch of devfreq fixes for panfrost that came up in a
> discussion with Robin Murphy during the code-review of the lima
> devfreq patches: [0]
>
> I am only able to test patch #1 properl
is welcome though!
[0] https://patchwork.freedesktop.org/series/70967/
[1] https://patchwork.kernel.org/cover/11311293/
Martin Blumenstingl (2):
dt-bindings: gpu: mali-utgard: Add the #cooling-cells property
drm/lima: Add optional devfreq and cooling device support
.../bindings/gpu/arm
Hi Steven,
On Mon, Jan 13, 2020 at 6:10 PM Steven Price wrote:
>
> On 09/01/2020 17:27, Martin Blumenstingl wrote:
> > On Thu, Jan 9, 2020 at 12:31 PM Steven Price wrote:
> >>
> >> On 07/01/2020 23:06, Martin Blumenstingl wrote:
> >>> dev_pm_opp_set
If devfreq_recommended_opp() fails we need to undo
dev_pm_opp_of_add_table() by calling dev_pm_opp_of_remove_table() (just
like we do it in the other error-path below).
Fixes: f3ba91228e8e91 ("drm/panfrost: Add initial panfrost driver")
Reviewed-by: Steven Price
Signed-off-
work.freedesktop.org/patch/346898/
[1] https://patchwork.freedesktop.org/series/71744/
Martin Blumenstingl (3):
drm/panfrost: enable devfreq based the "operating-points-v2" property
drm/panfrost: call dev_pm_opp_of_remove_table() in all error-paths
drm/panfrost: Use the mali-supp
for "is devfreq enabled" that is not tied to
dev_pm_opp_of_add_table() makes things easier).
Signed-off-by: Martin Blumenstingl
---
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_de
the GPU regulator when updating the frequency (just like
we did this manually before when we open-coded dev_pm_opp_set_rate()).
Fixes: 221bc77914cbcc ("drm/panfrost: Use generic code for devfreq")
Reported-by: Robin Murphy
Signed-off-by: Martin Blumenstingl
---
drivers/gpu/dr
On Thu, Jan 9, 2020 at 12:31 PM Steven Price wrote:
>
> On 07/01/2020 23:06, Martin Blumenstingl wrote:
> > dev_pm_opp_set_rate() needs a reference to the regulator which should be
> > updated when updating the GPU frequency. The name of the regulator has
> > to be passe
Hi Robin,
On Wed, Jan 8, 2020 at 12:18 PM Robin Murphy wrote:
>
> On 07/01/2020 11:06 pm, Martin Blumenstingl wrote:
> > Decouple the check to see whether we want to enable devfreq for the GPU
> > from dev_pm_opp_set_regulators(). This is preparation work for addin
If devfreq_recommended_opp() fails we need to undo
dev_pm_opp_of_add_table() by calling dev_pm_opp_of_remove_table() (just
like we do it in the other error-path below).
Fixes: f3ba91228e8e91 ("drm/panfrost: Add initial panfrost driver")
Signed-off-by: Martin Blumenstingl
---
drive
for the OPP tables or dynamic clock changes there yet.
So patches #2 and #3 are compile-tested only.
[0] https://patchwork.freedesktop.org/patch/346898/
Martin Blumenstingl (3):
drm/panfrost: enable devfreq based the "operating-points-v2" property
drm/panfrost: call dev_pm_opp_of_re
the GPU regulator when updating the frequency (just like
we did this manually before when we open-coded dev_pm_opp_set_rate()).
Fixes: 221bc77914cbcc ("drm/panfrost: Use generic code for devfreq")
Reported-by: Robin Murphy
Signed-off-by: Martin Blumenstingl
---
drivers/gpu/dr
for "is devfreq enabled" that is not tied to
dev_pm_opp_of_add_table() makes things easier).
Signed-off-by: Martin Blumenstingl
---
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_de
Hi Robin,
On Wed, Jan 1, 2020 at 1:55 PM Robin Murphy wrote:
>
> On 2019-12-31 4:47 pm, Martin Blumenstingl wrote:
> > Hi Robin,
> >
> > On Tue, Dec 31, 2019 at 5:40 PM Robin Murphy wrote:
> >>
> >> On 2019-12-31 2:17 pm, Martin Blumenstingl wrote:
Hi Qiang,
On Tue, Dec 31, 2019 at 3:54 AM Qiang Yu wrote:
[...]
> > diff --git a/drivers/gpu/drm/lima/lima_sched.c
> > b/drivers/gpu/drm/lima/lima_sched.c
> > index f522c5f99729..851c496a168b 100644
> > --- a/drivers/gpu/drm/lima/lima_sched.c
> > +++ b/drivers/gpu/drm/lima/lima_sched.c
> > @@
Hi Robin,
On Mon, Dec 30, 2019 at 1:47 AM Robin Murphy wrote:
>
> On 2019-12-29 11:19 pm, Martin Blumenstingl wrote:
> > Hi Robin,
> >
> > On Sun, Dec 29, 2019 at 11:58 PM Robin Murphy wrote:
> >>
> >> Hi Martin,
> >>
> >> On 2019-12
Hi Robin,
On Tue, Dec 31, 2019 at 5:40 PM Robin Murphy wrote:
>
> On 2019-12-31 2:17 pm, Martin Blumenstingl wrote:
> > Hi Robin,
> >
> > On Mon, Dec 30, 2019 at 1:47 AM Robin Murphy wrote:
> >>
> >> On 2019-12-29 11:19 pm, Martin Blumenstingl wrote:
Hi Robin,
On Sun, Dec 29, 2019 at 11:58 PM Robin Murphy wrote:
>
> Hi Martin,
>
> On 2019-12-27 5:37 pm, Martin Blumenstingl wrote:
> > Most platforms with a Mali-400 or Mali-450 GPU also have support for
> > changing the GPU clock frequency. Add devfreq support s
rived from panfrost_devfreq.c. Thanks to Chen-Yu Tsai for
the suggestion!
- I did not unify the code with panfrost yet because I don't know where
to put the result. any suggestion is welcome though!
[0] https://patchwork.freedesktop.org/series/70967/
Martin Blumenstingl (1):
drm/lima: Ad
locking when reading or writing the devfreq statistics because (unlike
than panfrost) we have multiple PP and GP IRQs which may finish jobs
concurrently.
Signed-off-by: Martin Blumenstingl
---
drivers/gpu/drm/lima/Kconfig| 1 +
drivers/gpu/drm/lima/Makefile | 3 +-
drivers/gpu/drm
On Mon, Dec 16, 2019 at 4:03 AM Chen-Yu Tsai wrote:
>
> On Mon, Dec 16, 2019 at 5:12 AM Martin Blumenstingl
> wrote:
> >
> > This is my attempt at adding devfreq (and cooling device) support to
> > the lima driver.
> > I didn't have much time to do in-de
Hi Alyssa,
On Mon, Dec 16, 2019 at 4:48 PM Alyssa Rosenzweig
wrote:
>
> If so much code is being duplicated over, I'm wondering if it makes
> sense for us to move some of the common devfreq code to core DRM
> helpers?
if you have any recommendation where to put it then please let me know
(I am
On Mon, Dec 16, 2019 at 3:51 AM Qiang Yu wrote:
[...]
> For the code, I think you may need some lock to protect the time records as
> there are two kernel threads gp/pp will try to mark GPU busy and several
> interrupts try to mark GPU idle.
good catch, thank you for this!
I assume the reason is
defined). However, I still need to test this on a GXL
board (which is currently missing the GPU OPP table).
Martin Blumenstingl (1):
drm/lima: Add optional devfreq support
drivers/gpu/drm/lima/Kconfig| 1 +
drivers/gpu/drm/lima/Makefile | 3 +-
drivers/gpu/drm/lima/
taken from panfrost_devfreq.c.
Signed-off-by: Martin Blumenstingl
---
drivers/gpu/drm/lima/Kconfig| 1 +
drivers/gpu/drm/lima/Makefile | 3 +-
drivers/gpu/drm/lima/lima_devfreq.c | 162
drivers/gpu/drm/lima/lima_devfreq.h | 15 +++
drivers/gp
DRM_MODE_MATCH_ASPECT_RATIO as suggested
by Neil
[0] https://patchwork.kernel.org/patch/11268161/
Martin Blumenstingl (2):
drm: meson: venc: cvbs: deduplicate the meson_cvbs_mode lookup code
drm: meson: venc: cvbs: fix CVBS mode matching
drivers/gpu/drm/meson/meson_venc_cvbs.c | 48 ++---
1
Use a utility function to remove a bit of code duplication between
meson_venc_cvbs_encoder_atomic_check() and
meson_venc_cvbs_encoder_mode_set(). Both need to look up the struct
meson_venc_cvbs based on a drm_display_mode.
Signed-off-by: Martin Blumenstingl
---
drivers/gpu/drm/meson
support for Amlogic Meson Graphic Controller")
Signed-off-by: Martin Blumenstingl
---
drivers/gpu/drm/meson/meson_venc_cvbs.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/meson/meson_venc_cvbs.c
b/drivers/gpu/drm/meson/meson_venc_cvbs.c
index 6b8a0
nc.c tvenc_mode_{pal,ntsc}) which are
both not setting "picture_aspect_ratio" either.
Fixes: 222ec1618c3ace ("drm: Add aspect ratio parsing in DRM layer")
Fixes: bbbe775ec5b5da ("drm: Add support for Amlogic Meson Graphic Controller")
Signed-off-by: Martin Blumenstingl
On Mon, Aug 26, 2019 at 4:47 PM Neil Armstrong wrote:
>
> When calculating the HDMI PLL settings for a DMT mode PHY frequency,
> use the correct max fractional PLL value for G12A VPU.
>
> With this fix, we can finally setup the 1024x76-60 mode.
nit-pick: is this really 1024x76 or 1024x768?
Hi Neil,
On Wed, Jan 9, 2019 at 2:36 PM Neil Armstrong wrote:
>
> Since commit 2bcd3ecab773 when switching mode from X11 (ubuntu mate for
> example) the display gets blurry, looking like an invalid framebuffer width.
>
> This commit fixed atomic crtc modesetting but didn't update the display
>
Hi Neil,
On Tue, Dec 11, 2018 at 10:21 AM Neil Armstrong wrote:
>
> On 08/12/2018 18:12, Martin Blumenstingl wrote:
> > Add the GPU clock tree on Meson8, Meson8b and Meson8m2.
> >
> > The GPU clock tree on Meson8b and Meson8m2 is almost identical to the
> > one on
rbo" setting is described by "turbo_clock = 4" where 4 is the
index of the table above.
Signed-off-by: Martin Blumenstingl
---
arch/arm/boot/dts/meson8.dtsi | 58 +++
1 file changed, 58 insertions(+)
diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm
. For now meson8_hw_onecell_data is a clone of our
existing meson8b_hw_onecell_data.
Signed-off-by: Martin Blumenstingl
---
drivers/clk/meson/meson8b.c | 203 ++--
1 file changed, 197 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk
fined
state.
Signed-off-by: Martin Blumenstingl
---
Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt
b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt
index 63cd91
s/home
[1] https://abload.de/img/dump0myic0.png
[2] https://patchwork.kernel.org/cover/10719445/
Martin Blumenstingl (5):
dt-bindings: gpu: mali-utgard: add Amlogic Meson8 and Meson8b
compatible
clk: meson: meson8b: use a separate clock table for Meson8
clk: meson: meson8b: add the GPU cl
.
Signed-off-by: Martin Blumenstingl
---
drivers/clk/meson/meson8b.c | 146
drivers/clk/meson/meson8b.h | 9 ++-
2 files changed, 154 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
index 0b9353d8d4fd
where 4 is the
index of the table above.
Signed-off-by: Martin Blumenstingl
---
arch/arm/boot/dts/meson8b.dtsi | 46 ++
1 file changed, 46 insertions(+)
diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
index 5d036842c355..dd498e681939 100
1 - 100 of 106 matches
Mail list logo
