Re: [PATCH v6,15/24] media: mediatek: vcodec: Add one plane format

2024-05-31 Thread Nicolas Dufresne
Le jeudi 16 mai 2024 à 20:20 +0800, Yunfei Dong a écrit : > Adding capture formats to support V4L2_PIX_FMT_MS21. This format has > one plane and only be used for secure video playback at current period. Please, replace "one plane" with "single allocation". This should disambiguate the message a

Re: [PATCH v6,14/24] media: mediatek: vcodec: Add capture format to support one plane memory

2024-05-31 Thread Nicolas Dufresne
Hi, Le jeudi 23 mai 2024 à 18:36 +0800, Chen-Yu Tsai a écrit : > On Thu, May 23, 2024 at 6:14 PM Andrzej Pietrasiewicz > wrote: > > > > Hi, > > > > I'm having second thoughts, please see inline, > > > > W dniu 22.05.2024 o 14:26, Andrzej Pietrasiewicz pisze: > > > Hi Yunfei, > > > > > > W

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-22 Thread Nicolas Dufresne
Le jeudi 16 mai 2024 à 14:20 +0300, Laurent Pinchart a écrit : > On Thu, May 16, 2024 at 07:00:31AM +, Simon Ser wrote: > > On Tuesday, May 14th, 2024 at 22:42, Laurent Pinchart wrote: > > > > > My experience on Arm platforms is that the KMS drivers offer allocation > > > for scanout buffers,

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-21 Thread nicolas . dufresne
Le mardi 21 mai 2024 à 10:43 +0200, Maxime Ripard a écrit : > On Thu, May 16, 2024 at 01:11:51PM GMT, > nicolas.dufre...@collabora.corp-partner.google.com wrote: > > Le jeudi 16 mai 2024 à 14:27 +0300, Laurent Pinchart a écrit : > > > Hi Nicolas, > > > > > > On Wed, May 15, 2024 at 01:43:58PM

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-16 Thread nicolas . dufresne
Le jeudi 16 mai 2024 à 14:27 +0300, Laurent Pinchart a écrit : > Hi Nicolas, > > On Wed, May 15, 2024 at 01:43:58PM -0400, > nicolas.dufre...@collabora.corp-partner.google.com wrote: > > Le mardi 14 mai 2024 à 23:42 +0300, Laurent Pinchart a écrit : > > > > You'll hit the same limitation as we

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-15 Thread nicolas . dufresne
Le mardi 14 mai 2024 à 23:42 +0300, Laurent Pinchart a écrit : > > You'll hit the same limitation as we hit in GStreamer, which is that KMS > > driver > > only offer allocation for render buffers and most of them are missing > > allocators > > for YUV buffers, even though they can import in

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-14 Thread Nicolas Dufresne
Hi, Le mardi 14 mai 2024 à 23:45 +0300, Laurent Pinchart a écrit : > > And finally, none of this fixes the issue that the heap allocation are not > > being > > accounted properly and allow of an easy memory DoS. So uaccess should be > > granted > > with care, meaning that defaulting a "desktop"

Re: [PATCH v7 7/8] media: imagination: Round to closest multiple for cropping region

2024-05-14 Thread Nicolas Dufresne
Le samedi 11 mai 2024 à 22:38 +0530, Devarsh Thakkar a écrit : > Hi Andy, > > Thanks for the quick review. > On 10/05/24 20:40, Andy Shevchenko wrote: > > On Fri, May 10, 2024 at 12:10:01AM +0530, Devarsh Thakkar wrote: > > > If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up >

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-13 Thread Nicolas Dufresne
Le lundi 13 mai 2024 à 11:34 +0300, Laurent Pinchart a écrit : > On Mon, May 13, 2024 at 10:29:22AM +0200, Maxime Ripard wrote: > > On Wed, May 08, 2024 at 10:36:08AM +0200, Daniel Vetter wrote: > > > On Tue, May 07, 2024 at 04:07:39PM -0400, Nicolas Dufresne wrote: > > >

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-13 Thread Nicolas Dufresne
Le lundi 13 mai 2024 à 15:51 +0200, Maxime Ripard a écrit : > On Mon, May 13, 2024 at 09:42:00AM -0400, Nicolas Dufresne wrote: > > Le lundi 13 mai 2024 à 10:29 +0200, Maxime Ripard a écrit : > > > On Wed, May 08, 2024 at 10:36:08AM +0200, Daniel Vetter wrote: > > > >

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-13 Thread Nicolas Dufresne
Le lundi 13 mai 2024 à 10:29 +0200, Maxime Ripard a écrit : > On Wed, May 08, 2024 at 10:36:08AM +0200, Daniel Vetter wrote: > > On Tue, May 07, 2024 at 04:07:39PM -0400, Nicolas Dufresne wrote: > > > Hi, > > > > > > Le mardi 07 mai 2024 à 21:36 +0300, Lauren

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-07 Thread Nicolas Dufresne
Hi, Le mardi 07 mai 2024 à 21:36 +0300, Laurent Pinchart a écrit : > Shorter term, we have a problem to solve, and the best option we have > found so far is to rely on dma-buf heaps as a backend for the frame > buffer allocatro helper in libcamera for the use case described above. > This won't

Re: [PATCH v5 1/9] drm/mediatek/uapi: Add DRM_MTK_GEM_CREATE_ENCRYPTED flag

2024-04-16 Thread Nicolas Dufresne
Hi, Le mercredi 03 avril 2024 à 18:26 +0800, Shawn Sung a écrit : > From: "Jason-JH.Lin" > > Add DRM_MTK_GEM_CREATE_ENCRYPTED flag to allow user to allocate Is "ENCRYPTED" a proper naming ? My expectation is that this would hold data in a PROTECTED memory region but that no cryptographic

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-07 Thread Nicolas Dufresne
Le jeudi 29 février 2024 à 10:02 +0100, Maxime Ripard a écrit : > Hi Helen, > > Thanks for working on this > > On Wed, Feb 28, 2024 at 07:55:25PM -0300, Helen Koike wrote: > > This patch introduces a `.gitlab-ci` file along with a `ci/` folder, > > defininga basic test pipeline triggered by code

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Nicolas Dufresne
Hi, Le jeudi 29 février 2024 à 16:16 +0200, Nikolai Kondrashov a écrit : > On 2/29/24 2:20 PM, Guillaume Tucker wrote: > > Hello, > > > > On 28/02/2024 23:55, Helen Koike wrote: > > > Dear Kernel Community, > > > > > > This patch introduces a `.gitlab-ci` file along with a `ci/` folder, > > >

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Nicolas Dufresne
Hi Tim, just replying below to one of your comment which I happen to be involved in, but I'll let others reply for the more specific comments. Le jeudi 29 février 2024 à 02:44 +, Bird, Tim a écrit : > > -Original Message- > > From: Helen Koike > > > > > > Hey all, > > > >

Re: [PATCH v3,04/21] v4l: add documentation for secure memory flag

2024-01-17 Thread Nicolas Dufresne
Hi, Le mercredi 06 décembre 2023 à 16:15 +0800, Yunfei Dong a écrit : > From: Jeffrey Kardatzke > > Adds documentation for V4L2_MEMORY_FLAG_SECURE. As I noticed from DMA Heap discussions, shall this also be renamed SECURE -> RESTRICTED ? regards, Nicolas > > Signed-off-by: Jeffrey Kardatzke

Re: [PATCH 3/9] dma-heap: Provide accessors so that in-kernel drivers can allocate dmabufs from specific heaps

2023-09-12 Thread Nicolas Dufresne
Le mardi 12 septembre 2023 à 08:47 +, Yong Wu (吴勇) a écrit : > On Mon, 2023-09-11 at 12:12 -0400, Nicolas Dufresne wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > Hi, >

Re: [PATCH 3/9] dma-heap: Provide accessors so that in-kernel drivers can allocate dmabufs from specific heaps

2023-09-12 Thread Nicolas Dufresne
Le mardi 12 septembre 2023 à 16:46 +0200, Christian König a écrit : > Am 12.09.23 um 10:52 schrieb Yong Wu (吴勇): > > [SNIP] > > > But what we should try to avoid is that newly merged drivers provide > > > both a driver specific UAPI and DMA-heaps. The justification that > > > this > > > makes it

Re: [PATCH 3/9] dma-heap: Provide accessors so that in-kernel drivers can allocate dmabufs from specific heaps

2023-09-12 Thread Nicolas Dufresne
Le lundi 11 septembre 2023 à 12:13 +0200, Christian König a écrit : > Am 11.09.23 um 04:30 schrieb Yong Wu: > > From: John Stultz > > > > This allows drivers who don't want to create their own > > DMA-BUF exporter to be able to allocate DMA-BUFs directly > > from existing DMA-BUF Heaps. > > > >

Re: [PATCH 3/9] dma-heap: Provide accessors so that in-kernel drivers can allocate dmabufs from specific heaps

2023-09-11 Thread Nicolas Dufresne
Hi, Le lundi 11 septembre 2023 à 10:30 +0800, Yong Wu a écrit : > From: John Stultz > > This allows drivers who don't want to create their own > DMA-BUF exporter to be able to allocate DMA-BUFs directly > from existing DMA-BUF Heaps. > > There is some concern that the premise of DMA-BUF heaps

Re: [RFC]: shmem fd for non-DMA buffer sharing cross drivers

2023-08-22 Thread Nicolas Dufresne
Hi, Le mardi 22 août 2023 à 19:14 +0800, Hsia-Jun Li a écrit : > Hello > > I would like to introduce a usage of SHMEM slimier to DMA-buf, the major > purpose of that is sharing metadata or just a pure container for cross > drivers. > > We need to exchange some sort of metadata between

Re: [v2] media: mediatek: vcodec: fix AV1 decode fail for 36bit iova

2023-08-02 Thread Nicolas Dufresne
t; > Fixes: 2f5d0aef37c6 ("media: mediatek: vcodec: support stateless AV1 decoder") > Signed-off-by: Xiaoyong Lu With some rework of the commit message, see my suggestions above: Reviewed-by: Nicolas Dufresne > --- > Changes from v1 > > - prefer '|' rather than '+' > -

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-07-13 Thread Nicolas Dufresne
Le samedi 08 juillet 2023 à 21:11 +0200, Thomas Zimmermann a écrit : > Hi > > Am 07.07.23 um 20:09 schrieb Nicolas Dufresne: > [...] > > > > +config DRM_VERISILICON > > > > + tristate "DRM Support for VeriSilicon" > > > > &g

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-07-07 Thread Nicolas Dufresne
Hi Thomas, Le lundi 19 juin 2023 à 14:59 +0200, Thomas Zimmermann a écrit : > Hi, > > I appreciate that you split the driver into small patches. Please find > some comments below. > > Am 02.06.23 um 09:40 schrieb Keith Zhao: > > Add a basic platform driver of the DRM driver for JH7110 SoC. > >

Re: media: mediatek: vcodec: fix AV1 decode fail for 36bit iova

2023-06-28 Thread Nicolas Dufresne
Hi, Le mercredi 28 juin 2023 à 13:41 +0800, Xiaoyong Lu a écrit : > Decoder hardware will access incorrect iova address when tile buffer is > 36bit, leading to iommu fault when hardware access dram data. > > Fixes: 2f5d0aef37c6 ("media: mediatek: vcodec: support stateless AV1 decoder") >

Re: [RFC PATCH v8] media: mediatek: vcodec: support stateless AV1 decoder

2023-03-31 Thread Nicolas Dufresne
you still have to pull the uAPI of course). > > Signed-off-by: Xiaoyong Lu Tested-by: Nicolas Dufresne Reviewed-by: Nicolas Dufresne > --- > Changes from v7: Please, don't forget to include your fluster test result here too. Fluster has 3 test suites, you should provide the s

Re: [PATCH v3 2/7] media: Add Y210, Y212 and Y216 formats

2023-02-24 Thread Nicolas Dufresne
Le jeudi 23 février 2023 à 15:10 +0200, Tomi Valkeinen a écrit : > Hi, > > On 22/02/2023 17:28, Nicolas Dufresne wrote: > > Hi Tomi, > > > > Le mercredi 21 décembre 2022 à 11:24 +0200, Tomi Valkeinen a écrit : > > > Add Y210, Y212 and Y216 formats. > &

Re: [PATCH v3 2/7] media: Add Y210, Y212 and Y216 formats

2023-02-22 Thread Nicolas Dufresne
Hi Tomi, Le mercredi 21 décembre 2022 à 11:24 +0200, Tomi Valkeinen a écrit : > Add Y210, Y212 and Y216 formats. > > Signed-off-by: Tomi Valkeinen > --- > .../media/v4l/pixfmt-packed-yuv.rst | 49 ++- > drivers/media/v4l2-core/v4l2-ioctl.c | 3 ++ >

Re: Try to address the DMA-buf coherency problem

2022-12-06 Thread Nicolas Dufresne
Le lundi 05 décembre 2022 à 09:28 +0100, Christian König a écrit : > Hi Tomasz, > > Am 05.12.22 um 07:41 schrieb Tomasz Figa: > > [SNIP] > > > In other words explicit ownership transfer is not something we would > > > want as requirement in the framework, cause otherwise we break tons of > > >

Re: [PATCH 2/7] media: Add Y210, Y212 and Y216 formats

2022-12-06 Thread Nicolas Dufresne
Hi, Le mardi 06 décembre 2022 à 15:39 +0200, Tomi Valkeinen a écrit : > Add Y210, Y212 and Y216 formats. > > Signed-off-by: Tomi Valkeinen This patch is simply missing an update to: Documentation/userspace-api/media/v4l/yuv-formats.rst regards, Nicolas > --- >

Re: [PATCH 1/7] media: Add 2-10-10-10 RGB formats

2022-12-06 Thread Nicolas Dufresne
Hi, Le mardi 06 décembre 2022 à 15:39 +0200, Tomi Valkeinen a écrit : > Add XBGR2101010, ABGR2101010 and BGRA1010102 formats. > > Signed-off-by: Tomi Valkeinen This patch is simply missing an update to Documentation/userspace-api/media/v4l/pixfmt-rgb.rst regards, Nicolas > --- >

Re: Try to address the DMA-buf coherency problem

2022-11-25 Thread Nicolas Dufresne
Le mercredi 23 novembre 2022 à 17:33 +0100, Daniel Vetter a écrit : > On Wed, Nov 23, 2022 at 10:33:38AM +0200, Pekka Paalanen wrote: > > On Tue, 22 Nov 2022 18:33:59 +0100 > > Christian König wrote: > > > > > We should have come up with dma-heaps earlier and make it clear that > > > exporting

Re: Try to address the DMA-buf coherency problem

2022-11-19 Thread Nicolas Dufresne
Le vendredi 18 novembre 2022 à 11:32 -0800, Rob Clark a écrit : > On Thu, Nov 17, 2022 at 7:38 AM Nicolas Dufresne wrote: > > > > Le jeudi 17 novembre 2022 à 13:10 +0100, Christian König a écrit : > > > > > DMA-Buf let's the exporter setup the D

Re: Try to address the DMA-buf coherency problem

2022-11-17 Thread Nicolas Dufresne
Le jeudi 17 novembre 2022 à 13:10 +0100, Christian König a écrit : > > > DMA-Buf let's the exporter setup the DMA addresses the importer uses to > > > be able to directly decided where a certain operation should go. E.g. we > > > have cases where for example a P2P write doesn't even go to memory,

Re: Try to address the DMA-buf coherency problem

2022-11-04 Thread Nicolas Dufresne
Le vendredi 04 novembre 2022 à 10:03 +0100, Christian König a écrit : > Am 03.11.22 um 23:16 schrieb Nicolas Dufresne: > > [SNIP] > > > > Was there APIs suggested to actually make it manageable by userland to > > allocate > > from the GPU? Yes, this

Re: Try to address the DMA-buf coherency problem

2022-11-03 Thread Nicolas Dufresne
Le mercredi 02 novembre 2022 à 12:18 +0100, Christian König a écrit : > Am 01.11.22 um 22:09 schrieb Nicolas Dufresne: > > [SNIP] > > > > But the client is just a video player. It doesn't understand how to > > > > allocate BOs for Panfrost or AMD o

Re: Try to address the DMA-buf coherency problem

2022-11-01 Thread Nicolas Dufresne
Le mardi 01 novembre 2022 à 18:40 +0100, Christian König a écrit : > Am 28.10.22 um 20:47 schrieb Daniel Stone: > > Hi Christian, > > > > On Fri, 28 Oct 2022 at 18:50, Christian König > > wrote: > > > Am 28.10.22 um 17:46 schrieb Nicolas Dufresne: > >

Re: Try to address the DMA-buf coherency problem

2022-10-28 Thread Nicolas Dufresne
Hi, just dropping some real live use case, sorry I'm not really proposing solutions, I believe you are much more knowledgeable in this regard. Le vendredi 28 octobre 2022 à 16:26 +0200, Christian König a écrit : > Am 28.10.22 um 13:42 schrieb Lucas Stach: > > Am Freitag, dem 28.10.2022 um 10:40

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-24 Thread Nicolas Dufresne
Le vendredi 19 août 2022 à 23:44 +0800, Hsia-Jun Li a écrit : > > On 8/19/22 23:28, Nicolas Dufresne wrote: > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > >

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-24 Thread Nicolas Dufresne
Le jeudi 18 août 2022 à 14:33 +0800, Hsia-Jun Li a écrit : > > On 8/18/22 14:06, Tomasz Figa wrote: > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > > > > Hi Randy, > > > > On Tue, Aug 9,

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-23 Thread Nicolas Dufresne
gt; On Sat, Aug 20, 2022 at 12:44 AM Hsia-Jun Li wrote: > > > > > > > > > > > > On 8/19/22 23:28, Nicolas Dufresne wrote: > > > > CAUTION: Email originated externally, do not click links or open > > > > attachments unless you recognize

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-23 Thread Nicolas Dufresne
Le mardi 23 août 2022 à 15:40 +0800, Hsia-Jun Li a écrit : > > In current state, If your driver can support it, userland does not strictly > > need > > to re-allocate if the resolution is changed to smaller. In most SVC > > scenarios, > > the largest resolution is known in advance, so

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-22 Thread Nicolas Dufresne
Le samedi 20 août 2022 à 08:10 +0800, Hsia-Jun Li a écrit : > > On 8/20/22 03:17, Nicolas Dufresne wrote: > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > > >

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-19 Thread Nicolas Dufresne
Le vendredi 19 août 2022 à 02:13 +0300, Laurent Pinchart a écrit : > On Thu, Aug 18, 2022 at 02:33:42PM +0800, Hsia-Jun Li wrote: > > On 8/18/22 14:06, Tomasz Figa wrote: > > > On Tue, Aug 9, 2022 at 1:28 AM Hsia-Jun Li wrote: > > > > > > > > From: "Hsia-Jun(Randy) Li" > > > > > > > > The most

Re: [EXT] Re: [PATCH 1/3] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-19 Thread Nicolas Dufresne
er...@vger.kernel.org; > linaro-mm-...@lists.linaro.org; christian.koe...@amd.com; > linux-me...@vger.kernel.org; n...@arm.com; Clément Faure > ; dri-devel@lists.freedesktop.org; > benjamin.gaign...@collabora.com > Subject: Re: [EXT] Re: [PATCH 1/3] dma-buf: heaps: add Linar

Re: [EXT] Re: [PATCH 1/3] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-17 Thread Nicolas Dufresne
Hi Folks, Le mardi 16 août 2022 à 11:20 +, Olivier Masse a écrit : > Hi Brian, > > > On ven., 2022-08-12 at 17:39 +0100, Brian Starkey wrote: > > Caution: EXT Ema > > [...] > > > > Interesting, that's not how the devices I've worked on operated. > > > > Are you saying that you have to

Re: [PATCH 3/5] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-16 Thread Nicolas Dufresne
Hi, Le mardi 02 août 2022 à 11:58 +0200, Olivier Masse a écrit : > add Linaro secure heap bindings: linaro,secure-heap Just a curiosity, how is this specific to Linaro OPTEE OS ? Shouldn't it be "de- linaro-ified" somehow ? regards, Nicolas > use genalloc to allocate/free buffer from buffer

Re: DMA-buf and uncached system memory

2022-06-27 Thread Nicolas Dufresne
Le lundi 27 juin 2022 à 16:06 +0200, Lucas Stach a écrit : > Am Montag, dem 27.06.2022 um 09:54 -0400 schrieb Nicolas Dufresne: > > Le jeudi 23 juin 2022 à 11:33 +0200, Lucas Stach a écrit : > > > > > > > > See for example on AMD/Intel hardware most of the en

Re: DMA-buf and uncached system memory

2022-06-27 Thread Nicolas Dufresne
Le jeudi 23 juin 2022 à 11:33 +0200, Lucas Stach a écrit : > > > > See for example on AMD/Intel hardware most of the engines can perfectly > > deal with cache coherent memory accesses. Only the display engines can't. > > > > So on import time we can't even say if the access can be coherent and

Re: DMA-buf and uncached system memory

2022-06-27 Thread Nicolas Dufresne
Hi, Le jeudi 23 juin 2022 à 10:58 +0200, Lucas Stach a écrit : > > > In the DMA API keeping things mapped is also a valid use-case, but then > > > you need to do explicit domain transfers via the dma_sync_* family, > > > which DMA-buf has not inherited. Again those sync are no-ops on cache > > >

Re: DMA-buf and uncached system memory

2022-06-22 Thread Nicolas Dufresne
Le mardi 16 février 2021 à 10:25 +0100, Daniel Vetter a écrit : > So I think if AMD also guarantees to drop clean cachelines just do the > same thing we do right now for intel integrated + discrete amd, but in > reserve. It's fragile, but it does work. Sorry to disrupt, but if you pass V4L2

Re: DMA-buf and uncached system memory

2022-06-21 Thread Nicolas Dufresne
Hi Christian and Andy, Le mardi 21 juin 2022 à 12:34 +0200, Christian König a écrit : >  Hi Andy, >   >  Am 21.06.22 um 12:17 schrieb Andy.Hsieh: >   > > On 2/16/21 4:39 AM, Nicolas Dufresne wrote: > > > Le lundi 15 février 2021 à 09:58 +0100, Christian Köni

Re: [PATCH v7, 04/15] media: mtk-vcodec: Read max resolution from dec_capability

2022-06-21 Thread Nicolas Dufresne
Le vendredi 17 juin 2022 à 14:46 +0800, Chen-Yu Tsai a écrit : > Hi, > > On Mon, Feb 28, 2022 at 04:29:15PM -0500, Nicolas Dufresne wrote: > > Hi Yunfei, > > > > this patch does not work unless userland calls enum_framesizes, which is > > completely optional.

Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186

2022-06-21 Thread Nicolas Dufresne
Le mercredi 15 juin 2022 à 19:37 +0800, yunfei.d...@mediatek.com a écrit : > Hi Nicolas, > > Thanks for your comments. > On Mon, 2022-06-13 at 16:10 -0400, Nicolas Dufresne wrote: > > > > > > Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > &

Re: [PATCH v4, 3/3] media: mediatek: vcodec: add h264 decoder driver for mt8186

2022-06-21 Thread Nicolas Dufresne
Le mercredi 15 juin 2022 à 19:33 +0800, yunfei.d...@mediatek.com a écrit : > Hi Nicolas, > > Thanks for your comments. > On Mon, 2022-06-13 at 16:08 -0400, Nicolas Dufresne wrote: > > Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > > > Add h264 deco

Re: [PATCH] media: mediatek: vcodec: Initialize decoder parameters after getting dec_capability

2022-06-21 Thread Nicolas Dufresne
Hi Yunfei, Le samedi 18 juin 2022 à 15:29 +0800, Yunfei Dong a écrit : > Need to get dec_capability from scp first, then initialize decoder > supported format and other parameters according to dec_capability value. Perhaps something to improve in the future. On top of describing the fix, it

Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186

2022-06-14 Thread Nicolas Dufresne
Le lundi 13 juin 2022 à 16:10 -0400, Nicolas Dufresne a écrit : > Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > > Firstly, add mt8186 compatible and private data, then add document for > > compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single co

Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186

2022-06-13 Thread Nicolas Dufresne
Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > Firstly, add mt8186 compatible and private data, then add document for > compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single core > architecture, need to add new interface for h264 hardware decoder. Would be nice to take the

Re: [PATCH v4, 3/3] media: mediatek: vcodec: add h264 decoder driver for mt8186

2022-06-13 Thread Nicolas Dufresne
Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > Add h264 decode driver to support mt8186. For the architecture > is single core, need to add new interface to decode. > > Signed-off-by: Yunfei Dong > --- > .../vcodec/vdec/vdec_h264_req_multi_if.c | 177 +- > 1

Re: [PATCH v7 0/6] Proposal for a GPU cgroup controller

2022-05-12 Thread Nicolas Dufresne
Le mercredi 11 mai 2022 à 13:31 -0700, T.J. Mercier a écrit : > On Wed, May 11, 2022 at 6:21 AM Nicolas Dufresne wrote: > > > > Hi, > > > > Le mardi 10 mai 2022 à 23:56 +, T.J. Mercier a écrit : > > > This patch series revisits the proposal for a

Re: [PATCH v7 0/6] Proposal for a GPU cgroup controller

2022-05-11 Thread Nicolas Dufresne
Hi, Le mardi 10 mai 2022 à 23:56 +, T.J. Mercier a écrit : > This patch series revisits the proposal for a GPU cgroup controller to > track and limit memory allocations by various device/allocator > subsystems. The patch series also contains a simple prototype to > illustrate how Android

Re: [PATCH v8, 00/15] media: mtk-vcodec: support for M8192 decoder

2022-04-13 Thread Nicolas Dufresne
Le mercredi 13 avril 2022 à 09:57 +0200, AngeloGioacchino Del Regno a écrit : > Il 13/04/22 09:03, allen-kh.cheng ha scritto: > > Hi Nicolas, > > > > On Tue, 2022-04-12 at 10:48 -0400, Nicolas Dufresne wrote: > > > Le lundi 11 avril 2022 à 11:41 +0800, yunfei.d

Re: [PATCH v8, 00/15] media: mtk-vcodec: support for M8192 decoder

2022-04-12 Thread Nicolas Dufresne
Le lundi 11 avril 2022 à 11:41 +0800, yunfei.d...@mediatek.com a écrit : > Hi Nicolas, > > On Thu, 2022-03-31 at 16:48 -0400, Nicolas Dufresne wrote: > > Hi Yunfei, > > > > thanks for the update, I should be testing this really soon. > > > > Le jeudi

Re: [PATCH v8, 16/17] media: mediatek: vcodec: support stateless VP9 decoding

2022-04-07 Thread Nicolas Dufresne
Le mercredi 06 avril 2022 à 15:23 -0400, Nicolas Dufresne a écrit : > Hi Yunfei, > > Le jeudi 31 mars 2022 à 10:48 +0800, Yunfei Dong a écrit : > > Add support for VP9 decoding using the stateless API, > > as supported by MT8192. And the drivers is lat and core architecture

Re: [PATCH v8, 16/17] media: mediatek: vcodec: support stateless VP9 decoding

2022-04-07 Thread Nicolas Dufresne
Le jeudi 31 mars 2022 à 10:48 +0800, Yunfei Dong a écrit : > Add support for VP9 decoding using the stateless API, > as supported by MT8192. And the drivers is lat and core architecture. > > Signed-off-by: George Sun > Signed-off-by: Xiaoyong Lu > Signed-off-by: Yunfei Dong > Reviewed-by:

Re: [PATCH v8, 16/17] media: mediatek: vcodec: support stateless VP9 decoding

2022-04-06 Thread Nicolas Dufresne
Hi Yunfei, Le jeudi 31 mars 2022 à 10:48 +0800, Yunfei Dong a écrit : > Add support for VP9 decoding using the stateless API, > as supported by MT8192. And the drivers is lat and core architecture. > > Signed-off-by: George Sun > Signed-off-by: Xiaoyong Lu > Signed-off-by: Yunfei Dong >

Re: [PATCH] media: mediatek: vcodec: Fix v4l2 compliance decoder cmd test fail

2022-04-06 Thread Nicolas Dufresne
use decoder cmd. > > Fixes: 8cdc3794b2e3 ("media: mtk-vcodec: vdec: support stateless API") > Signed-off-by: Yunfei Dong > Reviewed-by: AngeloGioacchino Del Regno > Acked-by: Nicolas Dufresne > --- > changes compared with v2: > - add reviewed-by t

Re: [PATCH v8, 00/15] media: mtk-vcodec: support for M8192 decoder

2022-03-31 Thread Nicolas Dufresne
Hi Yunfei, thanks for the update, I should be testing this really soon. Le jeudi 31 mars 2022 à 10:47 +0800, Yunfei Dong a écrit : > This series adds support for mt8192 h264/vp8/vp9 decoder drivers. Firstly, > refactor > power/clock/interrupt interfaces for mt8192 is lat and core architecture.

Re: [PATCH v7, 15/15] media: mtk-vcodec: support stateless VP9 decoding

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:40 +0800, Yunfei Dong a écrit : > Add support for VP9 decoding using the stateless API, > as supported by MT8192. And the drivers is lat and core architecture. You already have a reviewed tag, but I'm under the impression that there is a fair amount of duplication

Re: [PATCH v7, 14/15] media: mtk-vcodec: support stateless VP8 decoding

2022-03-01 Thread Nicolas Dufresne
o much code, I'll give you my: Reviewed-by: Nicolas Dufresne > > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/Makefile| 1 + > .../mtk-vcodec/mtk_vcodec_dec_stateless.c | 24 +- > .../platform/mtk-vcodec/mtk_vcodec_drv.h | 1

Re: [PATCH v7, 13/15] media: mtk-vcodec: support stateless H.264 decoding for mt8192

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:40 +0800, Yunfei Dong a écrit : > Adds h264 lat and core architecture driver for mt8192, > and the decode mode is frame based for stateless decoder. > > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/Makefile| 1 + >

Re: [PATCH v7, 12/15] media: mtk-vcodec: Extract H264 common code

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:40 +0800, Yunfei Dong a écrit : > Mt8192 can use some of common code with mt8183. Moves them to > a new file in order to reuse. With the documentation fixed as per my comments below, you can add: Reviewed-by: Nicolas Dufresne > > Signed-off-by:

Re: [PATCH v7, 09/15] media: mtk-vcodec: disable vp8 4K capability

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:40 +0800, Yunfei Dong a écrit : > For vp8 not support 4K, need to disable it. This patch will need to be changed after you have moved this code into the proper ioctl. > > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 3

Re: [PATCH v7, 06/15] media: mtk-vcodec: Refactor get and put capture buffer flow

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:39 +0800, Yunfei Dong a écrit : > For lat and core decode in parallel, need to get capture buffer > when core start to decode and put capture buffer to display > list when core decode done. > > Signed-off-by: Yunfei Dong > --- >

Re: [PATCH v7, 05/15] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:39 +0800, Yunfei Dong a écrit : > lat thread: output queue \ >-> lat hardware -> lat trans buffer > lat trans buffer / > > core thread: capture queue \ > ->core hardware ->

Re: [PATCH v7, 03/15] media: mtk-vcodec: get capture queue buffer size from scp

2022-03-01 Thread Nicolas Dufresne
Thanks for your patch, though perhaps it could be improved, see comment below. Le mercredi 23 février 2022 à 11:39 +0800, Yunfei Dong a écrit : > Different capture buffer format has different buffer size, need to get > real buffer size according to buffer type from scp. > > Signed-off-by: Yunfei

Re: [PATCH v7, 07/15] media: mtk-vcodec: Refactor supported vdec formats and framesizes

2022-03-01 Thread Nicolas Dufresne
Le mercredi 23 février 2022 à 11:40 +0800, Yunfei Dong a écrit : > Supported output and capture format types for mt8192 are different > with mt8183. Needs to get format types according to decoder capability. This patch is both refactoring and changing the behaviour. Can you please split the

Re: [PATCH v7, 04/15] media: mtk-vcodec: Read max resolution from dec_capability

2022-02-28 Thread Nicolas Dufresne
Hi Yunfei, this patch does not work unless userland calls enum_framesizes, which is completely optional. See comment and suggestion below. Le mercredi 23 février 2022 à 11:39 +0800, Yunfei Dong a écrit : > Supported max resolution for different platforms are not the same: 2K > or 4K, getting it

Re: [PATCH v6, 06/15] media: mtk-vcodec: Refactor get and put capture buffer flow

2022-02-17 Thread Nicolas Dufresne
Le jeudi 17 février 2022 à 17:03 +0800, yunfei.d...@mediatek.com a écrit : > > > - ret = vdec_if_decode(ctx, bs_src, dst_buf, _chg); > > > + ret = vdec_if_decode(ctx, bs_src, NULL, _chg); > > >   if (ret) { > > >   mtk_v4l2_err(" <===[%d], src_buf[%d] sz=0x%zx pts=%llu > >

Re: [PATCH v6, 06/15] media: mtk-vcodec: Refactor get and put capture buffer flow

2022-01-28 Thread Nicolas Dufresne
Hi Yunfei, thanks for you work, see comments below... Le samedi 22 janvier 2022 à 11:53 +0800, Yunfei Dong a écrit : > For lat and core decode in parallel, need to get capture buffer > when core start to decode and put capture buffer to display > list when core decode done. > > Signed-off-by:

Re: [PATCH v4, 00/15] media: mtk-vcodec: support for MT8192 decoder

2022-01-11 Thread Nicolas Dufresne
Hello Yunfei, Le lundi 10 janvier 2022 à 16:34 +0800, Yunfei Dong a écrit : > This series adds support for mt8192 h264/vp8/vp9 decoder drivers. Firstly, > refactor > power/clock/interrupt interfaces for mt8192 is lat and core architecture. > > Secondly, add new functions to get frame buffer

Re: [PATCH v1, 12/12] media: mtk-vcodec: Add h264 slice api driver for mt8192

2021-12-15 Thread Nicolas Dufresne
Hi Yunfei, Le mercredi 15 décembre 2021 à 14:59 +0800, Yunfei Dong a écrit : > From: Yunfei Dong > > Adds h264 lat and core driver for mt8192. This is purely a nit, but I have first notice the usage of "slice" in the namespace and the title, which lead me to think this new platform was

Re: [PATCH v2] media: mtk-vcodec: Align width and height to 64 bytes

2021-11-03 Thread Nicolas Dufresne
Le mercredi 03 novembre 2021 à 11:37 +0800, Yunfei Dong a écrit : > Width and height need to 64 bytes aligned when setting the format. > Need to make sure all is 64 bytes align when use width and height to > calculate buffer size. > > Signed-off-by: Yunfei Dong > Change-Id:

Re: DMA-buf and uncached system memory

2021-02-15 Thread Nicolas Dufresne
Le lundi 15 février 2021 à 09:58 +0100, Christian König a écrit : > Hi guys, > > we are currently working an Freesync and direct scan out from system > memory on AMD APUs in A+A laptops. > > On problem we stumbled over is that our display hardware needs to scan > out from uncached system

Re: DMA-buf and uncached system memory

2021-02-15 Thread Nicolas Dufresne
Le lundi 15 février 2021 à 13:10 +0100, Christian König a écrit : > > > Am 15.02.21 um 13:00 schrieb Thomas Zimmermann: > > Hi > > > > Am 15.02.21 um 10:49 schrieb Thomas Zimmermann: > > > Hi > > > > > > Am 15.02.21 um 09:58 schrieb Christian König: > > > > Hi guys, > > > > > > > > we are

Re: [PATCH 2/9] misc: Add Xilinx AI engine device driver

2020-12-09 Thread Nicolas Dufresne
Le mercredi 18 novembre 2020 à 00:06 -0800, Wendy Liang a écrit : > Create AI engine device/partition hierarchical structure. > > Each AI engine device can have multiple logical partitions(groups of AI > engine tiles). Each partition is column based and has its own node ID > in the system. AI

Re: [PATCH v5 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation

2020-12-08 Thread Nicolas Dufresne
Le vendredi 13 novembre 2020 à 21:39 +0100, Daniel Vetter a écrit : > On Thu, Nov 12, 2020 at 08:11:02PM -0800, John Stultz wrote: > > On Thu, Nov 12, 2020 at 1:32 AM Daniel Vetter wrote: > > > On Thu, Nov 12, 2020 at 11:09:04AM +0530, Sumit Semwal wrote: > > > > On Tue, 10 Nov 2020 at 09:19,

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-27 Thread Nicolas Dufresne
Le mardi 25 août 2020 à 13:30 +0200, Mauro Carvalho Chehab a écrit : > Em Tue, 25 Aug 2020 05:29:29 +1000 > Dave Airlie escreveu: > > > On Thu, 20 Aug 2020 at 20:02, Laurent Pinchart > > wrote: > > > Hi Mauro, > > > > > > On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote:

Re: [RFC] Experimental DMA-BUF Device Heaps

2020-08-26 Thread Nicolas Dufresne
Le jeudi 20 août 2020 à 18:54 +0300, Laurent Pinchart a écrit : > Hi Ezequiel, > > On Thu, Aug 20, 2020 at 05:36:40AM -0300, Ezequiel Garcia wrote: > > Hi John, > > > > Thanks a ton for taking the time > > to go thru this. > > > > On Mon, 2020-08-17 at 21:13 -0700, John Stultz wrote: > > > On

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Nicolas Dufresne
Le samedi 04 avril 2020 à 15:55 +0200, Andreas Bergmeier a écrit : > The problem of data transfer costs is not new in Cloud environments. At work > we usually just opt for paying for it since dev time is scarser. For private > projects though, I opt for aggressive (remote) caching. > So you can

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Nicolas Dufresne
Le samedi 04 avril 2020 à 08:11 -0700, Rob Clark a écrit : > On Fri, Apr 3, 2020 at 7:12 AM Michel Dänzer wrote: > > On 2020-03-01 6:46 a.m., Marek Olšák wrote: > > > For Mesa, we could run CI only when Marge pushes, so that it's a strictly > > > pre-merge CI. > > > > Thanks for the suggestion!

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

2020-03-19 Thread Nicolas Dufresne
Le mercredi 18 mars 2020 à 11:05 +0100, Michel Dänzer a écrit : > On 2020-03-17 6:21 p.m., Lucas Stach wrote: > > That's one of the issues with implicit sync that explicit may solve: > > a single client taking way too much time to render something can > > block the whole pipeline up until the

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Nicolas Dufresne
Le mardi 17 mars 2020 à 11:27 -0500, Jason Ekstrand a écrit : > On Tue, Mar 17, 2020 at 10:33 AM Nicolas Dufresne > wrote: > > Le lundi 16 mars 2020 à 23:15 +0200, Laurent Pinchart a écrit : > > > Hi Jason, > > > > > > On Mon, Mar 16, 2020 at

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Nicolas Dufresne
Le lundi 16 mars 2020 à 23:15 +0200, Laurent Pinchart a écrit : > Hi Jason, > > On Mon, Mar 16, 2020 at 10:06:07AM -0500, Jason Ekstrand wrote: > > On Mon, Mar 16, 2020 at 5:20 AM Laurent Pinchart wrote: > > > On Wed, Mar 11, 2020 at 04:18:55PM -0400, Nicolas Dufresne wr

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-12 Thread Nicolas Dufresne
(I know I'm going to be spammed by so many mailing list ...) Le mercredi 11 mars 2020 à 14:21 -0500, Jason Ekstrand a écrit : > On Wed, Mar 11, 2020 at 12:31 PM Jason Ekstrand wrote: > > All, > > > > Sorry for casting such a broad net with this one. I'm sure most people > > who reply will get

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-03-02 Thread Nicolas Dufresne
Le dimanche 01 mars 2020 à 15:14 +0100, Michel Dänzer a écrit : > On 2020-02-29 8:46 p.m., Nicolas Dufresne wrote: > > Le samedi 29 février 2020 à 19:14 +0100, Timur Kristóf a écrit : > > > 1. I think we should completely disable running the CI on MRs which are > > >

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-03-02 Thread Nicolas Dufresne
Le samedi 29 février 2020 à 15:54 -0600, Jason Ekstrand a écrit : > On Sat, Feb 29, 2020 at 3:47 PM Timur Kristóf wrote: > > On Sat, 2020-02-29 at 14:46 -0500, Nicolas Dufresne wrote: > > > > 1. I think we should completely disable running the CI on MRs which > >

Re: [Intel-gfx] [Mesa-dev] gitlab.fd.o financial situation and impact on services

2020-03-02 Thread Nicolas Dufresne
Hi Jason, I personally think the suggestion are still a relatively good brainstorm data for those implicated. Of course, those not implicated in the CI scripting itself, I'd say just keep in mind that nothing is black and white and every changes end-up being time consuming. Le dimanche 01 mars

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-03-02 Thread Nicolas Dufresne
Le samedi 29 février 2020 à 19:14 +0100, Timur Kristóf a écrit : > On Fri, 2020-02-28 at 10:43 +, Daniel Stone wrote: > > On Fri, 28 Feb 2020 at 10:06, Erik Faye-Lund > > wrote: > > > On Fri, 2020-02-28 at 11:40 +0200, Lionel Landwerlin wrote: > > > > Yeah, changes on vulkan drivers or

  1   2   >