Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Paneer Selvam, Arunpravin
Hi Dave, Please help pull this patch into drm-next. This will fix any unnecessary warnings in memory pressure situation. Thanks for the help. Regards, Arun. On 5/17/2024 8:03 PM, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Paneer Selvam, Arunpravin
On 5/17/2024 7:30 PM, Matthew Auld wrote: On 17/05/2024 14:50, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during force_merge

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Paneer Selvam, Arunpravin
Hi Matthew, This fixes the problem. Regards, Arun. On 5/17/2024 7:20 PM, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during

Re: [PATCH] drm/buddy: Merge back blocks in bias range function

2024-05-17 Thread Paneer Selvam, Arunpravin
Hi Matthew, Could you help review this patch quickly. Hi Dave This patch just fixes the unnecessary warn on's triggered during the force_merge call. Regards, Arun. On 5/17/2024 6:08 PM, Arunpravin Paneer Selvam wrote: In bias range allocation, when we don't find the required blocks (i.e) on

Re: [git pull] drm urgent for 6.10-rc1

2024-05-16 Thread Paneer Selvam, Arunpravin
On 5/17/2024 12:01 AM, Alex Deucher wrote: On Thu, May 16, 2024 at 2:02 PM Linus Torvalds wrote: On Wed, 15 May 2024 at 19:54, Dave Airlie wrote: Here is the buddy allocator fix I picked up from the list, please apply. So I removed my reverts, and am running a kernel that includes the

Re: [git pull] drm for 6.10-rc1

2024-05-16 Thread Paneer Selvam, Arunpravin
On 5/16/2024 8:12 AM, Dave Airlie wrote: On Thu, 16 May 2024 at 10:06, Dave Airlie wrote: On Thu, 16 May 2024 at 09:50, Dave Airlie wrote: On Thu, 16 May 2024 at 06:29, Linus Torvalds wrote: On Wed, 15 May 2024 at 13:24, Linus Torvalds wrote: I have to revert both a68c7eaa7a8f

Re: [PATCH v2 2/2] drm/tests: Add a unit test for range bias allocation

2024-05-13 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 5/13/2024 1:49 PM, Matthew Auld wrote: On 12/05/2024 08:59, Arunpravin Paneer Selvam wrote: Allocate cleared blocks in the bias range when the DRM buddy's clear avail is zero. This will validate the bias range allocation in scenarios like system boot when no cleared blocks are

Re: [PATCH] drm/buddy: Fix the range bias clear memory allocation issue

2024-05-12 Thread Paneer Selvam, Arunpravin
Hi Daniel, On 5/8/2024 2:11 PM, Daniel Vetter wrote: On Wed, May 08, 2024 at 12:27:20PM +0530, Arunpravin Paneer Selvam wrote: Problem statement: During the system boot time, an application request for the bulk volume of cleared range bias memory when the clear_avail is zero, we dont fallback

Re: [PATCH v11 1/3] drm/buddy: Implement tracking clear page feature

2024-04-15 Thread Paneer Selvam, Arunpravin
Hi Christian, Could you please push these patches into drm branch. Thanks, Arun. On 4/15/2024 2:53 AM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the

Re: [PATCH v10 1/3] drm/buddy: Implement tracking clear page feature

2024-04-14 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 4/10/2024 6:22 PM, Matthew Auld wrote: On 08/04/2024 16:16, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each

Re: [PATCH v10 1/3] drm/buddy: Implement tracking clear page feature

2024-04-08 Thread Paneer Selvam, Arunpravin
Hi Matthew, Could you please review these changes as few clients are waiting for these patches. Thanks, Arun. On 4/8/2024 8:46 PM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

2024-04-01 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 3/28/2024 10:18 PM, Matthew Auld wrote: On 28/03/2024 16:07, Paneer Selvam, Arunpravin wrote: Hi Matthew, On 3/26/2024 11:39 PM, Matthew Auld wrote: On 18/03/2024 21:40, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

2024-03-28 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 3/26/2024 11:39 PM, Matthew Auld wrote: On 18/03/2024 21:40, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-27 Thread Paneer Selvam, Arunpravin
Hi Alex, On 3/26/2024 8:23 PM, Alex Deucher wrote: On Tue, Mar 26, 2024 at 10:01 AM Alex Deucher wrote: On Tue, Mar 26, 2024 at 9:59 AM Paneer Selvam, Arunpravin wrote: Hi Alex, On 3/26/2024 7:08 PM, Alex Deucher wrote: On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam wrote: Add

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-26 Thread Paneer Selvam, Arunpravin
Hi Alex, On 3/26/2024 7:08 PM, Alex Deucher wrote: On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam wrote: Add clear page support in vram memory region. v1(Christian): - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that.

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

2024-03-25 Thread Paneer Selvam, Arunpravin
Hi Matthew, ping? Thanks, Arun. On 3/19/2024 3:10 AM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. -

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-19 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/19/2024 7:17 PM, Christian König wrote: Am 19.03.24 um 12:41 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 3/19/2024 3:58 PM, Christian König wrote: Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region. v1(Christian

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-19 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/19/2024 3:58 PM, Christian König wrote: Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region. v1(Christian):    - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that.   

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

2024-03-07 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 3/6/2024 11:19 PM, Matthew Auld wrote: On 04/03/2024 16:32, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

2024-03-06 Thread Paneer Selvam, Arunpravin
Hi Matthew, Ping? Thanks, Arun. On 3/4/2024 10:02 PM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. -

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

2024-03-06 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/5/2024 5:41 PM, Christian König wrote: Am 05.03.24 um 12:14 schrieb Paneer Selvam, Arunpravin: On 3/5/2024 4:33 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

2024-03-05 Thread Paneer Selvam, Arunpravin
On 3/5/2024 4:33 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add amdgpu driver as user for the drm buddy defragmentation. Signed-off-by: Arunpravin Paneer Selvam ---   drivers/gpu

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

2024-03-05 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add amdgpu driver as user for the drm buddy defragmentation. Signed-off-by: Arunpravin Paneer Selvam ---   drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 17 +++--  

Re: [PATCH v7 3/3] drm/buddy: Add defragmentation support

2024-03-04 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 2/22/2024 12:12 AM, Matthew Auld wrote: On 21/02/2024 12:18, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1:    - Defragment the memory beginning from min_order till the required memory space is available. v2(Matthew):    - add amdgpu user

Re: [PATCH 2/2] drm/tests/buddy: stop using PAGE_SIZE

2024-02-29 Thread Paneer Selvam, Arunpravin
Reviewed-by: Arunpravin Paneer Selvam On 2/29/2024 4:21 PM, Matthew Auld wrote: Gives the wrong impression that min page-size has to be tied to the CPU PAGE_SIZE. Signed-off-by: Matthew Auld Cc: Arunpravin Paneer Selvam Cc: Christian König Cc: Arnd Bergmann ---

Re: [PATCH 1/2] drm/buddy: stop using PAGE_SIZE

2024-02-29 Thread Paneer Selvam, Arunpravin
Reviewed-by: Arunpravin Paneer Selvam On 2/29/2024 4:21 PM, Matthew Auld wrote: The drm_buddy minimum page-size requirements should be distinct from the CPU PAGE_SIZE. Only restriction is that the minimum page-size is at least 4K. Signed-off-by: Matthew Auld Cc: Arunpravin Paneer Selvam Cc:

Re: [PATCH] drm/tests/buddy: fix print format

2024-02-29 Thread Paneer Selvam, Arunpravin
Reviewed-by: Arunpravin Paneer Selvam On 2/29/2024 3:22 PM, Matthew Auld wrote: This will report a build warning once we have: 806cb2270237 ("kunit: Annotate _MSG assertion variants with gnu printf specifiers"). Reported-by: Stephen Rothwell Fixes: c70703320e55 ("drm/tests/drm_buddy: add

Re: [PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

2024-02-21 Thread Paneer Selvam, Arunpravin
On 2/16/2024 5:33 PM, Matthew Auld wrote: On 08/02/2024 15:49, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each block as

Re: [PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

2024-02-21 Thread Paneer Selvam, Arunpravin
On 2/16/2024 5:33 PM, Matthew Auld wrote: On 08/02/2024 15:49, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each block as

RE: [PATCH] drm/ttm: fix bulk move handling v2

2022-06-14 Thread Paneer Selvam, Arunpravin
[AMD Official Use Only - General] Hi Christian, I verified the patch, I don’t see the crashes. Reviewed-by: Arunpravin Paneer Selvam Thanks, Arun -Original Message- From: Christian König Sent: Monday, June 13, 2022 1:38 PM To: Paneer Selvam, Arunpravin ; m...@fireburn.co.uk; amd

RE: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-28 Thread Paneer Selvam, Arunpravin
: Monday, May 16, 2022 8:36 PM To: Mike Lothian Cc: Paneer Selvam, Arunpravin ; Intel Graphics Development ; amd-gfx list ; Maling list - DRI developers ; Deucher, Alexander ; Koenig, Christian ; Matthew Auld Subject: Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu On Mon, May 16, 2022

RE: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-04-26 Thread Paneer Selvam, Arunpravin
[AMD Official Use Only - General] Hi Christian, I will check this issue. Regards, Arun -Original Message- From: Koenig, Christian Sent: Tuesday, April 26, 2022 10:06 PM To: Mike Lothian ; Paneer Selvam, Arunpravin Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org

RE: [drm/selftests] 39ec47bbfd: kernel_BUG_at_drivers/gpu/drm/drm_buddy.c

2022-02-28 Thread Paneer Selvam, Arunpravin
[AMD Official Use Only] Hi Christian, I will check Thanks, Arun -Original Message- From: Koenig, Christian Sent: Monday, February 28, 2022 4:29 PM To: kernel test robot ; Paneer Selvam, Arunpravin Cc: 0day robot ; Matthew Auld ; LKML ; l...@lists.01.org; dri-devel

RE: [PATCH v9 1/6] drm: move the buddy allocator from i915 into common drm

2022-01-20 Thread Paneer Selvam, Arunpravin
and forth. Let me know when there are more rbs on the rest and I will push that as well. Thanks, Christian. -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Wednesday, January 19, 2022 12:54 PM To: Paneer Selvam, Arunpravin ; dri-devel@lists.freedesktop.org; intel

RE: [PATCH v4 2/6] drm: improve drm_buddy_alloc function

2021-12-09 Thread Paneer Selvam, Arunpravin
; Paneer Selvam, Arunpravin ; jani.nik...@linux.intel.com; matthew.a...@intel.com; tzimmerm...@suse.de; Deucher, Alexander ; Koenig, Christian Subject: [PATCH v4 2/6] drm: improve drm_buddy_alloc function - Make drm_buddy_alloc a single function to handle range allocation and non-range

RE: [PATCH v4 4/6] drm: implement a method to free unused pages

2021-12-09 Thread Paneer Selvam, Arunpravin
[Public] Hi Matthew, Ping? Regards, Arun -Original Message- From: Paneer Selvam, Arunpravin Sent: Wednesday, December 1, 2021 10:10 PM To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; amd-...@lists.freedesktop.org Cc: matthew.a...@intel.com; dan...@ffwll.ch

RE: [PATCH 1/2] Enable buddy memory manager support

2021-09-22 Thread Paneer Selvam, Arunpravin
ch public function Thanks, Arun -Original Message- From: Koenig, Christian Sent: Wednesday, September 22, 2021 12:28 PM To: Paneer Selvam, Arunpravin ; dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; amd-...@lists.freedesktop.org; matthew.a...@intel.com; dan...

RE: [PATCH 1/2] Enable buddy memory manager support

2021-09-22 Thread Paneer Selvam, Arunpravin
[AMD Public Use] Hi Alex, I will fix the name and send a document in my next version. Thanks, Arun -Original Message- From: Alex Deucher Sent: Tuesday, September 21, 2021 12:54 AM To: Paneer Selvam, Arunpravin Cc: Maling list - DRI developers ; Intel Graphics Development ; amd-gfx

RE: [PATCH 2/2] Add drm buddy manager support to amdgpu driver

2021-09-22 Thread Paneer Selvam, Arunpravin
[AMD Public Use] Hi Christian, Thanks for the review, I will the send the next version fixing all issues. Regards, Arun -Original Message- From: Christian König Sent: Wednesday, September 22, 2021 12:18 PM To: Paneer Selvam, Arunpravin ; Koenig, Christian ; dri-devel

RE: [PATCH 2/2] Add drm buddy manager support to amdgpu driver

2021-09-21 Thread Paneer Selvam, Arunpravin
[AMD Public Use] Hi Christian, Please find my comments. Thanks, Arun -Original Message- From: Koenig, Christian Sent: Tuesday, September 21, 2021 2:34 PM To: Paneer Selvam, Arunpravin ; dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; amd-...@lists.freedesktop.org