Hi
On Tue, Dec 7, 2021 at 8:13 AM Doug Anderson wrote:
>
> Hi,
>
> On Mon, Dec 6, 2021 at 5:44 PM Philip Chen wrote:
> >
> > Hi
> >
> > On Mon, Dec 6, 2021 at 4:29 PM Douglas Anderson
> > wrote:
> > >
> > > When we added the su
drm_bridge *bridge,
> if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR))
> return -EINVAL;
>
> + ps_bridge->aux.drm_dev = bridge->dev;
> ret = drm_dp_aux_register(_bridge->aux);
> if (ret) {
> dev_err(dev, "failed to register DP AUX channel: %d\n", ret);
> --
> 2.34.1.400.ga245620fadb-goog
>
Signed-off-by: Philip Chen
input/output endpoint of the controller is expected to have 4 lanes.
So let's set num_data_lanes to 4 by default.
Signed-off-by: Philip Chen
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
b/drivers/gpu/drm/msm/dsi/dsi
Add "Sam Ravnborg " to cc list for vis.
Remove "Andrzej Hajda " from cc list as the
address can't be found.
On Thu, Oct 28, 2021 at 10:58 AM Philip Chen wrote:
>
> Fit ps8640 driver into runtime power management framework:
>
> First, break _poweron() to 3 p
evice tree. In this case, panel driver can retrieve
EDID by triggering AUX transactions, without ps8640_bridge_get_edid()
calls at all.
To prevent the "old" and "new" options from interfering with each
other's logic flow, disable DRM_BRIDGE_OP_EDID when the new option
is taken.
Signed
s no reason to check there. The other user of "powered",
_get_edid(), only cares if pre_enable() has already been called.
Lastly, change some existing DRM_...() logging to dev_...() along the
way, since DRM_...() seem to be deprecated in [1].
[1] https://patchwork.freedesktop.org/patch/
Hi Doug,
On Wed, Oct 27, 2021 at 3:08 PM Doug Anderson wrote:
>
> Hi,
>
> On Tue, Oct 26, 2021 at 2:56 PM Philip Chen wrote:
> >
> > Fit ps8640 driver into runtime power management framework:
> >
> > First, break _poweron() to 3 parts: (1) turn on power an
Hi Doug
On Wed, Oct 27, 2021 at 3:13 PM Doug Anderson wrote:
>
> Hi,
>
> On Tue, Oct 26, 2021 at 2:56 PM Philip Chen wrote:
> >
> > Conventionally, panel is listed under the root of the device tree.
> > When userland asks for display mode, ps8640 bridge is resp
evice tree. In this case, panel driver can retrieve
EDID by triggering AUX transactions, without ps8640_bridge_get_edid()
calls at all.
To prevent the "old" and "new" options from interfering with each
other's logic flow, disable DRM_BRIDGE_OP_EDID when the new option
is taken.
Signed
s no reason to check there. The other user of "powered",
_get_edid(), only cares if pre_enable() has already been called.
Lastly, change some existing DRM_...() logging to dev_...() along the
way, since DRM_...() seem to be deprecated in [1].
[1] https://patchwork.freedesktop.org/patch/
Hi
On Tue, Oct 26, 2021 at 12:36 PM Stephen Boyd wrote:
>
> Quoting Philip Chen (2021-10-26 12:11:09)
> > Fit ps8640 driver into runtime power management framework:
> >
> > First, break _poweron() to 3 parts: (1) turn on power and wait for
> > ps8640's internal MCU
Hi
On Mon, Oct 25, 2021 at 1:05 PM Stephen Boyd wrote:
>
> Quoting Philip Chen (2021-10-21 14:05:59)
> > Fit ps8640 driver into runtime power management framework:
> >
> > First, break _poweron() to 3 parts: (1) turn on power and wait for
> > ps8640's internal MCU
evice tree. In this case, panel driver can retrieve
EDID by triggering AUX transactions, without ps8640_bridge_get_edid()
calls at all.
To prevent the "old" and "new" options from interfering with each
other's logic flow, disable DRM_BRIDGE_OP_EDID when the new option
is taken.
Signed
s no reason to check there. The other user of "powered",
_get_edid(), only cares if pre_enable() has already been called.
Lastly, change some existing DRM_...() logging to dev_...() along the
way, since DRM_...() seem to be deprecated in [1].
[1] https://patchwork.freedesktop.org/patch/
Hi,
On Mon, Oct 25, 2021 at 1:10 PM Stephen Boyd wrote:
>
> Quoting Philip Chen (2021-10-21 14:06:00)
> > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c
> > b/drivers/gpu/drm/bridge/parade-ps8640.c
> > index 220ca3b03d24..f99a2e0808b7 100644
> > --- a/drivers/
Hi Doug,
I see this patch fixes the order for
drm_bridge_chain_pre_enable() and drm_atomic_bridge_chain_post_disable().
For completeness, shouldn't we also fix the order for
drm_atomic_bridge_chain_pre_enable() and drm_bridge_chain_post_disable()?
Surely, if Sam's pending patches will land
Hi Doug,
On Mon, Oct 18, 2021 at 1:43 PM Doug Anderson wrote:
>
> Hi,
>
> On Sat, Oct 16, 2021 at 9:57 AM Philip Chen wrote:
> >
> > Conventionally, panel is listed under the root in the device tree.
> > When userland asks for display mode, ps8640 bridge is resp
Hi Doug,
On Mon, Oct 18, 2021 at 1:43 PM Doug Anderson wrote:
>
> Hi,
>
> On Sat, Oct 16, 2021 at 9:57 AM Philip Chen wrote:
> >
> > @@ -319,81 +345,70 @@ static void ps8640_bridge_poweron(struct ps8640
> > *ps_bridge)
> > */
> >
evice tree. In this case, panel driver can retrieve
EDID by triggering AUX transactions, without ps8640_bridge_get_edid()
calls at all.
To prevent the "old" and "new" options from interfering with each
other's logic flow, disable DRM_BRIDGE_OP_EDID when the new option
is take
s no reason to check there. The other user of "powered",
_get_edid(), only cares if pre_enable() has already been called.
Lastly, change some existing DRM_...() logging to dev_...() along the
way, since DRM_...() seem to be deprecated in [1].
[1] https://patchwork.freedesktop.org/patch/454760/
Signed
evice tree. In this case, panel driver can retrieve
EDID by triggering AUX transactions, without ps8640_bridge_get_edid()
calls at all.
To prevent the "old" and "new" options from interfering with each
other's logic flow, disable DRM_BRIDGE_OP_EDID when the new option
is take
here. The other user of "powered",
_get_edid(), only cares if pre_enable() has already been called.
Lastly, change some existing DRM_...() logging to dev_...() along the
way, since DRM_...() seem to be deprecated in [1].
[1] https://patchwork.freedesktop.org/patch/454760/
Signed-off-by:
dp-aux-bus.yaml says we can list an eDP panel as a child of
an eDP controller node to represent the fact that the panel
is connected to the controller's DP AUX bus.
Let's add it to the ps8640 bindings.
Signed-off-by: Philip Chen
---
(no changes since v1)
.../bindings/display/bridge/ps8640
Hi
On Tue, Sep 21, 2021 at 9:02 AM Doug Anderson wrote:
>
> Hi,
>
> On Sat, Sep 18, 2021 at 10:21 AM Philip Chen wrote:
> >
> > +static ssize_t ps8640_aux_transfer(struct drm_dp_aux *aux,
> > + struct drm_dp_aux_msg *msg)
&g
Implement the first version of AUX support, which will be useful as
we expand the driver to support varied use cases.
Reviewed-by: Sam Ravnborg
Signed-off-by: Philip Chen
---
Changes in v6:
- Error check the aux address is no greater than 20 bits
- Read RDATA into a u32 variable and then copy
Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs,
which will simplify the future update on ps8640 driver.
Reviewed-by: Douglas Anderson
Acked-by: Sam Ravnborg
Signed-off-by: Philip Chen
---
(no changes since v4)
Changes in v4:
- Remove excessive error logging from
Hi Sam,
On Sat, Sep 18, 2021 at 1:29 PM Sam Ravnborg wrote:
>
> Hi Philip,
> On Sat, Sep 18, 2021 at 10:21:17AM -0700, Philip Chen wrote:
> > Implement the first version of AUX support, which will be useful as
> > we expand the driver to support varied use cases.
> >
Implement the first version of AUX support, which will be useful as
we expand the driver to support varied use cases.
Signed-off-by: Philip Chen
---
Changes in v5:
- Add a couple of syntax fixes accidentally uncommited in v4
Changes in v4:
- Fix aux_transfer function:
- Replace dev_err
Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs,
which will simplify the future update on ps8640 driver.
Reviewed-by: Douglas Anderson
Signed-off-by: Philip Chen
---
(no changes since v4)
Changes in v4:
- Remove excessive error logging from the probe function
Changes
Hi
On Tue, Sep 14, 2021 at 5:57 PM Stephen Boyd wrote:
>
> Quoting Philip Chen (2021-09-14 16:28:45)
> > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c
> > b/drivers/gpu/drm/bridge/parade-ps8640.c
> > index 8d3e7a147170..dc349d729f5a 100644
> > --- a/drivers/
Hi
On Thu, Sep 16, 2021 at 1:31 PM Doug Anderson wrote:
>
> Hi,
>
> On Thu, Sep 16, 2021 at 1:15 PM Stephen Boyd wrote:
> >
> > > > > + return ret;
> > > > > + }
> > > > > +
> > > > > + /* Assume it's good */
> > > > > + msg->reply = 0;
> > > > > +
> > > > > +
Hi Doug and Stephen,
Thanks for the review.
Before we reach a consensus on the best logging option, I'll just
remove the printouts from this patch and just return PTR_ERR.
Once we reach a consensus, we can probably improve logging in a separate patch.
On Fri, Sep 17, 2021 at 8:02 AM Doug
Stephen Boyd wrote:
>
> Quoting Philip Chen (2021-09-14 16:28:43)
> > Use dev_err_probe() to add logs for error cases at probing time.
> >
> > Signed-off-by: Philip Chen
> > ---
> >
>
> Can you use a cover-letter for more than one patch series?
>
>
Implement the first version of AUX support, which will be useful as
we expand the driver to support varied use cases.
Signed-off-by: Philip Chen
---
Changes in v4:
- Fix aux_transfer function:
- Replace dev_err with DRM_DEV_ERROR
- Reorg the bit manipulation around address/len/request
Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs,
which will simplify the future update on ps8640 driver.
Reviewed-by: Douglas Anderson
Signed-off-by: Philip Chen
---
Changes in v4:
- Remove excessive error logging from the probe function
Changes in v3:
- Fix the nits
Hi Fabio
On Wed, Sep 15, 2021 at 2:00 PM Fabio Estevam wrote:
>
> On Wed, Sep 15, 2021 at 5:41 PM Philip Chen wrote:
>
> > As regmap_read() should always read 1 byte at a time, should I just do:
> > regmap_read(map, PAGE0_SWAUX_RDATA, (unsigned int*)(buf + i))
>
> The
Hi
On Tue, Sep 14, 2021 at 5:57 PM Stephen Boyd wrote:
>
> Quoting Philip Chen (2021-09-14 16:28:45)
> > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c
> > b/drivers/gpu/drm/bridge/parade-ps8640.c
> > index 8d3e7a147170..dc349d729f5a 100644
> > --- a/drivers/
Hi
On Mon, Sep 13, 2021 at 4:43 PM Doug Anderson wrote:
>
> Hi,
>
> On Mon, Sep 13, 2021 at 2:33 PM Philip Chen wrote:
> >
> > Implement the first version of AUX support, which will be useful as
> > we expand the driver to support varied use cases.
> >
Hi, Doug
Thanks for the review.
I fixed the nits you pointed out in v3.
PTAL.
On Mon, Sep 13, 2021 at 5:32 PM Doug Anderson wrote:
>
> Hi,
>
> On Mon, Sep 13, 2021 at 2:33 PM Philip Chen wrote:
> >
> > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c
> > b
Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs,
which will simplify the future update on ps8640 driver.
Reviewed-by: Douglas Anderson
Signed-off-by: Philip Chen
---
Changes in v3:
- Fix the nits from v2 review
Changes in v2:
- Add separate reg map config per page
Implement the first version of AUX support, which will be useful as
we expand the driver to support varied use cases.
Signed-off-by: Philip Chen
---
Changes in v3:
- Verify with HW and thus remove WARNING from the patch description
- Fix the reg names to better match the manual
- Fix
Use dev_err_probe() to add logs for error cases at probing time.
Signed-off-by: Philip Chen
---
(no changes since v1)
drivers/gpu/drm/bridge/parade-ps8640.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c
b
On Thu, Sep 9, 2021 at 2:27 PM Stephen Boyd wrote:
>
> Quoting Doug Anderson (2021-09-09 14:14:29)
> > On Thu, Sep 9, 2021 at 12:09 PM Stephen Boyd wrote:
> > >
> > >
> > > Oh does this have register pages? regmap has support for pages where you
> > > write some indirection register and then
On Thu, Sep 9, 2021 at 12:07 PM Stephen Boyd wrote:
>
> Quoting Philip Chen (2021-09-09 11:15:27)
> > On Wed, Sep 8, 2021 at 3:27 PM Stephen Boyd wrote:
> > >
> > > Quoting Philip Chen (2021-09-08 11:18:06)
> > >
> > > > +
in practice.
Signed-off-by: Philip Chen
---
Changes in v2:
- Handle the case where an AUX transaction has no payload
- Add a reg polling for p0.0x83 to confirm AUX cmd is issued and
read data is returned
- Replace regmap_noinc_read/write with looped regmap_read/write,
as regmap_noinc_read/write doesn't
Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs,
which will simplify the future update on ps8640 driver.
Signed-off-by: Philip Chen
---
Changes in v2:
- Add separate reg map config per page
drivers/gpu/drm/bridge/parade-ps8640.c | 89 ++
1 file
Hi,
On Wed, Sep 8, 2021 at 2:54 PM Stephen Boyd wrote:
>
> Quoting Philip Chen (2021-09-08 11:18:05)
> > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c
> > b/drivers/gpu/drm/bridge/parade-ps8640.c
> > index 685e9c38b2db..a16725dbf912 100644
> > --- a/drivers/
Hi,
On Wed, Sep 8, 2021 at 3:27 PM Stephen Boyd wrote:
>
> Quoting Philip Chen (2021-09-08 11:18:06)
> > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c
> > b/drivers/gpu/drm/bridge/parade-ps8640.c
> > index a16725dbf912..3f0241a60357 100644
> > --- a/drivers/
Implement the first version of AUX support, which will be useful as
we expand the driver to support varied use cases.
Signed-off-by: Philip Chen
---
drivers/gpu/drm/bridge/parade-ps8640.c | 123 +
1 file changed, 123 insertions(+)
diff --git a/drivers/gpu/drm/bridge
Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs,
which will simplify the future update on ps8640 driver.
Signed-off-by: Philip Chen
---
drivers/gpu/drm/bridge/parade-ps8640.c | 66 +++---
1 file changed, 39 insertions(+), 27 deletions(-)
diff --git
Hi,
On Tue, Aug 24, 2021 at 3:37 PM Doug Anderson wrote:
>
> Hi,
>
> On Fri, Aug 20, 2021 at 4:22 PM Philip Chen wrote:
> >
> > From: Philip Chen
> >
> > Reorg the macros as follows:
> > (1) Group the registers on the same page together.
> &
Reorg the macros as follows:
(1) Group the registers on the same page together.
(2) Group the register and its bit operation together while indenting
the macros of the bit operation with one space.
Also fix a misnomer for the number of mipi data lanes.
Signed-off-by: Philip Chen
---
Changes
From: Philip Chen
Reorg the macros as follows:
(1) Group the registers on the same page together.
(2) Group the register and its bit operation together while indenting
the macros of the bit operation with one space.
Also fix a misnomer for the number of mipi data lanes.
Signed-off-by: Philip
53 matches
Mail list logo
