Re: [PATCH] drm/display/dp: fix all kernel-doc warnings

2024-05-22 Thread Randy Dunlap
On 5/22/24 2:37 AM, Dmitry Baryshkov wrote: > On Tue, May 21, 2024 at 08:59:06PM -0700, Randy Dunlap wrote: >> Hi Dmitry, >> >> On 5/20/24 3:37 AM, Dmitry Baryshkov wrote: >>> On Wed, May 15, 2024 at 05:26:42PM -0700, Randy Dunlap wrote: >>>> Fix a stru

Re: [PATCH] drm/mode: fix all kernel-doc warnings

2024-05-21 Thread Randy Dunlap
Hi, On 5/20/24 3:39 AM, Dmitry Baryshkov wrote: > On Wed, May 15, 2024 at 05:26:52PM -0700, Randy Dunlap wrote: >> Add @width and @height descriptions for drm_plane_size_hint >> along with a reference to more info. >> >> Add a short description for drm_mode_clo

Re: [PATCH] drm/display/dp: fix all kernel-doc warnings

2024-05-21 Thread Randy Dunlap
Hi Dmitry, On 5/20/24 3:37 AM, Dmitry Baryshkov wrote: > On Wed, May 15, 2024 at 05:26:42PM -0700, Randy Dunlap wrote: >> Fix a struct member name in drm_dp_as_sdp. >> Add Returns: kernel-doc syntax for 4 functions. >> In the Returns: sections, spell "%true&

[PATCH] drm/mode: fix all kernel-doc warnings

2024-05-15 Thread Randy Dunlap
short description on line: * struct drm_mode_closefb Signed-off-by: Randy Dunlap --- Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann include/uapi/drm/drm_mode.h | 21 - 1 file

[PATCH] drm/display/dp: fix all kernel-doc warnings

2024-05-15 Thread Randy Dunlap
'drm_dp_dpcd_readb' drm_dp_helper.h:554: warning: No description found for return value of 'drm_dp_dpcd_writeb' drm_dp_helper.h:721: warning: No description found for return value of 'drm_dp_has_quirk' Signed-off-by: Randy Dunlap --- Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@list

Re: [PATCH] drm: Fix no_vblank field references in documentation

2024-04-23 Thread Randy Dunlap
On 4/16/24 2:02 PM, Randy Dunlap wrote: > > > On 4/16/24 2:00 PM, Marijn Suijten wrote: >> Hi Randy, >> >> [..] >> >>> Do you see differences in the generated html for these changes? >> >> I have not yet generated the HTML locally t

Re: [PATCH] drm: Fix no_vblank field references in documentation

2024-04-16 Thread Randy Dunlap
On 4/16/24 2:00 PM, Marijn Suijten wrote: > Hi Randy, > > [..] > >> Do you see differences in the generated html for these changes? > > I have not yet generated the HTML locally to test this patch, but will surely > do > if that's a requirement. > >> " somestruct" and "" should both be OK

Re: [PATCH] drm: Fix no_vblank field references in documentation

2024-04-16 Thread Randy Dunlap
Hi, On 4/16/24 12:29 PM, Marijn Suijten wrote: > Browsing the DRM documentation shows that drm_crtc_state.no_vblank > is not turned into a reference to the no_vblank field, but rather a > reference to `struct drm_crtc_state`. The only difference with other > field references is that the struct

Re: [PATCH] treewide: Fix common grammar mistake "the the"

2024-04-11 Thread Randy Dunlap
scripts/coccinelle/misc/badty.cocci | 2 +- > tools/perf/Documentation/perf-diff.txt| 2 +- > 30 files changed, 32 insertions(+), 32 deletions(-) > Reviewed-by: Randy Dunlap Thanks. -- #Randy

Re: [PATCH] fbdev/sh7760fb: allow modular build

2024-04-09 Thread Randy Dunlap
Hi, Will someone be merging this patch? thanks. On 2/10/24 1:31 AM, John Paul Adrian Glaubitz wrote: > On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote: >> There is no reason to prohibit sh7760fb from being built as a >> loadable module as suggested by Geert, so change th

Re: [RFC PATCH net-next v7 13/14] net: add devmem TCP documentation

2024-03-26 Thread Randy Dunlap
Hi, On 3/26/24 15:50, Mina Almasry wrote: > Add documentation outlining the usage and details of devmem TCP. > > Signed-off-by: Mina Almasry > > --- > > v7: > - Applied docs suggestions (Jakub). > > v2: > > - Missing spdx (simon) > - add to index.rst (simon) > > --- >

Re: [PATCH v2 1/8] drm: xlnx: Fix kerneldoc

2024-03-20 Thread Randy Dunlap
On 3/19/24 22:42, Tomi Valkeinen wrote: > On 20/03/2024 00:51, Sean Anderson wrote: >> Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed >> members. >> >> Signed-off-by: Sean Anderson >> --- >> >> Changes in v2: >> - New >> >>   drivers/gpu/drm/xlnx/zynqmp_disp.c  | 6

Re: [PATCH v5 11/16] drm/vkms: Add YUV support

2024-03-13 Thread Randy Dunlap
Hi, On 3/13/24 10:45, Louis Chauvet wrote: > From: Arthur Grillo > > > Signed-off-by: Arthur Grillo > [Louis Chauvet: > - Adapted Arthur's work > - Implemented the read_line_t callbacks for yuv > - add struct conversion_matrix > - remove struct pixel_yuv_u8 > - update the commit message > -

Re: [PATCH v5 05/16] drm/vkms: Add dummy pixel_read/pixel_write callbacks to avoid NULL pointers

2024-03-13 Thread Randy Dunlap
On 3/13/24 10:44, Louis Chauvet wrote: > Introduce two callbacks which does nothing. They are used in replacement > of NULL and it avoid kernel OOPS if this NULL is called. > > If those callback are used, it means that there is a mismatch between > what formats are announced by atomic_check

Re: [PATCH v5 03/16] drm/vkms: write/update the documentation for pixel conversion and pixel write functions

2024-03-13 Thread Randy Dunlap
Hi, On 3/13/24 10:44, Louis Chauvet wrote: > Add some documentation on pixel conversion functions. > Update of outdated comments for pixel_write functions. > > Signed-off-by: Louis Chauvet > --- > drivers/gpu/drm/vkms/vkms_composer.c | 7 > drivers/gpu/drm/vkms/vkms_drv.h | 13

Re: [PATCH] Removed vcpi field description to fix kernel doc warning

2024-03-07 Thread Randy Dunlap
On 3/7/24 18:51, R SUNDAR wrote: > For linux-next repo > > /include/drm/display/drm_dp_mst_helper.h:156: warning: Excess struct member > 'vcpi' description in 'drm_dp_mst_port' > > Signed-off-by: R SUNDAR or https://lore.kernel.org/lkml/20240106032321.28596-1-rdun...@infradead.org/ but I

Re: [PATCH] Removed funcs field description for kernel doc warning.

2024-03-04 Thread Randy Dunlap
nel.org/lkml/20240106032957.1195-1-rdun...@infradead.org/ but in any case I would like to see any one of these patches merged. Thanks. Reviewed-by: Randy Dunlap > --- > include/drm/drm_gem_vram_helper.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/drm/drm_gem

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-02 Thread Randy Dunlap
On 3/2/24 14:10, Guenter Roeck wrote: > On Thu, Feb 29, 2024 at 12:21 PM Linus Torvalds > wrote: >> >> On Thu, 29 Feb 2024 at 01:23, Nikolai Kondrashov wrote: >>> >>> However, I think a better approach would be *not* to add the .gitlab-ci.yaml >>> file in the root of the source tree, but

Re: linux-next: Tree for Feb 26 (drivers/gpu/drm/xe)

2024-02-26 Thread Randy Dunlap
On 2/25/24 22:55, Stephen Rothwell wrote: > Hi all, > > Changes since 20240223: > on powerpc32 or i386: ../drivers/gpu/drm/xe/xe_ggtt.c: In function 'xe_ggtt_set_pte': ../drivers/gpu/drm/xe/xe_ggtt.c:78:9: error: implicit declaration of function 'writeq'; did you mean 'writel'?

Re: [PATCH] drm/tests/drm_buddy: avoid 64-bit calculation

2024-02-16 Thread Randy Dunlap
nction has another possible flaw in that is mixes > what it calls pages with 4KB units. This is a big confusing at best, > or possibly broken when built on machines with larger pages. > > Fixes: a64056bb5a32 ("drm/tests/drm_buddy: add alloc_contiguous test") > Signed

Re: linux-next: Tree for Feb 15 (drivers/gpu/drm/tests/drm_buddy_test.o)

2024-02-15 Thread Randy Dunlap
On 2/14/24 19:52, Stephen Rothwell wrote: > Hi all, > > Changes since 20240214: > on i386: ld: drivers/gpu/drm/tests/drm_buddy_test.o: in function `drm_test_buddy_alloc_contiguous': /work/lnx/next/linux-next-20240215/X32/../drivers/gpu/drm/tests/drm_buddy_test.c:48:(.text+0x94): undefined

[PATCH v2] iosys-map: fix typo

2024-02-13 Thread Randy Dunlap
Correct a spello/typo in comments. Signed-off-by: Randy Dunlap Cc: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org --- v2: don't change "set up" to "setup" (Thomas) include/linux/iosys-map.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/include

[PATCH v3] drm: drm_crtc: correct some comments

2024-02-12 Thread Randy Dunlap
Fix some typos and punctuation. Signed-off-by: Randy Dunlap Cc: Alex Deucher Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- v2: s/instances/instance/ (Alex) v3: rebase and resend; add more Cc:s

Re: [PATCH RESEND] iosys-map: fix typos

2024-02-12 Thread Randy Dunlap
On 2/11/24 23:13, Thomas Zimmermann wrote: > Hi > > Am 12.02.24 um 05:28 schrieb Randy Dunlap: >> Correct spellos/typos in comments. >> >> Signed-off-by: Randy Dunlap >> Cc: Thomas Zimmermann >> Cc: dri-devel@lists.freedesktop.org >> --- >>

[PATCH RESEND] iosys-map: fix typos

2024-02-11 Thread Randy Dunlap
Correct spellos/typos in comments. Signed-off-by: Randy Dunlap Cc: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org --- include/linux/iosys-map.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/include/linux/iosys-map.h b/include/linux/iosys-map.h --- a/include

Re: [PATCH] gpu: drm: display: indent fix in comment

2024-02-10 Thread Randy Dunlap
On 2/8/24 07:20, Kousik Sanagavarapu wrote: > On Thu, Jan 25, 2024 at 12:05:56AM +0530, Kousik Sanagavarapu wrote: >> The comments explaining the function "drm_dp_mst_atom_check_mgr()" had >> uneven indentation which made "make htmldocs" complain: >> >>

[PATCH] fbdev/sh7760fb: allow modular build

2024-02-09 Thread Randy Dunlap
tterhoeven Signed-off-by: Randy Dunlap Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: John Paul Adrian Glaubitz Cc: Sam Ravnborg Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/video/fbdev/Kconfig |4 ++-- 1 file changed, 2 insert

[PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

2024-02-07 Thread Randy Dunlap
sts.freedesktop.org Signed-off-by: Randy Dunlap --- v2: add Geoff's Ack; add second Fixes: tag and more Cc:s (Thomas) arch/powerpc/platforms/ps3/Kconfig |1 + 1 file changed, 1 insertion(+) diff -- a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig --- a/arch/power

Re: linux-next: Tree for Feb 6 (gpu/drm/amd/display/ kernel-doc warnings)

2024-02-05 Thread Randy Dunlap
On 2/5/24 20:43, Stephen Rothwell wrote: > Hi all, > > Changes since 20240205: > Hi Rodrigo, Are you aware of these kernel-doc warnings? I think they are due to commit b8c1c3a82e75 Author: Rodrigo Siqueira Date: Mon Jan 22 14:24:57 2024 -0700 Documentation/gpu: Add kernel doc entry

[PATCH v2] drm/panel: re-alphabetize the menu list

2024-02-04 Thread Randy Dunlap
A few of the DRM_PANEL entries have become out of alphabetical order, so move them around a bit to restore alpha order. Signed-off-by: Randy Dunlap Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam Ravnborg Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc

[PATCH v2] drm/rect: fix kernel-doc typos

2024-02-04 Thread Randy Dunlap
Correct typos of "translated". Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Reviewed-by: Simon Ser Signed-off-by: Randy Dunlap --- v2: add Reviewed-by, rebase include/drm/drm_rect.h |

Re: linux-next: Tree for Jan 29 (drm/xe/ and FB_IOMEM_HELPERS)

2024-01-29 Thread Randy Dunlap
On 1/28/24 19:30, Stephen Rothwell wrote: > Hi all, > > Changes since 20240125: > > New trees: i2c-host-fixes, i2c-host > on riscv 64-bit or powerpc 64-bit: WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] Selected by [m]:

Re: linux-next: Tree for Jan 23 (drm/xe/)

2024-01-24 Thread Randy Dunlap
On 1/24/24 01:17, Jani Nikula wrote: > On Tue, 23 Jan 2024, Randy Dunlap wrote: >> On 1/22/24 18:29, Stephen Rothwell wrote: >>> Hi all, >>> >>> News: there will be no linux-next release on Friday >>> >>> Changes since 20240122: >&

Re: linux-next: Tree for Jan 23 (drm/xe/)

2024-01-23 Thread Randy Dunlap
On 1/22/24 18:29, Stephen Rothwell wrote: > Hi all, > > News: there will be no linux-next release on Friday > > Changes since 20240122: > on ARM64, when DRM_I915 is not set DRM_XE=m DEBUG_FS is not set ../drivers/gpu/drm/i915/display/intel_display_debugfs.c:1091:6: error: redefinition of

Re: [PATCH 2/2] scripts/kernel-doc: Do not process backslash lines in comments

2024-01-22 Thread Randy Dunlap
ly for lines which are no > comments, e.g. do not start with ' *'. > > Suggested-by: Matthew Wilcox > Signed-off-by: Anna-Maria Behnsen I compared several hundred html files before and after this patch and they were all the same, so I will say: Tested-by: Randy Dunlap Thanks. > --- &

Re: [PATCH] drm/display: fix typo

2024-01-19 Thread Randy Dunlap
On 1/19/24 02:22, Oleksandr Natalenko wrote: > While studying the code I've bumped into a small typo within the > kernel-doc for two functions, apparently, due to copy-paste. > > This commit fixes "sizo" word to be "size". > > Signed-off-by: Oleksa

Re: [PATCH] drm/imagination: fix ARRAY_SIZE build error

2024-01-18 Thread Randy Dunlap
Hi Matt, On 1/18/24 01:38, Matt Coster wrote: > On 10/01/2024 00:23, Randy Dunlap wrote: >> Fix a build error when using GCC 13.2.0 from kernel.org crosstools >> by changing ARRAY_SIZE() to the macro PVR_MIPS_PT_PAGE_COUNT: > > I assume you're referring to the x86_64 =>

[PATCH] drm/amd/display: remove kernel-doc misuses in dmub_replay.c

2024-01-14 Thread Randy Dunlap
and coasting vtotal. dmub_replay.c:284: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * send Replay general cmd to DMUB. Signed-off-by: Randy Dunlap Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siqueira Cc: amd-...@lists.freedesktop.

[PATCH] drm/doc: internals: remove section on PCI legacy support

2024-01-11 Thread Randy Dunlap
: no structured comments found Fixes: 2504c7ec728b ("drm: Remove source code for non-KMS drivers") Signed-off-by: Randy Dunlap Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org --- Documentati

[PATCH] dma-buf/dma-resv: fix spelling

2024-01-10 Thread Randy Dunlap
Fix spelling mistakes as reported by codespell. Signed-off-by: Randy Dunlap Cc: Sumit Semwal Cc: linux-me...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: Christian König Cc: linaro-mm-...@lists.linaro.org --- drivers/dma-buf/dma-resv.c |4 ++-- 1 file changed, 2 insertions

[PATCH] dma-buf/dma-fence: fix spelling

2024-01-10 Thread Randy Dunlap
Fix spelling mistakes as reported by codespell. Signed-off-by: Randy Dunlap Cc: Sumit Semwal Cc: Gustavo Padovan Cc: linux-me...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: Christian König Cc: linaro-mm-...@lists.linaro.org --- drivers/dma-buf/dma-fence.c |8 1 file

[PATCH] drm/imagination: fix ARRAY_SIZE build error

2024-01-09 Thread Randy Dunlap
| for (page_nr = ARRAY_SIZE(mips_data->pt_pages) - 1; page_nr >= 0; page_nr--) { |^~ Fixes: 927f3e0253c1 ("drm/imagination: Implement MIPS firmware processor and MMU support") Signed-off-by: Randy Dunlap Cc: Donald Robson Cc: Maxime R

Re: [PATCH v2] drm/vram-helper: fix kernel-doc warnings

2024-01-09 Thread Randy Dunlap
On 1/9/24 07:25, Daniel Vetter wrote: > On Tue, 9 Jan 2024 at 16:23, Randy Dunlap wrote: >> >> >> >> On 1/9/24 05:42, Daniel Vetter wrote: >>> On Tue, 9 Jan 2024 at 13:59, Daniel Vetter wrote: >>>> >>>> On Mon, Jan 08, 2

Re: [PATCH v2] drm/vram-helper: fix kernel-doc warnings

2024-01-09 Thread Randy Dunlap
On 1/9/24 05:42, Daniel Vetter wrote: > On Tue, 9 Jan 2024 at 13:59, Daniel Vetter wrote: >> >> On Mon, Jan 08, 2024 at 01:10:12PM -0800, Randy Dunlap wrote: >>> Hi Thomas, >>> >>> On 1/8/24 00:57, Thomas Zimmermann wrote: >>>> Hi, >&g

Re: [PATCH v2] drm/vram-helper: fix kernel-doc warnings

2024-01-08 Thread Randy Dunlap
Hi Thomas, On 1/8/24 00:57, Thomas Zimmermann wrote: > Hi, > > thanks for the fix. > > Am 06.01.24 um 04:29 schrieb Randy Dunlap: >> Remove the @funcs entry from struct drm_vram_mm to quieten the kernel-doc >> warning. >> >> Use the "define"

[PATCH] driver core: component: fix spellos

2024-01-06 Thread Randy Dunlap
Correct spelling mistakes reported by codespell. Signed-off-by: Randy Dunlap Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: dri-devel@lists.freedesktop.org --- drivers/base/component.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/drivers/base/com

[PATCH v2] drm/vram-helper: fix kernel-doc warnings

2024-01-05 Thread Randy Dunlap
LPER_FUNCS - drm_gem_vram_helper.h:185: warning: Excess struct member 'funcs' description in 'drm_vram_mm' Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- v2: Add commit d

[PATCH] drm/display/dp_mst: remove Excess struct member kernel-doc

2024-01-05 Thread Randy Dunlap
Quieten an "Excess struct member" kernel-doc warning by removing the extraneous line. drm_dp_mst_helper.h:156: warning: Excess struct member 'vcpi' description in 'drm_dp_mst_port' Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org C

[PATCH] drm/vram-helper: fix kernel-doc warnings

2024-01-05 Thread Randy Dunlap
drm_gem_vram_helper.h:129: warning: missing initial short description on line: * DRM_GEM_VRAM_PLANE_HELPER_FUNCS - drm_gem_vram_helper.h:185: warning: Excess struct member 'funcs' description in 'drm_vram_mm' Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel

Re: [PATCH -next] drm/nouveau: uapi: fix kerneldoc warnings

2024-01-04 Thread Randy Dunlap
On 1/2/24 19:10, Randy Dunlap wrote: > Hi Vegard, > > On 12/25/23 09:08, Randy Dunlap wrote: >> >> >> On 12/25/23 00:30, Vegard Nossum wrote: >>> >>> On 25/12/2023 08:40, Randy Dunlap wrote: >>>> I do see one thing that I don't l

Re: [PATCH -next] drm/nouveau: uapi: fix kerneldoc warnings

2024-01-02 Thread Randy Dunlap
Hi Vegard, On 12/25/23 09:08, Randy Dunlap wrote: > > > On 12/25/23 00:30, Vegard Nossum wrote: >> >> On 25/12/2023 08:40, Randy Dunlap wrote: >>> I do see one thing that I don't like in the generated html output. >>> It's not a pr

[PATCH] drm/amd/display: dcn35_hwseq: use common comment to prevent kernel-doc warnings

2023-12-31 Thread Randy Dunlap
escription on line: * power up sequence Signed-off-by: Randy Dunlap Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siqueira Cc: Alex Deucher Cc: Christian König Cc: "Pan, Xinhui" Cc: amd-...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- I

[PATCH 4/4] drm/nouveau/volt/gk20a: don't misuse kernel-doc comments

2023-12-31 Thread Randy Dunlap
62: warning: missing initial short description on line: * cvb_t_mv = Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk

[PATCH 2/4] drm/nouveau: don't misuse kernel-doc comments

2023-12-31 Thread Randy Dunlap
ed whenever a 32-bit process running under a 64(). Prototype was for nouveau_compat_ioctl() instead Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- dri

[PATCH 3/4] drm/nouveau/gr/gf100: don't misuse kernel-doc comments

2023-12-31 Thread Randy Dunlap
le if it is disabled by the gf100.c:1044: warning: missing initial short description on line: * Wait until GR goes idle. GR is considered idle if it is disabled by the Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Cc: Maarten L

[PATCH 1/4] drm/nouveau/disp: don't misuse kernel-doc comments

2023-12-31 Thread Randy Dunlap
e/adjusted_mode pair. crtc.c:629: warning: missing initial short description on line: * Sets up registers for the given mode/adjusted_mode pair. Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxim

[PATCH] drm/msm/dpu: fix kernel-doc warnings

2023-12-30 Thread Randy Dunlap
: warning: Excess struct member 'debugfs_root' description in 'dpu_encoder_virt' dpu_rm.c:35: warning: Excess struct member 'hw_res' description in 'dpu_rm_requirements' dpu_rm.c:208: warning: No description found for return value of '_dpu_rm_get_lm_peer' Signed-off-by: Randy Dunlap Cc: Rob Clark Cc

[PATCH] drm/imagination: pvr_device.h: fix all kernel-doc warnings

2023-12-30 Thread Randy Dunlap
:292: warning: Excess struct member 'lock' description in 'pvr_device' Signed-off-by: Randy Dunlap Cc: Frank Binns Cc: Donald Robson Cc: Matt Coster Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc

[PATCH] drm/gpuvm: fix all kernel-doc warnings in include/drm/drm_gpuvm.h

2023-12-30 Thread Randy Dunlap
: warning: Excess struct member 'offset' description in 'drm_gpuva_op_map' drm_gpuvm.h:844: warning: Excess struct member 'obj' description in 'drm_gpuva_op_map' Signed-off-by: Randy Dunlap Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc

[PATCH v2.1 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. intel_gsc.h:34: warning: Excess struct member 'gem_obj' description in 'intel_gsc' Also add missing field member descriptions. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas

Re: [PATCH v2 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Randy Dunlap
Hi Andi, On 12/28/23 08:25, Andi Shyti wrote: > Hi Randy, > > ... > >> /** >> * struct intel_gsc - graphics security controller >> * >> - * @gem_obj: scratch memory GSC operations >> - * @intf : gsc interface >> + * @intf : gsc interface >> + * @intf.adev : MEI aux. device for this

Re: [PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Randy Dunlap
Hi Andi, On 12/28/23 08:40, Andi Shyti wrote: > Hi Randy, > > [...] > >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h >> @@ -105,61 +105,67 @@ struct intel_guc { >> */ > > > struct { } interrupts is missing here. > >> struct { >>

[PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
: Excess struct member 'work' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'shift' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'last_stat_jiffies' description in 'intel_guc' 18 warnings as Errors Signed-off-by: Randy Dunlap Cc: Jani Nikula

[PATCH v2 4/4] drm/i915/perf: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
' i915_perf_types.h:341: warning: Excess struct member 'tail' description in 'i915_perf_stream' 3 warnings as Errors Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-...@lists.freedesktop.org Cc: Jonathan Corbet Cc: dri-devel

[PATCH v2 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. intel_gsc.h:34: warning: Excess struct member 'gem_obj' description in 'intel_gsc' Also add missing field member descriptions. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas

[PATCH v2 1/4] drm/i915/gem: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. i915_gem_context_types.h:420: warning: Excess struct member 'lock' description in 'i915_gem_context' Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc

Re: [PATCH 4/4] drm/i915/perf: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
On 12/26/23 09:05, Rodrigo Vivi wrote: > On Wed, Dec 20, 2023 at 07:20:29PM -0800, Randy Dunlap wrote: >> Document nested struct members with full names as described in >> Documentation/doc-guide/kernel-doc.rst. >> >> i915_perf_types.h:341: warning: Excess struct me

Re: [PATCH -next] drm/nouveau: uapi: fix kerneldoc warnings

2023-12-25 Thread Randy Dunlap
On 12/25/23 00:30, Vegard Nossum wrote: > > On 25/12/2023 08:40, Randy Dunlap wrote: >> I do see one thing that I don't like in the generated html output. >> It's not a problem with this patch. >> The #defines for DRM_NOUVEAU_VM_BIND_OP_MAP etc. have a ';' at

Re: [PATCH -next] drm/nouveau: uapi: fix kerneldoc warnings

2023-12-24 Thread Randy Dunlap
it cleaner if the #defines appeared between the kerneldoc > for the member and the member itself (which is something other DRM- > related UAPI docs do). > > - The %IDENTIFIER kerneldoc syntax is intended for "constants", and is > more appropriate in this context than

Re: [PATCH] drm/amd/display: avoid stringop-overflow warnings for dp_decide_lane_settings()

2023-12-21 Thread Randy Dunlap
m/amd/display: Improve robustness of FIXED_VS link > training at DP1 rates") > Signed-off-by: Arnd Bergmann Acked-by: Randy Dunlap Tested-by: Randy Dunlap # build-tested Thanks. > --- > .../gpu/drm/amd/display/dc/link/protocols/link_dp_training.c| 2 +- > .../gpu/drm/a

[PATCH 1/4] drm/i915/gem: reconcile Excess struct member kernel-doc warnings

2023-12-20 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. i915_gem_context_types.h:420: warning: Excess struct member 'lock' description in 'i915_gem_context' Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc

[PATCH 4/4] drm/i915/perf: reconcile Excess struct member kernel-doc warnings

2023-12-20 Thread Randy Dunlap
' i915_perf_types.h:341: warning: Excess struct member 'tail' description in 'i915_perf_stream' 3 warnings as Errors Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-...@lists.freedesktop.org Cc: Jonathan Corbet Cc: dri-devel

[PATCH 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-20 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. intel_gsc.h:34: warning: Excess struct member 'gem_obj' description in 'intel_gsc' Also add missing field member descriptions. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas

[PATCH 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

2023-12-20 Thread Randy Dunlap
: Excess struct member 'work' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'shift' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'last_stat_jiffies' description in 'intel_guc' 18 warnings as Errors Signed-off-by: Randy Dunlap Cc: Jani Nikula

Re: [PATCH] drivers: video: logo: use %u format specifier for unsigned int values

2023-12-19 Thread Randy Dunlap
type is 'unsigned int'. [invalidPrintfArgType_sint] > > Signed-off-by: Colin Ian King Reviewed-by: Randy Dunlap Thanks. > --- > drivers/video/logo/pnmtologo.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/logo/pnmtologo.c b

[PATCH] drm/nouveau/bios/init: drop kernel-doc notation

2023-12-18 Thread Randy Dunlap
init_done() instead Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm

[PATCH] drm/vmwgfx: fix kernel-doc Excess struct member 'base'

2023-12-15 Thread Randy Dunlap
-doc still reports 20 warnings of this nature: vmwgfx_surface.c:198: warning: No description found for return value of 'vmw_surface_dma_size' but I am not addressing those. Signed-off-by: Randy Dunlap Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/20231215070

[PATCH] drm/vmwgfx: fix all kernel-doc warnings in stdu

2023-12-15 Thread Randy Dunlap
for return value of 'vmw_stdu_init' Signed-off-by: Randy Dunlap Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312150347.5iceznlk-...@intel.com/ Cc: Zack Rusin Cc: VMware Graphics Reviewers Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard

Re: [PATCH V2] drivers: gpu: drm: vmwgfx: fixed typos

2023-12-14 Thread Randy Dunlap
d the old query buffer can be unpinned. However, > * since both the new query buffer and the old one are fenced with that > fence, > - * we can do an asynchronus unpin now, and be sure that the old query buffer > + * we can do an asynchronous unpin now, and be sure that the old query buff

Re: [PATCH] drivers: gpu: drm: vmwgfx: fixed typos

2023-12-14 Thread Randy Dunlap
On 12/14/23 21:30, Ghanshyam Agrawal wrote: > Fixed some typos in vmwgfx_execbuf.c > > Signed-off-by: Ghanshyam Agrawal > --- > drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c >

Re: [PATCH] gpu: drm: amd: fixed typos

2023-12-14 Thread Randy Dunlap
Hi-- On 12/14/23 21:20, Ghanshyam Agrawal wrote: > Fixed multiple typos in atomfirmware.h > > Signed-off-by: Ghanshyam Agrawal > --- > drivers/gpu/drm/amd/include/atomfirmware.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

[PATCH] drm/uapi: drm_mode.h: fix spellos and grammar

2023-12-12 Thread Randy Dunlap
Correct spellos reported by codespell. Fix some grammar (as 's' to a few words). Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- include/uapi/drm/drm_mode.h | 18 +- 1 file changed, 9

[PATCH] drm/i915/uapi: fix typos/spellos and punctuation

2023-12-12 Thread Randy Dunlap
Use "its" for possessive form instead of "it's". Hyphenate multi-word adjectives. Correct some spelling. End one line of code with ';' instead of ','. The before and after object files are identical. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodr

[PATCH] drm/fourcc: fix spelling/typos

2023-12-12 Thread Randy Dunlap
Correct spelling mistakes that were identified by codespell. Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- include/uapi/drm/drm_fourcc.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions

[PATCH] iosys-map: fix typos

2023-12-12 Thread Randy Dunlap
Correct spellos/typos in comments. Signed-off-by: Randy Dunlap Cc: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org --- include/linux/iosys-map.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/include/linux/iosys-map.h b/include/linux/iosys-map.h --- a/include

[PATCH] drm/drm_modeset_helper_vtables.h: fix typos/spellos

2023-12-12 Thread Randy Dunlap
Fix spelling problems as identified by codespell. Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- include/drm/drm_modeset_helper_vtables.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH] drm/panel: re-alphabetize the menu list

2023-12-07 Thread Randy Dunlap
On 12/7/23 01:52, Aradhya Bhatia wrote: > Hi Randy, > > Thanks for the patch! > > On 07/12/23 11:52, Randy Dunlap wrote: >> A few of the DRM_PANEL entries have become out of alphabetical order, >> so move them around a bit to restore alpha order. >> >> S

[PATCH] drm/panel: re-alphabetize the menu list

2023-12-06 Thread Randy Dunlap
A few of the DRM_PANEL entries have become out of alphabetical order, so move them around a bit to restore alpha order. Signed-off-by: Randy Dunlap Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam Ravnborg Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc

[PATCH v2] backlight: ili922x: drop kernel-doc for local macros

2023-12-06 Thread Randy Dunlap
:85: warning: missing initial short description on line: * START_BYTE(id, rs, rw) ili922x.c:118: warning: expecting prototype for CHECK_FREQ_REG(spi_device s, spi_transfer x)(). Prototype was for CHECK_FREQ_REG() instead Signed-off-by: Randy Dunlap Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo

Re: [PATCH] backlight: ili922x: fix W=1 kernel-doc warnings

2023-12-06 Thread Randy Dunlap
On 12/6/23 05:25, Lee Jones wrote: > On Wed, 06 Dec 2023, Daniel Thompson wrote: > >> On Tue, Dec 05, 2023 at 02:56:38PM -0800, Randy Dunlap wrote: >>> Fix kernel-doc warnings found when using "W=1". >>> >>> ili922x.c:85: warning: This comme

[PATCH] fbdev: hgafb: fix kernel-doc comments

2023-12-05 Thread Randy Dunlap
gafb.c:425: warning: No description found for return value of 'hgafb_pan_display' hgafb.c:425: warning: expecting prototype for hga_pan_display(). Prototype was for hgafb_pan_display() instead hgafb.c:455: warning: No description found for return value of 'hgafb_blank' Signed-off-by: Randy Dunlap

[PATCH] backlight: ili922x: fix W=1 kernel-doc warnings

2023-12-05 Thread Randy Dunlap
1: warning: contents before sections ili922x.c:118: warning: expecting prototype for CHECK_FREQ_REG(spi_device s, spi_transfer x)(). Prototype was for CHECK_FREQ_REG() instead Signed-off-by: Randy Dunlap Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc: Helge Deller Cc: linux-fb...@vger.

Re: [PATCH] video: fbdev: mmp: Fix typo in code comment

2023-11-24 Thread Randy Dunlap
Hi, On 11/24/23 01:52, Dario Binacchi wrote: > s/singals/signals/ > > Fixes: 641b4b1b6a7c ("video: mmpdisp: add spi port in display controller") > Signed-off-by: Dario Binacchi > --- > > drivers/video/fbdev/mmp/hw/mmp_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] drm/rockchip: rk3066_hdmi: include drm/drm_atomic.h

2023-11-22 Thread Randy Dunlap
^ > > Fixes: ae3436a5e7c2 ("drm/rockchip: rk3066_hdmi: Switch encoder hooks to > atomic") > Signed-off-by: Arnd Bergmann Acked-by: Randy Dunlap Tested-by: Randy Dunlap # build-tested Thanks. > --- > drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 + > 1 file change

Re: [PATCH] drm/amd: Document device reset methods

2023-11-10 Thread Randy Dunlap
Hi-- On 11/10/23 07:55, André Almeida wrote: > Document what each amdgpu driver reset method does. > > Signed-off-by: André Almeida > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 20 > 1 file changed, 20 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h >

Re: [PATCH v2] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Randy Dunlap
by: Hunter Chasens Acked-by: Randy Dunlap Thanks. > --- > drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c > b/drivers/gpu/drm/amd/pm/amdgpu_pm.c > index 517b9fb462

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Randy Dunlap
On 11/6/23 11:06, Hunter Chasens wrote: > First, apologies to Jani Nikula. I accedently top posted on the other thread. > My email client is giving me a hard time. The following works and, if > everyone agrees, I'll send out a v2. > > * E.g.:: > * > * S: 19Mhz * > * 0: 615Mhz > * 1:

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-05 Thread Randy Dunlap
On 11/5/23 21:15, Bagas Sanjaya wrote: > On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote: >> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> index 517b9fb4624c..703fe2542258 100644 >> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> +++

Re: [PATCH] drm/tiny: print 'struct resource *' correctly

2023-10-15 Thread Randy Dunlap
On 10/15/23 06:11, Yussef Dalton wrote: > Since format specifier %pr refers to a 'struct resource *', there is no > need to take the address of the 'res' variable since it is already of > type 'struct resource *'. > > Signed-off-by: Yussef Dalton Reviewed-by: Randy

Re: linux-next: Tree for Oct 12 (drivers/gpu/drm/msm/adreno/a6xx_gmu.o)

2023-10-12 Thread Randy Dunlap
On 10/11/23 22:43, Stephen Rothwell wrote: > Hi all, > > Changes since 20231011: > on powerpc 64BIT: powerpc64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume': a6xx_gmu.c:(.text+0x6afc): undefined reference to `qmp_send' powerpc64-linux-ld:

  1   2   3   4   5   6   7   8   9   >