Hi,
On Mon, 09 Jan 2023 11:12:02 +0100, Robin van der Gracht
wrote:
> On 2023-01-08 10:29, Sam Ravnborg wrote:
> > On Sat, Jan 07, 2023 at 10:02:38PM +0100, Miguel Ojeda wrote:
> >> On Sat, Jan 7, 2023 at 7:26 PM Sam Ravnborg via B4 Submission Endpoint
> >> wrote:
> >> >
> >> > Introduce
On Sun, 8 Jan 2023 18:26:12 +0100, Helge Deller wrote:
> On 1/7/23 21:53, Sam Ravnborg wrote:
> > Hi Stephen.
> >
> > On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote:
> >> On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint
Hi Sam,
On Sun, 8 Jan 2023 21:24:20 +0100, Sam Ravnborg wrote:
> > Here are my pending patches from last June on lore:
> >
>
> All patches are handled I think except this:
> > * https://lore.kernel.org/lkml/20220608205623.2106113-1-st...@sk2.org/
>
> Can I ask you to drop the assignment
On Mon, 9 Jan 2023 20:53:44 +0100, Stephen Kitt wrote:
> On Sun, 8 Jan 2023 21:24:20 +0100, Sam Ravnborg wrote:
> > > Here are my pending patches from last June on lore:
> > >
> >
> > All patches are handled I think except this:
> > > * https://l
-by: Stephen Kitt
Acked-by: Sam Ravnborg
---
drivers/video/fbdev/atmel_lcdfb.c | 22 +-
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/drivers/video/fbdev/atmel_lcdfb.c
b/drivers/video/fbdev/atmel_lcdfb.c
index 1fc8de4ecbeb..8187a7c4f910 100644
--- a/drivers
Hi Sam,
On Sun, 8 Jan 2023 21:29:43 +0100, Sam Ravnborg wrote:
> On Sun, Jan 08, 2023 at 08:28:17PM +0100, Stephen Kitt wrote:
> > On Sat, 07 Jan 2023 19:26:23 +0100, Sam Ravnborg via B4 Submission
> > Endpoint wrote:
> >
> > > From: Sam Ravnborg
>
props.state |= BL_CORE_FBBLANK;
>
> return backlight_update_status(bd);
> @@ -403,7 +382,6 @@ static inline int backlight_disable(struct
> backlight_device *bd) static inline bool backlight_is_blank(const struct
> backlight_device *bd) {
> return bd->props.power != FB_BLANK_UNBLANK ||
> -bd->props.fb_blank != FB_BLANK_UNBLANK ||
> bd->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK);
> }
>
>
> --
> 2.34.1
Reviewed-by: Stephen Kitt
pgpl8q7sIZKqi.pgp
Description: OpenPGP digital signature
On Sat, 07 Jan 2023 19:26:25 +0100, Sam Ravnborg via B4 Submission Endpoint
wrote:
> From: Sam Ravnborg
>
> Introduce backlight_get_brightness() to simplify logic
> and avoid direct access to backlight properties.
>
> Signed-off-by: Sam Ravnborg
> Cc: Benjamin Herrenschmidt
> Cc: Sam
- it was only used for debug.
>
> Signed-off-by: Sam Ravnborg
> Cc: Thomas Zimmermann
> Cc: Andy Shevchenko
> Cc: Javier Martinez Canillas
> Cc: Greg Kroah-Hartman
> Cc: Sam Ravnborg
> Cc: Stephen Kitt
> Cc: Peter Suti
> Cc: linux-fb...@vger.kernel.org
@@ static int omapbl_probe(struct platform_device *pdev)
> if (IS_ERR(dev))
> return PTR_ERR(dev);
>
> - bl->powermode = FB_BLANK_POWERDOWN;
> - bl->current_intensity = 0;
> -
> bl->pdata = pdata;
> bl->dev = >dev;
>
> @@ -149,7 +101,6 @@ static int omapbl_probe(struct platform_device *pdev)
>
> omap_cfg_reg(PWL); /* Conflicts with UART3 */
>
> - dev->props.fb_blank = FB_BLANK_UNBLANK;
> dev->props.brightness = pdata->default_intensity;
> omapbl_update_status(dev);
>
>
> --
> 2.34.1
Wow that gets rid of a lot of unnecessary code!
Reviewed-by: Stephen Kitt
pgpoLis1h6Y9E.pgp
Description: OpenPGP digital signature
- it was only used for debug.
>
> Signed-off-by: Sam Ravnborg
> Cc: Stephen Kitt
> Cc: Greg Kroah-Hartman
> Cc: Daniel Thompson
> Cc: Andy Shevchenko
> Cc: linux-fb...@vger.kernel.org
> ---
> drivers/staging/fbtft/fb_ssd1351.c | 9 +++--
> 1 file changed,
On 8 January 2023 08:45:46 CET, Stephen Kitt wrote:
>On 7 January 2023 21:53:46 CET, Sam Ravnborg wrote:
>>Hi Stephen.
>>
>>On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote:
>>> On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoi
On 7 January 2023 21:53:46 CET, Sam Ravnborg wrote:
>Hi Stephen.
>
>On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote:
>> On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint
>> wrote:
>> >From: Sam Ravnborg
>> >
>> &g
On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint
wrote:
>From: Sam Ravnborg
>
>The atmel_lcdfb had code to save/restore power state.
>This is not needed so drop it.
>
>Introduce backlight_is_brightness() to make logic simpler.
>
>Signed-off-by: Sam Ravnborg
>Cc: Nicolas
seems useful to use helper functions where
appropriate.
Stephen Kitt (4):
backlight: aat2870: Use backlight helper
backlight: arcxcnn: Use backlight helper
backlight: ipaq_micro: Use backlight helper
backlight: tosa: Use backlight helper
drivers/video/backlight/aat2870_bl.c| 7
Hi Daniel,
On Fri, 6 Jan 2023 18:43:36 +0100, Daniel Vetter wrote:
> On Fri, Jan 06, 2023 at 05:48:52PM +0100, Stephen Kitt wrote:
> > Instead of retrieving the backlight brightness in struct
> > backlight_properties manually, and then checking whether the backlight
> > sho
Not sure why git send-email didn't thread this, I can resend if
necessary.
Le 06/01/2023 17:48, Stephen Kitt a écrit :
This started with work on the removal of backlight_properties'
deprecated fb_blank field, much of which can be taken care of by using
helper functions provided by backlight.h
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
---
drivers/video/backlight
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
---
drivers/video/backlight
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
---
drivers/video/backlight
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
---
drivers/video/backlight
, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Thierry Reding
Cc: Sam Ravnborg
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
-by: Stephen Kitt
Cc: Thierry Reding
Cc: Sam Ravnborg
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
---
Changes since v1: removed the last remaining .fb_blank reference
---
drivers/gpu/drm/panel/panel-sony-acx565akm.c | 12 ++--
1 file changed, 2 insertions(+), 10
fields in
struct backlight_properties, use backlight_enable() and
backlight_disable(). These also call backlight_update_status() so the
separate call is no longer needed.
Signed-off-by: Stephen Kitt
Cc: Thierry Reding
Cc: Sam Ravnborg
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-devel
the last remaining fb_blank reference in drm/panel in the
last patch
- remove unnecessary parentheses
Stephen Kitt (3):
drm/panel: Use backlight helper
drm/panel: panel-dsi-cm: Use backlight helpers
drm/panel: sony-acx565akm: Use backlight helpers
.../drm/panel/panel-asus-z00t-tm5p5-n35596.c
-off-by: Stephen Kitt
Cc: Laurent Pinchart
Cc: Kieran Bingham
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
---
Changes since v1: clarified commit message, this doesn't touch fb_blank
---
drivers/gpu/drm/shmobile/shmob_drm_backlight.c | 6 +-
1 file changed, 1
Hi Sam,
On Fri, 10 Jun 2022 22:22:59 +0200, Sam Ravnborg wrote:
> On Tue, Jun 07, 2022 at 08:55:16PM +0200, Stephen Kitt wrote:
> > backlight_properties.fb_blank is deprecated. The states it represents
> > are handled by other properties; but instead of accessing those
> >
On Fri, 10 Jun 2022 21:52:36 +0200, Stephen Kitt wrote:
> On Fri, 10 Jun 2022 21:28:32 +0200, Sam Ravnborg wrote:
> > Hi Stephen.
> > On Fri, Jun 10, 2022 at 07:47:20PM +0200, Stephen Kitt wrote:
> > > Hi Sebastian,
> > >
> > > On Thu, 9
On Fri, 10 Jun 2022 21:28:32 +0200, Sam Ravnborg wrote:
> Hi Stephen.
> On Fri, Jun 10, 2022 at 07:47:20PM +0200, Stephen Kitt wrote:
> > Hi Sebastian,
> >
> > On Thu, 9 Jun 2022 23:52:36 +0200, Sebastian Reichel
> > wrote:
> > > On Tue, Jun 07, 2022
Hi Sebastian,
On Thu, 9 Jun 2022 23:52:36 +0200, Sebastian Reichel
wrote:
> On Tue, Jun 07, 2022 at 08:20:25PM +0200, Stephen Kitt wrote:
> > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c
> > b/drivers/gpu/drm/panel/panel-dsi-cm.c index b58cb064975f..aa36dc6cedd3
> > 100
On Fri, 10 Jun 2022 10:49:55 +0100, Daniel Thompson
wrote:
> On Thu, Jun 09, 2022 at 07:45:11PM +0200, Stephen Kitt wrote:
> > Hi Sam, Daniel,
> >
> > On Thu, 9 Jun 2022 19:30:57 +0200, Sam Ravnborg wrote:
> >
> > > thanks for taking care of
-by: Stephen Kitt
Cc: Nicolas Ferre
Cc: Helge Deller
Cc: Alexandre Belloni
Cc: Claudiu Beznea
Cc: linux-fb...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-ker...@lists.infradead.org
---
drivers/video/fbdev/atmel_lcdfb.c | 22 +-
1 file changed, 1
igging...
> On Thu, Jun 09, 2022 at 10:54:12AM +0100, Daniel Thompson wrote:
> > On Wed, Jun 08, 2022 at 10:56:23PM +0200, Stephen Kitt wrote:
> > > Instead of checking the state of various backlight_properties fields
> > > against the memorised s
Hi Laurent,
On Wed, 8 Jun 2022 10:08:40 +0300, Laurent Pinchart
wrote:
> On Tue, Jun 07, 2022 at 11:05:37PM +0200, Stephen Kitt wrote:
> > On Tue, 7 Jun 2022 20:31:32 +0200, Stephen Kitt wrote:
> > > backlight_properties.fb_blank is deprecated. The states it represents
uct atmel_lcdfb_info is no longer
necessary, so remove that while we're at it. Since we only ever care
about reading the current state in backlight_properties, drop the
updates at the end of the function.
Signed-off-by: Stephen Kitt
Cc: Nicolas Ferre
Cc: Helge Deller
Cc: Alexandre Belloni
Cc: Clau
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Lee Jones
Cc: Daniel
On Tue, 7 Jun 2022 20:10:22 +0200, Stephen Kitt wrote:
> backlight_properties.fb_blank is deprecated. The states it represents
> are handled by other properties; but instead of accessing those
> properties directly, drivers should use the helpers provided by
> backlight.h
On Tue, 7 Jun 2022 20:31:32 +0200, Stephen Kitt wrote:
> backlight_properties.fb_blank is deprecated. The states it represents
> are handled by other properties; but instead of accessing those
> properties directly, drivers should use the helpers provided by
> backlight.h
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Antonino Daplas
Cc
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Paul Mackerras
Cc
seems useful to use helper functions where
appropriate.
Stephen Kitt (4):
backlight: aat2870: Use backlight helper
backlight: arcxcnn: Use backlight helper
backlight: ipaq_micro: Use backlight helper
backlight: tosa: Use backlight helper
drivers/video/backlight/aat2870_bl.c| 7
fields in
struct backlight_properties, use backlight_enable() and
backlight_disable(). These also call backlight_update_status() so the
separate call is no longer needed.
Signed-off-by: Stephen Kitt
Cc: Thierry Reding
Cc: Sam Ravnborg
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-devel
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Benjamin Herrenschmidt
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Helge Deller
Cc: linux
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Antonino Daplas
Cc
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Helge Deller
Cc: linux
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Helge Deller
Cc: linux
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Lee Jones
Cc: Daniel
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Lee Jones
Cc: Daniel
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Lee Jones
Cc: Daniel
, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Laurent Pinchart
Cc: Kieran Bingham
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
backlight_is_blank().
Signed-off-by: Stephen Kitt
Cc: Greg Kroah-Hartman
Cc: "Noralf Trønnes"
Cc: Thomas Zimmermann
Cc: Andy Shevchenko
Cc: Javier Martinez Canillas
Cc: Len Baker
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fb...@vger.kernel.org
Cc: linux-stag...@lists.linux.dev
--
backlight_properties, use backlight_is_blank().
Signed-off-by: Stephen Kitt
Cc: Thierry Reding
Cc: Sam Ravnborg
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/panel/panel-sony-acx565akm.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions
backlight_properties.fb_blank is deprecated. The states it represents
are handled by other properties; but instead of accessing those
properties directly, drivers should use the helpers provided by
backlight.h.
This will ultimately allow fb_blank to be removed.
Stephen Kitt (3):
drm/panel: Use
, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt
Cc: Thierry Reding
Cc: Sam
Commit 973c096f6a85 ("vgacon: remove software scrollback support")
removed all uses of vga_init_done, so let's get rid of it entirely.
Signed-off-by: Stephen Kitt
---
drivers/video/console/vgacon.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/video/console/vgacon.c
And of course I forgot this is an internal API, so this doesn't work
without some of other stuff which isn't ready.
Please ignore...
Regards,
Stephen
Le 25/01/2020 12:46, Stephen Kitt a écrit :
Instead of hand-coding the dma_resv_list allocation, use
dma_resv_list_alloc, which masks
touches shared_max. This suggests we'd probably be better off without
it!)
Signed-off-by: Stephen Kitt
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
b/drivers/gpu/drm
59 matches
Mail list logo
