Re: [RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc()

2024-05-31 Thread Tomer Tayar
On 31/05/2024 13:46, Thorsten Blum wrote: > Use kvfree() to fix the following Coccinelle/coccicheck warning reported > by kfree_mismatch.cocci: > > WARNING kvmalloc is used to allocate this memory at line 10398 > > Signed-off-by: Thorsten Blum Reviewed-by: Tomer Tayar

Re: [PATCH 5/8] accel/habanalabs: remove timestamp registration debug prints

2024-05-27 Thread Tomer Tayar
On 27/05/2024 18:02, Ofir Bitton wrote: > There are several timestamp registration debug prints which > spams the kernel log whenever dyn debug is enabled. > Remove those prints. > > Signed-off-by: Ofir Bitton Reviewed-by: Tomer Tayar > --- > .../accel/habanalabs/common

Re: [PATCH 4/9] accel/habanalabs/gaudi2: align embedded specs headers

2024-05-27 Thread Tomer Tayar
On 27/05/2024 14:47, Ofir Bitton wrote: > Align embedded headers to latest release. > > Signed-off-by: Ofir Bitton Reviewed-by: Tomer Tayar > --- > .../habanalabs/include/gaudi2/gaudi2_fw_if.h | 27 + > .../include/gaudi2/gaudi2_reg_map.h | 8

Re: [RFC v4 1/5] drm/netlink: Add netlink infrastructure

2023-11-23 Thread Tomer Tayar
On 22/11/2023 16:32, Aravind Iddamsetty wrote: > On 11/10/23 17:54, Tomer Tayar wrote: >> On 20/10/2023 18:58, Aravind Iddamsetty wrote: >>> Define the netlink registration interface and commands, attributes that >>> can be commonly used across by drm drivers

Re: [RFC v2 5/5] drm/xe/RAS: send multicast event on occurrence of an error

2023-11-12 Thread Tomer Tayar
On 10/11/2023 14:27, Tomer Tayar wrote: > On 20/10/2023 18:58, Aravind Iddamsetty wrote: >> Whenever a correctable or an uncorrectable error happens an event is sent >> to the corresponding listeners of these groups. >> >> v2: Rebase >> >> Signed-off-by: Arav

Re: [RFC v2 5/5] drm/xe/RAS: send multicast event on occurrence of an error

2023-11-10 Thread Tomer Tayar
On 20/10/2023 18:58, Aravind Iddamsetty wrote: > Whenever a correctable or an uncorrectable error happens an event is sent > to the corresponding listeners of these groups. > > v2: Rebase > > Signed-off-by: Aravind Iddamsetty > --- > drivers/gpu/drm/xe/xe_hw_error.c | 33

Re: [RFC v3 3/5] drm/xe/RAS: Expose the error counters

2023-11-10 Thread Tomer Tayar
On 20/10/2023 18:58, Aravind Iddamsetty wrote: > We expose the various error counters supported on a hardware via genl > subsytem through the registered commands to userspace. The > DRM_RAS_CMD_QUERY lists the error names with config id, > DRM_RAD_CMD_READ_ONE returns the counter value for the

Re: [RFC v4 1/5] drm/netlink: Add netlink infrastructure

2023-11-10 Thread Tomer Tayar
ome commands that shall be used to expose RAS error counters. > > v2: > define common interfaces to genl netlink subsystem that all drm drivers > can leverage.(Tomer Tayar) > > v3: drop DRIVER_NETLINK flag and use the driver_genl_ops structure to > register to netlink subsystem

Re: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-11-10 Thread Tomer Tayar
rror-gt1-soc-fatal-hbm-ss1-7 0x1034 > error-gt1-soc-fatal-hbm-ss2-0 0x1035 > error-gt1-soc-fatal-hbm-ss2-1 0x1036 > error-gt1-soc-fatal-hbm-ss2-2 0x1000

Re: [PATCH 1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2

2023-09-01 Thread Tomer Tayar
an König > Tested-by: Stanislaw Gruszka > --- For the whole series: Reviewed-by: Tomer Tayar And at least "accel-wise": Tested-by: Tomer Tayar Thanks, Tomer

Re: [PATCH 5/5] drm/debugfs: rework drm_debugfs_create_files implementation

2023-07-12 Thread Tomer Tayar
On 11/07/2023 17:04, Christian König wrote: > Use managed memory allocation for this. That allows us to not keep > track of all the files any more. > > Signed-off-by: Christian König > --- > drivers/accel/drm_accel.c | 2 - > drivers/gpu/drm/drm_debugfs.c | 75

Re: [PATCH 3/5] drm/debugfs: rework debugfs directory creation v4

2023-07-12 Thread Tomer Tayar
On 11/07/2023 17:04, Christian König wrote: > Instead of the per minor directories only create a single debugfs > directory for the whole device directly when the device is initialized. > > For DRM devices each minor gets a symlink to the per device directory > for now until we can be sure that

Re: [PATCH] accel: make accel_class a static const structure

2023-07-03 Thread Tomer Tayar
lly > allocated at boot time. > > Cc: Oded Gabbay > Cc: dri-devel@lists.freedesktop.org > Suggested-by: Greg Kroah-Hartman > Signed-off-by: Ivan Orlov > Signed-off-by: Greg Kroah-Hartman Reviewed-by: Tomer Tayar Thanks, Tomer > --- > drivers/accel/drm_accel.c | 21 +

Re: [PATCH] accel/habanalabs: add more debugfs stub helpers

2023-06-09 Thread Tomer Tayar
ebugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? > [-Werror=implicit-function-declaration] > > Add stubs for these as well. > > Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later") > Signed-off-by: Arnd Bergmann Thanks, Reviewed-by: Tomer Tayar

Re: [Intel-xe] [RFC 1/5] drm/netlink: Add netlink infrastructure

2023-06-06 Thread Tomer Tayar
On 05/06/2023 20:18, Iddamsetty, Aravind wrote: > > On 04-06-2023 22:37, Tomer Tayar wrote: >> On 26/05/2023 19:20, Aravind Iddamsetty wrote: >>> Define the netlink commands and attributes that can be commonly used >>> across by drm drivers. >>>

Re: [Intel-xe] [RFC 2/5] drm/xe/RAS: Register a genl netlink family

2023-06-04 Thread Tomer Tayar
On 26/05/2023 19:20, Aravind Iddamsetty wrote: > Use the generic netlink(genl) subsystem to expose the RAS counters to > userspace. We define a family structure and operations and register to > genl subsystem and these callbacks will be invoked by genl subsystem when > userspace sends a registered

Re: [Intel-xe] [RFC 1/5] drm/netlink: Add netlink infrastructure

2023-06-04 Thread Tomer Tayar
On 26/05/2023 19:20, Aravind Iddamsetty wrote: > Define the netlink commands and attributes that can be commonly used > across by drm drivers. > > Signed-off-by: Aravind Iddamsetty > --- > include/uapi/drm/drm_netlink.h | 68 ++ > 1 file changed, 68

Re: [Intel-xe] [RFC 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-06-04 Thread Tomer Tayar
On 26/05/2023 19:20, Aravind Iddamsetty wrote: > Our hardware supports RAS(Reliability, Availability, Serviceability) by > exposing a set of error counters which can be used by observability > tools to take corrective actions or repairs. Traditionally there were > being exposed via PMU (for

Re: [PATCH 2/5] drm/debugfs: rework debugfs directory creation v3

2023-04-16 Thread Tomer Tayar
On 12/04/2023 17:52, Christian König wrote: > /** > - * accel_debugfs_init() - Initialize debugfs for accel minor > + * accel_debugfs_init() - Register debugfs for accel minor > + * @dev: Pointer to the device instance. > + * > + * This function creates a root directory for the device in

RE: [PATCH 08/27] habanalabs: add info when FD released while device still in use

2023-02-20 Thread Tomer Tayar
On Thu, Feb 20, 2023 at 17:55 Stanislaw Gruszka wrote: > On Fri, Feb 17, 2023 at 11:34:39AM +0000, Tomer Tayar wrote: > > > > > Ok, just place replace compose_device_in_use_info() with snprintf(). > > > I don't think you need custom

RE: [PATCH 08/27] habanalabs: add info when FD released while device still in use

2023-02-17 Thread Tomer Tayar
On Thu, Feb 16, 2023 at 17:05 Stanislaw Gruszka wrote: > On Thu, Feb 16, 2023 at 04:21:48PM +0200, Oded Gabbay wrote: > > On Thu, Feb 16, 2023 at 2:25 PM Stanislaw Gruszka > > wrote: > > > > > > On Sun, Feb 12, 2023 at 10:44:35PM +0200, Oded Gabbay

RE: [PATCH 06/27] habanalabs: use memhash_node_export_put() in hl_release_dmabuf()

2023-02-16 Thread Tomer Tayar
On Thu, Feb 16, 2023 at 13:48 Stanislaw Gruszka wrote: > > The same mutex lock/unlock and counter decrementing in > > hl_release_dmabuf() is already done in the memhash_node_export_put() > > helper function. > > > > Signed-off-by: Tomer Tayar > > Revi

RE: [PATCH 05/27] habanalabs: refactor debugfs init

2023-02-16 Thread Tomer Tayar
On Sun, Feb 12, 2023 at 22:45 Oded Gabbay wrote: > Make it easier to later add support for accel device. > > Signed-off-by: Oded Gabbay Reviewed-by: Tomer Tayar

RE: [PATCH 04/27] habanalabs: save class in hdev

2023-02-16 Thread Tomer Tayar
On Sun, Feb 12, 2023 at 22:45 Oded Gabbay wrote: > It is more concise than to pass it to device init. Once we will add the > accel class, then we won't need to change the function signatures. > > Signed-off-by: Oded Gabbay Reviewed-by: Tomer Tayar

RE: [PATCH 03/27] habanalabs: split cdev creation to separate function

2023-02-16 Thread Tomer Tayar
ff-by: Oded Gabbay Reviewed-by: Tomer Tayar