Re: [bug report] drm/prime: replace NULL with error value in drm_prime_pages_to_sg

regards YJ On Thu, 14 Jun 2018, 23:42 Dan Carpenter, wrote: > Hello YoungJun Cho, > > The patch 7e3d88f9cce3: "drm/prime: replace NULL with error value in > drm_prime_pages_to_sg" from Jun 24, 2013, leads to the following > static checker warning: > >

[RFC PATCH v2] drm/exynos: make non kms drivers to be indenpendent modules

Hi Inki, There are 3 comments below. On 11/19/2014 12:19 PM, Inki Dae wrote: > This patch makes non kms drivers to be independent modules. > For this, it removes all register codes to non kms drivers > from exynos_drm_drv module and adds module_init/exit > for each non kms driver so that each

[PATCH 9/9] drm/exynos: dsi: set TE GPIO IRQ status as IRQ_NOAUTOEN

The exynos_dsi_te_irq_handler() works only dsi(DPMS) is on. So it is enough to enable and disable TE GPIO IRQ in exynos_dsi_enable(disable)_irq() like DSI IRQ. Signed-off-by: YoungJun Cho Acked-by: Inki Dae a Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 13

[PATCH 8/9] drm/exynos: dsi: move TE irq handler registration position

The drm_helper_hpd_irq_event() does dpms control and the panel is initialized and displayed on by it. So the exynos_dsi_te_irq_handler() should be registered beforehand. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 6

[PATCH 7/9] drm/exynos: use irq_flags instead of triggering

From: Joonyoung Shim The drm_handle_vblank should be called whenever be vsync, te interrupt means vsync on i80 interface. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[PATCH 6/9] drm/exynos: fimd: add triggering unset routine in fimd_trigger()

There is a case like set config which requires triggering but vblank is not enabled yet. So triggering unset routine is required to exit from triggering mode. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 7 +++ 1

[PATCH 5/9] drm/exynos: fimd: modify I80 i/f irq relevant routine

into proper positions. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 53 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers

[PATCH 4/9] drm/exynos: fimd: add fimd_enable_shadow_channel_path() to cleanup

This function is valid only the SoC has SHADOWCON register and it should be used together with fimd_enable_video_output() to match the ENWIN_F bit in WINCON# and C#_EN_F bit in SHADOWCON. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos

[PATCH 3/9] drm/exynos: fimd: add fimd_enable_video_output() to cleanup

This bit is used for video output and logic signal control. So it is better for readability. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions

[PATCH 2/9] drm/exynos: fimd: move shadow unprotection position

The C#_EN_F in SHADOWCON register is updated per frame. So it should be protected by fimd_shadow_protect_win(). Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 1/9] drm/exynos: move triggering checking

From: Joonyoung Shim It's better to be checking whether triggerring in fimd_trigger function. Also it will return if in triggerring on fimd_te_handler, then it can't execute remain codes. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 14

[PATCH v2 0/9] drm/exynos: modify LCD I80 interface display

irq_flags instead of triggering YoungJun Cho (7): drm/exynos: fimd: move shadow unprotection position drm/exynos: fimd: add fimd_enable_video_output() to cleanup drm/exynos: fimd: add fimd_enable_shadow_channel_path() to cleanup drm/exynos: fimd: modify I80 i/f irq relevant routine drm/exynos

[PATCH 5/7] drm/exynos: fimd: modify I80 i/f interrupt relevant routine

Hi Inki, On 11/14/2014 10:36 AM, Inki Dae wrote: > On 2014년 10월 01일 15:19, YoungJun Cho wrote: >> For the I80 interface, the video interrupt pending register(VIDINTCON1) >> should be handled in fimd_irq_handler() and the video interrupt control >> register(VIDINTCO

[PATCH 2/2] drm/exynos: use irq_flags instead of triggering

Hi JoonYoung, On 11/14/2014 02:12 PM, Joonyoung Shim wrote: > Hi, > > On 11/14/2014 02:01 PM, YoungJun Cho wrote: >> Hi JoonYoung, >> >> On 11/14/2014 11:36 AM, Joonyoung Shim wrote: >>> The drm_handle_vblank should be called whenever be vsync, te interr

[PATCH 2/2] drm/exynos: use irq_flags instead of triggering

Hi JoonYoung, On 11/14/2014 11:36 AM, Joonyoung Shim wrote: > The drm_handle_vblank should be called whenever be vsync, te interrupt > means vsync on i80 interface. That's right. > > Signed-off-by: Joonyoung Shim > --- > Based on lastest exynos-drm-next branch and patch of Yo

[PATCH 6/7] drm/exynos: dsi: move TE irq handler registration position

Hi Inki, On 11/14/2014 10:49 AM, Inki Dae wrote: > On 2014년 10월 01일 15:19, YoungJun Cho wrote: >> The drm_helper_hpd_irq_event() does dpms control and panel is >> initialized and displayed on by it. >> So should register TE irq handler(exynos_dsi_te_irq_han

[PATCH 3/7] drm/exynos: fimd: modify vclk calculation for I80 i/f

Hi Inki, On 11/13/2014 06:12 PM, Inki Dae wrote: > On 2014년 10월 01일 15:19, YoungJun Cho wrote: >> The I80 interface uses SYS_WE and SYS_CS to process >> 1 pixel data, so it requires the twice faster clock >> than the pixel clock. >> And the frame done in

[PATCH 4/4] ARM: dts: add mipi dsi device node to exynos4415.dtsi

This patch adds mipi dsi device node to exynos4415.dtsi. Signed-off-by: YoungJun Cho Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4415.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/exynos4415.dtsi b/arch/arm/boot/dts/exynos4415.dtsi index

[PATCH 3/4] ARM: dts: add fimd device node to exynos4415.dtsi

This patch adds fimd device node to exynos4415.dtsi. Signed-off-by: YoungJun Cho Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4415.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/exynos4415.dtsi b/arch/arm/boot/dts/exynos4415.dtsi index c1c9b37

[PATCH 2/4] drm/exynos: fimd: support Exynos4415 SoC

This patch supports Exynos4415 SoC. Signed-off-by: YoungJun Cho Acked-by: Kyungmin Park --- Documentation/devicetree/bindings/video/samsung-fimd.txt | 1 + drivers/gpu/drm/exynos/exynos_drm_fimd.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/Documentation

[PATCH 1/4] drm/exynos: dsi: support Exynos4415 SoC

This patch supports Exynos4415 SoC. Signed-off-by: YoungJun Cho Acked-by: Kyungmin Park --- Documentation/devicetree/bindings/video/exynos_dsim.txt | 1 + drivers/gpu/drm/exynos/exynos_drm_dsi.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/Documentation

[PATCH 0/4] drm/exynos: support Exynos4415 SoC

t;[1]. [1] http://www.spinics.net/lists/dri-devel/msg71092.html YoungJun Cho (4): drm/exynos: dsi: support Exynos4415 SoC drm/exynos: fimd: support Exynos4415 SoC ARM: dts: add fimd device node to exynos4415.dtsi ARM: dts: add mipi dsi device node to exynos4415.dtsi .../devicetree/bind

[PATCH 7/7] drm/exynos: dsi: move DSIM_STATE_ENABLED set position

lay on command. And moves the display on command execution routine from prepare() to enable() in drm_panel_funcs also. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) d

[PATCH 6/7] drm/exynos: dsi: move TE irq handler registration position

The drm_helper_hpd_irq_event() does dpms control and panel is initialized and displayed on by it. So should register TE irq handler(exynos_dsi_te_irq_handler()) beforehand. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 19

[PATCH 5/7] drm/exynos: fimd: modify I80 i/f interrupt relevant routine

into proper positions. And adds triggering unset routine in fimd_trigger() to exit from it because there is a case like set config which requires triggering but vblank is not enabled. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos

[PATCH 4/7] drm/exynos: fimd: move handle vblank position in TE handler

For providing VBLANK information, drm_handle_vblank() should be called properly, but it is blocked by wait_vsync_event condition which is set by manager_ops->wait_for_vblank(). So moves it out from wait_vsync_event routine. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin P

[PATCH 3/7] drm/exynos: fimd: modify vclk calculation for I80 i/f

The I80 interface uses SYS_WE and SYS_CS to process 1 pixel data, so it requires the twice faster clock than the pixel clock. And the frame done interrupt should occurr prior to the next TE signal, H/W guy recommends to use as 1.73 times faster clock frequency. Signed-off-by: YoungJun Cho Acked

[PATCH 2/7] drm/exynos: fimd: add fimd_channel_win() to clean up code

The ENWIN_F in WINCON# register and C#_EN_Fs in SHADOWCON register should be always matched together, so adds fimd_channel_win() to clean up code. And this fimd_channel_win() should be called before unprotecting window in fimd_win_commit(). Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked

[PATCH 1/7] drm/exynos: fimd: remove unnecessary waiting vblank routine

w and vblank is already off when it is called. So addtional waiting vblank is not necessary any more. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_d

[PATCH 0/7] drm/exynos: modify LCD I80 interface display

information. Patch 5 arranges I80 interface interrupt configuration like RGB interface. Patches 6 and 7 prevent showing the command mode panel garbage GRAM screen data. I welcome any comments. Thank you. Best regards YJ YoungJun Cho (7): drm/exynos: fimd: remove unnecessary waiting vblank routine

[PATCH] drm/exynos: dsi: fix exynos_dsi_set_pll() wrong return value

The type of this function is unsigned long, and it is expected to return proper fout value or zero if something is wrong. So this patch fixes wrong return value for error cases. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_dsi.c

[PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

Hi Inki, Andrzej On 08/11/2014 04:09 PM, Inki Dae wrote: > On 2014? 08? 08? 18:40, Andrzej Hajda wrote: >> On 08/08/2014 11:02 AM, Andrzej Hajda wrote: >>> On 08/08/2014 09:37 AM, Inki Dae wrote: On 2014? 08? 08? 16:03, Thierry Reding wrote: > On Fri, Aug 08, 2014 at 10:45:47AM +0900,

[RFC PATCH] drm/mipi-dsi: add some generic functions for DCS

. mipi_dsi_set_maximum_return_packet_size() - Although it is not related with DCS, it is required before using mipi_dsi_dcs_read() to specify the maximum size of the payload in a long packet. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/drm_mipi_dsi.c | 113

[PATCH v6 10/14] drm/panel: add S6E3FA0 driver

in simple panel driver, so this and s6e8aa0 panel couldn't use that interface. The s6e3fa0 and s6e8aa0 are very similar so I think it is possible to combine together like simple panel driver. I want to ask you for advice on this. Thank you. Best regards YJ On 07/22/2014 12:56 PM, YoungJun Cho

[PATCH v2 1/2] drm/mipi-dsi: add (LPM) Low Power Mode transfer support

Hi Andrzej, On 07/29/2014 01:09 AM, Andrzej Hajda wrote: > On 07/28/2014 04:00 AM, Inki Dae wrote: >> This patch adds below two flags for LPM transfer, and it attaches LPM flags >> to a msg in accordance with master's mode_flags set by LCD Panel driver. >> >> MIPI_DSI_MODE_CMD_LPM >> - If this

[PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface

Hi Varka, On 07/22/2014 08:14 PM, Varka Bhadram wrote: > On 07/22/2014 04:40 PM, YoungJun Cho wrote: >> Hi Varka, >> >> This irq handler should be registered in attach() and unregistered in >> detach(). >> >> The devm_* APIs are released(freed) in remove(),

[PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface

regards YJ On 07/22/2014 07:57 PM, Varka Bhadram wrote: > On 07/22/2014 04:19 PM, YoungJun Cho wrote: > > (...) > >> +ret = gpio_request_one(dsi->te_gpio, GPIOF_IN, "te_gpio"); > > devm_* APIs..? > >> +if (ret) { >> +de

[PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface

to trigger to transfer video image. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 97 - 1 file changed, 95 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b

[PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface

Hi Andrzej, On 07/22/2014 07:12 PM, Andrzej Hajda wrote: > On 07/22/2014 03:23 AM, Inki Dae wrote: >> On 2014? 07? 21? 23:01, Andrzej Hajda wrote: >>> On 07/17/2014 11:01 AM, YoungJun Cho wrote: >>>> To support LCD I80 interface, the DSI host should register >>

[PATCH v6 10/14] drm/panel: add S6E3FA0 driver

Hi Thierry, On 07/22/2014 04:49 PM, Thierry Reding wrote: > On Tue, Jul 22, 2014 at 12:41:21PM +0900, YoungJun Cho wrote: >> On 07/21/2014 08:18 PM, Andrzej Hajda wrote: >>> On 07/21/2014 11:19 AM, Thierry Reding wrote: >>>> On Mon, Jul 21, 2014 at 10:56:0

[PATCH 1/4] drm/dsi: Make mipi_dsi_dcs_write() return ssize_t

Hi, On 07/22/2014 04:28 PM, Andrzej Hajda wrote: > Hi Thierry, > > Thanks for the patch. > > On 07/22/2014 09:12 AM, Thierry Reding wrote: >> From: Thierry Reding >> >> This function returns the value of the struct mipi_dsi_host_ops' >> .transfer() so make sure the return types are consistent.

[PATCH v6 10/14] drm/panel: add S6E3FA0 driver

Hi Thierry, Now I understand what you mean. I'll implement common DSI helper functions. Thank you. Best regards YJ On 07/21/2014 06:35 PM, Thierry Reding wrote: > On Fri, Jul 18, 2014 at 10:49:35AM +0900, YoungJun Cho wrote: >> Hi Thierry, >> >> Thank you a lot for kind

[PATCH v6 10/14] drm/panel: add S6E3FA0 driver

Hi, On 07/21/2014 08:18 PM, Andrzej Hajda wrote: > On 07/21/2014 11:19 AM, Thierry Reding wrote: >> On Mon, Jul 21, 2014 at 10:56:08AM +0200, Andrzej Hajda wrote: >>> On 07/18/2014 03:49 AM, YoungJun Cho wrote: >>>> Hi Thierry, >>>> >>>> Than

[PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface

Hi, On 07/22/2014 10:23 AM, Inki Dae wrote: > On 2014? 07? 21? 23:01, Andrzej Hajda wrote: >> On 07/17/2014 11:01 AM, YoungJun Cho wrote: >>> To support LCD I80 interface, the DSI host should register >>> TE interrupt handler from the TE GPIO of attached panel.

[PATCH v6 09/14] ARM: dts: s6e3fa0: add DT bindings

Hi Thierry, On 07/17/2014 07:38 PM, Thierry Reding wrote: > On Thu, Jul 17, 2014 at 06:01:24PM +0900, YoungJun Cho wrote: >> This patch adds DT bindings for s6e3fa0 panel. >> The bindings describes panel resources and display timings. > > The commit message here should

[PATCH v6 10/14] drm/panel: add S6E3FA0 driver

Hi Thierry, Thank you a lot for kind comments. On 07/17/2014 07:36 PM, Thierry Reding wrote: > On Thu, Jul 17, 2014 at 06:01:25PM +0900, YoungJun Cho wrote: > [...] >> diff --git a/drivers/gpu/drm/panel/panel-s6e3fa0.c >> b/drivers/gpu/drm/panel/panel-s6e3fa0.c > [...

[PATCH v6 14/14] ARM: dts: exynos5420: add dsi node

This patch adds common part of dsi node. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos5420.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi

[PATCH v6 13/14] ARM: dts: exynos5420: add mipi-phy node

This patch adds mipi-phy node for MIPI DSI device. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos5420.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi

[PATCH v6 12/14] ARM: dts: exynos5: add system register property

This patch adds sysreg property to fimd device node which is required to use I80 interface. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos5.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm

[PATCH v6 11/14] ARM: dts: exynos4: add system register property

This patch adds sysreg property to fimd device node which is required to use I80 interface. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm

[PATCH v6 10/14] drm/panel: add S6E3FA0 driver

This patch adds MIPI DSI command mode based S6E3FA0 AMOLED LCD Panel driver. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/panel/Kconfig | 7 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-s6e3fa0.c | 541

[PATCH v6 09/14] ARM: dts: s6e3fa0: add DT bindings

This patch adds DT bindings for s6e3fa0 panel. The bindings describes panel resources and display timings. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- .../devicetree/bindings/panel/samsung,s6e3fa0.txt | 46 ++ 1 file changed, 46 insertions

[PATCH v6 08/14] drm/exynos: dsi: add driver data to support Exynos5410/5420/5440 SoCs

data to distinguish it. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 157 +++- 1 file changed, 135 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers

[PATCH v6 07/14] ARM: dts: exynos_dsim: add exynos5410 compatible to DT bindings

This patch adds relevant to exynos5410 compatible for exynos5410 / 5420 / 5440 SoCs support. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- Documentation/devicetree/bindings/video/exynos_dsim.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v6 06/14] drm/exynos: fimd: support LCD I80 interface

mes faster than the original one to generate frame done IRQ prior to the next TE signal. - Implements trigger feature that transfers image data if there is page flip request, and implements TE handler to call trigger function. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyu

[PATCH v6 05/14] drm/exynos: dsi: add TE interrupt handler to support LCD I80 interface

To support LCD I80 interface, the DSI host should register TE interrupt handler from the TE GPIO of attached panel. So the panel generates a tearing effect synchronization signal then the DSI host calls the CRTC device manager to trigger to transfer video image. Signed-off-by: YoungJun Cho Acked

[PATCH v6 04/14] drm/exynos: add TE handler to support LCD I80 interface

it to the display controller. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 8 drivers/gpu/drm/exynos/exynos_drm_crtc.h | 7 +++ drivers/gpu/drm/exynos/exynos_drm_drv.h | 3 +++ 3 files changed, 18 insertions

[PATCH v6 03/14] ARM: dts: samsung-fimd: add LCD I80 interface specific properties

In case of using MIPI DSI based I80 interface panel, the relevant registers should be set. So this patch adds relevant DT bindings. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- .../devicetree/bindings/video/samsung-fimd.txt | 28 ++ 1 file

[PATCH v6 02/14] drm/exynos: use wait_event_timeout() for safety usage

lip in exynos_drm_crtc_page_flip() when exynos_drm_crtc_mode_set_commit() is failed. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH v6 01/14] drm/exynos: dsi: move the EoT packets configuration point

This configuration could be used in MIPI DSI command mode also. And adds user manual description for display configuration. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 14 -- 1

[PATCH v6 00/14] drm/exynos: support LCD I80 interface display

3FA0 AMOLED 5.7" LCD drm panel driver. The ohters add DT property nodes to support MIPI DSI command mode. I welcome any comments. Thank you. Best regards YJ YoungJun Cho (14): drm/exynos: dsi: move the EoT packets configuration point drm/exynos: use wait_event_timeout() for safety usage

[PATCH v5 05/14] drm/exynos: dsi: add pass TE host ops to support LCD I80 interface

Hi Thierry, On 07/16/2014 04:54 PM, Thierry Reding wrote: > On Wed, Jul 16, 2014 at 11:23:09AM +0900, YoungJun Cho wrote: >> Hi Inki, >> >> On 07/15/2014 11:34 AM, Inki Dae wrote: >>> On 2014? 07? 14? 20:03, Thierry Reding wrote: >>>> On Mon, Jul 14, 20

[PATCH v5 05/14] drm/exynos: dsi: add pass TE host ops to support LCD I80 interface

Hi Inki, On 07/15/2014 11:34 AM, Inki Dae wrote: > On 2014? 07? 14? 20:03, Thierry Reding wrote: >> On Mon, Jul 14, 2014 at 07:45:28PM +0900, YoungJun Cho wrote: >>> On 07/14/2014 06:41 PM, Thierry Reding wrote: >> [...] >>>> That said, I've been doing som

[PATCH RFA] drm: add of_graph endpoint helper to find possible CRTCs

Hi Russell, On 07/11/2014 03:01 AM, Russell King wrote: > Add a helper to allow encoders to find their possible CRTCs from the > OF graph without having to re-implement this functionality. We add a > device_node to drm_crtc which corresponds with the port node in the > DT description of the CRTC

[PATCH v5 05/14] drm/exynos: dsi: add pass TE host ops to support LCD I80 interface

Hi Thierry, On 07/14/2014 06:41 PM, Thierry Reding wrote: > On Mon, Jul 14, 2014 at 06:22:39PM +0900, YoungJun Cho wrote: >> Hi Thierry, >> >> Thank you for comment. >> >> On 07/10/2014 04:38 PM, Thierry Reding wrote: >>> On Thu, Jul 10, 2014 at 10:06:07A

[PATCH v5 05/14] drm/exynos: dsi: add pass TE host ops to support LCD I80 interface

Hi Thierry, Thank you for comment. On 07/10/2014 04:38 PM, Thierry Reding wrote: > On Thu, Jul 10, 2014 at 10:06:07AM +0900, YoungJun Cho wrote: >> On 07/10/2014 12:22 AM, Thierry Reding wrote: >>> On Tue, Jul 08, 2014 at 09:39:38AM +0900, YoungJun Cho wrote: >>>>

[PATCH v5 05/14] drm/exynos: dsi: add pass TE host ops to support LCD I80 interface

On 07/10/2014 12:22 AM, Thierry Reding wrote: > On Tue, Jul 08, 2014 at 09:39:38AM +0900, YoungJun Cho wrote: >> To support LCD I80 interface, the DSI host calls this function >> to notify the panel tearing effect synchronization signal to >> the CRTC device manager to trig

[PATCH v5 06/14] drm/exynos: fimd: support LCD I80 interface

mes faster than the original one to generate frame done IRQ prior to the next TE signal. - Implements trigger feature that transfers image data if there is page flip request, and implements TE handler to call trigger function. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyu

[PATCH v5 14/14] ARM: dts: exynos5420: add dsi node

This patch adds common part of dsi node. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos5420.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi

[PATCH v5 13/14] ARM: dts: exynos5420: add mipi-phy node

This patch adds mipi-phy node for MIPI DSI device. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos5420.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi

[PATCH v5 12/14] ARM: dts: exynos5: add system register property

This patch adds sysreg property to fimd device node which is required to use I80 interface. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos5.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm

[PATCH v5 11/14] ARM: dts: exynos4: add system register property

This patch adds sysreg property to fimd device node which is required to use I80 interface. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm

[PATCH v5 10/14] drm/panel: add S6E3FA0 driver

This patch adds MIPI DSI command mode based S6E3FA0 AMOLED LCD Panel driver. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/panel/Kconfig | 7 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-s6e3fa0.c | 569

[PATCH v5 09/14] ARM: dts: s6e3fa0: add DT bindings

This patch adds DT bindings for s6e3fa0 panel. The bindings describes panel resources and display timings. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- .../devicetree/bindings/panel/samsung,s6e3fa0.txt | 46 ++ 1 file changed, 46 insertions

[PATCH v5 08/14] drm/exynos: dsi: add driver data to support Exynos5410/5420/5440 SoCs

data to distinguish it. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 157 +++- 1 file changed, 135 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers

[PATCH v5 07/14] ARM: dts: exynos_dsim: add exynos5410 compatible to DT bindings

This patch adds relevant to exynos5410 compatible for exynos5410 / 5420 / 5440 SoCs support. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- Documentation/devicetree/bindings/video/exynos_dsim.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v5 06/14] drm/exynos: fimd: support LCD I80 interface

mes faster than the original one to generate frame done IRQ prior to the next TE signal. - Implements trigger feature that transfers image data if there is page flip request, and implements TE handler to call trigger function. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyu

[PATCH v5 05/14] drm/exynos: dsi: add pass TE host ops to support LCD I80 interface

To support LCD I80 interface, the DSI host calls this function to notify the panel tearing effect synchronization signal to the CRTC device manager to trigger to transfer video image. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos

[PATCH v5 04/14] drm/exynos: add TE handler to support LCD I80 interface

it to the display controller. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 8 drivers/gpu/drm/exynos/exynos_drm_crtc.h | 7 +++ drivers/gpu/drm/exynos/exynos_drm_drv.h | 3 +++ 3 files changed, 18 insertions

[PATCH v5 03/14] ARM: dts: samsung-fimd: add LCD I80 interface specific properties

In case of using MIPI DSI based I80 interface panel, the relevant registers should be set. So this patch adds relevant DT bindings. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- .../devicetree/bindings/video/samsung-fimd.txt | 28 ++ 1 file

[PATCH v5 02/14] drm/exynos: use wait_event_timeout() for safety usage

lip in exynos_drm_crtc_page_flip() when exynos_drm_crtc_mode_set_commit() is failed. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH v5 01/14] drm/exynos: dsi: move the EoT packets configuration point

This configuration could be used in MIPI DSI command mode also. And adds user manual description for display configuration. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 13 +++-- 1 file

[PATCH v5 00/14] drm/exynos: support LCD I80 interface display

uce MIPI DSI command mode based Samsung S6E3FA0 AMOLED 5.7" LCD drm panel driver. The ohters add DT property nodes to support MIPI DSI command mode. I welcome any comments. Thank you. Best regards YJ YoungJun Cho (14): drm/exynos: dsi: move the EoT packets configuration point drm/exyno

[PATCH 0/3] drm/exynos: add framework to control DISP1BLK setting

Hi Ajay, I'm sorry for say that the patchset for exynos drm supporting I80 i/f includes yours. The patchset is still in reviewing and I'm preparing v5. Please check this: http://www.spinics.net/lists/dri-devel/msg60943.html Thank you. Best regards YJ On Jun 25, 2014 11:19 PM, "Ajay Kumar"

[PATCH v4 14/14] ARM: dts: exynos5420: add dsi node

This patch adds common part of dsi node. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos5420.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi

[PATCH v4 13/14] ARM: dts: exynos5420: add mipi-phy node

This patch adds mipi-phy node for MIPI DSI device. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos5420.dtsi |6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi

[PATCH v4 12/14] ARM: dts: exynos5: add system register property

This patch adds sysreg property to fimd device node which is required to use I80 interface. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos5.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch

[PATCH v4 11/14] ARM: dts: exynos4: add system register property

This patch adds sysreg property to fimd device node which is required to use I80 interface. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos4.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch

[PATCH v4 10/14] drm/panel: add S6E3FA0 driver

This patch adds MIPI DSI command mode based S6E3FA0 AMOLED LCD Panel driver. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/panel/Kconfig |7 + drivers/gpu/drm/panel/Makefile|1 + drivers/gpu/drm/panel/panel-s6e3fa0.c | 568

[PATCH v4 09/14] ARM: dts: s6e3fa0: add DT bindings

This patch adds DT bindings for s6e3fa0 panel. The bindings describes panel resources and display timings. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- .../devicetree/bindings/panel/samsung,s6e3fa0.txt | 46 1 file changed, 46 insertions

[PATCH v4 08/14] drm/exynos: dsi: add driver data to support Exynos5420

-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 157 ++- 1 file changed, 135 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c

[PATCH v4 07/14] ARM: dts: exynos_dsim: add exynos5420 compatible to DT bindings

This patch adds relevant to exynos5420 compatible for exynos5420 SoC support. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- .../devicetree/bindings/video/exynos_dsim.txt |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation

[PATCH v4 06/14] drm/exynos: fimd: support LCD I80 interface

mes faster than the original one to generate frame done IRQ prior to the next TE signal. - Implements trigger feature that transfers image data if there is page flip request, and implements TE handler to call trigger function. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyu

[PATCH v4 05/14] drm/exynos: dsi: add TE handler to support LCD I80 interface

To support LCD I80 interface, the DSI host calls this handler to notify the panel tearing effect synchronization signal to the CRTC device manager to trigger to transfer video image. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos

[PATCH v4 04/14] drm/exynos: add TE handler to support LCD I80 interface

it to the display controller. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 11 +++ drivers/gpu/drm/exynos/exynos_drm_crtc.h |7 +++ drivers/gpu/drm/exynos/exynos_drm_drv.h |3 +++ include/drm

[PATCH v4 03/14] ARM: dts: samsung-fimd: add LCD I80 interface specific properties

In case of using MIPI DSI based I80 interface panel, the relevant registers should be set. So this patch adds relevant DT bindings. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park --- .../devicetree/bindings/video/samsung-fimd.txt | 28 1 file

[PATCH v4 02/14] drm/exynos: use wait_event_timeout() for safety usage

lip in exynos_drm_crtc_page_flip() when exynos_drm_crtc_mode_set_commit() is failed. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_crtc.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/driv

[PATCH v4 01/14] drm/exynos: dsi: move the EoT packets configuration point

This configuration could be used in MIPI DSI command mode also. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_dsi.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v4 00/14] drm/exynos: support LCD I80 interface display

ch is different from previous Exynos4 SoCs for some registers control. Patches 9 and 10 introduce MIPI DSI command mode based Samsung S6E3FA0 AMOLED 5.7" LCD drm panel driver. The ohters add DT property nodes to support MIPI DSI command mode. I welcome any comments. Thank you. Best regards YJ

[PATCH v3 13/15] ARM: dts: exynos5: add system register support

Hi Vivek, On 06/04/2014 08:50 PM, Vivek Gautam wrote: > On Mon, Jun 2, 2014 at 10:52 AM, YoungJun Cho wrote: >> This patch adds sysreg device node, and sysreg property >> to fimd device node which is required to use I80 interface. > > Same here. The system register

  1   2   3   >