Re: [PATCH] drm/ast: Fix modeset failed on DisplayPort

2023-05-24 Thread Jammy Huang
Hi Thomas, Thanks, I will modify the patch accordingly. On 2023/5/24 下午 06:47, Thomas Zimmermann wrote: Hi, this patch also fell through the cracks. Apologies. Am 24.05.23 um 04:29 schrieb Jammy Huang: Hi Thomas, Do you have other suggestion for this patch?? The main issue was that

Re: [PATCH] drm/ast: Fix modeset failed on DisplayPort

2023-05-24 Thread Thomas Zimmermann
Hi, this patch also fell through the cracks. Apologies. Am 24.05.23 um 04:29 schrieb Jammy Huang: Hi Thomas, Do you have other suggestion for this patch?? The main issue was that struct ast_private is now called struct ast_device. So the current patch cannot be applied. Please kindly

Re: [PATCH] drm/ast: Fix modeset failed on DisplayPort

2023-05-23 Thread Jammy Huang
Hi Thomas, Do you have other suggestion for this patch?? Please kindly advise. On 2023/4/25 下午 03:39, Jammy Huang wrote: Hi Thomas, I think DP501 is OK. It doesn't use ioregs in ast_dp501_read_edid(). On 2023/4/25 下午 03:27, Thomas Zimmermann wrote: Hi Am 25.04.23 um 09:03 schrieb Jammy

Re: [PATCH] drm/ast: Fix modeset failed on DisplayPort

2023-04-25 Thread Jammy Huang
Hi Thomas, I think DP501 is OK. It doesn't use ioregs in ast_dp501_read_edid(). On 2023/4/25 下午 03:27, Thomas Zimmermann wrote: Hi Am 25.04.23 um 09:03 schrieb Jammy Huang: If we switch display and update cursor together, it could lead to modeset failed because of concurrent access to IO

Re: [PATCH] drm/ast: Fix modeset failed on DisplayPort

2023-04-25 Thread Thomas Zimmermann
Hi Am 25.04.23 um 09:03 schrieb Jammy Huang: If we switch display and update cursor together, it could lead to modeset failed because of concurrent access to IO registers. Add lock protection in DP's edid access to avoid this problem. Thanks for the patch. I thought I fixed this issue

[PATCH] drm/ast: Fix modeset failed on DisplayPort

2023-04-25 Thread Jammy Huang
If we switch display and update cursor together, it could lead to modeset failed because of concurrent access to IO registers. Add lock protection in DP's edid access to avoid this problem. Signed-off-by: Jammy Huang --- drivers/gpu/drm/ast/ast_mode.c | 11 +++ 1 file changed, 11