Re: [PATCH] drm/i915: Remove unneeded double drm_rect_visible call in check_overlay_dst

2024-03-04 Thread Ville Syrjälä
On Fri, Mar 01, 2024 at 09:56:41PM +0300, Nikita Kiryushin wrote: > On 2/29/24 15:30, Ville Syrjälä wrote: > > I prefer the current way where we have no side effects in > > the if statement. > > > > This seem like a valid concern from readability and maintainability > standpoint. My patch was

Re: [PATCH] drm/i915: Remove unneeded double drm_rect_visible call in check_overlay_dst

2024-03-03 Thread Nikita Kiryushin
On 2/29/24 15:30, Ville Syrjälä wrote: I prefer the current way where we have no side effects in the if statement. This seem like a valid concern from readability and maintainability standpoint. My patch was aimed mostly at performance and maintainability using tools: some more pedantic

Re: [PATCH] drm/i915: Remove unneeded double drm_rect_visible call in check_overlay_dst

2024-02-29 Thread Ville Syrjälä
On Wed, Feb 28, 2024 at 09:32:47PM +0300, Nikita Kiryushin wrote: > > check_overlay_dst for clipped is called 2 times: in drm_rect_intersect > and than directly. Change second call for check of drm_rect_intersect > result to save some time (in locked code section). > > Found by Linux

[PATCH] drm/i915: Remove unneeded double drm_rect_visible call in check_overlay_dst

2024-02-29 Thread Nikita Kiryushin
check_overlay_dst for clipped is called 2 times: in drm_rect_intersect and than directly. Change second call for check of drm_rect_intersect result to save some time (in locked code section). Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 8d8b2dd3995f ("drm/i915: