Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2020 at 2:59 PM Melissa Wen wrote: > > Hi all, > > I traced the subtests' execution to figure out what happens (or not) in > a clean run and a blocked run, and this led me to suspect the > vkms_crtc_atomic_flush function. Examining the code and considering the > DRM doc, it seemed

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-21 Thread Melissa Wen
Hi all, I traced the subtests' execution to figure out what happens (or not) in a clean run and a blocked run, and this led me to suspect the vkms_crtc_atomic_flush function. Examining the code and considering the DRM doc, it seemed to me that a drm_crtc_vblank_get call was missing a

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2020 at 05:33:00AM +, Sidong Yang wrote: > Hi, Daniel and Melissa > > I tested some code for this problem trying to find the code that make problem > in igt test. > kms_cursor_crc test in igt test has 3 steps (preparation, test, cleanup). I > check each steps > and I found

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-20 Thread Sidong Yang
On Wed, Jul 15, 2020 at 06:08:44PM +0200, Daniel Vetter wrote: > On Wed, Jul 15, 2020 at 5:57 PM Melissa Wen wrote: > > > > On 07/15, Sidong Yang wrote: > > > On Wed, Jul 15, 2020 at 10:17:56AM +0200, Daniel Vetter wrote: > > > > On Tue, Jul 14, 2020 at 9:01 PM Melissa Wen > > > > wrote: > > >

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-15 Thread Daniel Vetter
On Wed, Jul 15, 2020 at 5:57 PM Melissa Wen wrote: > > On 07/15, Sidong Yang wrote: > > On Wed, Jul 15, 2020 at 10:17:56AM +0200, Daniel Vetter wrote: > > > On Tue, Jul 14, 2020 at 9:01 PM Melissa Wen wrote: > > > > > > > > On 07/14, Daniel Vetter wrote: > > > > > On Tue, Jul 14, 2020 at

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-15 Thread Melissa Wen
On 07/15, Sidong Yang wrote: > On Wed, Jul 15, 2020 at 10:17:56AM +0200, Daniel Vetter wrote: > > On Tue, Jul 14, 2020 at 9:01 PM Melissa Wen wrote: > > > > > > On 07/14, Daniel Vetter wrote: > > > > On Tue, Jul 14, 2020 at 07:39:42AM -0300, Melissa Wen wrote: > > > > > On Tue, Jul 14, 2020 at

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-15 Thread Sidong Yang
On Wed, Jul 15, 2020 at 10:17:56AM +0200, Daniel Vetter wrote: > On Tue, Jul 14, 2020 at 9:01 PM Melissa Wen wrote: > > > > On 07/14, Daniel Vetter wrote: > > > On Tue, Jul 14, 2020 at 07:39:42AM -0300, Melissa Wen wrote: > > > > On Tue, Jul 14, 2020 at 7:20 AM Melissa Wen > > > > wrote: > > >

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-15 Thread Daniel Vetter
On Tue, Jul 14, 2020 at 9:01 PM Melissa Wen wrote: > > On 07/14, Daniel Vetter wrote: > > On Tue, Jul 14, 2020 at 07:39:42AM -0300, Melissa Wen wrote: > > > On Tue, Jul 14, 2020 at 7:20 AM Melissa Wen wrote: > > > > > > > > On 07/13, Daniel Vetter wrote: > > > > > On Fri, Jul 10, 2020 at

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-14 Thread Melissa Wen
On 07/14, Daniel Vetter wrote: > On Tue, Jul 14, 2020 at 07:39:42AM -0300, Melissa Wen wrote: > > On Tue, Jul 14, 2020 at 7:20 AM Melissa Wen wrote: > > > > > > On 07/13, Daniel Vetter wrote: > > > > On Fri, Jul 10, 2020 at 02:05:33PM -0300, Melissa Wen wrote: > > > > > On 07/02, Daniel Vetter

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-14 Thread Daniel Vetter
On Tue, Jul 14, 2020 at 07:39:42AM -0300, Melissa Wen wrote: > On Tue, Jul 14, 2020 at 7:20 AM Melissa Wen wrote: > > > > On 07/13, Daniel Vetter wrote: > > > On Fri, Jul 10, 2020 at 02:05:33PM -0300, Melissa Wen wrote: > > > > On 07/02, Daniel Vetter wrote: > > > > > On Wed, Jul 01, 2020 at

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-14 Thread Melissa Wen
On Tue, Jul 14, 2020 at 7:20 AM Melissa Wen wrote: > > On 07/13, Daniel Vetter wrote: > > On Fri, Jul 10, 2020 at 02:05:33PM -0300, Melissa Wen wrote: > > > On 07/02, Daniel Vetter wrote: > > > > On Wed, Jul 01, 2020 at 03:31:34PM +, Sidong Yang wrote: > > > > > there is an error when igt

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-14 Thread Melissa Wen
On 07/13, Daniel Vetter wrote: > On Fri, Jul 10, 2020 at 02:05:33PM -0300, Melissa Wen wrote: > > On 07/02, Daniel Vetter wrote: > > > On Wed, Jul 01, 2020 at 03:31:34PM +, Sidong Yang wrote: > > > > there is an error when igt test is run continuously. > > > > vkms_atomic_commit_tail() > > >

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-13 Thread Daniel Vetter
On Fri, Jul 10, 2020 at 02:05:33PM -0300, Melissa Wen wrote: > On 07/02, Daniel Vetter wrote: > > On Wed, Jul 01, 2020 at 03:31:34PM +, Sidong Yang wrote: > > > there is an error when igt test is run continuously. > > > vkms_atomic_commit_tail() > > > need to call

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-10 Thread Melissa Wen
On 07/02, Daniel Vetter wrote: > On Wed, Jul 01, 2020 at 03:31:34PM +, Sidong Yang wrote: > > there is an error when igt test is run continuously. > > vkms_atomic_commit_tail() > > need to call drm_atomic_helper_wait_for_vblanks() for give up ownership of > > vblank events. without this code,

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-02 Thread Daniel Vetter
On Wed, Jul 01, 2020 at 03:31:34PM +, Sidong Yang wrote: > there is an error when igt test is run continuously. vkms_atomic_commit_tail() > need to call drm_atomic_helper_wait_for_vblanks() for give up ownership of > vblank events. without this code, next atomic commit will not enable vblank >

[PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-01 Thread Sidong Yang
there is an error when igt test is run continuously. vkms_atomic_commit_tail() need to call drm_atomic_helper_wait_for_vblanks() for give up ownership of vblank events. without this code, next atomic commit will not enable vblank and raise timeout error. Signed-off-by: Sidong Yang ---