Re: [PATCH] drm/vkms: fix misuse of WARN_ON

2021-03-25 Thread Melissa Wen
On 03/25, Dmitry Vyukov wrote: > On Wed, Mar 24, 2021 at 11:00 PM Melissa Wen wrote: > > > > On 03/20, Dmitry Vyukov wrote: > > > vkms_vblank_simulate() uses WARN_ON for timing-dependent condition > > > (timer overrun). This is a mis-use of WARN_ON, WARN_ON must be used > > > to denote kernel

Re: [PATCH] drm/vkms: fix misuse of WARN_ON

2021-03-24 Thread Melissa Wen
On 03/20, Dmitry Vyukov wrote: > vkms_vblank_simulate() uses WARN_ON for timing-dependent condition > (timer overrun). This is a mis-use of WARN_ON, WARN_ON must be used > to denote kernel bugs. Use pr_warn() instead. > > Signed-off-by: Dmitry Vyukov > Reported-by:

[PATCH] drm/vkms: fix misuse of WARN_ON

2021-03-20 Thread Dmitry Vyukov
vkms_vblank_simulate() uses WARN_ON for timing-dependent condition (timer overrun). This is a mis-use of WARN_ON, WARN_ON must be used to denote kernel bugs. Use pr_warn() instead. Signed-off-by: Dmitry Vyukov Reported-by: syzbot+4fc21a003c8332eb0...@syzkaller.appspotmail.com Cc: Rodrigo