Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix missing mutex unlock on error path

2024-04-19 Thread Markus Elfring
… > Add a mutex unlock call. How do you think about a wording variant like the following? Extend the exception handling so that the missed mutex_unlock() call will be performed finally. Regards, Markus

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix missing mutex unlock on error path

2024-04-19 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 02:36:37PM +0300, Aleksandr Mishin wrote: > In cdns_mhdp_atomic_enable(), there is an error return on failure of > drm_mode_duplicate() which leads to the mutex remaining locked. > Add a mutex unlock call. > > Found by Linux Verification Center (linuxtesting.org) with

[PATCH] drm: bridge: cdns-mhdp8546: Fix missing mutex unlock on error path

2024-04-19 Thread Aleksandr Mishin
In cdns_mhdp_atomic_enable(), there is an error return on failure of drm_mode_duplicate() which leads to the mutex remaining locked. Add a mutex unlock call. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 935a92a1c400 ("drm: bridge: cdns-mhdp8546: Fix possible null