[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

> Every modesetting operation can happen in atomic context or not in > atomic context, thanks to the wonder of oops printing and also kgdb, > trying to figure out which table in this one person's bios is the > "root" cause and special casing for it is insane since tomorrow 20 > other BIOSes could

[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

2012/1/4 Alan Cox : >> > So lets stick to practice, and the real world. Screwing up everything >> > else because of a crappy problem in your Atom BIOS code sucks but hey it >> > happens. screwing up everything because of a theoretical concern is just >> > dumb. >> >> Thanks for the flowers, but

[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

On Mit, 2012-01-04 at 00:52 +, Alan Cox wrote: > On Tue, 03 Jan 2012 19:25:46 +0100 > Michel D?nzer wrote: > > On Die, 2012-01-03 at 18:09 +, Alan Cox wrote: > > > On Tue, 3 Jan 2012 19:04:00 +0100 > > > Michel D?nzer wrote: > > > > > > > From: Michel D?nzer > > > > > > > > It can

[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

On Die, 2012-01-03 at 21:04 +0100, Daniel Vetter wrote: > On Tue, Jan 03, 2012 at 07:16:25PM +0100, Michel D?nzer wrote: > > On Die, 2012-01-03 at 18:09 +, Dave Airlie wrote: > > > 2012/1/3 Michel D?nzer : > > > > From: Michel D?nzer > > > > > > > > It can be called from atomic context,

[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

> > So lets stick to practice, and the real world. Screwing up everything > > else because of a crappy problem in your Atom BIOS code sucks but hey it > > happens. screwing up everything because of a theoretical concern is just > > dumb. > > Thanks for the flowers, but it's not just a theoretical

[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

On Tue, 03 Jan 2012 19:25:46 +0100 Michel D?nzer wrote: > On Die, 2012-01-03 at 18:09 +, Alan Cox wrote: > > On Tue, 3 Jan 2012 19:04:00 +0100 > > Michel D?nzer wrote: > > > > > From: Michel D?nzer > > > > > > It can be called from atomic context, e.g. when switching to console for >

Re: [PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

So lets stick to practice, and the real world. Screwing up everything else because of a crappy problem in your Atom BIOS code sucks but hey it happens. screwing up everything because of a theoretical concern is just dumb. Thanks for the flowers, but it's not just a theoretical concern,

Re: [PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

2012/1/4 Alan Cox a...@lxorguk.ukuu.org.uk: So lets stick to practice, and the real world. Screwing up everything else because of a crappy problem in your Atom BIOS code sucks but hey it happens. screwing up everything because of a theoretical concern is just dumb. Thanks for the

Re: [PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

Every modesetting operation can happen in atomic context or not in atomic context, thanks to the wonder of oops printing and also kgdb, trying to figure out which table in this one person's bios is the root cause and special casing for it is insane since tomorrow 20 other BIOSes could contain

[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

On Tue, Jan 03, 2012 at 07:16:25PM +0100, Michel D?nzer wrote: > On Die, 2012-01-03 at 18:09 +, Dave Airlie wrote: > > 2012/1/3 Michel D?nzer : > > > From: Michel D?nzer > > > > > > It can be called from atomic context, e.g. when switching to console for > > > panic > > > output. > > > > >

[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

On Die, 2012-01-03 at 18:09 +, Alan Cox wrote: > On Tue, 3 Jan 2012 19:04:00 +0100 > Michel D?nzer wrote: > > > From: Michel D?nzer > > > > It can be called from atomic context, e.g. when switching to console for > > panic > > output. > > Is this only special cases like a panic - if so

[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

On Die, 2012-01-03 at 18:09 +, Dave Airlie wrote: > 2012/1/3 Michel D?nzer : > > From: Michel D?nzer > > > > It can be called from atomic context, e.g. when switching to console for > > panic > > output. > > > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43941 > > I wonder how

[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

From: Michel D?nzer It can be called from atomic context, e.g. when switching to console for panic output. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43941 Signed-off-by: Michel D?nzer --- drivers/gpu/drm/radeon/atom.c |2 +- 1 files changed, 1

[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

On Tue, 3 Jan 2012 19:04:00 +0100 Michel D?nzer wrote: > From: Michel D?nzer > > It can be called from atomic context, e.g. when switching to console for panic > output. Is this only special cases like a panic - if so can it not be called in a way that distinguishes between normality and

[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

2012/1/3 Michel D?nzer : > From: Michel D?nzer > > It can be called from atomic context, e.g. when switching to console for panic > output. > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43941 I wonder how ugly it would be to check for atomic context or not, mdelay is quite a long busy

[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

From: Michel Dänzer michel.daen...@amd.com It can be called from atomic context, e.g. when switching to console for panic output. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43941 Signed-off-by: Michel Dänzer michel.daen...@amd.com --- drivers/gpu/drm/radeon/atom.c |2 +- 1 files

Re: [PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

On Tue, 3 Jan 2012 19:04:00 +0100 Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer michel.daen...@amd.com It can be called from atomic context, e.g. when switching to console for panic output. Is this only special cases like a panic - if so can it not be called in a way that

Re: [PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

2012/1/3 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer michel.daen...@amd.com It can be called from atomic context, e.g. when switching to console for panic output. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=43941 I wonder how ugly it would be to check for atomic context or

Re: [PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

On Die, 2012-01-03 at 18:09 +, Dave Airlie wrote: 2012/1/3 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer michel.daen...@amd.com It can be called from atomic context, e.g. when switching to console for panic output. Fixes:

Re: [PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

On Tue, Jan 03, 2012 at 07:16:25PM +0100, Michel Dänzer wrote: On Die, 2012-01-03 at 18:09 +, Dave Airlie wrote: 2012/1/3 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer michel.daen...@amd.com It can be called from atomic context, e.g. when switching to console for panic

Re: [PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

On Tue, 03 Jan 2012 19:25:46 +0100 Michel Dänzer mic...@daenzer.net wrote: On Die, 2012-01-03 at 18:09 +, Alan Cox wrote: On Tue, 3 Jan 2012 19:04:00 +0100 Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer michel.daen...@amd.com It can be called from atomic