Re: [PATCH 04/25] drm/vkms: Annotate vblank timer

2020-07-14 Thread Daniel Vetter
On Tue, Jul 14, 2020 at 4:56 PM Melissa Wen wrote: > > Hi, > > On 07/14, Daniel Vetter wrote: > > On Tue, Jul 14, 2020 at 11:57 AM Melissa Wen wrote: > > > > > > On 07/12, Rodrigo Siqueira wrote: > > > > Hi, > > > > > > > > Everything looks fine to me, I just noticed that the amdgpu patches did

Re: [PATCH 04/25] drm/vkms: Annotate vblank timer

2020-07-14 Thread Melissa Wen
Hi, On 07/14, Daniel Vetter wrote: > On Tue, Jul 14, 2020 at 11:57 AM Melissa Wen wrote: > > > > On 07/12, Rodrigo Siqueira wrote: > > > Hi, > > > > > > Everything looks fine to me, I just noticed that the amdgpu patches did > > > not apply smoothly, however it was trivial to fix the issues. > >

Re: [PATCH 04/25] drm/vkms: Annotate vblank timer

2020-07-14 Thread Daniel Vetter
On Tue, Jul 14, 2020 at 11:57 AM Melissa Wen wrote: > > On 07/12, Rodrigo Siqueira wrote: > > Hi, > > > > Everything looks fine to me, I just noticed that the amdgpu patches did > > not apply smoothly, however it was trivial to fix the issues. > > > > Reviewed-by: Rodrigo Siqueira > > > >

Re: [PATCH 04/25] drm/vkms: Annotate vblank timer

2020-07-14 Thread Melissa Wen
On 07/12, Rodrigo Siqueira wrote: > Hi, > > Everything looks fine to me, I just noticed that the amdgpu patches did > not apply smoothly, however it was trivial to fix the issues. > > Reviewed-by: Rodrigo Siqueira > > Melissa, > Since you are using vkms regularly, could you test this patch and

Re: [PATCH 04/25] drm/vkms: Annotate vblank timer

2020-07-12 Thread Rodrigo Siqueira
Hi, Everything looks fine to me, I just noticed that the amdgpu patches did not apply smoothly, however it was trivial to fix the issues. Reviewed-by: Rodrigo Siqueira Melissa, Since you are using vkms regularly, could you test this patch and review it? Remember to add your Tested-by when you

[PATCH 04/25] drm/vkms: Annotate vblank timer

2020-07-07 Thread Daniel Vetter
This is needed to signal the fences from page flips, annotate it accordingly. We need to annotate entire timer callback since if we get stuck anywhere in there, then the timer stops, and hence fences stop. Just annotating the top part that does the vblank handling isn't enough. Cc: