Re: [PATCH 05/24] drm/vkms: Use devm_drm_dev_alloc

2020-09-08 Thread Melissa Wen
Hi Daniel, Thanks for this work. This change works smoothly to me. However, there is a check in the vkms_exit that doesn't look very good. Please, see inline comment. On 09/04, Daniel Vetter wrote: > This means we also need to slightly restructure the exit code, so that > final cleanup of the

[PATCH 05/24] drm/vkms: Use devm_drm_dev_alloc

2020-09-04 Thread Daniel Vetter
This means we also need to slightly restructure the exit code, so that final cleanup of the drm_device is triggered by unregistering the platform device. Note that devres is both clean up when the driver is unbound (not the case for vkms, we don't bind), and also when unregistering the device