Thanks for reviewing - sounds good - will fix those comments up as per your
recommendation.
On Fri, 2023-01-20 at 11:14 +0200, Jani Nikula wrote:
> On Thu, 19 Jan 2023, Alan Previn wrote:
> > The Driver-FLR flow may inadvertently exit early before the full
> > completion of the re-init of the
rg; dri-devel@lists.freedesktop.org; Teres Alexis,
> > Alan Previn ; Vivi, Rodrigo
> >
> > Subject: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
> >
> >
alan:snip..
> > + /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw
On Thu, 19 Jan 2023, Alan Previn wrote:
> The Driver-FLR flow may inadvertently exit early before the full
> completion of the re-init of the internal HW state if we only poll
> GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
> we need a two-step completion wait-for-completion flow
ect: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion
>
> The Driver-FLR flow may inadvertently exit early before the full completion
> of the re-init of the internal HW state if we only poll GU_DEBUG Bit31
> (polling
> for it to toggle from 0 -> 1
Forwarded offline. Let's hold off R-B or merging until I verify that hw spec
update is finalized to be exactly as what this patch is (probably a minor
delay).
On Thu, 2023-01-19 at 14:57 -0500, Vivi, Rodrigo wrote:
> On Thu, Jan 19, 2023 at 11:49:55AM -0800, Alan Previn wrote:
> > The
On Thu, Jan 19, 2023 at 11:49:55AM -0800, Alan Previn wrote:
> The Driver-FLR flow may inadvertently exit early before the full
> completion of the re-init of the internal HW state if we only poll
> GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
> we need a two-step completion
The Driver-FLR flow may inadvertently exit early before the full
completion of the re-init of the internal HW state if we only poll
GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
we need a two-step completion wait-for-completion flow that also
involves GU_CNTL. See the patch and
