Re: [PATCH 2/2] drm/msm/dp: Return IRQ_NONE for unhandled interrupts

2023-01-25 Thread Kuogee Hsieh
On 1/25/2023 10:21 AM, Doug Anderson wrote: Hi, On Wed, Jan 25, 2023 at 9:22 AM Kuogee Hsieh wrote: -void dp_ctrl_isr(struct dp_ctrl *dp_ctrl) +irqreturn_t dp_ctrl_isr(struct dp_ctrl *dp_ctrl) { struct dp_ctrl_private *ctrl; u32 isr; + irqreturn_t ret = IRQ_NONE;

Re: [PATCH 2/2] drm/msm/dp: Return IRQ_NONE for unhandled interrupts

2023-01-25 Thread Doug Anderson
Hi, On Wed, Jan 25, 2023 at 9:22 AM Kuogee Hsieh wrote: > > > -void dp_ctrl_isr(struct dp_ctrl *dp_ctrl) > > +irqreturn_t dp_ctrl_isr(struct dp_ctrl *dp_ctrl) > > { > > struct dp_ctrl_private *ctrl; > > u32 isr; > > + irqreturn_t ret = IRQ_NONE; > > > > if (!dp_ctrl) > >

Re: [PATCH 2/2] drm/msm/dp: Return IRQ_NONE for unhandled interrupts

2023-01-25 Thread Kuogee Hsieh
On 1/19/2023 2:53 PM, Douglas Anderson wrote: If our interrupt handler gets called and we don't really handle the interrupt then we should return IRQ_NONE. The current interrupt handler didn't do this, so let's fix it. NOTE: for some of the cases it's clear that we should return IRQ_NONE and

[PATCH 2/2] drm/msm/dp: Return IRQ_NONE for unhandled interrupts

2023-01-19 Thread Douglas Anderson
If our interrupt handler gets called and we don't really handle the interrupt then we should return IRQ_NONE. The current interrupt handler didn't do this, so let's fix it. NOTE: for some of the cases it's clear that we should return IRQ_NONE and some cases it's clear that we should return