Re: [PATCH 2/2] drm/rockchip: vop: Leave vblank enabled in self-refresh

2023-01-06 Thread Brian Norris
On Fri, Jan 06, 2023 at 12:42:54PM +0100, Michel Dänzer wrote: > On 1/6/23 02:40, Brian Norris wrote: > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > > @@ -719,11 +719,11 @@ static void vop_crtc_atomic_disable(struct drm_crtc > >

Re: [PATCH 2/2] drm/rockchip: vop: Leave vblank enabled in self-refresh

2023-01-06 Thread Michel Dänzer
On 1/6/23 02:40, Brian Norris wrote: > If we disable vblank when entering self-refresh, vblank APIs (like > DRM_IOCTL_WAIT_VBLANK) no longer work. But user space is not aware when > we enter self-refresh, so this appears to be an API violation -- that > DRM_IOCTL_WAIT_VBLANK fails with EINVAL

[PATCH 2/2] drm/rockchip: vop: Leave vblank enabled in self-refresh

2023-01-05 Thread Brian Norris
If we disable vblank when entering self-refresh, vblank APIs (like DRM_IOCTL_WAIT_VBLANK) no longer work. But user space is not aware when we enter self-refresh, so this appears to be an API violation -- that DRM_IOCTL_WAIT_VBLANK fails with EINVAL whenever the display is idle and enters