Re: [PATCH 2/3] drm/vkms: Switch to shmem helpers

2020-10-12 Thread Melissa Wen
Hi Daniel, Thanks for this patch. It took me a while to understand the update. I run some tests and it looks good to me. On 10/10, Daniel Vetter wrote: > Inspired by a patch by Chris Wilson for vgem. Plus this gives us vmap > at the gem bo level, which we need for generic fbdev emulation. > >

Re: [PATCH 2/3] drm/vkms: Switch to shmem helpers

2020-10-12 Thread Thomas Zimmermann
On Sat, 10 Oct 2020 01:21:55 +0200 Daniel Vetter wrote: > Inspired by a patch by Chris Wilson for vgem. Plus this gives us vmap > at the gem bo level, which we need for generic fbdev emulation. > > Luckily shmem also tracks ->vaddr, so we just need to adjust the code > all over a bit to make

Re: [PATCH 2/3] drm/vkms: Switch to shmem helpers

2020-10-12 Thread Thomas Zimmermann
On Mon, 12 Oct 2020 11:59:03 +0100 Chris Wilson wrote: > Quoting Daniel Vetter (2020-10-10 00:21:55) > > Inspired by a patch by Chris Wilson for vgem. Plus this gives us vmap > > at the gem bo level, which we need for generic fbdev emulation. > > > > Luckily shmem also tracks ->vaddr, so we

Re: [PATCH 2/3] drm/vkms: Switch to shmem helpers

2020-10-12 Thread Chris Wilson
Quoting Daniel Vetter (2020-10-10 00:21:55) > Inspired by a patch by Chris Wilson for vgem. Plus this gives us vmap > at the gem bo level, which we need for generic fbdev emulation. > > Luckily shmem also tracks ->vaddr, so we just need to adjust the code > all over a bit to make this fit. > >

[PATCH 2/3] drm/vkms: Switch to shmem helpers

2020-10-09 Thread Daniel Vetter
Inspired by a patch by Chris Wilson for vgem. Plus this gives us vmap at the gem bo level, which we need for generic fbdev emulation. Luckily shmem also tracks ->vaddr, so we just need to adjust the code all over a bit to make this fit. Also wire up handle_to_fd, dunno why that was missing.