Re: [PATCH 3/3] drm/i915/hwmon: Expose power1_max_enable

2023-02-16 Thread Rodrigo Vivi
On Thu, Feb 16, 2023 at 11:25:50AM -0800, Guenter Roeck wrote: > On 2/16/23 10:57, Rodrigo Vivi wrote: > > On Tue, Feb 14, 2023 at 07:11:16PM -0800, Dixit, Ashutosh wrote: > > > On Mon, 13 Feb 2023 22:16:44 -0800, Guenter Roeck wrote: > > > > > > > > > > Hi Guenter, > > > > > > > On 2/13/23

Re: [PATCH 3/3] drm/i915/hwmon: Expose power1_max_enable

2023-02-16 Thread Guenter Roeck
On 2/16/23 10:57, Rodrigo Vivi wrote: On Tue, Feb 14, 2023 at 07:11:16PM -0800, Dixit, Ashutosh wrote: On Mon, 13 Feb 2023 22:16:44 -0800, Guenter Roeck wrote: Hi Guenter, On 2/13/23 21:33, Ashutosh Dixit wrote: On ATSM the PL1 power limit is disabled at power up. The previous uapi

Re: [PATCH 3/3] drm/i915/hwmon: Expose power1_max_enable

2023-02-16 Thread Rodrigo Vivi
On Tue, Feb 14, 2023 at 07:11:16PM -0800, Dixit, Ashutosh wrote: > On Mon, 13 Feb 2023 22:16:44 -0800, Guenter Roeck wrote: > > > > Hi Guenter, > > > On 2/13/23 21:33, Ashutosh Dixit wrote: > > > On ATSM the PL1 power limit is disabled at power up. The previous uapi > > > assumed that the PL1

Re: [PATCH 3/3] drm/i915/hwmon: Expose power1_max_enable

2023-02-14 Thread Dixit, Ashutosh
On Mon, 13 Feb 2023 22:16:44 -0800, Guenter Roeck wrote: > Hi Guenter, > On 2/13/23 21:33, Ashutosh Dixit wrote: > > On ATSM the PL1 power limit is disabled at power up. The previous uapi > > assumed that the PL1 limit is always enabled and therefore did not have a > > notion of a disabled PL1

Re: [PATCH 3/3] drm/i915/hwmon: Expose power1_max_enable

2023-02-13 Thread Guenter Roeck
On 2/13/23 21:33, Ashutosh Dixit wrote: On ATSM the PL1 power limit is disabled at power up. The previous uapi assumed that the PL1 limit is always enabled and therefore did not have a notion of a disabled PL1 limit. This results in erroneous PL1 limit values when PL1 limit is disabled. For

[PATCH 3/3] drm/i915/hwmon: Expose power1_max_enable

2023-02-13 Thread Ashutosh Dixit
On ATSM the PL1 power limit is disabled at power up. The previous uapi assumed that the PL1 limit is always enabled and therefore did not have a notion of a disabled PL1 limit. This results in erroneous PL1 limit values when PL1 limit is disabled. For example at power up, the disabled ATSM PL1