Re: [PATCH 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-25 Thread Joel Selvaraj
Hi Linus Walleij On 19/05/22 14:39, Linus Walleij wrote: Nope. But add the rate limited error print please! Will do. Lots of magic numbers. You don't have a datasheet do you? So you could #define some of the magic? Unfortunately, I don't have a datasheet and the power on sequence is taken

Re: [PATCH 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-19 Thread Linus Walleij
On Mon, May 16, 2022 at 2:56 PM Joel Selvaraj wrote: > On 13/05/22 03:21, Linus Walleij wrote: > > On Fri, May 6, 2022 at 2:18 PM Joel Selvaraj wrote: > >> +#define dsi_dcs_write_seq(dsi, seq...) do {\ > >> + static const u8 d[] = { seq };

Re: [PATCH 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-16 Thread Joel Selvaraj
Hi Linus Walleij, On 13/05/22 03:21, Linus Walleij wrote: On Fri, May 6, 2022 at 2:18 PM Joel Selvaraj wrote: +#define dsi_dcs_write_seq(dsi, seq...) do {\ + static const u8 d[] = { seq }; \ + int ret;

Re: [PATCH 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-12 Thread Linus Walleij
On Fri, May 6, 2022 at 2:18 PM Joel Selvaraj wrote: > Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode > panel, which can be found on some Xiaomi Poco F1 phones. The panel's > backlight is managed through QCOM WLED driver. > > Signed-off-by: Joel Selvaraj Cool! > +#define

[PATCH 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-06 Thread Joel Selvaraj
Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The panel's backlight is managed through QCOM WLED driver. Signed-off-by: Joel Selvaraj --- MAINTAINERS | 7 +