Re: [PATCH 7/7] drm/mgag200: Split up connector's mode_valid helper

2022-05-16 Thread Thomas Zimmermann
Hi Am 12.05.22 um 12:38 schrieb Jocelyn Falempe: ... One suggestion to avoid too much repetition: static int mgag200_get_bandwidth_kbps(mdev) { if (IS_G200_SE(mdev)) {     u32 unique_rev_id = mdev->model.g200se.unique_rev_id;     if (unique_rev_id == 0x01) {    

Re: [PATCH 7/7] drm/mgag200: Split up connector's mode_valid helper

2022-05-12 Thread Thomas Zimmermann
Hi Am 12.05.22 um 12:38 schrieb Jocelyn Falempe: On 09/05/2022 12:35, Thomas Zimmermann wrote: Split up the connector's mode_valid helper into a simple-pipe and a mode-config helper. The simple-pipe helper tests for display-size limits while the mode-config helper tests for memory-bandwidth

Re: [PATCH 7/7] drm/mgag200: Split up connector's mode_valid helper

2022-05-12 Thread Jocelyn Falempe
On 09/05/2022 12:35, Thomas Zimmermann wrote: Split up the connector's mode_valid helper into a simple-pipe and a mode-config helper. The simple-pipe helper tests for display-size limits while the mode-config helper tests for memory-bandwidth limits. Also add the mgag200_ prefix to

[PATCH 7/7] drm/mgag200: Split up connector's mode_valid helper

2022-05-09 Thread Thomas Zimmermann
Split up the connector's mode_valid helper into a simple-pipe and a mode-config helper. The simple-pipe helper tests for display-size limits while the mode-config helper tests for memory-bandwidth limits. Also add the mgag200_ prefix to mga_vga_calculate_mode_bandwidth() and comment on the