Re: [PATCH v2] drm/vkms: add alpha-premultiplied color blending

2020-08-30 Thread Rodrigo Siqueira
Reviewed-by: Rodrigo Siqueira On 08/25, Melissa Wen wrote: > The VKMS blend function was ignoring the alpha channel and just > overwriting vaddr_src with vaddr_dst. This XRGB approach triggers a > warning when running the kms_cursor_crc/cursor-alpha-transparent test > case. In IGT,

[PATCH v2] drm/vkms: add alpha-premultiplied color blending

2020-08-25 Thread Melissa Wen
The VKMS blend function was ignoring the alpha channel and just overwriting vaddr_src with vaddr_dst. This XRGB approach triggers a warning when running the kms_cursor_crc/cursor-alpha-transparent test case. In IGT, cairo_format_argb32 uses premultiplied alpha (according to documentation). Also