Re: [PATCH v2 1/2] drm/atomic: Allow vblank-enabled + self-refresh "disable"

2023-01-07 Thread Daniel Vetter
On Fri, Jan 06, 2023 at 05:27:33PM -0800, Brian Norris wrote: > On Fri, Jan 6, 2023 at 5:23 PM Brian Norris wrote: > > v2: > > * add 'ret != 0' warning case for self-refresh > > * describe failing test case and relation to drm/rockchip patch better > > Ugh, there's always something you

Re: [PATCH v2 1/2] drm/atomic: Allow vblank-enabled + self-refresh "disable"

2023-01-06 Thread Brian Norris
On Fri, Jan 6, 2023 at 5:23 PM Brian Norris wrote: > v2: > * add 'ret != 0' warning case for self-refresh > * describe failing test case and relation to drm/rockchip patch better Ugh, there's always something you remember right after you hit send: I forgot to better summarize some of the other

[PATCH v2 1/2] drm/atomic: Allow vblank-enabled + self-refresh "disable"

2023-01-06 Thread Brian Norris
The self-refresh helper framework overloads "disable" to sometimes mean "go into self-refresh mode," and this mode activates automatically (e.g., after some period of unchanging display output). In such cases, the display pipe is still considered "on", and user-space is not aware that we went into