Re: [PATCH v3] staging: fbtft: core: set smem_len before fb_deferred_io_init call

2022-07-28 Thread Dan Carpenter
On Thu, Jul 28, 2022 at 12:49:15PM +, Liu, Chuansheng wrote: > Hi Peter, > > > > > The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before > > initializing info->fix.smem_len. It is set to zero by the > > framebuffer_alloc() function. It will trigger a WARN_ON() at the > > start

RE: [PATCH v3] staging: fbtft: core: set smem_len before fb_deferred_io_init call

2022-07-28 Thread Liu, Chuansheng
reedesktop.org; linux-fb...@vger.kernel.org; linux- > stag...@lists.linux.dev; linux-ker...@vger.kernel.org > Subject: [PATCH v3] staging: fbtft: core: set smem_len before > fb_deferred_io_init call > > The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before > initializ

[PATCH v3] staging: fbtft: core: set smem_len before fb_deferred_io_init call

2022-07-28 Thread Peter Suti
The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before initializing info->fix.smem_len. It is set to zero by the framebuffer_alloc() function. It will trigger a WARN_ON() at the start of fb_deferred_io_init() and the function will not do anything. Fixes: 856082f021a2 ("fbdev: defio: