Re: [PATCH v3 1/6] drm/i915: Fix request locking during error capture & debugfs dump

2023-01-21 Thread Andy Shevchenko
On Fri, Jan 20, 2023 at 03:06:02PM -0800, John Harrison wrote: > On 1/19/2023 07:16, Andy Shevchenko wrote: > > On Wed, Jan 18, 2023 at 10:49:55PM -0800, john.c.harri...@intel.com wrote: ... > > > + found = false; > > > + spin_lock(>guc_state.lock); > > >

Re: [PATCH v3 1/6] drm/i915: Fix request locking during error capture & debugfs dump

2023-01-20 Thread John Harrison
On 1/19/2023 07:16, Andy Shevchenko wrote: On Wed, Jan 18, 2023 at 10:49:55PM -0800, john.c.harri...@intel.com wrote: From: John Harrison When GuC support was added to error capture, the locking around the request object was broken. Fix it up. The context based search manages the spinlocking

Re: [PATCH v3 1/6] drm/i915: Fix request locking during error capture & debugfs dump

2023-01-19 Thread Ceraolo Spurio, Daniele
On 1/18/2023 10:49 PM, john.c.harri...@intel.com wrote: From: John Harrison When GuC support was added to error capture, the locking around the request object was broken. Fix it up. The context based search manages the spinlocking around the search internally. So it needs to grab the

Re: [PATCH v3 1/6] drm/i915: Fix request locking during error capture & debugfs dump

2023-01-19 Thread Andy Shevchenko
On Wed, Jan 18, 2023 at 10:49:55PM -0800, john.c.harri...@intel.com wrote: > From: John Harrison > > When GuC support was added to error capture, the locking around the > request object was broken. Fix it up. > > The context based search manages the spinlocking around the search > internally.

[PATCH v3 1/6] drm/i915: Fix request locking during error capture & debugfs dump

2023-01-18 Thread John . C . Harrison
From: John Harrison When GuC support was added to error capture, the locking around the request object was broken. Fix it up. The context based search manages the spinlocking around the search internally. So it needs to grab the reference count internally as well. The execlist only request