Re: [PATCH v5] drm/i915: Consolidate TLB invalidation flow

2023-02-17 Thread Tvrtko Ursulin
On 16/02/2023 15:41, Matt Roper wrote: On Thu, Feb 16, 2023 at 09:21:23AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin As the logic for selecting the register and corresponsing values grew, the code become a bit unsightly. Consolidate by storing the required values at engine init time

Re: [PATCH v5] drm/i915: Consolidate TLB invalidation flow

2023-02-16 Thread Matt Roper
On Thu, Feb 16, 2023 at 09:21:23AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > As the logic for selecting the register and corresponsing values grew, the > code become a bit unsightly. Consolidate by storing the required values at > engine init time in the engine itself, and by doing

[PATCH v5] drm/i915: Consolidate TLB invalidation flow

2023-02-16 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As the logic for selecting the register and corresponsing values grew, the code become a bit unsightly. Consolidate by storing the required values at engine init time in the engine itself, and by doing so minimise the amount of invariant platform and engine checks during