Re: [PATCH v6 22/23] drm/vc4: vec: Add support for more analog TV standards

2022-10-27 Thread Maxime Ripard
Hi, On Thu, Oct 27, 2022 at 12:32:50AM +0200, Mateusz Kwiatkowski wrote: > I've seen that you've incorporated my PAL60 patch. Thanks! > > I still yet need to test your v6 changes, but looking at this code with just > my > mental static analysis, it seems to me that the

Re: [PATCH v6 22/23] drm/vc4: vec: Add support for more analog TV standards

2022-10-26 Thread Mateusz Kwiatkowski
Hi Maxime, I've seen that you've incorporated my PAL60 patch. Thanks! I still yet need to test your v6 changes, but looking at this code with just my mental static analysis, it seems to me that the vc4_vec_encoder_atomic_check() should have the tv_mode validation. I should've added it to the

[PATCH v6 22/23] drm/vc4: vec: Add support for more analog TV standards

2022-10-26 Thread maxime
From: Mateusz Kwiatkowski Add support for the following composite output modes (all of them are somewhat more obscure than the previously defined ones): - NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to 4.43361875 MHz (the PAL subcarrier frequency). Never used for