Re: [RFC PATCH 1/3] drm/vkms: decouple cursor plane setup from crtc_init

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 10:42 AM Melissa Wen wrote: > > On 02/22, Daniel Vetter wrote: > > On Sat, Feb 20, 2021 at 11:38:50AM -0300, Melissa Wen wrote: > > > Initialize CRTC only with primary plane (without cursor) as a preparation > > > to init overlay plane before cursor plane and keep cursor

Re: [RFC PATCH 1/3] drm/vkms: decouple cursor plane setup from crtc_init

2021-02-23 Thread Melissa Wen
On 02/22, Daniel Vetter wrote: > On Sat, Feb 20, 2021 at 11:38:50AM -0300, Melissa Wen wrote: > > Initialize CRTC only with primary plane (without cursor) as a preparation > > to init overlay plane before cursor plane and keep cursor on the top. > > > > Signed-off-by: Melissa Wen > > Why can't

Re: [RFC PATCH 1/3] drm/vkms: decouple cursor plane setup from crtc_init

2021-02-22 Thread Daniel Vetter
On Sat, Feb 20, 2021 at 11:38:50AM -0300, Melissa Wen wrote: > Initialize CRTC only with primary plane (without cursor) as a preparation > to init overlay plane before cursor plane and keep cursor on the top. > > Signed-off-by: Melissa Wen Why can't we first initialize all the planes (primary,

[RFC PATCH 1/3] drm/vkms: decouple cursor plane setup from crtc_init

2021-02-20 Thread Melissa Wen
Initialize CRTC only with primary plane (without cursor) as a preparation to init overlay plane before cursor plane and keep cursor on the top. Signed-off-by: Melissa Wen --- drivers/gpu/drm/vkms/vkms_crtc.c | 4 ++-- drivers/gpu/drm/vkms/vkms_drv.h| 2 +-