Re: [PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
On 23.11.2023 09:19, Thomas Zimmermann wrote: > Hi > > Am 23.11.23 um 08:16 schrieb Heiner Kallweit: >> On 23.11.2023 07:56, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 20.11.23 um 22:46 schrieb Heiner Kallweit: After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in

Re: [PATCH v3 07/11] drm/mediatek: Support alpha blending in VDOSYS0

2023-11-23 Thread 胡俊光

Re: [PATCH] drm: mediatek: mtk_disp_gamma: Fix breakage due to merge issue

2023-11-23 Thread AngeloGioacchino Del Regno
Il 25/10/23 12:49, AngeloGioacchino Del Regno ha scritto: While the commit that was sent to the mailing lists was fine, something happened during merge and the mtk_gamma_set() function got broken as a writel() was turned into a readl(). Fix that by changing that back to the expected writel().

Re: [PATCH] phy: mediatek: mipi: mt8183: fix minimal supported frequency

2023-11-23 Thread AngeloGioacchino Del Regno
Il 23/11/23 12:02, Michael Walle ha scritto: The lowest supported clock frequency of the PHY is 125MHz (see also mtk_mipi_tx_pll_enable()), but the clamping in .round_rate() has the wrong minimal value, which will make the .enable() op return -EINVAL on low frequencies. Fix the minimal clamping

Re: [PATCH] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread AngeloGioacchino Del Regno
Il 23/11/23 12:15, AngeloGioacchino Del Regno ha scritto: Il 23/11/23 11:35, Boris Brezillon ha scritto: On Thu, 23 Nov 2023 10:53:20 +0100 AngeloGioacchino Del Regno wrote: Some SoCs may be equipped with a GPU containing two core groups and this is exactly the case of Samsung's Exynos 5422

Re: [PATCH v2] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread AngeloGioacchino Del Regno
Il 23/11/23 12:57, Krzysztof Kozlowski ha scritto: On 23/11/2023 12:50, AngeloGioacchino Del Regno wrote: Some SoCs may be equipped with a GPU containing two core groups and this is exactly the case of Samsung's Exynos 5422 featuring an ARM Mali-T628 MP6 GPU: the support for this GPU in

Re: [PATCH v2 1/4] i915: make inject_virtual_interrupt() void

2023-11-23 Thread Christian Brauner
> > + if (!vgpu->msi_trigger) > > + return; > > + eventfd_signal(vgpu->msi_trigger, 1); > > } > > I think it's a little simpler to write as > if (vgpu->msi_trigger) > eventfd_signal(vgpu->msi_trigger, 1); Good point. I folded that suggestion into the patch.

[PATCH] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread AngeloGioacchino Del Regno
Some SoCs may be equipped with a GPU containing two core groups and this is exactly the case of Samsung's Exynos 5422 featuring an ARM Mali-T628 MP6 GPU: the support for this GPU in Panfrost is partial, as this driver currently supports using only one core group and that's reflected on all parts

Re: [PATCH] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread Krzysztof Kozlowski
On 23/11/2023 10:53, AngeloGioacchino Del Regno wrote: > Some SoCs may be equipped with a GPU containing two core groups > and this is exactly the case of Samsung's Exynos 5422 featuring > an ARM Mali-T628 MP6 GPU: the support for this GPU in Panfrost > is partial, as this driver currently

Re: [PATCH v18 15/26] drm/panfrost: Explicitly get and put drm-shmem pages

2023-11-23 Thread Dmitry Osipenko
On 11/23/23 12:05, Boris Brezillon wrote: > On Thu, 23 Nov 2023 01:04:56 +0300 > Dmitry Osipenko wrote: > >> On 11/10/23 13:53, Boris Brezillon wrote: >>> Hm, there was no drm_gem_shmem_get_pages_sgt() call here, why should we >>> add a drm_gem_shmem_get_pages()? What we should do instead is add

Re: [PATCH v1 3/4] drm/rockchip: rk3066_hdmi: Remove useless output format

2023-11-23 Thread Johan Jonker
On 11/20/23 18:06, Heiko Stuebner wrote: > Hi Johan, > > Am Donnerstag, 2. November 2023, 14:42:19 CET schrieb Johan Jonker: >> The Rk3066 hdmi output format is hard coded to RGB. Remove >> all useless code related to colorimetry and enc_out_format. >> >> Signed-off-by: Johan Jonker > > I

Re: [PATCH v2 2/4] eventfd: simplify eventfd_signal()

2023-11-23 Thread Christian Brauner
> > * eventfd_signal - Adds @n to the eventfd counter. > > This still refers to @n here, and in patch 4. Fixed and folded. Thanks!

Re: [PATCH] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread AngeloGioacchino Del Regno
Il 23/11/23 13:59, Boris Brezillon ha scritto: On Thu, 23 Nov 2023 12:15:01 +0100 AngeloGioacchino Del Regno wrote: Il 23/11/23 11:35, Boris Brezillon ha scritto: On Thu, 23 Nov 2023 10:53:20 +0100 AngeloGioacchino Del Regno wrote: Some SoCs may be equipped with a GPU containing two

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-23 Thread Neil Armstrong
On 23/11/2023 09:08, Dmitry Baryshkov wrote: On Thu, 23 Nov 2023 at 07:05, Sui Jingfeng wrote: Hi, On 2023/11/16 19:19, Dmitry Baryshkov wrote: On Thu, 16 Nov 2023 at 12:13, Sui Jingfeng wrote: Hi, On 2023/11/16 17:30, Dmitry Baryshkov wrote: On Thu, 16 Nov 2023 at 11:14, Sui Jingfeng

Re: [PATCH v9 00/20] Imagination Technologies PowerVR DRM driver

2023-11-23 Thread H. Nikolaus Schaller
> Am 22.11.2023 um 20:34 schrieb Maxime Ripard : > > Hi, > > On Wed, Nov 22, 2023 at 04:34:21PM +, Donald Robson wrote: >> This patch series adds the initial DRM driver for Imagination Technologies >> PowerVR >> GPUs, starting with those based on our Rogue architecture. It's worth >>

Re: [PATCH v3 101/108] drm/bridge: ti-sn65dsi86: Make use of devm_pwmchip_alloc() function

2023-11-23 Thread Laurent Pinchart
Hi Uwe, (CC'ing Bartosz) Thank you for the patch. On Tue, Nov 21, 2023 at 02:50:43PM +0100, Uwe Kleine-König wrote: > This prepares the pwm driver of the ti-sn65dsi86 to further changes of > the pwm core outlined in the commit introducing devm_pwmchip_alloc(). > There is no intended semantical

[PATCH] drm/sched: Fix bounds limiting when given a malformed entity

2023-11-23 Thread Luben Tuikov
If we're given a malformed entity in drm_sched_entity_init()--shouldn't happen, but we verify--with out-of-bounds priority value, we set it to an allowed value. Fix the expression which sets this limit. Signed-off-by: Luben Tuikov Fixes: 56e449603f0ac5 ("drm/sched: Convert the GPU scheduler to

Re: [PATCH v3] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread AngeloGioacchino Del Regno
Il 23/11/23 14:13, Boris Brezillon ha scritto: On Thu, 23 Nov 2023 13:05:21 +0100 AngeloGioacchino Del Regno wrote: Some SoCs may be equipped with a GPU containing two core groups and this is exactly the case of Samsung's Exynos 5422 featuring an ARM Mali-T628 MP6 GPU: the support for this

[PATCH v3] drm/mediatek: Stop using iommu_present()

2023-11-23 Thread Robin Murphy
Remove the pointless check. If an IOMMU is providing transparent DMA API ops for any device(s) we care about, the DT code will have enforced the appropriate probe ordering already. And if the IOMMU *is* entirely absent, then attempting to go ahead with CMA and either suceeding or failing

Re: [PATCH v2] drm/amdgpu: Fix cat debugfs amdgpu_regs_didt causes kernel null pointer

2023-11-23 Thread Christian König
Am 23.11.23 um 02:22 schrieb Lu Yao: For 'AMDGPU_FAMILY_SI' family cards, in 'si_common_early_init' func, init 'didt_rreg' and 'didt_wreg' to 'NULL'. But in func 'amdgpu_debugfs_regs_didt_read/write', using 'RREG32_DIDT' 'WREG32_DIDT' lacks of relevant judgment. And other

Re: [PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-23 Thread Thomas Zimmermann
Hi Am 23.11.23 um 09:34 schrieb Heiner Kallweit: On 23.11.2023 09:19, Thomas Zimmermann wrote: Hi Am 23.11.23 um 08:16 schrieb Heiner Kallweit: On 23.11.2023 07:56, Thomas Zimmermann wrote: Hi Am 20.11.23 um 22:46 schrieb Heiner Kallweit: After removal of the legacy EEPROM driver and

Re: [PATCH v18 15/26] drm/panfrost: Explicitly get and put drm-shmem pages

2023-11-23 Thread Boris Brezillon
On Thu, 23 Nov 2023 01:04:56 +0300 Dmitry Osipenko wrote: > On 11/10/23 13:53, Boris Brezillon wrote: > > Hm, there was no drm_gem_shmem_get_pages_sgt() call here, why should we > > add a drm_gem_shmem_get_pages()? What we should do instead is add a > > drm_gem_shmem_get_pages() for each

[PATCH v5 19/20] drivers/gpu/drm/display: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 18/20] drivers/gpu/drm/gma500: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 10/20] drivers/video/fbdev/cyber2000fb.c: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 05/20] drivers/video/fbdev: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 17/20] drivers/gpu/drm/ast/ast_i2c.c: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 00/20] remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 03/20] drm/amd/display: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 06/20] drivers/video/fbdev/core/fb_ddc.c: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PULL] drm-misc-fixes

2023-11-23 Thread Maarten Lankhorst
Hi Dave, Daniel, Lots of small fixes for various drivers. Cheers, ~Maarten drm-misc-fixes-2023-11-23: Fixes for v6.7-rc3: - Panel fixes for innolux and auo,b101uan08.3 panel. - Fix ivpu MMIO reset. - AST fix on connetor disconnection. - nouveau gsp fix. - rockchip color fix. - Fix

Re: [PATCH 5/8] drm/bridge: it66121: Add a helper function to read chip id

2023-11-23 Thread Sui Jingfeng
Hi, On 2023/11/23 15:48, Dmitry Baryshkov wrote: On Thu, 23 Nov 2023 at 07:37, Sui Jingfeng wrote: Hi, On 2023/11/16 21:00, Dmitry Baryshkov wrote: On Thu, 16 Nov 2023 at 14:18, Sui Jingfeng wrote: Hi, On 2023/11/15 00:06, Dmitry Baryshkov wrote: On Tue, 14 Nov 2023 at 17:09, Sui

Re: [RFC PATCH] of/platform: Disable sysfb if a simple-framebuffer node is found

2023-11-23 Thread Thomas Zimmermann
Hi Am 18.11.23 um 12:10 schrieb Javier Martinez Canillas: Ard Biesheuvel writes: Hello Ard, On Fri, 17 Nov 2023 at 00:09, Rob Herring wrote: [...] This could also lead to an interesting scenario. As simple-framebuffer can define its memory in a /reserved-memory node, but that is

[PATCH 2/2] drm/panel-simple: add Evervision VGG644804 panel entry

2023-11-23 Thread Michael Walle
Timings taken from the datasheet, although sometimes there are just typical values and it's not clear if they are no min and max values or if you must use the typical value exactly. To make things worse, there is no back porch but only a combined sync and back porch length. Unfortunately, there

[PATCH 1/2] dt-bindings: display: simple: add Evervision VGG644804 panel

2023-11-23 Thread Michael Walle
Add Evervision VGG644804 5.7" 640x480 LVDS panel compatible string. Signed-off-by: Michael Walle --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml

Re: [PATCH] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread AngeloGioacchino Del Regno
Il 23/11/23 11:39, Krzysztof Kozlowski ha scritto: On 23/11/2023 10:53, AngeloGioacchino Del Regno wrote: Some SoCs may be equipped with a GPU containing two core groups and this is exactly the case of Samsung's Exynos 5422 featuring an ARM Mali-T628 MP6 GPU: the support for this GPU in

[PATCH v2] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread AngeloGioacchino Del Regno
Some SoCs may be equipped with a GPU containing two core groups and this is exactly the case of Samsung's Exynos 5422 featuring an ARM Mali-T628 MP6 GPU: the support for this GPU in Panfrost is partial, as this driver currently supports using only one core group and that's reflected on all parts

Re: [PATCH v18 22/26] drm/shmem-helper: Don't free refcounted GEM

2023-11-23 Thread Dmitry Osipenko
On 11/23/23 12:08, Boris Brezillon wrote: > On Thu, 23 Nov 2023 01:30:24 +0300 > Dmitry Osipenko wrote: > >> On 11/13/23 12:54, Boris Brezillon wrote: >>> On Mon, 30 Oct 2023 02:02:01 +0300 >>> Dmitry Osipenko wrote: >>> Don't free refcounted shmem object to prevent use-after-free bug

Re: [PATCH v3 101/108] drm/bridge: ti-sn65dsi86: Make use of devm_pwmchip_alloc() function

2023-11-23 Thread Uwe Kleine-König
Hello Doug, hello Bjorn, On Tue, Nov 21, 2023 at 08:14:14AM -0800, Doug Anderson wrote: > On Tue, Nov 21, 2023 at 8:05 AM Uwe Kleine-König > wrote: > > On Tue, Nov 21, 2023 at 07:15:51AM -0800, Doug Anderson wrote: > > > > @@ -1585,22 +1586,28 @@ static const struct pwm_ops ti_sn_pwm_ops = { > >

[PATCH v5 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH v5 09/20] drivers/video/fbdev/via/via_i2c.c: remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[PATCH] drm/i915/display: Fix null pointer dereference in intel_dp_aux_wait_done and intel_dp_aux_xfer

2023-11-23 Thread Kunwu Chan
kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. When "intel_dp->aux.name" is NULL, these error messages will trigger the null pointer dereference issue. Signed-off-by: Kunwu Chan --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 12 ++-- 1

Is there a potential race condition when drm resume?

2023-11-23 Thread Andy Yan
From: Andy Yan Hi: I get a use-after-free KASAN report on a psr enabled system as bellow: It seems there is a race happens like this: task 6074: userspace suspend_devices_and_enter+0xa20/0xba0

Re: [PATCH] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread Boris Brezillon
On Thu, 23 Nov 2023 10:53:20 +0100 AngeloGioacchino Del Regno wrote: > Some SoCs may be equipped with a GPU containing two core groups > and this is exactly the case of Samsung's Exynos 5422 featuring > an ARM Mali-T628 MP6 GPU: the support for this GPU in Panfrost > is partial, as this driver

Re: [PATCH] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread AngeloGioacchino Del Regno
Il 23/11/23 11:35, Boris Brezillon ha scritto: On Thu, 23 Nov 2023 10:53:20 +0100 AngeloGioacchino Del Regno wrote: Some SoCs may be equipped with a GPU containing two core groups and this is exactly the case of Samsung's Exynos 5422 featuring an ARM Mali-T628 MP6 GPU: the support for this

Re: [PATCH] drm/msm/gpu: Fix null-pointer dereference in zap_shader_load_mdt

2023-11-23 Thread Konrad Dybcio
On 11/23/23 04:33, Kunwu Chan wrote: kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Ensure the allocation was successful by checking the pointer validity. Fixes: a9e2559c931d ("drm/msm/gpu: Move zap shader loading to adreno") Signed-off-by:

Re: [PATCH v2] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread Krzysztof Kozlowski
On 23/11/2023 12:50, AngeloGioacchino Del Regno wrote: > Some SoCs may be equipped with a GPU containing two core groups > and this is exactly the case of Samsung's Exynos 5422 featuring > an ARM Mali-T628 MP6 GPU: the support for this GPU in Panfrost > is partial, as this driver currently

[PULL] drm-misc-next

2023-11-23 Thread Maxime Ripard
Hi, Here's this week drm-misc-next PR. It's been fairly calm, but there's one big change: the IMG GPU driver is now merged! Maxime drm-misc-next-2023-11-23: drm-misc-next for 6.8: UAPI Changes: Cross-subsystem Changes: Core Changes: - Drop deprecated drm_kms_helper.edid_firmware module

Re: [PATCH] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread Boris Brezillon
On Thu, 23 Nov 2023 12:15:01 +0100 AngeloGioacchino Del Regno wrote: > Il 23/11/23 11:35, Boris Brezillon ha scritto: > > On Thu, 23 Nov 2023 10:53:20 +0100 > > AngeloGioacchino Del Regno > > wrote: > > > >> Some SoCs may be equipped with a GPU containing two core groups > >> and this is

[PATCH 4/4] drm/mediatek: support the DSI0 output on the MT8195 VDOSYS0

2023-11-23 Thread Michael Walle
With the latest dynamic selection of the output component, we can now support different outputs. Move current output component into the dynamic routes array and add the new DSI0 output. Signed-off-by: Michael Walle --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +++- 1 file changed, 7

[PATCH 2/4] dt-bindings: phy: add compatible for Mediatek MT8195

2023-11-23 Thread Michael Walle
Add the compatible string for MediaTek MT8195 SoC, using the same MIPI D-PHY block as the MT8183. Signed-off-by: Michael Walle --- Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/4] dt-bindings: display: mediatek: dsi: add compatible for MediaTek MT8195

2023-11-23 Thread Michael Walle
Add the compatible string for MediaTek MT8195 SoC, using the same DSI block as the MT8183. Signed-off-by: Michael Walle --- .../devicetree/bindings/display/mediatek/mediatek,dsi.yaml| 4 1 file changed, 4 insertions(+) diff --git

[PATCH 3/4] arm64: dts: mediatek: mt8195: add DSI and MIPI DPHY nodes

2023-11-23 Thread Michael Walle
Add the two DSI controller node and the associated DPHY nodes. Individual boards have to enable them in the board device tree. Signed-off-by: Michael Walle --- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 48 1 file changed, 48 insertions(+) diff --git

[PATCH 0/4] drm/mediatek: support DSI output on MT8195

2023-11-23 Thread Michael Walle
Add support for a DSI output on VDOSYS0. Luckily, there is a new feature to support dynamic selections of the output (connector). Use it to add support for a DSI output. Apart from that, this is pretty straghtforward by just adding new compatibles and add the correct DSI nodes to the SoC dtsi.

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-23 Thread Dmitry Baryshkov
On Thu, 23 Nov 2023 at 07:05, Sui Jingfeng wrote: > > Hi, > > > On 2023/11/16 19:19, Dmitry Baryshkov wrote: > > On Thu, 16 Nov 2023 at 12:13, Sui Jingfeng wrote: > >> Hi, > >> > >> > >> On 2023/11/16 17:30, Dmitry Baryshkov wrote: > >>> On Thu, 16 Nov 2023 at 11:14, Sui Jingfeng wrote: >

[PATCH] drm/amd/pm: fix a memleak in aldebaran_tables_init

2023-11-23 Thread Dinghao Liu
When kzalloc() for smu_table->ecc_table fails, we should free the previously allocated resources to prevent memleak. Fixes: edd794208555 ("drm/amd/pm: add message smu to get ecc_table v2") Signed-off-by: Dinghao Liu --- drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 5 - 1 file

Re: [PATCH v18 22/26] drm/shmem-helper: Don't free refcounted GEM

2023-11-23 Thread Boris Brezillon
On Thu, 23 Nov 2023 01:30:24 +0300 Dmitry Osipenko wrote: > On 11/13/23 12:54, Boris Brezillon wrote: > > On Mon, 30 Oct 2023 02:02:01 +0300 > > Dmitry Osipenko wrote: > > > >> Don't free refcounted shmem object to prevent use-after-free bug that > >> is worse than a memory leak. > >> > >>

Re: [PATCH v3 101/108] drm/bridge: ti-sn65dsi86: Make use of devm_pwmchip_alloc() function

2023-11-23 Thread Uwe Kleine-König
Hello Laurent, On Thu, Nov 23, 2023 at 11:46:52AM +0200, Laurent Pinchart wrote: > (CC'ing Bartosz) I'm already in discussion with Bart :-) > On Tue, Nov 21, 2023 at 02:50:43PM +0100, Uwe Kleine-König wrote: > > This prepares the pwm driver of the ti-sn65dsi86 to further changes of > > the pwm

[PATCH v3] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread AngeloGioacchino Del Regno
Some SoCs may be equipped with a GPU containing two core groups and this is exactly the case of Samsung's Exynos 5422 featuring an ARM Mali-T628 MP6 GPU: the support for this GPU in Panfrost is partial, as this driver currently supports using only one core group and that's reflected on all parts

Re: [PATCH v3] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread Krzysztof Kozlowski
On 23/11/2023 13:05, AngeloGioacchino Del Regno wrote: > Some SoCs may be equipped with a GPU containing two core groups > and this is exactly the case of Samsung's Exynos 5422 featuring > an ARM Mali-T628 MP6 GPU: the support for this GPU in Panfrost > is partial, as this driver currently

Re: [RFC v4 1/5] drm/netlink: Add netlink infrastructure

2023-11-23 Thread Tomer Tayar
On 22/11/2023 16:32, Aravind Iddamsetty wrote: > On 11/10/23 17:54, Tomer Tayar wrote: >> On 20/10/2023 18:58, Aravind Iddamsetty wrote: >>> Define the netlink registration interface and commands, attributes that >>> can be commonly used across by drm drivers. This patch intends to use >>> the

[PATCH] phy: mediatek: mipi: mt8183: fix minimal supported frequency

2023-11-23 Thread Michael Walle
The lowest supported clock frequency of the PHY is 125MHz (see also mtk_mipi_tx_pll_enable()), but the clamping in .round_rate() has the wrong minimal value, which will make the .enable() op return -EINVAL on low frequencies. Fix the minimal clamping value. Fixes: efda51a58b4a ("drm/mediatek: add

Re: [PATCH v3] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread Boris Brezillon
On Thu, 23 Nov 2023 13:05:21 +0100 AngeloGioacchino Del Regno wrote: > Some SoCs may be equipped with a GPU containing two core groups > and this is exactly the case of Samsung's Exynos 5422 featuring > an ARM Mali-T628 MP6 GPU: the support for this GPU in Panfrost > is partial, as this driver

Re: [PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-23 Thread Thomas Zimmermann
Hi Am 23.11.23 um 08:16 schrieb Heiner Kallweit: On 23.11.2023 07:56, Thomas Zimmermann wrote: Hi Am 20.11.23 um 22:46 schrieb Heiner Kallweit: After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.

[PATCH v4] drm/test: add a test suite for GEM objects backed by shmem

2023-11-23 Thread Marco Pagani
This patch introduces an initial KUnit test suite for GEM objects backed by shmem buffers. Suggested-by: Javier Martinez Canillas Signed-off-by: Marco Pagani v4: - Add missing MMU dependency for DRM_GEM_SHMEM_HELPER (kernel test robot) v3: - Explicitly cast pointers in the helpers - Removed

Re: [Intel-gfx] [PATCH v5 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

2023-11-23 Thread Andi Shyti
Hi Heiner, On Thu, Nov 23, 2023 at 10:40:35AM +0100, Heiner Kallweit wrote: > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. > Class-based device auto-detection is a legacy mechanism and shouldn't > be

Re: [PATCH] drm/i915/display: Fix null pointer dereference in intel_dp_aux_wait_done and intel_dp_aux_xfer

2023-11-23 Thread Ville Syrjälä
On Thu, Nov 23, 2023 at 06:04:31PM +0800, Kunwu Chan wrote: > kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. When "intel_dp->aux.name" is NULL, > these error messages will trigger the null pointer dereference issue. How did you reach that

Re: [PATCH v3] drm/panfrost: Ignore core_mask for poweroff and sync interrupts

2023-11-23 Thread AngeloGioacchino Del Regno
Il 23/11/23 13:43, Krzysztof Kozlowski ha scritto: On 23/11/2023 13:05, AngeloGioacchino Del Regno wrote: Some SoCs may be equipped with a GPU containing two core groups and this is exactly the case of Samsung's Exynos 5422 featuring an ARM Mali-T628 MP6 GPU: the support for this GPU in

[PATCH 0/2] Make scheduling of the same index, the same

2023-11-23 Thread Luben Tuikov
The first patch renames priority MIN to LOW. The second patch makes the "priority" of the same run-queue index in any two schedulers, the same. This series sits on top on this fix https://patchwork.freedesktop.org/patch/568723/ which I sent yesterday. Luben Tuikov (2): drm/sched: Rename

[PATCH 2/2] drm/sched: Reverse run-queue priority enumeration

2023-11-23 Thread Luben Tuikov
Reverse run-queue priority enumeration such that the higest priority is now 0, and for each consecutive integer the prioirty diminishes. Run-queues correspond to priorities. To an external observer a scheduler created with a single run-queue, and another created with DRM_SCHED_PRIORITY_COUNT

[PATCH 1/2] drm/sched: Rename priority MIN to LOW

2023-11-23 Thread Luben Tuikov
Rename DRM_SCHED_PRIORITY_MIN to DRM_SCHED_PRIORITY_LOW. This mirrors DRM_SCHED_PRIORITY_HIGH, for a list of DRM scheduler priorities in ascending order, DRM_SCHED_PRIORITY_LOW, DRM_SCHED_PRIORITY_NORMAL, DRM_SCHED_PRIORITY_HIGH, DRM_SCHED_PRIORITY_KERNEL. Cc: Rob Clark Cc: Abhinav

Re: [PATCH v5 9/9] drm: ci: Update xfails

2023-11-23 Thread Vignesh Raman
Hi Daniel, On 19/10/23 13:55, Daniel Stone wrote: By the time we get this error, it indicates that there was previously memory corruption, but it is only being noticed at a later point. The skip lists here are way too big - stuff like drm_read is common testing not affected by virtio at all -

[PATCH v2 00/17] drm/v3d: Introduce CPU jobs

2023-11-23 Thread Maíra Canal
This patchset implements the basic infrastructure for a new type of V3D job, a CPU job. A CPU job is a job that requires CPU intervention. It would be nice to perform this operations on the kernel space as we can attach multiple in/out syncobjs to it. Why we want a CPU job on the kernel?

[PATCH v2 03/17] drm/v3d: Detach job submissions IOCTLs to a new specific file

2023-11-23 Thread Maíra Canal
From: Melissa Wen We will include a new job submission type, the CPU job submission. For readability and maintability, separate the job submission IOCTLs and related operations from v3d_gem.c. Minor fix in the CSD submission kernel doc: CSD (texture formatting) -> CSD (compute shader).

[PATCH v2 06/17] drm/v3d: Decouple job allocation from job initiation

2023-11-23 Thread Maíra Canal
We want to allow the IOCTLs to allocate the job without initiating it. This will be useful for the CPU job submission IOCTL, as the CPU job has the need to use information from the user extensions. Currently, the user extensions are parsed before the job allocation, making it impossible to fill

[PATCH v2 05/17] drm/v3d: Don't allow two multisync extensions in the same job

2023-11-23 Thread Maíra Canal
Currently, two multisync extensions can be added to the same job and only the last multisync extension will be used. To avoid this vulnerability, don't allow two multisync extensions in the same job. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_submit.c | 5 + 1 file changed, 5

[PATCH v2 12/17] drm/v3d: Create a CPU job extension for a indirect CSD job

2023-11-23 Thread Maíra Canal
A CPU job is a type of job that performs operations that requires CPU intervention. An indirect CSD job is a job that, when executed in the queue, will map the indirect buffer, read the dispatch parameters, and submit a regular dispatch. Therefore, it is a job that needs CPU intervention. So,

[PATCH v2 14/17] drm/v3d: Create a CPU job extension for the reset timestamp job

2023-11-23 Thread Maíra Canal
A CPU job is a type of job that performs operations that requires CPU intervention. A reset timestamp job is a job that resets the timestamp queries based on the value offset of the first query. As V3D doesn't provide any mechanism to obtain a timestamp from the GPU, it is a job that needs CPU

[PATCH v2 07/17] drm/v3d: Add a CPU job submission

2023-11-23 Thread Maíra Canal
From: Melissa Wen Create a new type of job, a CPU job. A CPU job is a type of job that performs operations that requires CPU intervention. The overall idea is to use user extensions to enable different types of CPU job, allowing the CPU job to perform different operations according to the type

[PATCH v2 08/17] drm/v3d: Use v3d_get_extensions() to parse CPU job data

2023-11-23 Thread Maíra Canal
Currently, v3d_get_extensions() only parses multisync data and assigns it to the `struct v3d_submit_ext`. But, to implement the CPU job with user extensions, we want v3d_get_extensions() to be able to parse CPU job data and assign it to the `struct v3d_cpu_job`. Therefore, allow the function

[PATCH v2 04/17] drm/v3d: Simplify job refcount handling

2023-11-23 Thread Maíra Canal
From: Melissa Wen Instead of checking if the job is NULL every time we call the function, check it inside the function. Signed-off-by: Melissa Wen Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_submit.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git

[PATCH v2 02/17] drm/v3d: Move wait BO ioctl to the v3d_bo file

2023-11-23 Thread Maíra Canal
From: Melissa Wen IOCTLs related to BO operations reside on the file v3d_bo.c. The wait BO ioctl is the only IOCTL regarding BOs that is placed in a different file. So, move it to the v3d_bo.c file. Signed-off-by: Melissa Wen Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_bo.c | 33

[PATCH v2 13/17] drm/v3d: Create a CPU job extension for the timestamp query job

2023-11-23 Thread Maíra Canal
A CPU job is a type of job that performs operations that requires CPU intervention. A timestamp query job is a job that calculates the query timestamp and updates the query availability by signaling a syncobj. As V3D doesn't provide any mechanism to obtain a timestamp from the GPU, it is a job

[PATCH v2 09/17] drm/v3d: Create tracepoints to track the CPU job

2023-11-23 Thread Maíra Canal
Create tracepoints to track the three major events of a CPU job lifetime: 1. Submission of a `v3d_submit_cpu` IOCTL 2. Beginning of the execution of a CPU job 3. Ending of the execution of a CPU job Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_sched.c | 4 +++

[PATCH v2 10/17] drm/v3d: Detach the CSD job BO setup

2023-11-23 Thread Maíra Canal
From: Melissa Wen Detach CSD job setup from CSD submission ioctl to reuse it in CPU submission ioctl for indirect CSD job. Signed-off-by: Melissa Wen Co-developed-by: Maíra Canal Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_submit.c | 52 +--- 1 file

[PATCH v2 11/17] drm/v3d: Enable BO mapping

2023-11-23 Thread Maíra Canal
For the indirect CSD CPU job, we will need to access the internal contents of the BO with the dispatch parameters. Therefore, create methods to allow the mapping and unmapping of the BO. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_bo.c | 18 ++

[PATCH RESEND 1/3] drm/stm: dsi: add pm runtime ops

2023-11-23 Thread Raphael Gallais-Pou
From: Yannick Fertre Update control of clocks and supply thanks to the PM runtime mechanism to avoid kernel crash during a system suspend. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 28 +++ 1 file changed, 20 insertions(+), 8 deletions(-)

[PATCH RESEND 3/3] arm: dts: st: fix DSI peripheral clock on stm32mp15 boards

2023-11-23 Thread Raphael Gallais-Pou
In RCC driver, 'DSI_K' is a kernel clock while 'DSI' has pclk4 as parent clock, which means that it is an APB peripheral clock. Swap the clocks in the DSI peripheral clock reference. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/st/stm32mp157.dtsi | 2 +-

[PATCH RESEND 2/3] drm/stm: dsi: expose DSI PHY internal clock

2023-11-23 Thread Raphael Gallais-Pou
DSISRC __ __\_ |\ pll4_p_ck ->| 1 |dsi_k ck_dsi_phy ->| 0 | |/ A DSI clock is missing in the clock framework. Looking at the clk_summary, it appears that 'ck_dsi_phy' is not

[PATCH RESEND 0/3] Update STM DSI PHY driver

2023-11-23 Thread Raphael Gallais-Pou
This patch series aims to add several features of the dw-mipi-dsi phy driver that are missing or need to be updated. First patch adds runtime PM functionality to the driver. Second patch adds a clock provider generated by the PHY itself. As explained in the commit log of the second patch, a

  1   2   >