Some unit tests intentionally trigger warning backtraces by passing bad
parameters to kernel API functions. Such unit tests typically check the
return value from such calls, not the existence of the warning backtrace.
Such intentionally generated warning backtraces are neither desirable
nor
Some unit tests intentionally trigger warning backtraces by passing
bad parameters to API functions. Such unit tests typically check the
return value from those calls, not the existence of the warning backtrace.
Such intentionally generated warning backtraces are neither desirable
nor useful for
The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests
intentionally trigger warning backtraces by providing bad parameters to
the tested functions. What is tested is the return value, not the existence
of a warning backtrace. Suppress the backtraces to avoid clogging the
kernel
Add support for selectively suppressing WARNING tracebacks to x86.
This requires adding the function triggering tracebacks to the __bug_table
object section.
To limit image size impact, the pointer to the function name is only added
to the __bug_table section if both CONFIG_KUNIT and
Add support for selectively suppressing WARNING tracebacks to loongarch.
This requires adding the function triggering tracebacks to the __bug_table
object section.
To limit image size impact, the pointer to the function name is only added
to the __bug_table section if both CONFIG_KUNIT and
Add support for selectively suppressing WARNING tracebacks to arm64.
This requires adding the function triggering tracebacks to the __bug_table
object section.
To limit image size impact, the pointer to the function name is only added
to the __bug_table section if both CONFIG_KUNIT and
On Wed, 2024-03-06 at 02:14 +0800, kernel test robot wrote:
> > |-- drivers-gpu-drm-nouveau-nvkm-subdev-gsp-r535.c:warning:Function-
> > parameter-or-struct-member-gsp-not-described-in-nvkm_gsp_radix3_sg
Could someone please apply
On Tue, Mar 5, 2024 at 4:54 AM Yunsheng Lin wrote:
>
> On 2024/3/5 10:01, Mina Almasry wrote:
>
> ...
>
> >
> > Perf - page-pool benchmark:
> > ---
> >
> > bench_page_pool_simple.ko tests with and without these changes:
> > https://pastebin.com/raw/ncHDwAbn
> >
> > AFAIK
The expression htotal * vtotal can have a zero value on
overflow. It is necessary to prevent division by zero like in
fb_var_to_videomode().
Found by Linux Verification Center (linuxtesting.org) with Svace.
Signed-off-by: Roman Smirnov
Reviewed-by: Sergey Shtylyov
---
V1 -> V2: Replaced the
On Tue, Mar 05, 2024 at 10:48:56AM +0100, Jérémie Dautheribes wrote:
> Hi Conor,
>
> On 04/03/2024 20:29, Conor Dooley wrote:
> > On Mon, Mar 04, 2024 at 05:04:51PM +0100, Jérémie Dautheribes wrote:
> > > Hello everyone,
> > >
> > > This patch series add support for the Crystal Clear Technology
On 3/5/24 11:54, Kees Cook wrote:
On Tue, Mar 05, 2024 at 10:40:29AM -0800, Guenter Roeck wrote:
[...]
warning = (bug->flags & BUGFLAG_WARNING) != 0;
once = (bug->flags & BUGFLAG_ONCE) != 0;
done = (bug->flags & BUGFLAG_DONE) != 0;
+ if (warning &&
On Mon, Mar 4, 2024 at 6:02 PM Mina Almasry wrote:
>
> Convert netmem to be a union of struct page and struct netmem. Overload
> the LSB of struct netmem* to indicate that it's a net_iov, otherwise
> it's a page.
>
> Currently these entries in struct page are rented by the page_pool and
> used
On Tue, Mar 5, 2024, at 21:00, Mina Almasry wrote:
> On Tue, Mar 5, 2024 at 1:05 AM Arnd Bergmann wrote:
>> On Tue, Mar 5, 2024, at 03:01, Mina Almasry wrote:
>
> A key goal of this patch series is that the kernel does not try to
> parse the skb frags that reside in the dma-buf for that precise
>
On Mon, Mar 4, 2024, at 3:34 PM, Vinay Belgaumkar wrote:
> Allow user to provide a low latency context hint. When set, KMD
> sends a hint to GuC which results in special handling for this
> context. SLPC will ramp the GT frequency aggressively every time
> it switches to this context. The down
On Mon, Mar 4, 2024 at 6:04 PM Rob Clark wrote:
> On Mon, Mar 4, 2024 at 5:38 PM Gurchetan Singh
> wrote:
> >
> >
> >
> >
> > On Fri, Mar 1, 2024 at 10:54 AM Rob Clark wrote:
> >>
> >> From: Rob Clark
> >>
> >> Perfetto can use these traces to track global and per-process GPU memory
> >>
Hi,
On Tue, Mar 5, 2024 at 12:17 AM Jani Nikula wrote:
>
> On Mon, 04 Mar 2024, Doug Anderson wrote:
> > Hi,
> >
> > On Mon, Mar 4, 2024 at 4:19 PM Hsin-Yi Wang wrote:
> >>
> >> > > Probably change to u32 drm_edid_get_panel_id(const struct drm_edid
> >> > > *);? Given that we still need to
On Tue, Mar 05, 2024 at 10:40:29AM -0800, Guenter Roeck wrote:
> [...]
> warning = (bug->flags & BUGFLAG_WARNING) != 0;
> once = (bug->flags & BUGFLAG_ONCE) != 0;
> done = (bug->flags & BUGFLAG_DONE) != 0;
>
> + if (warning && IS_SUPPRESSED_WARNING(function))
> +
On Mon, Mar 04, 2024 at 03:24:51PM -0600, Rob Herring wrote:
> On Mon, Mar 04, 2024 at 07:29:04PM +, Conor Dooley wrote:
> > On Mon, Mar 04, 2024 at 05:04:51PM +0100, Jérémie Dautheribes wrote:
> > > Hello everyone,
> > >
> > > This patch series add support for the Crystal Clear Technology
>
On Tue, Mar 5, 2024 at 4:55 AM Yunsheng Lin wrote:
>
> On 2024/3/5 10:01, Mina Almasry wrote:
>
> ...
>
> >
> > The netdev_dmabuf_binding struct is refcounted, and releases its
> > resources only when all the refs are released.
> >
> > Signed-off-by: Willem de Bruijn
> > Signed-off-by: Kaiyuan
On Fri, Mar 01, 2024 at 12:28:57AM +0100, Andi Shyti wrote:
> Some of the CCS engines are disabled. They should not be listed
> in the uabi_engine list, that is the list of engines that the
> user can see.
Fused off engines already aren't visible to userspace (or to the kernel
for that matter).
Hi Thomas,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next-fixes linus/master v6.8-rc7
next-20240305]
[If your patch
On Tue, Mar 5, 2024 at 12:42 AM Arnd Bergmann wrote:
>
> On Tue, Mar 5, 2024, at 03:01, Mina Almasry wrote:
> > --- a/arch/alpha/include/uapi/asm/socket.h
> > +++ b/arch/alpha/include/uapi/asm/socket.h
> > #define SO_PEERPIDFD 77
> > +#define SO_DEVMEM_LINEAR 79
> > +#define
On 2/27/24 13:14, Thomas Zimmermann wrote:
> Dma-buf locking semantics require the caller of pin and unpin to hold
> the buffer's reservation lock. Fix DRM to adhere to the specs. This
> enables to fix the locking in DRM's console emulation. Similar changes
> for vmap and mmap have been posted at
On Tue, Mar 5, 2024 at 1:55 PM David Wei wrote:
>
> On 2024-03-04 18:01, Mina Almasry wrote:
> > +struct memory_provider_ops {
> > + int (*init)(struct page_pool *pool);
> > + void (*destroy)(struct page_pool *pool);
> > + struct page *(*alloc_pages)(struct page_pool *pool, gfp_t
On Mon, Mar 04, 2024 at 03:34:50PM -0800, Vinay Belgaumkar wrote:
> Allow user to provide a low latency context hint. When set, KMD
> sends a hint to GuC which results in special handling for this
> context. SLPC will ramp the GT frequency aggressively every time
> it switches to this context. The
On Tue, Mar 5, 2024 at 10:02 AM Ricardo B. Marliere
wrote:
>
> On 5 Mar 09:07, T.J. Mercier wrote:
> >
> > Reviewed-by: T.J. Mercier
> >
> > Is this really a resend? I don't see anything on lore and I can't
> > recall seeing this patch in my inbox before.
>
> Hi T.J. thanks for reviewing!
>
>
On Tue, Mar 5, 2024, at 20:22, Mina Almasry wrote:
> On Tue, Mar 5, 2024 at 12:42 AM Arnd Bergmann wrote:
>> On Tue, Mar 5, 2024, at 03:01, Mina Almasry wrote:
>>
>> This structure requires a special compat handler to run
>> x86-32 binaries on x86-64 because of the different alignment
>>
On Tue, Mar 5, 2024 at 1:05 AM Arnd Bergmann wrote:
>
> On Tue, Mar 5, 2024, at 03:01, Mina Almasry wrote:
>
> > +int netdev_bind_dmabuf(struct net_device *dev, unsigned int dmabuf_fd,
> > +struct netdev_dmabuf_binding **out)
> > +{
> > + struct netdev_dmabuf_binding
When vm-binding an already-created BO, the entirety of its virtual size is
then backed by system memory, so its RSS is always the same as its virtual
size.
Signed-off-by: Adrián Larumbe
---
drivers/gpu/drm/panthor/panthor_drv.c | 1 +
drivers/gpu/drm/panthor/panthor_gem.c | 12
2
These values are sampled by the firmware right before jumping into the UM
command stream and immediately after returning from it, and then kept inside a
per-job accounting structure. That structure is held inside the group's syncobjs
buffer object, at an offset that depends on the job's queue slot
This patch series enables userspace utilities like gputop and nvtop to
query a render context's fdinfo file and figure out rates of engine
and memory utilisation.
Adrián Larumbe (2):
drm/panthor: Enable fdinfo for cycle and time measurements
drm/panthor: Enable fdinfo for memory stats
On Mon, Mar 4, 2024 at 6:02 PM Mina Almasry wrote:
>
> Abstrace the memory type from the page_pool so we can later add support
> for new memory types. Convert the page_pool to use the new netmem type
> abstraction, rather than use struct page directly.
>
> As of this patch the netmem type is a
On 2024-03-04 18:01, Mina Almasry wrote:
> +struct memory_provider_ops {
> + int (*init)(struct page_pool *pool);
> + void (*destroy)(struct page_pool *pool);
> + struct page *(*alloc_pages)(struct page_pool *pool, gfp_t gfp);
> + bool (*release_page)(struct page_pool *pool, struct
Cong,
On Mon, Mar 4, 2024 at 5:26 PM Cong Yang
wrote:
>
> The current measured frame rate is 59.95Hz, which does not meet the
> requirements of touch-stylus and stylus cannot work normally. After
> adjustment, the actual measurement is 60.001Hz. Now this panel looks
> like it's only used by me
There are 2 different AUO panels using the same panel id. One of the
variants requires using overridden modes to resolve glitching issue as
described in commit 70e0d5550f5c ("drm/panel-edp: Add auo_b116xa3_mode").
Other variants should use the modes parsed from EDID.
Signed-off-by: Hsin-Yi Wang
Debugfs isn't always available in production builds that try to squeeze
every single byte out of the kernel image, but we still need a way to
toggle the timestamp and cycle counter registers so that jobs can be
profiled for fdinfo's drm engine and cycle calculations.
Drop the debugfs knob and
This is v3 of the patch already discussed in [2] and [1]
Changelog:
v3:
- Replaced manual kobj initialisation with a device attribute
- Handle user input with kstrtobool instead of treating it as an uint
v2:
- Turned the profile mode atomic variable into a boolean
- Rewrote the sysfs file's
New patch description for v3 patch
update upstream MAINTAINERS mail list
New patch description for v2 patch
Missing declaration for i variable in function
it6505_irq_video_error_handler
, add it by this patch
Origianl description for v1 patch
From: kuro chung
ITE added a FIFO reset bit for input video. When system power resume,
the TTL input of it6505 may get some noise before video signal stable
and the hardware function reset is required.
But the input FIFO reset will also trigger error interrupts of output module
rising.
Thus,
On 2024-03-04 18:01, Mina Almasry wrote:
> + if (pool->p.queue)
> + binding = READ_ONCE(pool->p.queue->binding);
> +
> + if (binding) {
> + pool->mp_ops = _devmem_ops;
> + pool->mp_priv = binding;
> + }
This is specific to TCP devmem. For ZC Rx we
On 2024-03-05 18:42, Mina Almasry wrote:
> On Tue, Mar 5, 2024 at 6:28 PM David Wei wrote:
>>
>> On 2024-03-04 18:01, Mina Almasry wrote:
>>> + if (pool->p.queue)
>>> + binding = READ_ONCE(pool->p.queue->binding);
>>> +
>>> + if (binding) {
>>> + pool->mp_ops =
Create a type drm_edid_ident as the identity of an EDID. Currently it
contains panel id and monitor name.
Create a function that can match a given EDID and an identity:
1. Reject if the panel id doesn't match.
2. If name is not null in identity, try to match it in the detailed timing
blocks.
Currently edid quirks are matched by panel id only.
Modify it to match with identity so it's easier to be extended
for more complex matching if required.
Suggested-by: Jani Nikula
Signed-off-by: Hsin-Yi Wang
---
v4: new
Per discussion https://lore.kernel.org/lkml/87a5nd4tsg@intel.com/
---
It's found that some panels have variants that they share the same panel id
although their EDID and names are different. When matching generic edp
panels, we should first match with both panel identity, which contains both
panel id and panel name. If not found, match with panel id only.
It's found that some panels have variants that they share the same panel id
although their EDID and names are different. Besides panel id, now we need
more information from the EDID base block to distinguish these panel
variants.
Add drm_edid_read_base_block() to return the EDID base block, which
This series is a follow up for 1a5e81de180e ("Revert "drm/panel-edp: Add
auo_b116xa3_mode""). It's found that 2 different AUO panels use the same
product id. One of them requires an overridden mode, while the other should
use the mode directly from edid.
Match the panel for identity (id and
Allow user to provide a low latency context hint. When set, KMD
sends a hint to GuC which results in special handling for this
context. SLPC will ramp the GT frequency aggressively every time
it switches to this context. The down freq threshold will also be
lower so GuC will ramp down the GT freq
On Tue, Mar 5, 2024 at 6:28 PM David Wei wrote:
>
> On 2024-03-04 18:01, Mina Almasry wrote:
> > + if (pool->p.queue)
> > + binding = READ_ONCE(pool->p.queue->binding);
> > +
> > + if (binding) {
> > + pool->mp_ops = _devmem_ops;
> > + pool->mp_priv =
On Tue, Mar 5, 2024 at 6:47 PM David Wei wrote:
>
> On 2024-03-05 18:42, Mina Almasry wrote:
> > On Tue, Mar 5, 2024 at 6:28 PM David Wei wrote:
> >>
> >> On 2024-03-04 18:01, Mina Almasry wrote:
> >>> + if (pool->p.queue)
> >>> + binding = READ_ONCE(pool->p.queue->binding);
>
Uprev IGT and add amd, v3d, vc4 and vgem specific
tests to testlist. Have testlist.txt per driver
and include a base testlist so that the driver
specific tests will run only on those hardware.
Also add testlists to the MAINTAINERS file.
Signed-off-by: Vignesh Raman
---
v3:
- New patch in
For rockchip rk3288 and rk3399, the GPU driver is panfrost.
So add support in drm-ci to test panfrost driver for rockchip
SOC and update xfails. Skip KMS tests for panfrost driver
since it is not a not a KMS driver.
Signed-off-by: Vignesh Raman
---
v2:
- Add panfrost GPU jobs for rockchip SOC
For rockchip rk3288 and rk3399, the display driver is rockchip.
Currently, in drm-ci for rockchip, only the display driver is
tested. Refactor the existing rockchip jobs so that gpu driver
testing jobs can be added later and update xfails accordingly.
Signed-off-by: Vignesh Raman
---
v2:
-
Update xfails with the newly added tests in testlist-amdgpu.txt.
Signed-off-by: Vignesh Raman
---
v4:
- New patch in the series. Run tests with newly added tests in
testlist-amdgpu.txt and update xfails.
---
.../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 26 +--
For mediatek mt8173 and mt8183, the display driver is mediatek.
Currently, in drm-ci for mediatek, only the display driver is
tested. Refactor the existing mediatek jobs so that gpu driver
testing jobs can be added later and update xfails accordingly.
Since the correct driver name is passed from
Add job that runs igt on top of vkms.
Signed-off-by: Vignesh Raman
Acked-by: Jessica Zhang
Tested-by: Jessica Zhang
Acked-by: Maxime Ripard
Signed-off-by: Helen Koike
---
v4:
- New patch in the series.
https://lore.kernel.org/lkml/20240201065346.801038-1-vignesh.ra...@collabora.com/
For Amlogic Meson SOC the display driver is meson. Currently,
in drm-ci for meson, only the display driver is tested.
Refactor the existing meson jobs so that gpu driver testing
jobs can be added later and update xfails accordingly.
Signed-off-by: Vignesh Raman
---
v2:
- Refactor the patch to
For mediatek mt8173, the GPU driver is powervr and for mediatek
mt8183, the GPU driver is panfrost. So add support in drm-ci to
test panfrost and powervr GPU driver for mediatek SOCs and update
xfails. Powervr driver was merged in linux kernel, but there's no
mediatek support yet. So disable the
Enable CONFIG_DRM_ANALOGIX_ANX7625 in the arm64 defconfig to get
display driver probed on the mt8183-kukui-jacuzzi-juniper machine.
arch/arm64/configs/defconfig has CONFIG_DRM_ANALOGIX_ANX7625=m,
but drm-ci don't have initrd with modules, so add
CONFIG_DRM_ANALOGIX_ANX7625=y in CI arm64 config.
zlib.net is not allowing tarball download anymore and results
in below error in kernel+rootfs_arm32 container build,
urllib.error.HTTPError: HTTP Error 403: Forbidden
urllib.error.HTTPError: HTTP Error 415: Unsupported Media Type
Uprev mesa which includes a fix for this issue.
For amlogic meson SOC the GPU driver is panfrost. So add
support in drm-ci to test panfrost driver for amlogic meson
SOC and update xfails. Skip KMS tests for panfrost driver
since it is not a not a KMS driver.
Signed-off-by: Vignesh Raman
---
v2:
- Add panfrost GPU jobs for amlogic meson SOC
On Tue, Mar 5, 2024 at 11:25 AM Doug Anderson wrote:
>
> Hi,
>
> On Tue, Mar 5, 2024 at 12:17 AM Jani Nikula
> wrote:
> >
> > On Mon, 04 Mar 2024, Doug Anderson wrote:
> > > Hi,
> > >
> > > On Mon, Mar 4, 2024 at 4:19 PM Hsin-Yi Wang wrote:
> > >>
> > >> > > Probably change to u32
Hi Maíra,
On 19/02/24 14:22, Vignesh Raman wrote:
Hi Maíra,
On 10/02/24 23:50, Maíra Canal wrote:
On 2/10/24 15:17, Maíra Canal wrote:
On 1/30/24 12:03, Vignesh Raman wrote:
Uprev IGT and add amd, v3d, vc4 and vgem specific
tests to testlist. Have testlist.txt per driver
and include a base
For linux-next repository.
./drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h:1: warning: no structured
comments found
./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:132: warning: Incorrect use of
kernel-doc format: * @@overlap_only: Whether overlapping of different
planes is allowed.
Hi,
I have to admit that v3 was a lazy attempt. This one should be on
the right path.
this series does basically two things:
1. Disables automatic load balancing as adviced by the hardware
workaround.
2. Assigns all the CCS slices to one single user engine. The user
will then be able to
The hardware should not dynamically balance the load between CCS
engines. Wa_14019159160 recommends disabling it across all
platforms.
Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement")
Signed-off-by: Andi Shyti
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Matt Roper
Cc: # v6.2+
Enable only one CCS engine by default with all the compute sices
allocated to it.
While generating the list of UABI engines to be exposed to the
user, exclude any additional CCS engines beyond the first
instance.
This change can be tested with igt i915_query.
Fixes: d2eae8e98d59 ("drm/i915/dg2:
For the upcoming changes we need a cleaner way to build the list
of uabi engines.
Suggested-by: Tvrtko Ursulin
Signed-off-by: Andi Shyti
Cc: # v6.2+
---
drivers/gpu/drm/i915/gt/intel_engine_user.c | 29 -
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git
idge detect\n");
>
> - return anx7625_sink_detect(ctx);
> + status = anx7625_sink_detect(ctx);
> + anx7625_audio_update_connector_status(ctx, status);
Nit: add an empty line here.
> + return status;
> }
>
> static struct edid *anx7625_bri
Some ARM SOCs have a separate display controller and GPU, each with
different drivers. For mediatek mt8173, the GPU driver is powervr,
and the display driver is mediatek. In the case of mediatek mt8183,
the GPU driver is panfrost, and the display driver is mediatek.
With rockchip rk3288/rk3399,
To be able to handle list unlocking while traversing the LRU
list, we want the iterators not only to point to the next
position of the list traversal, but to insert themselves as
list nodes at that point to work around the fact that the
next node might otherwise disappear from the list while
the
The -ENOSPC failure from ttm_bo_swapout() meant that the lru_lock
was dropped and simply restarting the iteration meant we'd likely
hit the same error again on the same resource. Now that we can
restart the iteration even if the lock was dropped, do that.
Cc: Christian König
Cc: Somalapuram
Have iterators insert themselves into the list they are iterating
over using hitch list nodes. Since only the iterator owner
can remove these list nodes from the list, it's safe to unlock
the list and when continuing, use them as a starting point. Due to
the way LRU bumping works in TTM, newly
To address the problem with hitches moving when bulk move
sublists are lru-bumped, register the list cursors with the
ttm_lru_bulk_move structure when traversing its list, and
when lru-bumping the list, move the cursor hitch to the tail.
This also means it's mandatory for drivers to call
This patch-set is a prerequisite for a standalone TTM shrinker
and for exhaustive TTM eviction using sleeping dma_resv locks,
which is the motivation for it.
Currently when unlocking the TTM lru list lock, iteration needs
to be restarted from the beginning, rather from the next LRU list
node.
Hi,
Doug Anderson 于2024年3月6日周三 08:23写道：
>
> Cong,
>
> On Mon, Mar 4, 2024 at 5:26 PM Cong Yang
> wrote:
> >
> > The current measured frame rate is 59.95Hz, which does not meet the
> > requirements of touch-stylus and stylus cannot work normally. After
> > adjustment, the actual measurement is
The kcalloc() in nouveau_dmem_evict_chunk() will return null if
the physical memory has run out. As a result, if we dereference
src_pfns, dst_pfns or dma_addrs, the null pointer dereference bugs
will happen.
Moreover, the GPU is going away. If the kcalloc() fails, we could not
evict all pages
to v1:
https://lore.kernel.org/r/20240305-anx7625-v1-1-83ed3ccfa...@chromium.org
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c
b/drivers/gpu/drm/bridge/analogix/anx7625.c
index
On 29.02.24 20:04, Rob Clark wrote:
>
> This is the main pull for v6.9, description below.
>
> [...]
>
> GPU:
> - fix sc7180 UBWC config
Why was that queued for 6.9? That is a fix for a 6.8 regression that for
untrained eyes like mine does not look overly dangerous (but of course I
might be
Hi
Am 05.03.24 um 01:36 schrieb Michael Ellerman:
Christophe Leroy writes:
Le 04/03/2024 à 11:32, Thomas Zimmermann a écrit :
Hi
Am 04.03.24 um 10:55 schrieb Jani Nikula:
Removal of the backlight include from fb.h uncovered an implicit
dependency in powerpc asm/backlight.h. Add the
On Mon, 04 Mar 2024, Doug Anderson wrote:
> Hi,
>
> On Mon, Mar 4, 2024 at 4:19 PM Hsin-Yi Wang wrote:
>>
>> > > Probably change to u32 drm_edid_get_panel_id(const struct drm_edid
>> > > *);? Given that we still need to parse id from
>> > > drm_edid_read_base_block().
>> >
>> > No, we no longer
Hello Adam,
Thank you for the patch.
On Mon, Mar 04, 2024 at 06:48:57PM -0600, Adam Ford wrote:
> The IRQ registration currently assumes that the GPIO is dedicated
> to it, but that may not necessarily be the case. If the board has
> another device sharing the GPIO, it won't be registered and
On Tue, Mar 5, 2024, at 03:01, Mina Almasry wrote:
> --- a/arch/alpha/include/uapi/asm/socket.h
> +++ b/arch/alpha/include/uapi/asm/socket.h
> #define SO_PEERPIDFD 77
> +#define SO_DEVMEM_LINEAR 79
> +#define SO_DEVMEM_DMABUF 80
> --- a/arch/mips/include/uapi/asm/socket.h
> +++
At least the i915 and amd drivers enable a bunch more compiler warnings
than the kernel defaults.
Extend most of the W=1 warnings to the entire drm subsystem by
default. Use the copy-pasted warnings from scripts/Makefile.extrawarn
with s/KBUILD_CFLAGS/subdir-ccflags-y/ to make it easier to
Add kconfig to enable -Werror subsystem wide. This is useful for
development and CI to keep the subsystem warning free, while avoiding
issues outside of the subsystem that kernel wide CONFIG_WERROR=y might
hit.
v2: Don't depend on COMPILE_TEST
Reviewed-by: Hamza Mahfooz # v1
Signed-off-by: Jani
Hi,
Simplify old code in few backlight drivers.
Changes in v2
=
1. Patch #1: Drop "Error :" msg.
2. Add Rb tags.
Link to v1:
https://lore.kernel.org/r/20240304-backlight-probe-v1-0-e5f57d0df...@linaro.org
Best regards,
Krzysztof
---
Krzysztof Kozlowski (7):
backlight: gpio:
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Reviewed-by: Daniel Thompson
Signed-off-by: Krzysztof Kozlowski
---
drivers/video/backlight/l4f00242t03.c | 34 ++
1 file changed, 14
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski
---
drivers/video/backlight/gpio_backlight.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git
Don't pollute dmesg on deferred probe and simplify the code with
dev_err_probe().
Reviewed-by: Daniel Thompson
Signed-off-by: Krzysztof Kozlowski
---
drivers/video/backlight/as3711_bl.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
Don't pollute dmesg on deferred probe and simplify the code with
dev_err_probe().
Reviewed-by: Daniel Thompson
Signed-off-by: Krzysztof Kozlowski
---
drivers/video/backlight/bd6107.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/bd6107.c
Don't pollute dmesg on deferred probe and simplify the code with
dev_err_probe().
Reviewed-by: Daniel Thompson
Signed-off-by: Krzysztof Kozlowski
---
drivers/video/backlight/lm3630a_bl.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
Code can be simpler: return directly when devm_gpiod_get_optional()
failed.
Reviewed-by: Daniel Thompson
Signed-off-by: Krzysztof Kozlowski
---
drivers/video/backlight/lm3630a_bl.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/lm3630a_bl.c
Core code already prints detailed information about failure of memory
allocation.
Reviewed-by: Daniel Thompson
Signed-off-by: Krzysztof Kozlowski
---
drivers/video/backlight/pandora_bl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/backlight/pandora_bl.c
On Mon, 04 Mar 2024, Hsin-Yi Wang wrote:
> On Mon, Mar 4, 2024 at 4:09 PM Jani Nikula
> wrote:
>>
>> On Mon, 04 Mar 2024, Hsin-Yi Wang wrote:
>> > To clarify:
>> > struct drm_edid currently is only internal to drm_edid.c. So with
>> > change we will have to move it to the header drm_edid.h
>>
Resend of [1] with an intent to merge after the CI results come in. This
is aiming for v6.10, so we'll have maximal time to find all the issues
my configs didn't catch.
I built this on x86-64 (both gcc and clang), arm and arm64, and
everything passed.
BR,
Jani.
[1]
On Tue, 05 Mar 2024, Thomas Zimmermann wrote:
> Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for the
> backlight header has recently been removed from . Add it to
> via-pmu-backlight.c to get the necessary symbols.
>
> Reported-by: Naresh Kamboju
> Closes:
>
On Tue, Mar 05, 2024 at 09:11:56AM +0100, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Daniel Thompson
Daniel.
On Tue, 05 Mar 2024, Thomas Zimmermann wrote:
> Replace with a forward declaration in to
> resolves an unnecessary dependency. Remove pmac_backlight_curve_lookup()
*resolve
> and struct fb_info from source and header files. The function and the
> framebuffer struct is unused. No functional
Hi Pin-yen Lin,
Please see my reply below, Thank you.
BR Kuro Chung
-Original Message-
From: Pin-yen Lin
Sent: Wednesday, February 21, 2024 7:02 PM
To: Kuro Chung (鐘仕廷)
Cc: Allen Chen ; Kenneth Hung (洪家倫)
; Allen Chen ;
Andrzej Hajda ; Neil Armstrong ;
Robert Foss ;
On 04/03/2024 11:40, Daniel Thompson wrote:
> On Mon, Mar 04, 2024 at 11:11:38AM +0100, Krzysztof Kozlowski wrote:
>> Common pattern of handling deferred probe can be simplified with
>> dev_err_probe(). Less code and also it prints the error value.
>>
>> Signed-off-by: Krzysztof Kozlowski
>> ---
Hi Daniel,
Great to see this moving forward!
On 2024-03-01, Daniel Vetter wrote:
> But for the initial cut of a drm panic printing support I don't think
> we need that, because the critical sections are extremely small and
> only happen once per display refresh. So generally just 60 tiny locked
1 - 100 of 243 matches
Mail list logo
