Re: [PATCH v7 2/3] drm/i915/gt: Do not generate the command streamer for all the CCS

2024-03-28 Thread Andi Shyti
Hi Matt, > > + /* > > +* Do not create the command streamer for CCS slices beyond the first. > > +* All the workload submitted to the first engine will be shared among > > +* all the slices. > > +* > > +* Once the user will be allowed to customize the CCS mode, then this > >

Re: [PATCH] drm/i915/gem: Replace dev_priv with i915

2024-03-28 Thread Andi Shyti
Hi, On Thu, Mar 28, 2024 at 08:18:33AM +0100, Andi Shyti wrote: > Anyone using 'dev_priv' instead of 'i915' in a cleaned-up area > should be fined and required to do community service for a few > days. Not to scare people off, I would add another sentence in between: "Using 'i915' instead of

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-28 Thread Linus Walleij
On Tue, Mar 26, 2024 at 3:49 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The -Woverride-init warn about code that may be intentional or not, > but the inintentional ones tend to be real bugs, so there is a bit of > disagreement on whether this warning option should be enabled by default >

Re: [RFC PATCH v3 3/6] drm/amd/display: switch amdgpu_dm_connector to use struct drm_edid

2024-03-28 Thread Jani Nikula
On Wed, 27 Mar 2024, Melissa Wen wrote: > Replace raw edid handling (struct edid) with the opaque EDID type > (struct drm_edid) on amdgpu_dm_connector for consistency. It may also > prevent mismatch of approaches in different parts of the driver code. > Working in progress. It was only exercised

Re: [RFC 0/5] Introduce drm sharpening property

2024-03-28 Thread Pekka Paalanen
On Wed, 27 Mar 2024 13:29:16 +0200 Pekka Paalanen wrote: > On Wed, 27 Mar 2024 07:11:48 + > "Garg, Nemesa" wrote: > > > > -Original Message- > > > From: Pekka Paalanen > > > Sent: Wednesday, March 13, 2024 3:07 PM > > > To: Garg, Nemesa > > > Cc: Simon Ser ;

[RFC 3/7] drm/virtio: Add helpers to initialize and free the imported object

2024-03-28 Thread Vivek Kasireddy
The imported object can be considered a guest blob resource; therefore, we use create_blob cmd while creating it. These helpers are used in the next patch which does the actual import. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- drivers/gpu/drm/virtio/virtgpu_prime.c | 69

[RFC 2/7] drm/virtio: Add a helper to map and note the dma addrs and lengths

2024-03-28 Thread Vivek Kasireddy
This helper would be used when first initializing the object as part of import and also when updating the plane where we need to ensure that the imported object's backing is valid. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- drivers/gpu/drm/virtio/virtgpu_drv.h | 6

[RFC 7/7] udmabuf: Implement UDMABUF_CREATE_LIST_FOR_PCIDEV ioctl

2024-03-28 Thread Vivek Kasireddy
By implementing this request, the udmabuf driver would be able to support creating a dmabuf from a PCI device's bar region. This would facilitate P2P DMA operations between any two PCI devices as long as they are compatible. Based on the information (devid, bar) provided by the VMM, once the PCI

[RFC 6/7] udmabuf/uapi: Add new ioctl to create a dmabuf from PCI bar regions

2024-03-28 Thread Vivek Kasireddy
This new ioctl can be used by a VMM such as Qemu or other userspace applications to create a dmabuf from a PCI device's memory regions. The PCI device's id that the userspace app is required to provide needs to be encoded in the format specified by the following macro (defined in

[RFC 4/7] drm/virtio: Import prime buffers from other devices as guest blobs

2024-03-28 Thread Vivek Kasireddy
By importing scanout buffers from other devices, we should be able to use the virtio-gpu driver in KMS only mode. Note that we attach dynamically and register a move_notify() callback so that we can let the VMM know of any location changes associated with the backing store of the imported object

[RFC 0/7] drm/virtio: Import scanout buffers from other devices

2024-03-28 Thread Vivek Kasireddy
Having virtio-gpu import scanout buffers (via prime) from other devices means that we'd be adding a head to headless GPUs assigned to a Guest VM or additional heads to regular GPU devices that are passthrough'd to the Guest. In these cases, the Guest compositor can render into the scanout buffer

[RFC 1/7] drm/virtio: Implement VIRTIO_GPU_CMD_RESOURCE_DETACH_BACKING cmd

2024-03-28 Thread Vivek Kasireddy
This cmd is useful to let the VMM (i.e, Qemu) know that the backing store associated with a resource is no longer valid, so that the VMM can perform any cleanup or unmap operations. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- drivers/gpu/drm/virtio/virtgpu_drv.h | 2 ++

[RFC 5/7] drm/virtio: Ensure that bo's backing store is valid while updating plane

2024-03-28 Thread Vivek Kasireddy
To make sure that the imported bo's backing store is valid, we first pin the associated dmabuf, import the sgt if need be and then unpin it after the update is complete. Note that we pin/unpin the dmabuf even when the backing store is valid to ensure that it does not move when the host update

Re: [PATCH 00/18] Add audio support for the MediaTek Genio 350-evk board

2024-03-28 Thread Alexandre Mergnat
Hi Angelo On 26/02/2024 15:54, AngeloGioacchino Del Regno wrote: Il 26/02/24 15:01, Alexandre Mergnat ha scritto: This serie aim to add the following audio support for the Genio 350-evk: - Playback    - 2ch Headset Jack (Earphone)    - 1ch Line-out Jack (Speaker)    - 8ch HDMI Tx - Capture   

Re: [PATCH v9 1/6] dmaengine: Add API function dmaengine_prep_peripheral_dma_vec()

2024-03-28 Thread Vinod Koul
On 10-03-24, 13:48, Paul Cercueil wrote: > This function can be used to initiate a scatter-gather DMA transfer, > where the address and size of each segment is located in one entry of > the dma_vec array. > > The major difference with dmaengine_prep_slave_sg() is that it supports > specifying the

Re: [PATCH] drm/i915/gem: Replace dev_priv with i915

2024-03-28 Thread Tvrtko Ursulin
On 28/03/2024 07:18, Andi Shyti wrote: Anyone using 'dev_priv' instead of 'i915' in a cleaned-up area should be fined and required to do community service for a few days. I thought I had cleaned up the 'gem/' directory in the past, but still, old aficionados of the 'dev_priv' name keep

Re: [PATCH] drm/i915/gt: Limit the reserved VM space to only the platforms that need it

2024-03-28 Thread Nirmoy Das
Hi Andi, On 3/27/2024 9:05 PM, Andi Shyti wrote: Commit 9bb66c179f50 ("drm/i915: Reserve some kernel space per vm") reduces the available VM space of one page in order to apply Wa_16018031267 and Wa_16018063123. This page was reserved indiscrimitely in all platforms even when not needed. Limit

About upstreaming ArmChina NPU driver

2024-03-28 Thread Dejia Shang
Dear Kernel Maintainers, I am a driver developer and would like to upstream the ArmChina Zhouyi NPU driver ("Zhouyi" is the brand) to accel subsystem. The driver is already open sourced (both UMD and KMD) and anyone can find the code from https://github.com/Arm-China/Compass_NPU_Driver.git.

[PATCH net-next v5 3/3] net: ethernet: ti: am65-cpsw: Add minimal XDP support

2024-03-28 Thread Julien Panis
This patch adds XDP (eXpress Data Path) support to TI AM65 CPSW Ethernet driver. The following features are implemented: - NETDEV_XDP_ACT_BASIC (XDP_PASS, XDP_TX, XDP_DROP, XDP_ABORTED) - NETDEV_XDP_ACT_REDIRECT (XDP_REDIRECT) - NETDEV_XDP_ACT_NDO_XMIT (ndo_xdp_xmit callback) The page pool memory

[PATCH net-next v5 2/3] net: ethernet: ti: Add desc_infos member to struct k3_cppi_desc_pool

2024-03-28 Thread Julien Panis
This patch introduces a member and the related accessors which can be used to store descriptor specific additional information. This member can store, for instance, an ID to differentiate a skb TX buffer type from a xdpf TX buffer type. Signed-off-by: Julien Panis ---

[PATCH net-next v5 0/3] Add minimal XDP support to TI AM65 CPSW Ethernet driver

2024-03-28 Thread Julien Panis
This patch adds XDP support to TI AM65 CPSW Ethernet driver. The following features are implemented: NETDEV_XDP_ACT_BASIC, NETDEV_XDP_ACT_REDIRECT, and NETDEV_XDP_ACT_NDO_XMIT. Zero-copy and non-linear XDP buffer supports are NOT implemented. Besides, the page pool memory model is used to get

[PATCH net-next v5 1/3] net: ethernet: ti: Add accessors for struct k3_cppi_desc_pool members

2024-03-28 Thread Julien Panis
This patch adds accessors for desc_size and cpumem members. They may be used, for instance, to compute a descriptor index. Signed-off-by: Julien Panis --- drivers/net/ethernet/ti/k3-cppi-desc-pool.c | 12 drivers/net/ethernet/ti/k3-cppi-desc-pool.h | 2 ++ 2 files changed, 14

[PATCH 0/3] DisplayPort support for SM6350/SM7225

2024-03-28 Thread Luca Weiss
+ .../bindings/display/msm/qcom,sm6350-mdss.yaml | 10 +++ arch/arm64/boot/dts/qcom/sm6350.dtsi | 88 ++ 3 files changed, 99 insertions(+) --- base-commit: 871760455183dc66b3e185f8d3ed2184cc9fac25 change-id: 20240328-sm6350-dp-41238153b448 Best regards, -- Luca Weiss

[PATCH 3/3] arm64: dts: qcom: sm6350: Add DisplayPort controller

2024-03-28 Thread Luca Weiss
Add the node for the DisplayPort controller found on the SM6350 SoC. Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 88 1 file changed, 88 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi

[PATCH 1/3] dt-bindings: display: msm: dp-controller: document SM8250 compatible

2024-03-28 Thread Luca Weiss
Add the compatible string for the DisplayPort controller on SM6350 which is compatible with the one on SM8350. Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 2/3] dt-bindings: display: msm: sm6350-mdss: document DP controller subnode

2024-03-28 Thread Luca Weiss
Document the displayport controller subnode of the SM6350 MDSS. Signed-off-by: Luca Weiss --- .../devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml

Re: [PATCH 1/3] dt-bindings: display: msm: dp-controller: document SM8250 compatible

2024-03-28 Thread Luca Weiss
Stupid typo in subject, should of course be SM6350, not SM8250. On Thu Mar 28, 2024 at 10:42 AM CET, Luca Weiss wrote: > Add the compatible string for the DisplayPort controller on SM6350 which > is compatible with the one on SM8350. > > Signed-off-by: Luca Weiss > --- >

Re: [PATCH v2 1/3] arch: Select fbdev helpers with CONFIG_VIDEO

2024-03-28 Thread Sam Ravnborg
On Wed, Mar 27, 2024 at 09:41:29PM +0100, Thomas Zimmermann wrote: > Various Kconfig options selected the per-architecture helpers for > fbdev. But none of the contained code depends on fbdev. Standardize > on CONFIG_VIDEO, which will allow to add more general helpers for > video functionality. >

Re: [PATCH v2 3/3] arch: Rename fbdev header and source files

2024-03-28 Thread Sam Ravnborg
Hi Thomas, On Wed, Mar 27, 2024 at 09:41:31PM +0100, Thomas Zimmermann wrote: > The per-architecture fbdev code has no dependencies on fbdev and can > be used for any video-related subsystem. Rename the files to 'video'. > Use video-sti.c on parisc as the source file depends on CONFIG_STI_CORE. >

Re: [RFC PATCH v3 0/6] drm/amd/display: switch amdgpu_dm_connector to use struct drm_edid

2024-03-28 Thread Jani Nikula
On Wed, 27 Mar 2024, Melissa Wen wrote: > 2. Most of the edid data handled by `dm_helpers_parse_edid_caps()` are >in drm_edid halpers, but there are still a few that are not managed by >them yet. For example: >``` > edid_caps->serial_number = edid_buf->serial; >

Re: [PATCH v3 07/13] drm: Make drivers depends on DRM_DW_HDMI

2024-03-28 Thread Jani Nikula
On Wed, 27 Mar 2024, Maxime Ripard wrote: > DRM_DW_HDMI has a number of dependencies that might not be enabled. > However, drivers were used to selecting it while not enforcing the > DRM_DW_HDMI dependencies. > > This could result in Kconfig warnings (and further build breakages) such > as: > >

[PATCH v8 1/3] drm/i915/gt: Disable HW load balancing for CCS

2024-03-28 Thread Andi Shyti
The hardware should not dynamically balance the load between CCS engines. Wa_14019159160 recommends disabling it across all platforms. Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement") Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Matt Roper Cc: # v6.2+

[PATCH v8 3/3] drm/i915/gt: Enable only one CCS for compute workload

2024-03-28 Thread Andi Shyti
Enable only one CCS engine by default with all the compute sices allocated to it. While generating the list of UABI engines to be exposed to the user, exclude any additional CCS engines beyond the first instance. This change can be tested with igt i915_query. Fixes: d2eae8e98d59 ("drm/i915/dg2:

[PATCH v8 2/3] drm/i915/gt: Do not generate the command streamer for all the CCS

2024-03-28 Thread Andi Shyti
We want a fixed load CCS balancing consisting in all slices sharing one single user engine. For this reason do not create the intel_engine_cs structure with its dedicated command streamer for CCS slices beyond the first. Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement")

Re: [PATCH] drm/i915/gt: Limit the reserved VM space to only the platforms that need it

2024-03-28 Thread Andi Shyti
Hi Nirmoy, On Thu, Mar 28, 2024 at 09:54:12AM +0100, Nirmoy Das wrote: > On 3/27/2024 9:05 PM, Andi Shyti wrote: > > Commit 9bb66c179f50 ("drm/i915: Reserve some kernel space per > > vm") reduces the available VM space of one page in order to apply > > Wa_16018031267 and Wa_16018063123. > > > >

[PATCH] drm/i915/gem: Replace dev_priv with i915

2024-03-28 Thread Andi Shyti
Anyone using 'dev_priv' instead of 'i915' in a cleaned-up area should be fined and required to do community service for a few days. I thought I had cleaned up the 'gem/' directory in the past, but still, old aficionados of the 'dev_priv' name keep sneaking it in. Signed-off-by: Andi Shyti Cc:

[PATCH v8 0/3] Disable automatic load CCS load balancing

2024-03-28 Thread Andi Shyti
Hi, I think we are at the end of it and hopefully this is the last version. Thanks Matt for having followed this series until here. This series does basically two things: 1. Disables automatic load balancing as adviced by the hardware workaround. 2. Assigns all the CCS slices to one single

[PATCH] drm/msm/adreno: Set highest_bank_bit for A619

2024-03-28 Thread Luca Weiss
be 14 but causes corruption at e.g. 1920x1200 on DP */ + gpu->ubwc_config.highest_bank_bit = 13; + if (adreno_is_a619_holi(gpu)) gpu->ubwc_config.highest_bank_bit = 13; --- base-commit: d5a436a7b5958caa6fc0dcda6c842f9d951be73b change-id: 20240328-a6

[GIT PULL] Immutable branch between MFD, Auxdisplay, HID and FB due for the v6.9 merge window

2024-03-28 Thread Lee Jones
Enjoy! The following changes since commit 4cece764965020c22cff7665b18a012006359095: Linux 6.9-rc1 (2024-03-24 14:10:05 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git ib-backlight-auxdisplay-hid-fb-v6.9 for you to fetch

[PULL] drm-misc-next

2024-03-28 Thread Maarten Lankhorst
Hi Dave, Sima, Happy easter!! Cheers, ~Maarten drm-misc-next-2024-03-28: drm-misc-next for v6.10-rc1: The deal of a lifetime! You get ALL of the previous drm-misc-next-2024-03-21-1 tag!! But WAIT, there's MORE! Cross-subsystem Changes: - Assorted DT binding updates. Core Changes: - Clarify

Re: [PATCH 0/2] video: backlight: constify struct class usage

2024-03-28 Thread Greg Kroah-Hartman
On Thu, Mar 28, 2024 at 11:41:31AM +, Lee Jones wrote: > On Tue, 05 Mar 2024, Ricardo B. Marliere wrote: > > > This is a simple and straight forward cleanup series that aims to make the > > class structures in backlight constant. This has been possible since 2023 > > [1]. > > > > [1]:

Re: [PATCH v2 1/2] video: backlight: make backlight_class constant

2024-03-28 Thread Lee Jones
On Thu, 28 Mar 2024 12:59:06 +0100, Greg Kroah-Hartman wrote: > Since commit 43a7206b0963 ("driver core: class: make class_register() take > a const *"), the driver core allows for struct class to be in read-only > memory, so move the backlight_class structure to be declared at build time >

Re: [PATCH net-next v5 1/3] net: ethernet: ti: Add accessors for struct k3_cppi_desc_pool members

2024-03-28 Thread Julien Panis
On 3/28/24 13:06, Naveen Mamindlapalli wrote: -Original Message- From: Julien Panis Sent: Thursday, March 28, 2024 2:57 PM To: David S. Miller ; Eric Dumazet ; Jakub Kicinski ; Paolo Abeni ; Russell King ; Alexei Starovoitov ; Daniel Borkmann ; Jesper Dangaard Brouer ; John Fastabend ;

Re: [PATCH v2 3/3] arch: Rename fbdev header and source files

2024-03-28 Thread Thomas Zimmermann
Hi Am 28.03.24 um 13:51 schrieb Arnd Bergmann: On Thu, Mar 28, 2024, at 13:46, Helge Deller wrote: On 3/27/24 21:41, Thomas Zimmermann wrote: +++ b/arch/arc/include/asm/video.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef _ASM_VIDEO_H_ +#define _ASM_VIDEO_H_ + +#include

[PATCH 2/4] drm/panel: simple: Add missing Innolux G121X1-L03 format, flags, connector

2024-03-28 Thread Marek Vasut
The .bpc = 6 implies .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG , add the missing bus_format. Add missing connector type and bus_flags as well. Documentation [1] 1.4 GENERAL SPECIFICATI0NS indicates this panel is capable of both RGB 18bit/24bit panel, the current configuration uses 18bit mode,

[PATCH 4/4] drm/panel: simple: Add Innolux G121XCE-L01 LVDS display support

2024-03-28 Thread Marek Vasut
G121XCE-L01 is a Color Active Matrix Liquid Crystal Display composed of a TFT LCD panel, a driver circuit, and LED backlight system. The screen format is intended to support the 4:3, 1024(H) x 768(V) screen and either 262k/16.7M colors (RGB 6-bits or 8-bits) with LED backlight driver circuit. All

[PATCH 3/4] drm/panel: simple: Convert Innolux G121X1-L03 to display_timing

2024-03-28 Thread Marek Vasut
Use display_timing instead of drm_display_mode to define a range of possible display timings supported by this panel. This makes the panel support more flexible and improves compatibility. No functional change is expected. The settings are picked from documentation [1] section 6.1 INPUT SIGNAL

[PATCH 1/4] dt-bindings: display: simple: Document support for Innolux G121XCE-L01

2024-03-28 Thread Marek Vasut
Document support for Innolux CheMei 12" G121XCE-L01 XGA LVDS display. G121XCE-L01 is a Color Active Matrix Liquid Crystal Display composed of a TFT LCD panel, a driver circuit, and LED backlight system. The screen format is intended to support the 4:3, 1024(H) x 768(V) screen and either

Re: [PATCH] drm: DRM_WERROR should depend on DRM

2024-03-28 Thread Jani Nikula
On Tue, 26 Mar 2024, Jani Nikula wrote: > On Tue, 26 Mar 2024, Geert Uytterhoeven wrote: >> There is no point in asking the user about enforcing the DRM compiler >> warning policy when configuring a kernel without DRM support. >> >> Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR") >>

Re: [PATCH v2 1/3] arch: Select fbdev helpers with CONFIG_VIDEO

2024-03-28 Thread Thomas Zimmermann
Hi Am 28.03.24 um 13:39 schrieb Helge Deller: On 3/27/24 21:41, Thomas Zimmermann wrote: Various Kconfig options selected the per-architecture helpers for fbdev. But none of the contained code depends on fbdev. Standardize on CONFIG_VIDEO, which will allow to add more general helpers for video

Re: [PATCH v2 2/3] arch: Remove struct fb_info from video helpers

2024-03-28 Thread Thomas Zimmermann
Hi Am 28.03.24 um 12:04 schrieb Helge Deller: On 3/27/24 21:41, Thomas Zimmermann wrote: The per-architecture video helpers do not depend on struct fb_info or anything else from fbdev. Remove it from the interface and replace fb_is_primary_device() with video_is_primary_device(). The new

[PULL] drm-misc-fixes

2024-03-28 Thread Thomas Zimmermann
Hi Dave, Sima, this is the weekly PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2024-03-28: Short summary of fixes pull: bridge: - select DRM_KMS_HELPER dma-buf: - fix NULL-pointer deref dp: - fix div-by-zero in DP MST unplug code fbdev: - select FB_IOMEM_FOPS for SBus nouveau:

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-03-28 Thread Pekka Paalanen
On Fri, 15 Mar 2024 13:09:56 -0400 wrote: > From: Leo Li > > These patches aim to make the amdgpgu KMS driver play nicer with compositors > when building multi-plane scanout configurations. They do so by: > > 1. Making cursor behavior more sensible. > 2. Allowing placement of DRM OVERLAY

Re: [PATCH v6 10/14] drm/panthor: Add the scheduler logical block

2024-03-28 Thread Boris Brezillon
Hi Nathan, On Thu, 28 Mar 2024 08:38:09 -0700 Nathan Chancellor wrote: > Hi Boris, > > On Thu, Feb 29, 2024 at 05:22:24PM +0100, Boris Brezillon wrote: > > > --- > > drivers/gpu/drm/panthor/panthor_sched.c | 3502 +++ > > drivers/gpu/drm/panthor/panthor_sched.h | 50 + >

Re: Proposal to add CRIU support to DRM render nodes

2024-03-28 Thread Tvrtko Ursulin
Hi Felix, I had one more thought while browsing around the amdgpu CRIU plugin. It appears it relies on the KFD support being compiled in and /dev/kfd present, correct? AFAICT at least, it relies on that to figure out the amdgpu DRM node. In would be probably good to consider designing

Re: [PATCH] drm/panfrost: fix power transition timeout warnings

2024-03-28 Thread Steven Price
On 22/03/2024 16:45, Christian Hewitt wrote: > Increase the timeout value to prevent system logs on Amlogic boards flooding > with power transition warnings: > > [ 13.047638] panfrost ffe4.gpu: shader power transition timeout > [ 13.048674] panfrost ffe4.gpu: l2 power transition

Re: [PATCH 1/2] drm/amd/display: Introduce overlay cursor mode

2024-03-28 Thread Harry Wentland
On 2024-03-28 11:48, Robert Mader wrote: Hi, On 15.03.24 18:09, sunpeng...@amd.com wrote: From: Leo Li [Why] DCN is the display hardware for amdgpu. DRM planes are backed by DCN hardware pipes, which carry pixel data from one end (memory), to the other (output encoder). Each DCN pipe

[PATCH] drm/mediatek: Init `ddp_comp` with devm_kcalloc()

2024-03-28 Thread Douglas Anderson
In the case where `conn_routes` is true we allocate an extra slot in the `ddp_comp` array but mtk_drm_crtc_create() never seemed to initialize it in the test case I ran. For me, this caused a later crash when we looped through the array in mtk_drm_crtc_mode_valid(). This showed up for me when I

Re: [PATCH 2/3] dt-bindings: display: panel: visionox,vtdr6130: Add mode property

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > Add DSI mode property and compression mode property > > Signed-off-by: Jun Nie > --- > .../bindings/display/panel/visionox,vtdr6130.yaml | 8 > 1 file changed, 8 insertions(+) > > diff --git >

Re: [PATCH 3/3] drm/panel: Enable DSC for Visionox VTDR6130 panel

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > Enable display compression (DSC v1.2) for 1080x2400 Visionox > VTDR6130 AMOLED DSI panel. DTS property is needed to enable DSC. > Default configuration is video mode + non-DSC for any back > compatibility. The changelog talks about the DSC only,

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

2024-03-28 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 3/26/2024 11:39 PM, Matthew Auld wrote: On 18/03/2024 21:40, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each

[PATCH] drm/panthor: Fix clang -Wunused-but-set-variable in tick_ctx_apply()

2024-03-28 Thread Nathan Chancellor
--- base-commit: d180649238f04183950d9c8a7d8a2c2f1788a89c change-id: 20240328-panthor-drop-csg_mod_mask-b4bbe317d690 Best regards, -- Nathan Chancellor

Re: [PATCH] drm/panthor: Fix clang -Wunused-but-set-variable in tick_ctx_apply()

2024-03-28 Thread Steven Price
gt;csg_slots[csg_id]; > - csg_mod_mask |= BIT(csg_id); > group_bind_locked(group, csg_id); > csg_slot_prog_locked(ptdev, csg_id, new_csg_prio--); > csgs_upd_ctx_queue_reqs(ptdev, _ctx, csg_id, > > --- > base-commit: d180649238f04183950d9c8a7d8a2c2f1788a89c > change-id: 20240328-panthor-drop-csg_mod_mask-b4bbe317d690 > > Best regards,

Re: [PATCH 0/2] video: backlight: constify struct class usage

2024-03-28 Thread Greg Kroah-Hartman
On Thu, Mar 28, 2024 at 09:46:01AM -0300, Ricardo B. Marliere wrote: > On 28 Mar 13:01, Greg Kroah-Hartman wrote: > > On Thu, Mar 28, 2024 at 11:41:31AM +, Lee Jones wrote: > > > On Tue, 05 Mar 2024, Ricardo B. Marliere wrote: > > > > > > > This is a simple and straight forward cleanup series

Re: [PATCH][next] drm/nouveau/gr/gf100: Remove second semicolon

2024-03-28 Thread Danilo Krummrich
On 3/15/24 10:09, Colin Ian King wrote: There is a statement with two semicolons. Remove the second one, it is redundant. Signed-off-by: Colin Ian King Applied, thanks! --- drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] nouveau/uvmm: fix addr/range calcs for remap operations

2024-03-28 Thread Danilo Krummrich
On 3/28/24 03:43, Dave Airlie wrote: From: Dave Airlie dEQP-VK.sparse_resources.image_rebind.2d_array.r64i.128_128_8 was causing a remap operation like the below. op_remap: prev: 003fffed 000f a5abd18a op_remap: next: op_remap: unmap:

Re: [PATCH v2 1/6] drm/msm/dp: Drop unused dp_debug struct

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 16:35, Bjorn Andersson wrote: > > From: Bjorn Andersson > > The members of struct dp_debug are no longer used, so the only purpose > of this struct is as a type of the return value of dp_debug_get(), to > signal success/error. > > Drop the struct in favor of signalling the

Re: [PATCH 19/43] drm/virtio: Use fbdev-shmem

2024-03-28 Thread Dmitry Osipenko
On 3/12/24 18:45, Thomas Zimmermann wrote: > Implement fbdev emulation with fbdev-shmem. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: David Airlie > Cc: Gerd Hoffmann > Cc: Gurchetan Singh > Cc: Chia-I

Re: [PATCH 3/3] arm64: dts: qcom: sm6350: Add DisplayPort controller

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 11:43, Luca Weiss wrote: > > Add the node for the DisplayPort controller found on the SM6350 SoC. > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/sm6350.dtsi | 88 > > 1 file changed, 88 insertions(+) > Reviewed-by:

Re: [PATCH 1/2] drm/amd/display: Introduce overlay cursor mode

2024-03-28 Thread Pekka Paalanen
On Fri, 15 Mar 2024 13:09:57 -0400 wrote: > From: Leo Li > > [Why] > > DCN is the display hardware for amdgpu. DRM planes are backed by DCN > hardware pipes, which carry pixel data from one end (memory), to the > other (output encoder). > > Each DCN pipe has the ability to blend in a cursor

Re: [PATCH v6 10/14] drm/panthor: Add the scheduler logical block

2024-03-28 Thread Nathan Chancellor
Hi Boris, On Thu, Feb 29, 2024 at 05:22:24PM +0100, Boris Brezillon wrote: > --- > drivers/gpu/drm/panthor/panthor_sched.c | 3502 +++ > drivers/gpu/drm/panthor/panthor_sched.h | 50 + > 2 files changed, 3552 insertions(+) > create mode 100644

Re: [PATCH 1/2] drm/panthor: Enable fdinfo for cycle and time measurements

2024-03-28 Thread Liviu Dudau
Hi Adrián, Appologies for the delay in reviewing this. On Tue, Mar 05, 2024 at 09:05:49PM +, Adrián Larumbe wrote: > These values are sampled by the firmware right before jumping into the UM > command stream and immediately after returning from it, and then kept inside a > per-job accounting

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

2024-03-28 Thread Matthew Auld
On 28/03/2024 16:07, Paneer Selvam, Arunpravin wrote: Hi Matthew, On 3/26/2024 11:39 PM, Matthew Auld wrote: On 18/03/2024 21:40, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in

[PATCH] dma-buf: Do not build debugfs related code when !CONFIG_DEBUG_FS

2024-03-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin There is no point in compiling in the list and mutex operations which are only used from the dma-buf debugfs code, if debugfs is not compiled in. Put the code in questions behind some kconfig guards and so save some text and maybe even a pointer per object at runtime when

Re: [PATCH v2 2/3] arch: Remove struct fb_info from video helpers

2024-03-28 Thread Helge Deller
On 3/28/24 14:33, Thomas Zimmermann wrote: Am 28.03.24 um 12:04 schrieb Helge Deller: On 3/27/24 21:41, Thomas Zimmermann wrote: The per-architecture video helpers do not depend on struct fb_info or anything else from fbdev. Remove it from the interface and replace fb_is_primary_device() with

Re: [PATCH 1/3] drm/msm/dpu: fix DSC for DSI video mode

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > Fix DSC timing and control configurations in DPU for DSI video mode. > Only compression ratio 3:1 is handled and tested. > > This patch is modified from patchs of Jonathan Marek. > > Signed-off-by: Jun Nie This almost looks like a joke, except it

Re: [PATCH 2/2] drm/amd/display: Move PRIMARY plane zpos higher

2024-03-28 Thread Pekka Paalanen
On Fri, 15 Mar 2024 13:09:58 -0400 wrote: > From: Leo Li > > [Why] > > Compositors have different ways of assigning surfaces to DRM planes for > render offloading. It may decide between various strategies: overlay, > underlay, or a mix of both > > One way for compositors to implement the

Re: [PATCH 19/22] rpmsg: virtio: drop owner assignment

2024-03-28 Thread Mathieu Poirier
On Wed, Mar 27, 2024 at 01:41:12PM +0100, Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Depends on the first patch. > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 1 - > 1 file changed, 1

Re: [PATCH v2 1/3] arch: Select fbdev helpers with CONFIG_VIDEO

2024-03-28 Thread Helge Deller
On 3/27/24 21:41, Thomas Zimmermann wrote: Various Kconfig options selected the per-architecture helpers for fbdev. But none of the contained code depends on fbdev. Standardize on CONFIG_VIDEO, which will allow to add more general helpers for video functionality. CONFIG_VIDEO protects each

Re: [PATCH 0/2] video: backlight: constify struct class usage

2024-03-28 Thread Ricardo B. Marliere
On 28 Mar 13:01, Greg Kroah-Hartman wrote: > On Thu, Mar 28, 2024 at 11:41:31AM +, Lee Jones wrote: > > On Tue, 05 Mar 2024, Ricardo B. Marliere wrote: > > > > > This is a simple and straight forward cleanup series that aims to make the > > > class structures in backlight constant. This has

[PATCH] drm/virtio: add driver_priv validation in virtio_gpu_create_context

2024-03-28 Thread Maxim Korotkov
The pointer file->driver_priv was dereferenced without checking against NULL, but in the "virtio_gpu_transfer_to_host_ioctl" function it was checked against NULL after calling virtio_gpu_create_context function. Found by Security Code and Linux Verification Center(linuxtesting.org) Fixes:

Re: [PATCH] drm/i915/gem: Calculate object page offset for partial memory mapping

2024-03-28 Thread Andi Shyti
Hi Nirmoy, On Tue, Mar 26, 2024 at 01:05:37PM +0100, Nirmoy Das wrote: > On 3/26/2024 12:12 PM, Andi Shyti wrote: > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c > > > > b/drivers/gpu/drm/i915/gem/i915_gem_mman.c > > > > index a2195e28b625..57a2dda2c3cc 100644 > > > > ---

Re: [PATCH v2 2/3] arch: Remove struct fb_info from video helpers

2024-03-28 Thread Helge Deller
On 3/27/24 21:41, Thomas Zimmermann wrote: The per-architecture video helpers do not depend on struct fb_info or anything else from fbdev. Remove it from the interface and replace fb_is_primary_device() with video_is_primary_device(). The new helper Since you rename this function, wouldn't

[PATCH 1/3] drm/msm/dpu: fix DSC for DSI video mode

2024-03-28 Thread Jun Nie
Fix DSC timing and control configurations in DPU for DSI video mode. Only compression ratio 3:1 is handled and tested. This patch is modified from patchs of Jonathan Marek. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-

[PATCH 3/3] drm/panel: Enable DSC for Visionox VTDR6130 panel

2024-03-28 Thread Jun Nie
Enable display compression (DSC v1.2) for 1080x2400 Visionox VTDR6130 AMOLED DSI panel. DTS property is needed to enable DSC. Default configuration is video mode + non-DSC for any back compatibility. Below modes works on SM8650. While cmd mode does not work yet. - video mode + DSC - video mode -

[PATCH 2/3] dt-bindings: display: panel: visionox, vtdr6130: Add mode property

2024-03-28 Thread Jun Nie
Add DSI mode property and compression mode property Signed-off-by: Jun Nie --- .../bindings/display/panel/visionox,vtdr6130.yaml | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml

Re: [PATCH net-next v5 3/3] net: ethernet: ti: am65-cpsw: Add minimal XDP support

2024-03-28 Thread Julien Panis
On 3/28/24 12:42, Ratheesh Kannoth wrote: On 2024-03-28 at 14:56:42, Julien Panis (jpa...@baylibre.com) wrote: This patch adds XDP (eXpress Data Path) support to TI AM65 CPSW Ethernet driver. The following features are implemented: - NETDEV_XDP_ACT_BASIC (XDP_PASS, XDP_TX, XDP_DROP,

Re: [PATCH v2 3/3] arch: Rename fbdev header and source files

2024-03-28 Thread Arnd Bergmann
On Thu, Mar 28, 2024, at 13:46, Helge Deller wrote: > On 3/27/24 21:41, Thomas Zimmermann wrote: >> +++ b/arch/arc/include/asm/video.h >> @@ -0,0 +1,8 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> + >> +#ifndef _ASM_VIDEO_H_ >> +#define _ASM_VIDEO_H_ >> + >> +#include >> + >> +#endif /*

Re: [PATCH v2 3/3] arch: Rename fbdev header and source files

2024-03-28 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.9-rc1 next-20240328] [cannot apply to tip/x86/core deller-parisc/for-next arnd-asm-generic/master] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH v5 14/16] drm/vkms: Create KUnit tests for YUV conversions

2024-03-28 Thread Pekka Paalanen
On Mon, 25 Mar 2024 11:34:17 -0300 Maíra Canal wrote: > On 3/13/24 14:45, Louis Chauvet wrote: > > From: Arthur Grillo > > > > Create KUnit tests to test the conversion between YUV and RGB. Test each > > conversion and range combination with some common colors. > > > > The code used to

Re: [PATCH v2 1/2] video: backlight: make backlight_class constant

2024-03-28 Thread Lee Jones
On Thu, 28 Mar 2024, Lee Jones wrote: > On Thu, 28 Mar 2024 12:59:06 +0100, Greg Kroah-Hartman wrote: > > Since commit 43a7206b0963 ("driver core: class: make class_register() take > > a const *"), the driver core allows for struct class to be in read-only > > memory, so move the backlight_class

Re: [PATCH v5 16/16] drm/vkms: Add support for DRM_FORMAT_R*

2024-03-28 Thread Pekka Paalanen
On Wed, 13 Mar 2024 18:45:10 +0100 Louis Chauvet wrote: > This add the support for: > - R1/R2/R4/R8 > > R1 format was tested with [1] and [2]. > > [1]: > https://lore.kernel.org/r/20240313-new_rotation-v2-0-6230fd5ca...@bootlin.com > [2]: >

Re: [PATCH 1/2] drm/qxl: remove unused `count` variable from `qxl_surface_id_alloc()`

2024-03-28 Thread Miguel Ojeda
On Thu, Mar 28, 2024 at 11:18 AM Maxime Ripard wrote: > > "a while ago" here being 2 hours before your message :) Ah, I meant the original reports that Nathan mentioned in his message. Yeah, the message itself from Nathan happened right before :) > I've added a Closes tag for that report too. >

Re: [PATCH 1/2] drm/qxl: remove unused `count` variable from `qxl_surface_id_alloc()`

2024-03-28 Thread Maxime Ripard
On Wed, Mar 27, 2024 at 07:14:12PM +0100, Miguel Ojeda wrote: > On Wed, Mar 27, 2024 at 6:56 PM Miguel Ojeda wrote: > > > > Closes: > > https://lore.kernel.org/lkml/caniq72mjc5t4n25sqvysroehxxpxypz4ppznesjhenc3qap...@mail.gmail.com/ > > Should have a [1] at the end. I added it while committing

[GIT PULL] Immutable branch between MFD, Auxdisplay, Staging, fbdev and OMAP due for the v6.9 merge window

2024-03-28 Thread Lee Jones
Enjoy! The following changes since commit 4cece764965020c22cff7665b18a012006359095: Linux 6.9-rc1 (2024-03-24 14:10:05 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git ib-backlight-auxdisplay-staging-omap-v6.9 for you to fetch

Re: About upstreaming ArmChina NPU driver

2024-03-28 Thread Sudeep Holla
On Thu, Mar 28, 2024 at 07:46:01AM +, Dejia Shang wrote: > IMPORTANT NOTICE: The contents of this email and any attachments may be > privileged and confidential. If you are not the intended recipient, please > delete the email immediately. It is strictly prohibited to disclose the >

Re: [RESEND v3 2/2] drm: Add CONFIG_DRM_WERROR

2024-03-28 Thread Jani Nikula
On Wed, 27 Mar 2024, Nathan Chancellor wrote: > On Wed, Mar 27, 2024 at 09:59:01AM +0200, Jani Nikula wrote: >> An alternative would be to "depends on !COMPILE_TEST" that we have in >> i915, but then some folks want to have COMPILE_TEST in drm, because some >> drivers are otherwise hard for

[PATCH v11 0/9] drm/panic: Add a drm panic handler

2024-03-28 Thread Jocelyn Falempe
This introduces a new drm panic handler, which displays a message when a panic occurs. So when fbcon is disabled, you can still see a kernel panic. This is one of the missing feature, when disabling VT/fbcon in the kernel: https://www.reddit.com/r/linux/comments/10eccv9/config_vtn_in_2023/ Fbcon

[PATCH v11 1/9] drm/panic: Add drm panic locking

2024-03-28 Thread Jocelyn Falempe
From: Daniel Vetter Rough sketch for the locking of drm panic printing code. The upshot of this approach is that we can pretty much entirely rely on the atomic commit flow, with the pair of raw_spin_lock/unlock providing any barriers we need, without having to create really big critical sections

[PATCH v11 2/9] drm/panic: Add a drm panic handler

2024-03-28 Thread Jocelyn Falempe
This module displays a user friendly message when a kernel panic occurs. It currently doesn't contain any debug information, but that can be added later. v2 * Use get_scanout_buffer() instead of the drm client API. (Thomas Zimmermann) * Add the panic reason to the panic message (Nerdopolis)

  1   2   >