[git pull] drm fixes for 5.18-rc7

2022-05-12 Thread Dave Airlie
Hey Linus, Pretty quiet week on the fixes front, 4 amdgpu and one i915 fix. I think there might be a few misc fbdev ones outstanding, but I'll see if they are necessary and pass them on if so. Dave. drm-fixes-2022-05-13: drm fixes for 5.18-rc7 amdgpu: - Disable ASPM for VI boards on ADL

Re: Improve TTMs empty object handling

2022-05-12 Thread Luben Tuikov
Patch set reviewed. Good stuff. Acked-by: Luben Tuikov Regards, Luben On 2022-05-09 09:09, Christian König wrote: > Hi everyone, > > re-sending this because Daniel was requesting a background why this is > useful. > > When TTM creates a buffer this object initially should not have any >

[PATCH v2 8/8] dt-bindings: arm: qcom: document sda660 SoC and ifc6560 board

2022-05-12 Thread Dmitry Baryshkov
Add binding documentation for the Inforce IFC6560 board which uses Snapdragon SDA660. Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml

[PATCH v2 6/8] arm64: dts: qcom: sdm630: use defined symbols for interconnects

2022-05-12 Thread Dmitry Baryshkov
Replace numeric values with the symbolic names defined in the bindings header. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi

[PATCH v2 5/8] arm64: dts: qcom: sdm630: add second (HS) USB host support

2022-05-12 Thread Dmitry Baryshkov
Add DT entries for the second DWC3 USB host, which is limited to the USB2.0 (HighSpeed), and the corresponding QUSB PHY. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 55 1 file changed, 55 insertions(+) diff --git

[PATCH v2 7/8] arm64: dts: qcom: sdm660: Add initial Inforce IFC6560 board support

2022-05-12 Thread Dmitry Baryshkov
The IFC6560 is a board from Inforce Computing, built around the SDA660 SoC. This patch describes core clocks, some regulators from the two PMICs, debug uart, storage, bluetooth and audio DSP remoteproc. The regulator settings are inherited from prior work by Konrad Dybcio and AngeloGioacchino Del

[PATCH v2 1/8] arm64: dts: qcom: sdm660: disable dsi1/dsi1_phy by default

2022-05-12 Thread Dmitry Baryshkov
Follow the typical practice and keep DSI1/DSI1 PHY disabled by default. They should be enabled in the board DT files. No existing boards use them at this moment. Reviewed-by: Marijn Suijten Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdm660.dtsi | 3

[PATCH v2 2/8] arm64: dts: qcom: sdm630: disable dsi1/dsi1_phy by default

2022-05-12 Thread Dmitry Baryshkov
Follow the typical practice and keep DSI0/DSI0 PHY disabled by default. They should be enabled in the board DT files. No existing boards use them at this moment. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v2 3/8] arm64: dts: qcom: sdm630: disable GPU by default

2022-05-12 Thread Dmitry Baryshkov
The SoC's device tree file disables gpucc and adreno's SMMU by default. So let's disable the GPU too. Moreover it looks like SMMU might be not usable without additional patches (which means that GPU is unusable too). No board uses GPU at this moment. Fixes: 5cf69dcbec8b ("arm64: dts: qcom:

[PATCH v2 4/8] arm64: dts: qcom: sdm630: fix the qusb2phy ref clock

2022-05-12 Thread Dmitry Baryshkov
According to the downstram DT file, the qusb2phy ref clock should be GCC_RX0_USB2_CLKREF_CLK, not GCC_RX1_USB2_CLKREF_CLK. Fixes: c65a4ed2ea8b ("arm64: dts: qcom: sdm630: Add USB configuration") Cc: Konrad Dybcio Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov ---

[PATCH v2 0/8] arm64: dts: qcom: initial Inforce IFC6560 board support

2022-05-12 Thread Dmitry Baryshkov
This work is largely based on the previous work by Bjorn Andersson ([1]) Changes since v1 (mostly based on Kondrad's review): - Also disabled dsi0/dsi0 phy in sdm630.dtsi - Removed the clock from BAM DMA devices rather than disabling them completely - Replaced numbers with symbolic names for

Re: [PATCH v3 1/4] drm/dp: Add wait_hpd_asserted() callback to struct drm_dp_aux

2022-05-12 Thread Doug Anderson
Hi, On Wed, May 11, 2022 at 6:58 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2022-04-18 10:17:54) > > Sometimes it's useful for users of the DP AUX bus (like panels) to be > > able to poll HPD. Let's add a callback that allows DP AUX busses > > drivers to provide this. > > > >

Re: [PATCH v4] drm/msm/dsi: don't powerup at modeset time for parade-ps8640

2022-05-12 Thread Abhinav Kumar
Hi, On 5/12/2022 3:44 PM, Doug Anderson wrote: Hi, On Thu, May 12, 2022 at 3:34 PM Abhinav Kumar wrote: On 5/12/2022 3:16 PM, Dmitry Baryshkov wrote: On 13/05/2022 01:00, Douglas Anderson wrote: Commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time") caused sc7180

Re: [PATCH 2/2] drm/msm: push IRQ setup into individual drivers

2022-05-12 Thread Abhinav Kumar
On 5/6/2022 6:00 PM, Dmitry Baryshkov wrote: Afther the commit f026e431cf86 ("drm/msm: Convert to Linux IRQ interfaces") converted MSM DRM driver to handle IRQs on it's own (rather than using the DRM IRQ mid-layer), there is little point in keeping irq wrapper in the msm_drv.c which just call

Re: [PATCH v4] drm/msm/dsi: don't powerup at modeset time for parade-ps8640

2022-05-12 Thread Doug Anderson
Hi, On Thu, May 12, 2022 at 3:34 PM Abhinav Kumar wrote: > > On 5/12/2022 3:16 PM, Dmitry Baryshkov wrote: > > On 13/05/2022 01:00, Douglas Anderson wrote: > >> Commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > >> time") caused sc7180 Chromebooks that use the parade-ps8640

Re: [PATCH v4] drm/msm/dsi: don't powerup at modeset time for parade-ps8640

2022-05-12 Thread Abhinav Kumar
On 5/12/2022 3:16 PM, Dmitry Baryshkov wrote: On 13/05/2022 01:00, Douglas Anderson wrote: Commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time") caused sc7180 Chromebooks that use the parade-ps8640 bridge chip to fail to turn the display back on after it turns off.

Re: [PATCH v1 13/15] mm: handling Non-LRU pages returned by vm_normal_pages

2022-05-12 Thread Sierra Guiza, Alejandro (Alex)
On 5/11/2022 1:50 PM, Jason Gunthorpe wrote: On Thu, May 05, 2022 at 04:34:36PM -0500, Alex Sierra wrote: diff --git a/mm/memory.c b/mm/memory.c index 76e3af9639d9..892c4cc54dc2 100644 +++ b/mm/memory.c @@ -621,6 +621,13 @@ struct page *vm_normal_page(struct vm_area_struct *vma, unsigned

Re: [PATCH v4] drm/msm/dsi: don't powerup at modeset time for parade-ps8640

2022-05-12 Thread Dmitry Baryshkov
On 13/05/2022 01:00, Douglas Anderson wrote: Commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time") caused sc7180 Chromebooks that use the parade-ps8640 bridge chip to fail to turn the display back on after it turns off. Unfortunately, it doesn't look easy to fix the

Re: [PATCH v3] drm/msm/dsi: only powerup at modeset time if "early_poweron" modparam

2022-05-12 Thread Doug Anderson
Hi, On Thu, May 12, 2022 at 1:59 PM Dmitry Baryshkov wrote: > > On 12/05/2022 23:52, Douglas Anderson wrote: > > Commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > > time") caused sc7180 Chromebooks that use the parade-ps8640 bridge > > chip to fail to turn the display back on

[PATCH v4] drm/msm/dsi: don't powerup at modeset time for parade-ps8640

2022-05-12 Thread Douglas Anderson
Commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time") caused sc7180 Chromebooks that use the parade-ps8640 bridge chip to fail to turn the display back on after it turns off. Unfortunately, it doesn't look easy to fix the parade-ps8640 driver to handle the new power sequence.

Re: [PATCH 3/3] drm/panel: introduce ebbg,ft8719 panel

2022-05-12 Thread Linus Walleij
On Fri, May 6, 2022 at 2:18 PM Joel Selvaraj wrote: > Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode > panel, which can be found on some Xiaomi Poco F1 phones. The panel's > backlight is managed through QCOM WLED driver. > > Signed-off-by: Joel Selvaraj Cool! > +#define

Re: [PATCH] drm/amdgpu: Move mutex_init(>message_lock) to smu_early_init()

2022-05-12 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 12, 2022 at 4:45 PM Hans de Goede wrote: > > Lockdep complains about the smu->message_lock mutex being used before > it is initialized through the following call path: > > amdgpu_device_init() > amdgpu_dpm_mode2_reset() > smu_mode2_reset() >

Re: [PATCH] drm/i915: Fix CFI violation with show_dynamic_id()

2022-05-12 Thread Kees Cook
On May 12, 2022 2:17:04 PM PDT, Nathan Chancellor wrote: >When an attribute group is created with sysfs_create_group(), the >->sysfs_ops() callback is set to kobj_sysfs_ops, which sets the ->show() >callback to kobj_attr_show(). kobj_attr_show() uses container_of() to >get the ->show()

[PATCH] drm/i915: Fix CFI violation with show_dynamic_id()

2022-05-12 Thread Nathan Chancellor
When an attribute group is created with sysfs_create_group(), the ->sysfs_ops() callback is set to kobj_sysfs_ops, which sets the ->show() callback to kobj_attr_show(). kobj_attr_show() uses container_of() to get the ->show() callback from the attribute it was passed, meaning the ->show() callback

Re: [PATCH v3] drm/msm/dsi: only powerup at modeset time if "early_poweron" modparam

2022-05-12 Thread Dmitry Baryshkov
On 12/05/2022 23:52, Douglas Anderson wrote: Commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time") caused sc7180 Chromebooks that use the parade-ps8640 bridge chip to fail to turn the display back on after it turns off. Unfortunately, it doesn't look easy to fix the

[PATCH v3] drm/msm/dsi: only powerup at modeset time if "early_poweron" modparam

2022-05-12 Thread Douglas Anderson
Commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time") caused sc7180 Chromebooks that use the parade-ps8640 bridge chip to fail to turn the display back on after it turns off. Unfortunately, it doesn't look easy to fix the parade-ps8640 driver to handle the new power sequence.

[PATCH] drm/amdgpu: Move mutex_init(>message_lock) to smu_early_init()

2022-05-12 Thread Hans de Goede
Lockdep complains about the smu->message_lock mutex being used before it is initialized through the following call path: amdgpu_device_init() amdgpu_dpm_mode2_reset() smu_mode2_reset() smu_v12_0_mode2_reset() smu_cmn_send_smc_msg_with_param() Move the mutex_init() call to

[PATCH v6] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

2022-05-12 Thread Kuogee Hsieh
dp_catalog_ctrl_reset() will software reset DP controller. But it will not reset programmable registers to default value. DP driver still have to clear mask bits to interrupt status registers to disable interrupts after software reset of controller. At current implementation,

Re: [PATCH v12, 00/17] media: mtk-vcodec: support for M8192 decoder

2022-05-12 Thread Nícolas F . R . A . Prado
On Thu, May 12, 2022 at 10:19:33AM +0800, Yunfei Dong wrote: > This series adds support for mt8192 h264/vp8/vp9 decoder drivers. Firstly, > refactor > power/clock/interrupt interfaces for mt8192 is lat and core architecture. > > Secondly, add new functions to get frame buffer size and resolution

Re: [PATCH v5] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

2022-05-12 Thread Kuogee Hsieh
On 5/11/2022 6:03 PM, Dmitry Baryshkov wrote: On Thu, 12 May 2022 at 04:01, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-05-11 17:41:50) On 12/05/2022 03:02, Kuogee Hsieh wrote: diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index af7a80c..f3e333e

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-12 Thread Dmitry Osipenko
On 5/12/22 20:04, Daniel Vetter wrote: > On Thu, 12 May 2022 at 13:36, Dmitry Osipenko > wrote: >> >> On 5/11/22 22:09, Daniel Vetter wrote: >>> On Wed, May 11, 2022 at 07:06:18PM +0300, Dmitry Osipenko wrote: On 5/11/22 16:09, Daniel Vetter wrote: > I'd like to ask you to reduce the

Re: [PATCH v1 01/15] mm: add zone device coherent type memory support

2022-05-12 Thread Sierra Guiza, Alejandro (Alex)
On 5/11/2022 9:58 PM, Alistair Popple wrote: Alex Sierra writes: [...] diff --git a/mm/rmap.c b/mm/rmap.c index fedb82371efe..d57102cd4b43 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1995,7 +1995,8 @@ void try_to_migrate(struct folio *folio, enum ttu_flags flags)

Re: [PATCH v5 7/7] fbdev: Make registered_fb[] private to fbmem.c

2022-05-12 Thread Sam Ravnborg
On Wed, May 11, 2022 at 07:34:38PM +0200, Javier Martinez Canillas wrote: > Hello Guenter, > > On 5/11/22 19:17, Guenter Roeck wrote: > > On 5/11/22 10:00, Sam Ravnborg wrote: > > [snip] > > >>> struct fb_info *registered_fb[FB_MAX] __read_mostly; > >>> -EXPORT_SYMBOL(registered_fb); > >>> -

Re: [PATCH v4 0/7] Make the rest of the VFIO driver interface use vfio_device

2022-05-12 Thread Alex Williamson
On Thu, 5 May 2022 21:08:38 -0300 Jason Gunthorpe wrote: > Prior series have transformed other parts of VFIO from working on struct > device or struct vfio_group into working directly on struct > vfio_device. Based on that work we now have vfio_device's readily > available in all the drivers. >

Re: [BUG] Warning and NULL-ptr dereference in amdgpu driver with 5.18

2022-05-12 Thread Jörg Rödel
On Thu, May 12, 2022 at 09:47:29AM -0400, Alex Deucher wrote: > Are those new? Maybe the card is not seated correctly? Can you try > another slot? I can't remember having seen these TLP error messages with older kernels. 5.17 still works fine with this card. I will try to put the card into

Re: [PATCH] drm/amd/display: Remove macro DC_DEFAULT_LOG_MASK

2022-05-12 Thread kernel test robot
://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/pengfuyuan/drm-amd-display-Remove-macro-DC_DEFAULT_LOG_MASK/20220512-185320 base: git://anongit.freedesktop.org/drm/drm drm-next config: powerpc64-randconfig-s032-20220512 (https://download.01.org/0day-ci

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-12 Thread Daniel Vetter
On Thu, 12 May 2022 at 13:36, Dmitry Osipenko wrote: > > On 5/11/22 22:09, Daniel Vetter wrote: > > On Wed, May 11, 2022 at 07:06:18PM +0300, Dmitry Osipenko wrote: > >> On 5/11/22 16:09, Daniel Vetter wrote: > >>> I'd like to ask you to reduce the scope of the patchset and build the >

[PATCH] drm/amd/display: Remove macro DC_DEFAULT_LOG_MASK

2022-05-12 Thread pengfuyuan
[Why & How] The DC_DEFAULT_LOG_MASK macro has not been used for a long time, so remove it. Signed-off-by: pengfuyuan --- .../drm/amd/display/include/logger_types.h| 34 --- 1 file changed, 34 deletions(-) diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h

Re: [PATCH] drm/i915: Use i915_gem_object_ggtt_pin_ww for reloc_iomap

2022-05-12 Thread Matthew Auld
On 11/05/2022 19:38, Maarten Lankhorst wrote: Op 11-05-2022 om 20:23 schreef Matthew Auld: On 11/05/2022 12:52, Maarten Lankhorst wrote: Instead of its own path, use the common path when it doesn't result in evicting any vma. This fixes the case where we don't wait for binding.

Re: [REPORT] syscall reboot + umh + firmware fallback

2022-05-12 Thread Tejun Heo
Hello, On Thu, May 12, 2022 at 08:18:24PM +0900, Byungchul Park wrote: > > 1. wait_for_completion_killable_timeout() doesn't need someone to wake it up > >to make forward progress because it will unstick itself after timeout > >expires. > > I have a question about this one. Yes, it would

Re: [PATCH 1/2] drm/bridge: tc358767: Factor out DSI and DPI RX enablement

2022-05-12 Thread Robert Foss
On Thu, 12 May 2022 at 18:02, Robert Foss wrote: > > On Fri, 29 Apr 2022 at 22:56, Marek Vasut wrote: > > > > Factor out register programming to configure the chip video RX side for > > reception of video data from DSI or DPI. This is particularly useful in > > the (e)DP output mode, where the

Re: [PATCH 2/2] drm/bridge: tc358767: Add DSI-to-(e)DP mode support

2022-05-12 Thread Robert Foss
On Fri, 29 Apr 2022 at 22:56, Marek Vasut wrote: > > Implement DSI-to-e(DP) mode, which is a mix of currently supported > DSI-to-DPI and DPI-to-(e)DP modes. The input side is configured as > either DSI or DPI, the DP AUX channel is registered for both input > side options, and the DSI host is

Re: [PATCH 1/2] drm/bridge: tc358767: Factor out DSI and DPI RX enablement

2022-05-12 Thread Robert Foss
On Fri, 29 Apr 2022 at 22:56, Marek Vasut wrote: > > Factor out register programming to configure the chip video RX side for > reception of video data from DSI or DPI. This is particularly useful in > the (e)DP output mode, where the video data can be received from either > DPI or DSI. While only

Re: [PATCH v5] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

2022-05-12 Thread Kuogee Hsieh
On 5/11/2022 6:03 PM, Dmitry Baryshkov wrote: On Thu, 12 May 2022 at 04:01, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-05-11 17:41:50) On 12/05/2022 03:02, Kuogee Hsieh wrote: diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index af7a80c..f3e333e

Re: [PATCH libdrm] xf86drmMode: Create drmModeCreatePropertyBlobWithFlags

2022-05-12 Thread Simon Ser
Note, the headers in include/drm/ must be updated in a special manner from the kernel. See the README in the subdir for details.

[PATCH libdrm] xf86drmMode: Create drmModeCreatePropertyBlobWithFlags

2022-05-12 Thread Mark Yacoub
[Why] The kernel has support for creating a blob with flags, particularly write only flag. The user space should use libdrm library to make use of the blob flags. [How] Create drmModeCreatePropertyBlobWithFlags which has the same implementation as the existing drmModeCreatePropertyBlob but with a

Re: [PATCH] drm/meson: Fix refcount leak in meson_encoder_hdmi_init

2022-05-12 Thread Neil Armstrong
Hi, On 12/05/2022 14:38, Martin Blumenstingl wrote: On Wed, May 11, 2022 at 7:41 AM Miaoqian Lin wrote: of_find_device_by_node() takes reference, we should use put_device() to release it when not need anymore. Add missing put_device() in error path to avoid refcount leak. Fixes:

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-12 Thread Charan Teja Kalla
Thanks Christian for the comments!! On 5/11/2022 12:33 PM, Christian König wrote: > >> The single number approach, generated by atomic, wouldn't break the >> uapi, but that number won't give any meaningful information especially >> when this is targeted just for debug purpose. And just 'inode'

Re: [PATCH] drm: Create support for Write-Only property blob

2022-05-12 Thread Mark Yacoub
friendly ping :) On Tue, May 10, 2022 at 3:08 PM Mark Yacoub wrote: > > [Why] > User space might need to inject data into the kernel without allowing it > to be read again by any user space. > An example of where this is particularly useful is secret keys fetched > by user space and injected

Re: [PATCH] drm: Add a debug message when getting a prop is missing

2022-05-12 Thread Mark Yacoub
friendly ping :) On Tue, May 10, 2022 at 2:28 PM Mark Yacoub wrote: > > [Why] > If a connector property is attached but > drm_atomic_connector_get_property doesn't handle a case for it, > modeteset will crash with a segfault without. > > [How] > Add a debug message indicating that a connector

Re: [PATCH v4 10/15] drm/shmem-helper: Take reservation lock instead of drm_gem_shmem locks

2022-05-12 Thread Daniel Vetter
On Thu, May 12, 2022 at 09:29:35AM +0200, Christian König wrote: > Am 11.05.22 um 21:05 schrieb Daniel Vetter: > > [SNIP] > > > > > It's unclear to me which driver may ever want to do the mapping under > > > > > the dma_resv_lock. But if we will ever have such a driver that will > > > > > need >

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-12 Thread Daniel Vetter
On Thu, May 12, 2022 at 03:28:16PM +0200, Tomeu Vizoso wrote: > On 5/11/22 7:46 PM, Rob Clark wrote: > > On Wed, May 11, 2022 at 10:12 AM Daniel Vetter wrote: > > > > > > On Tue, 10 May 2022 at 22:26, Rob Clark wrote: > > > > > > > > On Tue, May 10, 2022 at 12:39 PM Jessica Zhang > > > >

Re: [PATCH] drm/msm/a6xx: Fix refcount leak in a6xx_gpu_init

2022-05-12 Thread Akhil P Oommen
On 5/12/2022 5:49 PM, Miaoqian Lin wrote: of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. a6xx_gmu_init() passes the node to of_find_device_by_node() and of_dma_configure(), of_find_device_by_node() will takes its

Re: [REPORT] syscall reboot + umh + firmware fallback

2022-05-12 Thread Theodore Ts'o
On Thu, May 12, 2022 at 08:18:24PM +0900, Byungchul Park wrote: > I have a question about this one. Yes, it would never been stuck thanks > to timeout. However, IIUC, timeouts are not supposed to expire in normal > cases. So I thought a timeout expiration means not a normal case so need > to

[LINUX PATCH 2/2] drm: xlnx: dsi: driver for Xilinx DSI Tx subsystem

2022-05-12 Thread Venkateshwar Rao Gannavarapu
The Xilinx MIPI DSI Tx Subsystem soft IP is used to display video data from AXI-4 stream interface. It supports upto 4 lanes, optional register interface for the DPHY and multiple RGB color formats. This is a MIPI-DSI host driver and provides DSI bus for panels. This driver also helps to

[LINUX PATCH 0/2] Add Xilinx DSI-Tx DRM driver

2022-05-12 Thread Venkateshwar Rao Gannavarapu
MIPI DSI TX subsystem allows you to quickly create systems based on the MIPI protocol. It interfaces between the video processing subsystems and MIPI-based displays. An internal high-speed physical layer design, D-PHY, is provided to allow direct connection to display peripherals. The subsystem

[LINUX PATCH 1/2] dt-bindings: display: xlnx: Add DSI 2.0 Tx subsystem documentation

2022-05-12 Thread Venkateshwar Rao Gannavarapu
This patch adds dt binding for Xilinx DSI TX subsystem. The Xilinx MIPI DSI (Display serial interface) Transmitter Subsystem implements the Mobile Industry Processor Interface (MIPI) based display interface. It supports the interface with the programmable logic (FPGA). Signed-off-by:

Re: [BUG] Warning and NULL-ptr dereference in amdgpu driver with 5.18

2022-05-12 Thread Alex Deucher
On Thu, May 12, 2022 at 4:35 AM Jörg Rödel wrote: > > On Tue, May 10, 2022 at 04:41:57PM -0400, Alex Deucher wrote: > > Does setting amdgpu.runpm=0 on the kernel command line in grub help? > > If so, that should fixed with: > >

Re: [PATCH , v4] media: mediatek: vcodec: Fix v4l2 compliance decoder cmd test fail

2022-05-12 Thread AngeloGioacchino Del Regno
Il 23/04/22 09:35, Yunfei Dong ha scritto: Will return -EINVAL using standard framework api when test stateless decoder with cmd VIDIOC_(TRY)DECODER_CMD. Disable them to adjust v4l2 compliance test for user driver(GStreamer/Chrome) won't use decoder cmd. Fixes: 8cdc3794b2e3 ("media: mtk-vcodec:

Patch "drm/amd/display/dc/gpio/gpio_service: Pass around correct dce_{version, environment} types" has been added to the 5.4-stable tree

2022-05-12 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amd/display/dc/gpio/gpio_service: Pass around correct dce_{version, environment} types to the 5.4-stable tree which can be found at:

Patch "drm/amd/display/dc/gpio/gpio_service: Pass around correct dce_{version, environment} types" has been added to the 4.19-stable tree

2022-05-12 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amd/display/dc/gpio/gpio_service: Pass around correct dce_{version, environment} types to the 4.19-stable tree which can be found at:

Patch "drm/amd/display/dc/gpio/gpio_service: Pass around correct dce_{version, environment} types" has been added to the 5.10-stable tree

2022-05-12 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amd/display/dc/gpio/gpio_service: Pass around correct dce_{version, environment} types to the 5.10-stable tree which can be found at:

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-12 Thread Tomeu Vizoso
On 5/11/22 7:46 PM, Rob Clark wrote: On Wed, May 11, 2022 at 10:12 AM Daniel Vetter wrote: On Tue, 10 May 2022 at 22:26, Rob Clark wrote: On Tue, May 10, 2022 at 12:39 PM Jessica Zhang wrote: On 5/10/2022 7:13 AM, Tomeu Vizoso wrote: And use it to store expectations about what the

Re: [PATCH v7 0/6] Proposal for a GPU cgroup controller

2022-05-12 Thread Nicolas Dufresne
Le mercredi 11 mai 2022 à 13:31 -0700, T.J. Mercier a écrit : > On Wed, May 11, 2022 at 6:21 AM Nicolas Dufresne wrote: > > > > Hi, > > > > Le mardi 10 mai 2022 à 23:56 +, T.J. Mercier a écrit : > > > This patch series revisits the proposal for a GPU cgroup controller to > > > track and

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-05-12 Thread Peter Geis
On Thu, May 12, 2022 at 8:17 AM Robin Murphy wrote: > > On 2022-05-08 17:53, Peter Geis wrote: > > On Sun, May 8, 2022 at 9:40 AM Piotr Oniszczuk > > wrote: > >> > >> > >> > >>> Wiadomość napisana przez Sascha Hauer w dniu > >>> 22.04.2022, o godz. 09:28: > >>> > >>> From: Michael Riesch >

Re: [PATCH] drm/meson: Fix refcount leak in meson_encoder_hdmi_init

2022-05-12 Thread Martin Blumenstingl
On Wed, May 11, 2022 at 7:41 AM Miaoqian Lin wrote: > > of_find_device_by_node() takes reference, we should use put_device() > to release it when not need anymore. > Add missing put_device() in error path to avoid refcount > leak. > > Fixes: 0af5e0b41110 ("drm/meson: encoder_hdmi: switch to

Re: [PATCH] drm/meson: Fix refcount leak in meson_encoder_hdmi_init

2022-05-12 Thread Neil Armstrong
On 11/05/2022 07:40, Miaoqian Lin wrote: of_find_device_by_node() takes reference, we should use put_device() to release it when not need anymore. Add missing put_device() in error path to avoid refcount leak. Fixes: 0af5e0b41110 ("drm/meson: encoder_hdmi: switch to bridge

[PATCH] drm/msm/a6xx: Fix refcount leak in a6xx_gpu_init

2022-05-12 Thread Miaoqian Lin
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. a6xx_gmu_init() passes the node to of_find_device_by_node() and of_dma_configure(), of_find_device_by_node() will takes its reference, of_dma_configure() doesn't need the

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-05-12 Thread Robin Murphy
On 2022-05-08 17:53, Peter Geis wrote: On Sun, May 8, 2022 at 9:40 AM Piotr Oniszczuk wrote: Wiadomość napisana przez Sascha Hauer w dniu 22.04.2022, o godz. 09:28: From: Michael Riesch Enable the RK356x Video Output Processor (VOP) 2 on the Radxa ROCK3 Model A. Signed-off-by:

[PATCH] video: fbdev: Fix refcount leak in clcdfb_of_vram_setup

2022-05-12 Thread Miaoqian Lin
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: d10715be03bd ("video: ARM CLCD: Add DT support") Signed-off-by: Miaoqian Lin --- drivers/video/fbdev/amba-clcd.c

Re: [PATCH v1 0/7] drm/bridge_connector: perform HPD enablement automatically

2022-05-12 Thread Dmitry Baryshkov
On 29/04/2022 21:51, Dmitry Baryshkov wrote: From all the drivers using drm_bridge_connector only iMX/dcss and OMAP DRM driver do a proper work of calling drm_bridge_connector_en/disable_hpd() in right places. Rather than teaching each and every driver how to properly handle

Re: [PATCH v2 2/2] drm/vkms: return early if compose_plane fails

2022-05-12 Thread Melissa Wen
On 04/15, Tales Lelo da Aparecida wrote: > Do not exit quietly from compose_plane. If any plane has an invalid > map, propagate the error value upwards. While here, add log messages > for the invalid index. > > Signed-off-by: Tales Lelo da Aparecida > --- > drivers/gpu/drm/vkms/vkms_composer.c

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-12 Thread Dmitry Osipenko
On 5/11/22 22:09, Daniel Vetter wrote: > On Wed, May 11, 2022 at 07:06:18PM +0300, Dmitry Osipenko wrote: >> On 5/11/22 16:09, Daniel Vetter wrote: >>> I'd like to ask you to reduce the scope of the patchset and build the >>> shrinker only for virtio-gpu. I know that I first suggested to

Re: [PATCH 1/5] dma-buf: cleanup dma_fence_unwrap selftest v2

2022-05-12 Thread Christian König
Hey Daniel, a gentle ping on this here. Those patches come before my drm-exec work, so would be nice if we could get that reviewed first. Thanks, Christian. Am 06.05.22 um 16:11 schrieb Christian König: I had to send this out once more. This time with the right mail addresses and a much

Re: [REPORT] syscall reboot + umh + firmware fallback

2022-05-12 Thread Byungchul Park
Tejun wrote: > Hello, Hello, > I'm not sure I'm reading it correctly but it looks like "process B" column I think you're interpreting the report correctly. > is superflous given that it's waiting on the same lock to do the same thing > that A is already doing (besides, you can't really halt

Re: [PATCH 7/7] drm/mgag200: Split up connector's mode_valid helper

2022-05-12 Thread Thomas Zimmermann
Hi Am 12.05.22 um 12:38 schrieb Jocelyn Falempe: On 09/05/2022 12:35, Thomas Zimmermann wrote: Split up the connector's mode_valid helper into a simple-pipe and a mode-config helper. The simple-pipe helper tests for display-size limits while the mode-config helper tests for memory-bandwidth

Re: [PATCH v2 3/4] soc: visconti: Add Toshiba Visconti AFFINE image processing accelerator

2022-05-12 Thread Hans Verkuil
On 4/27/22 15:23, Yuji Ishikawa wrote: > Adds support to AFFINE image processing accelerator on Toshiba Visconti ARM > SoCs. > This accelerator supoorts affine transform, lens undistortion and LUT > transform. > > Signed-off-by: Yuji Ishikawa > Reviewed-by: Nobuhiro Iwamatsu > --- > v1 -> v2:

Re: [PATCH] drm/meson: Fix refcount leak in meson_encoder_hdmi_init

2022-05-12 Thread Miaoqian Lin
Hi, On 2022/5/12 17:32, Neil Armstrong wrote: > Hi, > > On 12/05/2022 11:21, Miaoqian Lin wrote: >> of_find_device_by_node() takes a reference to the embedded struct device, >> we should use put_device() to release it when not need anymore. >> Add missing put_device() in error path to avoid

Re: [PATCH 0/4] Add Toshiba Visconti DNN image processing accelerator driver

2022-05-12 Thread Hans Verkuil
Hi Yuji, On 4/28/22 15:11, Yuji Ishikawa wrote: > This series is the DNN image processing accelerator driver for Toshiba's ARM > SoC, Visconti[0]. > This provides DT binding documentation, device driver, MAINTAINER files. > > The second patch "soc: visconti: Add Toshiba Visconti image

Re: (subset) [PATCH] MAINTAINERS: add Melissa to V3D maintainers

2022-05-12 Thread Melissa Wen
On 05/12, Maxime Ripard wrote: > On Fri, 29 Apr 2022 18:33:30 -0100, Melissa Wen wrote: > > I've been contributing to v3d through improvements, reviews, testing, > > debugging, etc. So, I'm adding myself as a co-maintainer of the V3D > > driver. > > > > > > Applied to drm/drm-misc

Re: [bug report] drm/msm: devcoredump iommu fault support

2022-05-12 Thread Dan Carpenter
On Mon, May 09, 2022 at 07:48:23AM -0700, Rob Clark wrote: > On Sun, May 8, 2022 at 11:28 PM Dan Carpenter > wrote: > > 407 } else { > > 408 /* > > 409 * We couldn't attribute this fault to any > > particular context, > > 410

Re: [PATCH 13/14] drm/vc4: crtc: Fix out of order frames during asynchronous page flips

2022-05-12 Thread Melissa Wen
On 05/09, Melissa Wen wrote: > O 05/09, Melissa Wen wrote: > > On 05/03, Maxime Ripard wrote: > > > When doing an asynchronous page flip (PAGE_FLIP ioctl with the > > > DRM_MODE_PAGE_FLIP_ASYNC flag set), the current code waits for the > > > possible GPU buffer being rendered through a call to > >

Re: [PATCH 7/7] drm/mgag200: Split up connector's mode_valid helper

2022-05-12 Thread Jocelyn Falempe
On 09/05/2022 12:35, Thomas Zimmermann wrote: Split up the connector's mode_valid helper into a simple-pipe and a mode-config helper. The simple-pipe helper tests for display-size limits while the mode-config helper tests for memory-bandwidth limits. Also add the mgag200_ prefix to

Re: [PATCH v2] mgag200: Enable atomic gamma lut update

2022-05-12 Thread Jocelyn Falempe
On 12/05/2022 10:52, Thomas Zimmermann wrote: Hi Am 11.05.22 um 17:28 schrieb Jocelyn Falempe: Add support for atomic update of gamma lut. With this patch the "Night light" feature of gnome3 is working properly on mgag200. v2:   - Add a default linear gamma function   - renamed functions with

[PATCH] drm/i915: Fix vm use-after-free in vma destruction

2022-05-12 Thread Thomas Hellström
In vma destruction, the following race may occur: Thread 1: Thread 2: i915_vma_destroy(); ... list_del_init(vma->vm_link); ... mutex_unlock(vma->vm->mutex); __i915_vm_release(); release_references(); And in release_reference() we

Re: [DKIM] [PATCH v12, 13/17] media: mediatek: vcodec: Extract H264 common code

2022-05-12 Thread Hans Verkuil
Hi Yunfei, On 5/12/22 04:19, Yunfei Dong wrote: > Mt8192 can use some of common code with mt8183. Moves them to > a new file in order to reuse. > > Signed-off-by: Yunfei Dong > Reviewed-by: Nicolas Dufresne > --- > .../media/platform/mediatek/vcodec/Makefile | 1 + >

Re: [PATCH] drm/meson: Fix refcount leak in meson_encoder_hdmi_init

2022-05-12 Thread Neil Armstrong
Hi, On 12/05/2022 11:21, Miaoqian Lin wrote: of_find_device_by_node() takes a reference to the embedded struct device, we should use put_device() to release it when not need anymore. Add missing put_device() in error path to avoid refcount leak. Fixes: 0af5e0b41110 ("drm/meson: encoder_hdmi:

[PATCH] drm/meson: Fix refcount leak in meson_encoder_hdmi_init

2022-05-12 Thread Miaoqian Lin
of_find_device_by_node() takes a reference to the embedded struct device, we should use put_device() to release it when not need anymore. Add missing put_device() in error path to avoid refcount leak. Fixes: 0af5e0b41110 ("drm/meson: encoder_hdmi: switch to bridge

Re: [REPORT] syscall reboot + umh + firmware fallback

2022-05-12 Thread Tejun Heo
Hello, Just took a look out of curiosity. On Thu, May 12, 2022 at 02:25:57PM +0900, Byungchul Park wrote: > PROCESS A PROCESS B WORKER C > > __do_sys_reboot() > __do_sys_reboot() > mutex_lock(_transition_mutex) > ... mutex_lock(_transition_mutex) <- stuck >

Re: (subset) [PATCH -next] drm/vc4: hdmi: Fix build error for implicit function declaration

2022-05-12 Thread Maxime Ripard
On Tue, 10 May 2022 21:51:48 +0800, Hui Tang wrote: > drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_connector_detect’: > drivers/gpu/drm/vc4/vc4_hdmi.c:228:7: error: implicit declaration of function > ‘gpiod_get_value_cansleep’; did you mean ‘gpio_get_value_cansleep’? >

Re: [PATCH 0/3] drm/client: Fix display-mode selection

2022-05-12 Thread Maxime Ripard
On Wed, May 11, 2022 at 08:31:22PM +0200, Thomas Zimmermann wrote: > Pick user-defined display mode in DRM clients if the mode has been > validated by the driver. Otherwise pick a preferred display mode. > > Booting the kernel with video= and giving an unsupported display > mode can easily turn

Re: [PATCH v2] mgag200: Enable atomic gamma lut update

2022-05-12 Thread Thomas Zimmermann
Hi Am 11.05.22 um 17:28 schrieb Jocelyn Falempe: Add support for atomic update of gamma lut. With this patch the "Night light" feature of gnome3 is working properly on mgag200. v2: - Add a default linear gamma function - renamed functions with mgag200 prefix - use format's 4cc code

Re: [BUG] Warning and NULL-ptr dereference in amdgpu driver with 5.18

2022-05-12 Thread Jörg Rödel
On Tue, May 10, 2022 at 04:41:57PM -0400, Alex Deucher wrote: > Does setting amdgpu.runpm=0 on the kernel command line in grub help? > If so, that should fixed with: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f95af4a9236695caed24fe6401256bb974e8f2a7

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-05-12 Thread Maxime Ripard
Hi Daniel, An update on this On Thu, Apr 28, 2022 at 02:09:40PM +0200, Daniel Vetter wrote: > > We integrated this in the (downstream) RaspberryPi kernel, and it seems > > to trigger some weird regressions: > > > > - If we move the cursor under X, the primary plane update is stuck: > >

Re: (subset) [PATCH] MAINTAINERS: add Melissa to V3D maintainers

2022-05-12 Thread Maxime Ripard
On Fri, 29 Apr 2022 18:33:30 -0100, Melissa Wen wrote: > I've been contributing to v3d through improvements, reviews, testing, > debugging, etc. So, I'm adding myself as a co-maintainer of the V3D > driver. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: [PATCH v9 18/22] drm/mediatek: Add mt8195 Embedded DisplayPort driver

2022-05-12 Thread Maxime Ripard
Hi, On Wed, May 11, 2022 at 05:59:13AM -0700, Guillaume Ranquet wrote: > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include >

Re: [PATCH v4 10/15] drm/shmem-helper: Take reservation lock instead of drm_gem_shmem locks

2022-05-12 Thread Christian König
Am 11.05.22 um 21:05 schrieb Daniel Vetter: [SNIP] It's unclear to me which driver may ever want to do the mapping under the dma_resv_lock. But if we will ever have such a driver that will need to map imported buffer under dma_resv_lock, then we could always add the dma_buf_vmap_locked()

Re: [PATCH 3/3] drm/client: Don't add new command-line mode

2022-05-12 Thread Javier Martinez Canillas
On 5/11/22 20:31, Thomas Zimmermann wrote: > Don't add a mode for the kernel's command-line parameters from > within the DRM client code. Doing so can result in an unusable > display. If there's no compatible command-line mode, the client > will use one of the connector's preferred modes. > > All

[PATCH] drm/amd/display: clean up some inconsistent indenting

2022-05-12 Thread Jiapeng Chong
Eliminate the follow smatch warning: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9687 amdgpu_dm_atomic_commit_tail() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 --- 1 file

Re: [PATCH 2/3] drm/client: Look for command-line modes first

2022-05-12 Thread Javier Martinez Canillas
On 5/11/22 20:31, Thomas Zimmermann wrote: > When picking a mode, first look for modes that have been specified > by the user on the kernel's command line. Only if that fails, use > the existing heuristic of picking a nearby mode from it's various > parameters. > > Signed-off-by: Thomas

  1   2   >