Resume is missing a locks on gt sleepable registers.
---
drivers/gpu/drm/i915/i915_suspend.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_suspend.c
b/drivers/gpu/drm/i915/i915_suspend.c
index 60a94d2..9259dcf 100644
---
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
intel/Makefile.am |3 ++-
intel/intel_debug.h | 44
2 files changed, 46 insertions(+), 1 deletions(-)
diff --git a/intel/Makefile.am b/intel/Makefile.am
index b6a9014..7a44aaf 100644
Version 2 of the patch series is pretty much the same as version 1. 2 of the
patches have already been picked up by the kernel and mesa so they are
gone.
The only major change is in mesa where I no longer load a binary blob
from an environment variable, but instead compile the bytes directly in
On Wed, Jul 13, 2011 at 01:51:42PM -0700, Ben Widawsky wrote:
Version 2 of the patch series is pretty much the same as version 1. 2 of the
patches have already been picked up by the kernel and mesa so they are
gone.
The only major change is in mesa where I no longer load a binary blob
This is the revised patch series for fragment shader debugging.
There is no major change, though of interest are:
* forcewaked acts more like a daemon
* forcewaked isn't needed for debugging only there for sample
* i915 detection is now done by stating i915_forcewake_user_lock
* register
Cc: Chris Wilson ch...@chris-wilson.co.uk
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
intel/Makefile.am |3 ++-
intel/intel_debug.h | 44
2 files changed, 46 insertions(+), 1 deletions(-)
diff --git a/intel/Makefile.am b/intel
On Tue, Jul 19, 2011 at 11:06:17PM +0200, Julien Cristau wrote:
On Wed, Jul 13, 2011 at 13:51:43 -0700, Ben Widawsky wrote:
+#define SHADER_DEBUG_SOCKET /tmp/gen_debug
Not sure what this is used for, but does it really need to be in /tmp?
It is the shared socket between a debug client (ie
On Thu, Jul 21, 2011 at 11:22:12PM +0200, Julien Cristau wrote:
On Thu, Jul 21, 2011 at 13:54:41 +, Ben Widawsky wrote:
On Tue, Jul 19, 2011 at 11:06:17PM +0200, Julien Cristau wrote:
On Wed, Jul 13, 2011 at 13:51:43 -0700, Ben Widawsky wrote:
+#define SHADER_DEBUG_SOCKET /tmp
On Wed, Jul 27, 2011 at 05:16:31PM +0200, Julien Cristau wrote:
On Wed, Jul 27, 2011 at 15:08:08 +, Ben Widawsky wrote:
On Thu, Jul 21, 2011 at 11:22:12PM +0200, Julien Cristau wrote:
On Thu, Jul 21, 2011 at 13:54:41 +, Ben Widawsky wrote:
On Tue, Jul 19, 2011 at 11:06:17PM
On Fri, Oct 07, 2011 at 07:00:42PM -0300, Eugeni Dodonov wrote:
This adds a new function intel_drm_get_valid_edid, which is used instead
of drm_get_edid within the i915 driver.
It does a similar check to the one in previous patch, but it is limited to
i915 driver.
The check is similar to
(32, l)
Acked-by: Ben Widawsky b...@bwidawsk.net
The forcewake increased size should have been fixed a bit with the
forcewake struct encapsulation patch I posted to intel-gfx mailing list.
Keith, if you take this, could you also look into that patch?
1315951648-5380-1-git-send-email-...@bwidawsk.net
Packard kei...@keithp.com
Cc: Ben Widawsky b...@bwidawsk.net
---
wfm Reviewed-by: Ben Widawsky b...@bwidawsk.net
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Cleanups recommended by Dave Airlie.
Cc: Keith Packard kei...@keithp.com
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/char/agp/intel-agp.h |6 ++
drivers/char/agp/intel-gtt.c |7 ---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/char/agp
On Tue, 1 Nov 2011 11:29:49 -0700
Ben Widawsky b...@bwidawsk.net wrote:
Cleanups recommended by Dave Airlie.
Cc: Keith Packard kei...@keithp.com
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/char/agp/intel-agp.h |6 ++
drivers/char/agp/intel-gtt.c |7 ---
2
this up further, so
instead of figuring out all the failure conditions pwrite can cause,
let's just go with
Acked-by: Ben Widawsky b...@bwidawsk.net
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
On Sun, 6 Nov 2011 20:13:49 +0100
Daniel Vetter daniel.vet...@ffwll.ch wrote:
... instead of get_user_pages, because that fails on non page-backed
user addresses like e.g. a gtt mapping of a bo.
To get there essentially copy the vfs read path into pagecache. We
can't call that right away
On Mon, Nov 21, 2011 at 05:02:44PM +0100, Daniel Vetter wrote:
On Sun, Nov 20, 2011 at 09:56:32PM -0800, Ben Widawsky wrote:
[snip the patch]
Bikeshed, but I would much prefer a #define for the swizzle
bit/cacheline size.
I've looked at this stuff way too long, so I'm biased, but 64
On Mon, Nov 21, 2011 at 09:55:07AM -0800, Ben Widawsky wrote:
On Mon, Nov 21, 2011 at 05:02:44PM +0100, Daniel Vetter wrote:
On Sun, Nov 20, 2011 at 09:56:32PM -0800, Ben Widawsky wrote:
[snip the patch]
Bikeshed, but I would much prefer a #define for the swizzle
bit/cacheline size
On Sun, Nov 06, 2011 at 08:13:53PM +0100, Daniel Vetter wrote:
Useful when the page is already mapped to copy date in/out.
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_cache.c | 23 +++
On Tue, Dec 06, 2011 at 12:12:33PM +0100, Daniel Vetter wrote:
The recursion loop goes retire_requests-unbind-gpu_idle-retire_reqeusts.
Every time we go through this we need a
- active object that can be retired
- and there are no other references to that object than the one from
the
On 12/16/2011 11:22 AM, Keith Packard wrote:
On Tue, 13 Dec 2011 19:26:50 +0100, Daniel Vetter dan...@ffwll.ch wrote:
On Tue, Dec 13, 2011 at 10:14:46AM -0800, Keith Packard wrote:
On Tue, 13 Dec 2011 10:14:15 -0500, Alex Villacís Lasso
a_villa...@palosanto.com wrote:
By using a bootable
On 01/05/2012 07:24 AM, Daniel Vetter wrote:
On Wed, Jan 04, 2012 at 07:35:41PM -0800, Keith Packard wrote:
Here are the rest of the 3.3 pending changes.
This has a bunch of small bug fixes and overlay plane support for i915.
The following changes since commit
On Wed, Jan 11, 2012 at 04:04:20PM -0500, Adam Jackson wrote:
On Wed, 2012-01-11 at 12:16 -0800, Eric Anholt wrote:
I remember at one point you had a plan along the lines of passing shmem
fds across the protocol. I'm curious what happened to that -- too hard
to get the passing to work,
From: Adam Jackson a...@redhat.com
This is about as minimal of a virtual GEM service as possible. My plan
is to use this with non-native-3D hardware for buffer sharing between X
and DRI.
The current drisw winsys assumes an unmodified X server, which means
it's hopelessly inefficient for both
:
git://people.freedesktop.org/~bwidawsk/vgem-gpu-tools master
I've also pushed this repo here:
git://people.freedesktop.org/~bwidawsk/drm-intel vgem
Adam Jackson (1):
drm/vgem: virtual GEM provider
Ben Widawsky (4):
drm/vgem: fops should be separate and constified
drm/vgem: Add
...or else it just won't build.
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/vgem/vgem_drv.c | 20 +++-
1 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index 82c6787..3084389
and use it
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/vgem/vgem_drv.c | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index 3084389..d47bd71 100644
--- a/drivers/gpu/drm
Similar to i915, it's nice to be able to query this device uniquely and
get some info
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/vgem/vgem_drv.c | 29 +
include/drm/vgem_drm.h | 11 +++
2 files changed, 32 insertions(+), 8
after I figure out if locking is actually required right now.
Hmm, and now that I think about it, mremap, and munmap may not work
either.
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/vgem/vgem_drv.c | 105 --
1 files changed, 99 insertions
On 02/09/2012 12:36 AM, Chris Wilson wrote:
On Thu, 9 Feb 2012 00:19:31 +0100, Ben Widawsky b...@bwidawsk.net wrote:
Mostly copied from i915 gtt mmaps, this will properly fault in pages as
the user tries to use them. The only thing of note are that no
prefaulting occurs, so perhaps some kind
On 02/09/2012 11:43 AM, Chris Wilson wrote:
In particular, declare the hidden CPU mmaps to valgrind so that it knows
about those memory regions.
References: https://bugs.freedesktop.org/show_bug.cgi?id=35071
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
Acked-by: Ben Widawsky b
On Fri, Feb 10, 2012 at 12:50:01PM -0500, Yufeng Shen wrote:
GMBUS has several ports and each has it's own corresponding
I2C adpater. When multiple I2C adapters call gmbus_xfer() at
the same time there is a race condition in using the underlying
GMBUS controller. Fixing this by adding a mutex
On Thu, 16 Feb 2012 07:23:52 +
Dave Airlie airl...@gmail.com wrote:
On Wed, Feb 15, 2012 at 9:22 PM, Adam Jackson a...@redhat.com wrote:
On 2/8/12 6:19 PM, Ben Widawsky wrote:
Similar to i915, it's nice to be able to query this device uniquely and
get some info
Signed-off-by: Ben
On Thu, 16 Feb 2012 05:52:12 -0800 (PST)
Jakob Bornecrantz ja...@vmware.com wrote:
- Original Message -
From: Adam Jackson a...@redhat.com
This is about as minimal of a virtual GEM service as possible. My
plan is to use this with non-native-3D hardware for buffer sharing
On Tue, 21 Feb 2012 11:08:52 -0500
Adam Jackson a...@redhat.com wrote:
On Tue, 2012-02-21 at 15:34 +, Dave Airlie wrote:
Not sure what you mean there, those 3 APIs are just to create dumb
unaccelerated objects,
probably are fine for vgem's use. For scanout we create framebuffer
From: Dave Airlie airl...@redhat.com
---
drivers/gpu/drm/Makefile|2 +-
drivers/gpu/drm/drm_drv.c |3 +
drivers/gpu/drm/drm_gem.c |3 +-
drivers/gpu/drm/drm_prime.c | 126 +++
include/drm/drm.h | 10 +++-
include/drm/drmP.h
better tests with just VGEM.
Adam Jackson (1):
drm/vgem: virtual GEM provider
Ben Widawsky (5):
drm: DRM_DEBUG_PRIME
drm: per device prime dma buf hash
drm/vgem: prime export support
drm/vgem: import support
drm: actually enable PRIME
Dave Airlie (1):
drm: base prime support
---
include/drm/drmP.h |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 9558111..5ed9b41 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -91,6 +91,7 @@ struct drm_device;
#define DRM_UT_CORE0x01
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
include/drm/drmP.h |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 9558111..5ed9b41 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -91,6 +91,7 @@ struct
]
Reviewed-by: Adam Jackson a...@redhat.com
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/Kconfig |8 +
drivers/gpu/drm/Makefile|1 +
drivers/gpu/drm/vgem/Makefile |4 +
drivers/gpu/drm/vgem/vgem_drv.c | 382
a lock introduced to help with the various ref count
dances (and subsequent hash list traversals).
Cc: Daniel Vetter daniel.vet...@ffwll.ch
Cc: Dave Airlie airl...@redhat.com
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/drm_gem.c |3 ++
drivers/gpu/drm/drm_prime.c | 46
dma-buf export implementation. Heavily influenced by Dave Airlie's proof
of concept work.
Cc: Daniel Vetter daniel.vet...@ffwll.ch
Cc: Dave Airlie airl...@redhat.com
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/vgem/Makefile |2 +-
drivers/gpu/drm/vgem
for detailed explanation.
Cc: Daniel Vetter daniel.vet...@ffwll.ch
Cc: Dave Airlie airl...@redhat.com
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/vgem/vgem_dma_buf.c | 120 +++
1 files changed, 120 insertions(+), 0 deletions(-)
diff --git
Enable prime in both Kconfig and vgem.
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/Kconfig |1 +
drivers/gpu/drm/vgem/vgem_drv.c |3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index
v3: Fix Ville pointed out using buffer + kmalloc
v4: add locking as per ickle review
v5: allow re-exporting the original dma-buf (Daniel)
Signed-off-by: Dave Airlie airl...@redhat.com
I swear there was some other reason for the global hash... if only I
could remember it.
Acked-by: Ben
).
--
Ben Widawsky, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
The kernel patches have now landed in Daniel's -next-queued tree.
Begin forwarded message:
Date: Fri, 11 May 2012 13:54:11 -0700
From: Ben Widawsky b...@bwidawsk.net
To: intel-...@lists.freedesktop.org
Cc: Ben Widawsky b...@bwidawsk.net
Subject: [Intel-gfx] [PATCH] intel: add a timed wait
On Wed, 30 May 2012 10:41:20 -0700
Eric Anholt e...@anholt.net wrote:
On Sun, 27 May 2012 13:16:54 -0700, Ben Widawsky b...@bwidawsk.net wrote:
diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
index b776d2f..695a449 100644
--- a/intel/intel_bufmgr_gem.c
+++ b/intel
we all agreed on for the color?
--
Ben Widawsky, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Setting myself up for a late night crying session once again. Most of the
people reading this probably know the history and reasons for the patches. If
not, you can search the intel-gfx mailing list to try to learn more. I won't
recap the whole thing here, and instead let the patches speak for
The patches have already been sucked in to the kernel. So we need a
placeholder for this IOCTL until the libdrm wait render patches land.
---
include/drm/i915_drm.h |1 +
1 file changed, 1 insertion(+)
diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
index af3ce17..6d9a9f1 100644
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
include/drm/i915_drm.h | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
index 6d9a9f1..0ca2d4f 100644
--- a/include/drm/i915_drm.h
+++ b/include/drm
Add an opaque type representing a HW context.
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
intel/intel_bufmgr.h |1 +
intel/intel_bufmgr_priv.h |5 +
2 files changed, 6 insertions(+)
diff --git a/intel/intel_bufmgr.h b/intel/intel_bufmgr.h
index c197abc..83a43cb 100644
To support this we extract the common execbuf2 functionality to be
called with, or without contexts.
The context'd execbuf does not support some of the dri1 stuff.
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
intel/intel_bufmgr.h |5 +
intel/intel_bufmgr_gem.c | 32
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
intel/intel_decode.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/intel/intel_decode.c b/intel/intel_decode.c
index bf23706..5f90a47 100644
--- a/intel/intel_decode.c
+++ b/intel/intel_decode.c
@@ -139,6
Based off of a patch from Ken Graunke. I just modified it for a more
modern mesa (also don't allow contexts on blit ring).
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
src/mesa/drivers/dri/i965/brw_context.c|1 +
src/mesa/drivers/dri/i965/brw_vtbl.c |5 -
src
On Mon, 4 Jun 2012 16:01:54 -0700
Paul Berry stereotype...@gmail.com wrote:
On 4 June 2012 14:43, Ben Widawsky b...@bwidawsk.net wrote:
Based off of a patch from Ken Graunke. I just modified it for a more
modern mesa (also don't allow contexts on blit ring).
Signed-off-by: Ben Widawsky
was far from comprehensive.
--
Ben Widawsky, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
run make headers_isntall on d-i-n, copy to here
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
include/drm/i915_drm.h |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
index af3ce17..725a8de 100644
--- a/include/drm
make headers_install in kernel. Copy to here.
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
include/drm/i915_drm.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
index 725a8de..1881f8a 100644
--- a/include/drm/i915_drm.h
int drm_intel_gem_bo_wait(drm_intel_bo *bo, uint64_t timeout_ns)
This should bump the libdrm version. We're waiting for context support
so we can do both features in one bump.
v2: don't return remaining timeout amount
use get param and fallback for older kernels
Signed-off-by: Ben Widawsky b
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
intel/intel_bufmgr.h |1 +
intel/intel_bufmgr_gem.c | 30 ++
2 files changed, 31 insertions(+)
diff --git a/intel/intel_bufmgr.h b/intel/intel_bufmgr.h
index c197abc..10ccc25 100644
--- a/intel/intel_bufmgr.h
make headers_install in kernel. Copy to here.
v2: signed ns_timeout
Cc: Chris Wilson ch...@chris-wilson.co.uk
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
include/drm/i915_drm.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/drm/i915_drm.h b/include/drm
prototypes now have a signed input value
Cc: Chris Wilson ch...@chris-wilson.co.uk
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
intel/intel_bufmgr.h |1 +
intel/intel_bufmgr_gem.c | 30 ++
2 files changed, 31 insertions(+)
diff --git a/intel
On Tue, 5 Jun 2012 15:42:39 -0700
Ben Widawsky b...@bwidawsk.net wrote:
make headers_install in kernel. Copy to here.
v2: signed ns_timeout
Cc: Chris Wilson ch...@chris-wilson.co.uk
Signed-off-by: Ben Widawsky b...@bwidawsk.net
This has been pushed with IRC
Acked-by Kenneth Graunke kenn
On Tue, 5 Jun 2012 11:58:11 -0700
Ben Widawsky b...@bwidawsk.net wrote:
run make headers_isntall on d-i-n, copy to here
Signed-off-by: Ben Widawsky b...@bwidawsk.net
This has been pushed with IRC
Acked-by Kenneth Graunke kenn...@whitecape.org
---
include/drm/i915_drm.h |4 +++-
1
Anyone aware of what this will break? It seems to be a much nicer thing
to do for callers. If people do not like it, I will probably just create
a #define drmIoctl2 or some such thing.
Cc: Daniel Vetter daniel.vet...@ffwll.ch
Cc: Keith Packard kei...@keithp.com
Signed-off-by: Ben Widawsky b
On Thu, 7 Jun 2012 09:10:08 +0200
Daniel Vetter dan...@ffwll.ch wrote:
On Wed, Jun 06, 2012 at 04:42:11PM -0700, Ben Widawsky wrote:
int drm_intel_gem_bo_wait(drm_intel_bo *bo, uint64_t timeout_ns)
This should bump the libdrm version. We're waiting for context support
so we can do both
also return -ETIME.
Cc: Eric Anholt e...@anholt.net
Cc: Daniel Vetter daniel.vet...@ffwll.ch
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
intel/intel_bufmgr.h |1 +
intel/intel_bufmgr_gem.c | 57 ++
2 files changed, 58 insertions(+)
diff
On Tue, 05 Jun 2012 16:37:20 -0700
Kenneth Graunke kenn...@whitecape.org wrote:
On 06/04/2012 02:42 PM, Ben Widawsky wrote:
Setting myself up for a late night crying session once again. Most of the
people reading this probably know the history and reasons for the patches.
If
not, you
evicted.
I am not aware of a good way to test it's effectiveness
performance-wise; but it introduces no regressions with piglit on my
ILK, or SNB.
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
intel/intel_bufmgr_gem.c | 46 ++
1 file changed, 34
On Tue, 19 Jun 2012 09:22:03 +0100
Chris Wilson ch...@chris-wilson.co.uk wrote:
On Mon, 18 Jun 2012 20:38:15 -0700, Ben Widawsky b...@bwidawsk.net wrote:
The history on this patch goes back quite a way. This time around, the
patch builds on top of the map_unsynchronized that Eric pushed
get rid of the data arg
(file), but otherwise this is
Reviewed-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/i915/i915_gem_context.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_context.c
b/drivers/gpu/drm/i915
The logic seemed to be inverse to me.
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
intel/intel_decode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/intel/intel_decode.c b/intel/intel_decode.c
index c9bfee4..eac48c3 100644
--- a/intel/intel_decode.c
+++ b/intel
two instances of
warning: cannot optimize loop, the loop counter may overflow
[-Wunsafe-loop-optimizations]
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
intel/intel_decode.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/intel/intel_decode.c b/intel/intel_decode.c
On Wed, 27 Jun 2012 10:02:35 -0700
Eric Anholt e...@anholt.net wrote:
Ben Widawsky b...@bwidawsk.net writes:
The logic seemed to be inverse to me.
Signed-off-by: Ben Widawsky b...@bwidawsk.net
Reviewed-by: Eric Anholt e...@anholt.net
This patch was bonghits :-(
My bad, I've fixed
git send-email doesn't appear to be doing the right thing.
Begin forwarded message:
Date: Fri, 29 Jun 2012 11:17:47 -0700
From: Ben Widawsky b...@bwidawsk.net
To: xorg-annou...@lists.freedesktop.org
Cc: mesa-...@lists.freedesktop.org, intel-...@lists.freedesktop.org,
dri-devel
On Fri, 29 Jun 2012 11:48:29 -0700
Ben Widawsky b...@bwidawsk.net wrote:
git send-email doesn't appear to be doing the right thing.
Begin forwarded message:
Date: Fri, 29 Jun 2012 11:17:47 -0700
From: Ben Widawsky b...@bwidawsk.net
To: xorg-annou...@lists.freedesktop.org
Cc: mesa
@@
* IN THE SOFTWARE.
*/
+#define _GNU_SOURCE
+
#include string.h
#include stdlib.h
#include stdio.h
I can't reproduce this. Can anyone else confirm this is broken, and if
so that the above patch fixes it?
--
Ben Widawsky, Intel Open Source Technology Center
The link generated by the release script was incorrect. They should be
http://dri.freedesktop.org/libdrm/libdrm-2.4.37.tar.gz
http://dri.freedesktop.org/libdrm/libdrm-2.4.37.tar.bz2
On Fri, 29 Jun 2012 11:17:47 -0700
Ben Widawsky b...@bwidawsk.net wrote:
I botched the 2.3.36 release quite
On Tue, 3 Jul 2012 12:21:27 +0300
Lauri Kasanen c...@gmx.com wrote:
On Mon, 2 Jul 2012 14:54:58 -0700
Ben Widawsky b...@bwidawsk.net wrote:
+#define _GNU_SOURCE
+
#include string.h
#include stdlib.h
#include stdio.h
I can't reproduce this. Can anyone else confirm
On 2012-08-02 00:20, James Bottomley wrote:
On Wed, 2012-08-01 at 22:08 -0700, bwidawsk wrote:
On 2012-08-01 03:06, Chris Wilson wrote:
On Wed, 01 Aug 2012 10:38:36 +0100, James Bottomley
james.bottom...@hansenpartnership.com wrote:
On Wed, 2012-08-01 at 09:58 +0100, Chris Wilson wrote:
On
with the old macro.
In any case, I think this warrants further review.
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/i915/i915_drv.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
On Mon, 6 Aug 2012 12:31:31 -0700
Ben Widawsky b...@bwidawsk.net wrote:
While trying to track down the power regression, I noticed that on my
SNB I had more severe problems, ie. forcewake seemed to never happen
once i915 was loaded. After a bit of bisection, I tracked the bad commit
by default on SNB
Because of an apparent bug causing a GPU hang.
I think this is what gave me the power savings in 3.4 when the PCI
layer
was ready for it.
It got re-enabled accidentally in 3.5 by a mismerge of
commit 2911a35b2e4eb87ec48d03aeb11f019e51ae3c0d
Author: Ben Widawsky b...@bwidawsk.net
= port | GMBUS_RATE_100KHZ;
/* gmbus seems to be broken on i830 */
- if (IS_I830(dev))
+ if (1)
bus-force_bit = true;
intel_gpio_setup(bus, port);
--
Ben Widawsky, Intel Open Source Technology Center
On 2012-09-01 12:22, Chris Wilson wrote:
On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky b...@bwidawsk.net
wrote:
I have no problem with Daniel's patch. It's just a matter of cutting
through some scheduler BS of when the GPU wants to change
frequency
vs. when we actually change the GPU
On 2012-09-01 12:14, Daniel Vetter wrote:
On Sat, Sep 1, 2012 at 8:35 PM, Ben Widawsky b...@bwidawsk.net
wrote:
On 2012-09-01 11:28, Arjan van de Ven wrote:
On 9/1/2012 11:26 AM, Ben Widawsky wrote:
On 2012-08-30 04:26, Daniel Vetter wrote:
We've had and still have too many issues where
On 2012-09-01 19:44, Arjan van de Ven wrote:
On 9/1/2012 6:36 PM, Ben Widawsky wrote:
It depends on what you're trying to measure. I think this patch is
quite useful but I think I'll make you defend your patch now since
you're the maintainer and you took
your own patch and you're shooting
On 2012-09-01 20:06, Arjan van de Ven wrote:
On 9/1/2012 8:05 PM, Ben Widawsky wrote:
, from a single trace event you should know the current frequency
and the previous frequency.
but if you're doing a heavy game or whatever... you may stay at the
highest all the time,
and I get no information
.
--
Ben Widawsky, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
On Sun, 9 Sep 2012 12:42:55 -0700
Ben Widawsky b...@bwidawsk.net wrote:
On the Intel driver we've developed and reviewed some patches which
enable GPU frequency settings in sysfs. Similar interfaces have
existed for some time in our debugfs, but now we're getting interest
from users like
/staging/omapdrm/omap_atomic.c
create mode 100644 drivers/staging/omapdrm/omap_atomic.h
--
1.7.9.5
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ben Widawsky, Intel Open
Wu, Yuanhan Liu Intel Corporation
Darn. I'll send a patch to the list tonight. (It's weird because I
thought I tested this).
--
Ben Widawsky, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel
Somehow this hunk got dropped from my last patch. We do not have the
rc6_attrs when there is no CONFIG_PM so this causes a compilation error.
Reported-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/i915/i915_sysfs.c | 2 ++
1 file
Google should be able to find something.
--
Ben Widawsky, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
drivers/gpu/drm/i915/i915_drv.h:1545:2: warning: '__f' is static but
declared in inline function 'i915_gem_chipset_flush' which is not static
Reported-by: kbuild test robot fengguang...@intel.com
dri-devel-Reference: 50a4d41c.586vhmwghpukzbkb%fengguang...@intel.com
Signed-off-by: Ben Widawsky
'
Found by Fenguang's 0-DAY kernel build testing
Recommend to squash this in to, since it is not on an upstream branch
yet.
commit 00fc2c3c53d7bfc9a29e5f4bdf2677f0c399f3bc
Author: Ben Widawsky b...@bwidawsk.net
Date: Thu Jan 17 12:45:14 2013 -0800
drm/i915: Remove gtt_mappable_total
Cc: dri
to Dan for catching this. /me hides
Cc: sta...@kernel.org
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Ben Widawsky b...@bwidawsk.net
---
drivers/gpu/drm/i915/i915_reg.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b
, asize - usize);
}
Sorry if these are stupid questions.
--
Ben Widawsky, Intel Open Source Technology Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
1 - 100 of 371 matches
Mail list logo
