Re: [PATCH v2 6/6] drm/tinydrm: Embed the mode in tinydrm_connector

On 01/09/2018 08:05 AM, Noralf Trønnes wrote: Den 09.01.2018 11.08, skrev Daniel Vetter: On Mon, Jan 08, 2018 at 07:46:27PM -0600, David Lechner wrote: On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary

Re: [PATCH v2 6/6] drm/tinydrm: Embed the mode in tinydrm_connector

On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary use of ret variable at the end of tinydrm_display_pipe_init(). Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Reviewed-by: David Lechn

Re: [PATCH v2 5/6] drm/tinydrm/mi0283qt: Let the display pipe handle power

viewed-by: David Lechner <da...@lechnology.com> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 3/6] drm/tinydrm/mipi-dbi: Add mipi_dbi_enable_flush()

On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Add and use a function for enabling, flushing and turning on backlight. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Reviewed-by: David Lechner <da...@lechnology.com> ___ dri-d

Re: [PATCH v2 4/6] drm/tinydrm/mipi-dbi: Add poweron-reset functions

On 01/08/2018 07:38 PM, David Lechner wrote: On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Split out common poweron-reset functionality. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> ---   drivers/gpu/drm/tinydrm/mi0283qt.c | 20 ++--   drivers/gpu/drm/tinydrm/mipi-dbi.

Re: [PATCH v3 7/7] drm/tinydrm/mipi-dbi: Change reset active time

return; gpiod_set_value_cansleep(mipi->reset, 0); - msleep(20); + usleep_range(20, 1000); gpiod_set_value_cansleep(mipi->reset, 1); msleep(120); } Reviewed-by: David Lechner <da...@lechnology.com> Tested-by: David Lechner <

Re: [PATCH v3 4/7] drm/tinydrm/mipi-dbi: Add poweron-reset functions

pipe); void mipi_dbi_hw_reset(struct mipi_dbi *mipi); bool mipi_dbi_display_is_on(struct mipi_dbi *mipi); +int mipi_dbi_poweron_reset(struct mipi_dbi *mipi); +int mipi_dbi_poweron_conditional_reset(struct mipi_dbi *mipi); u32 mipi_dbi_spi_cmd_max_speed(struct spi_device *spi, size_t len); i

[PATCH v2] drm: drm_memory: fix compiler warning on 32-bit targets

"drm: add func to get max iomem address v2") Signed-off-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/drm_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c index 7ca500b..3c54044 10

Re: [PATCH] drm: drm_memory: fix compiler warning on 32-bit targets

On 02/19/2018 05:00 PM, David Lechner wrote: The end field of struct resource is unsigned long, so on 32-bit targets, this is a 32-bit value. This results in a compiler warning of "warning: comparison of distinct pointer types lacks a cast". Fix it by making max_iomem unsigned lon

[PATCH] drm/tinydrm: Allocate dummy SPI RX buffer if needed

. in mipi_dbi_init()). Cc: Noralf Trønnes <nor...@tronnes.org> Suggested-by: Noralf Trønnes <nor...@tronnes.org> Signed-off-by: David Lechner <da...@lechnology.com> --- This is a follow up from the mail thread "tinydrm: page allocation failure" [1]. I actually got an allocation f

[PATCH] drm: drm_memory: fix compiler warning on 32-bit targets

t;drm: add func to get max iomem address v2") Signed-off-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/drm_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c index 7ca500b..597f496 10

[PATCH 0/3] update compatible string for ILI9225

This updates the device tree compatible string for an ILI9225 display. Detailed explanation is in the patches. David Lechner (3): dt-bindings: Add "vot" vendor prefix dt-bindings: update compatible string for ILI9225 drm/tinydrm: Update ILI9225 compatible string Documentation/

[PATCH 2/3] dt-bindings: update compatible string for ILI9225

fig", "vendor,ip-part"; [1]: https://patchwork.ozlabs.org/patch/839352/ [2]: https://patchwork.ozlabs.org/patch/843576/ Signed-off-by: David Lechner <da...@lechnology.com> --- Documentation/devicetree/bindings/display/ilitek,ili9225.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[PATCH 3/3] drm/tinydrm: Update ILI9225 compatible string

so the actual vendor and model name are now known. This previous bindings have not made it to the mainline kernel yet, so this is not breaking backwards compatibility. Signed-off-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/tinydrm/ili9225.c | 4 ++-- 1 file changed, 2 inser

[PATCH 1/3] dt-bindings: Add "vot" vendor prefix

This adds a vendor prefix "vot" for Vision Optical Technology Co., Ltd. They make LCD displays. Signed-off-by: David Lechner <da...@lechnology.com> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/dev

[PATCH] drm: fix tainted kernel caused by drm_panel_orientation_quirks.c

drm_panel_orientation_quirks.c introduced in commit 404d1a3edc38 ("drm: Add panel orientation quirks, v6.") taints the kernel when compiled as a module. Fix this by adding MODULE_LICENSE(). Signed-off-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/drm_panel_orientat

[PATCH v3 3/3] drm/tinydrm: add driver for ST7735R panels

This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner <da...@lechnology.com> --- v3 changes: * Changed compatible string * use SPDX license header * Renamed mode struct to use panel name instead of

[PATCH v3 0/3] DRM driver for Sitronix ST7735R display panels

tring in DT bindings (dropped ACK because of this) * Use SPDX license ID David Lechner (3): dt-bindings: add jianda vendor prefix dt-bindings: Add binding for Sitronix ST7735R display panels drm/tinydrm: add driver for ST7735R panels .../bindings/display/sitronix,st7735r.txt

[PATCH v3 2/3] dt-bindings: Add binding for Sitronix ST7735R display panels

This adds a new device tree binding for Sitronix ST7735R display panels, such as the Adafruit 1.8" TFT. Signed-off-by: David Lechner <da...@lechnology.com> --- v3 changes: * compatible string is changed from "sitronix,st7735r-jd-t18003-t01" to "jianda,jd-t18003-t0

[PATCH v3 1/3] dt-bindings: add jianda vendor prefix

This adds a vendor prefix "jianda" for Jiandangjing Technology Co., Ltd. Signed-off-by: David Lechner <da...@lechnology.com> --- v3 changes: * new patch in v3 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Document

Re: [PATCH v3 3/3] drm/tinydrm: add driver for ST7735R panels

On 12/21/2017 01:23 PM, David Lechner wrote: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner <da...@lechnology.com> --- + mipi_dbi_command(mipi, ST7735R_GAMCTRP1, 0x0f, 0x1a, 0x0f,

[PATCH v4 1/3] dt-bindings: add jianda vendor prefix

This adds a vendor prefix "jianda" for Jiandangjing Technology Co., Ltd. Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Rob Herring <r...@kernel.org> --- v4 changes: * Fixed alphabetical order v3 changes: * new patch in v3 Documentation/devi

Re: tinydrm: page allocation failure

On 12/14/2017 01:55 PM, Noralf Trønnes wrote: Den 14.12.2017 17.25, skrev David Lechner: On 12/11/2017 06:45 AM, Noralf Trønnes wrote: Den 11.12.2017 04.28, skrev David Lechner: I'm using drm-misc/drm-misc-next and occasionally getting errors as seen in the stack traces below. I'm

[PATCH v4 0/3] DRM driver for Sitronix ST7735R display panels

refix on panel-specific functions/structs to panel prefix instead of controller * Use gamma curve from Adafruit's Arduino library. v3 changes: * New patch for jianda vendor prefix * Change compatible string in DT bindings (dropped ACK because of this) * Use SPDX license ID David Lechner (3): dt-bin

[PATCH v4 2/3] dt-bindings: Add binding for Sitronix ST7735R display panels

This adds a new device tree binding for Sitronix ST7735R display panels, such as the Adafruit 1.8" TFT. Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Rob Herring <r...@kernel.org> --- v4 changes: * none v3 changes: * compatible string is changed from &qu

[PATCH v4 3/3] drm/tinydrm: add driver for ST7735R panels

This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Noralf Trønnes <nor...@tronnes.org> --- v4 changes: * renamed st7735r_pipe_enable to jd_t18003_t01_pipe

Re: [PATCH] drm/tinydrm: add backlight dependency for ili9341

On 07/10/2018 10:55 AM, Noralf Trønnes wrote: Anyways, thanks for fixing this: Acked-by: Noralf Trønnes David Lechner do you apply this? Noralf. Yes, I will pick it up. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https

Re: [PATCH] drm/tinydrm: Fix doc build warnings

' drivers/gpu/drm/tinydrm/mipi-dbi.c:272: warning: Function parameter or member 'plane_state' not described in 'mipi_dbi_enable_flush' Move struct member docs inline so it's not missed next time. Cc: David Lechner Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/mipi-dbi.c | 2

Re: [PATCH] drm/tinydrm: Fix doc build warnings

On 07/10/2018 11:31 AM, Noralf Trønnes wrote: Den 10.07.2018 18.18, skrev David Lechner: On 07/10/2018 10:05 AM, Noralf Trønnes wrote: include/drm/tinydrm/tinydrm.h:34: warning: Function parameter or member 'fb_dirty' not described in 'tinydrm_device' drivers/gpu/drm/tinydrm/mipi-dbi.c:272

Re: [PATCH] drm/tinydrm: Fix doc build warnings

On 07/10/2018 12:09 PM, Noralf Trønnes wrote: Den 10.07.2018 18.40, skrev David Lechner: On 07/10/2018 11:31 AM, Noralf Trønnes wrote: Den 10.07.2018 18.18, skrev David Lechner: On 07/10/2018 10:05 AM, Noralf Trønnes wrote: include/drm/tinydrm/tinydrm.h:34: warning: Function parameter

Re: [PATCH] drm/tinydrm: add backlight dependency for ili9341

On 07/09/2018 10:20 AM, Arnd Bergmann wrote: This tinydrm driver fails to link without the backlight support: drivers/gpu/drm/tinydrm/ili9341.o: In function `ili9341_probe': ili9341.c:(.text+0x578): undefined reference to `devm_of_find_backlight' Fixes: 3fa0e8f6f960 ("drm/tinydrm: new driver

[PATCH] drm/tilcdc: Fix setting clock divider for omap-l138

clock rate. Tested working on a TI OMAP-L138 LCDK board. Signed-off-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c

Re: [PATCH 2/9] drm: Move simple_display_pipe prepare_fb helper into gem fb helpers

;maarten.lankho...@linux.intel.com> Cc: Sean Paul <seanp...@chromium.org> Cc: David Airlie <airl...@linux.ie> Cc: David Lechner <da...@lechnology.com> Cc: "Noralf Trønnes" <nor...@tronnes.org> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Shawn Guo <shawn..

Re: [PATCH 1/2] drm/simple-kms-helper: Plumb plane state to the enable hook

On 03/27/2018 05:07 AM, Ville Syrjälä wrote: On Sat, Mar 24, 2018 at 12:26:32PM -0500, David Lechner wrote: On 03/22/2018 03:27 PM, Ville Syrjala wrote: From: Ville Syrjälä <ville.syrj...@linux.intel.com> We'll need access to the plane state during .atomic_enable(). Some more d

Re: [PATCH v2 2/2] drm/tinydrm: Make fb_dirty into a lower level hook

e'll just stick it into tinydrm_device directly for now. v2: Deal with the fb->dirty() in tinydrm_display_pipe_update() as weel (Noralf) Cc: "Noralf Trønnes" <nor...@tronnes.org> Cc: David Lechner <da...@lechnology.com> Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> R

Re: [PATCH 1/2] drm/simple-kms-helper: Plumb plane state to the enable hook

On 03/22/2018 03:27 PM, Ville Syrjala wrote: From: Ville Syrjälä We'll need access to the plane state during .atomic_enable(). Some more details in the commit message would be useful. It is not clear to me why this change is being made.

Re: [PATCH v5 5/5] drm/tinydrm: Switch from CMA to shmem buffers

can do dma on is_vmalloc() addresses making this >> possible. >> >> Cc: David Lechner >> Signed-off-by: Noralf Trønnes >> Acked-by: David Lechner >> Tested-by: David Lechner >> --- > > David, > FYI This series is scratched. > See the shmem hel

Re: [PATCH v2 13/14] drm/tinydrm: do not reply on drmP.h from drm_gem_cma_helper.h

tinydrm/ for this add dependencies that othwewise was pulled in by drmP.h from drm_gem_cma_helper.h To avoid that tinydrm.h became "include everything", push include files to the individual drivers. Signed-off-by: Sam Ravnborg Cc: "Noralf Trønnes" Cc: David Airlie Cc: Eric Anhol

Re: [PATCH v1 7/7] drm: remove include of drmP.h from drm_gem_cma_helper.h

On 12/26/18 3:03 PM, Sam Ravnborg wrote: Fix fallout in various files/drivers. What fallout is being fixed? It would be helpful if we received the full patch series for context. It would also be nice to have a more detailed description in this commit message.

Re: [PATCH v3 4/5] drm/tinydrm: Use damage helper for dirtyfb

ili9225_init() equal to mipi_dbi_init() so use it. v3: Include vblank header (Sam) ili9225 and st7586 can't use mipi_dbi_enable_flush() (David) v2: Remove fb check in mipi_dbi_enable_flush() it can't be NULL (kbuild test robot) Cc: David Lechner Cc: Eric Anholt Signed-off-by: Noralf

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

On 1/14/19 10:13 AM, Noralf Trønnes wrote: I see that you have this call chain: st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty(). That doesn't look safe. The st7586 driver allocates a tx_buf with size: size_t bufsize = (mode->vdisplay + 2) / 3 * mode->hdisplay;

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

On 1/14/19 3:50 PM, David Lechner wrote: On 1/14/19 10:13 AM, Noralf Trønnes wrote: I see that you have this call chain: st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty(). That doesn't look safe. The st7586 driver allocates a tx_buf with size: size_t bufsize =

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

On 1/14/19 4:43 PM, Noralf Trønnes wrote: Den 14.01.2019 23.33, skrev David Lechner: On 1/14/19 3:50 PM, David Lechner wrote: On 1/14/19 10:13 AM, Noralf Trønnes wrote: I see that you have this call chain: st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

On 1/14/19 4:53 PM, Noralf Trønnes wrote: Den 14.01.2019 23.33, skrev David Lechner: On 1/14/19 3:50 PM, David Lechner wrote: On 1/14/19 10:13 AM, Noralf Trønnes wrote: I see that you have this call chain: st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

ili9225_init() equal to mipi_dbi_init() so use it. v2: Remove fb check in mipi_dbi_enable_flush() it can't be NULL (kbuild test robot) Cc: David Lechner Cc: Eric Anholt Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg Acked-by: Daniel Vetter --- ... diff --git a/drivers/gpu/drm

Re: [PATCH 4/4] drm/tinydrm: Use damage helper for dirtyfb

ili9225_init() equal to mipi_dbi_init() so use it. Cc: David Lechner Cc: Eric Anholt Signed-off-by: Noralf Trønnes --- ... +static void ili9225_pipe_update(struct drm_simple_display_pipe *pipe, + struct drm_plane_state *old_state) +{ + struct drm_plane_state

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

On 1/13/19 3:19 PM, David Lechner wrote: On 1/11/19 2:12 PM, Noralf Trønnes wrote: This switches to drm_atomic_helper_dirtyfb() as the framebuffer dirty handler. All flushing will now happen in the pipe functions. Also enable the damage plane property for all except repaper which can only do

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

ili9225_init() equal to mipi_dbi_init() so use it. v2: Remove fb check in mipi_dbi_enable_flush() it can't be NULL (kbuild test robot) Cc: David Lechner Cc: Eric Anholt Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg Acked-by: Daniel Vetter --- Tested-by: David Lechner Reviewed

Re: [PATCH v3 1/2] drm: Add library for shmem backed GEM objects

On 09/11/2018 07:43 AM, Noralf Trønnes wrote: This adds a library for shmem backed GEM objects with the necessary drm_driver callbacks. Signed-off-by: Noralf Trønnes --- ... +static int drm_gem_shmem_vmap_locked(struct drm_gem_shmem_object *shmem) +{ + struct drm_gem_object *obj =

Re: [PATCH v3 2/2] drm/tinydrm: Switch from CMA to shmem buffers

On 09/11/2018 07:44 AM, Noralf Trønnes wrote: This move makes tinydrm useful for more drivers. tinydrm doesn't need continuous memory, but at the time it was convenient to use the CMA library. The spi core can do dma on is_vmalloc() addresses making this possible. Cc: David Lechner Signed-off

Re: [PATCH 2/4] drm/tiny/ili9341: Move driver to drm/panel

On 8/1/19 8:52 AM, Noralf Trønnes wrote: Move the driver to drm/panel and take advantage of the new panel support in drm_mipi_dbi. Change the file name to match the naming standard in drm/panel. The DRM driver name is kept since it is ABI. Add missing MAINTAINERS entry. Cc: David Lechner

Re: [4/4] drm/panel/ili9341: Support DPI panels

On 8/1/19 8:52 AM, Noralf Trønnes wrote: Add support for panels that use the DPI interface. ILI9341 has onboard RAM so the assumption made here is that all such panels support pixel upload over DBI. The presence/absense of the Device Tree 'port' node decides which interface is used for pixel

Re: [PATCH 3/4] drm/tiny/mi0283qt: Move driver to panel-ilitek-ili9341

On 8/1/19 8:52 AM, Noralf Trønnes wrote: The MI0283QT panels use a ILI9341 controller so it makes sense to merge it with the other ili9341 code. The DRM driver name is ABI, so that is retained. Cc: David Lechner Signed-off-by: Noralf Trønnes --- ... @@ -216,6 +339,10 @@ static int

Re: [PATCH v2 3/9] drm/tinydrm: Rename remaining variable mipi -> dbidev

the variable name 'mipi' but this is not a good name since MIPI refers to a lot of standards. This patch changes the variable name to 'dbidev' where it refers to the pipeline part of struct mipi_dbi. Cc: Eric Anholt Cc: David Lechner Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- Acked

Re: [PATCH v2 10/11] drm/tinydrm/mipi-dbi: Add mipi_dbi_init_with_formats()

since it only supports one format. v2: Forgot to remove the mipi->rotation assignment in st7586, mipi_dbi_init_with_formats() handles it. Cc: David Lechner Acked-by: David Lechner Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/mipi-dbi.c |

Re: [PATCH v2 4/9] drm/tinydrm: Split struct mipi_dbi in two

out. Rename functions to match the new struct mipi_dbi_dev: - drm_to_mipi_dbi() -> drm_to_mipi_dbi_dev(). - mipi_dbi_init*() -> mipi_dbi_dev_init*(). Cc: Eric Anholt Cc: David Lechner Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- Acked-by: David L

Re: [PATCH v2 2/9] drm/tinydrm: Rename variable mipi -> dbi

: Eric Anholt Cc: David Lechner Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 7/9] drm/tinydrm/mipi-dbi: Select DRM_KMS_HELPER

On 7/22/19 5:43 AM, Noralf Trønnes wrote: mipi-dbi uses several KMS helper functions but that build dependency is not expressed. Select DRM_KMS_HELPER to fix that. Reported-by: kbuild test robot Signed-off-by: Noralf Trønnes --- Reviewed-by: David Lechner

Re: [PATCH v2 8/9] drm/tinydrm: Move mipi-dbi

: Eric Anholt Cc: David Lechner Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 9/9] MAINTAINERS: Remove tinydrm entry

On 7/22/19 5:43 AM, Noralf Trønnes wrote: tinydrm is just a collection of tiny drivers now. Add T: drm-misc entry for tinydrm drivers that lacks it. Cc: David Lechner Reviewed-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner

Re: [PATCH v2 5/9] drm/tinydrm/mipi-dbi: Remove CMA helper dependency

Trønnes --- Reviewed-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 6/9] drm/tinydrm/Kconfig: drivers: Select BACKLIGHT_CLASS_DEVICE

depend on the user visible symbol FB. That is a can of worms I'm not willing to tackle. I fear that such a change will result in me handling difficult fallouts for the next weeks. So I'm following DRM suite here. Signed-off-by: Noralf Trønnes --- Reviewed-by: David Lechner

Re: [PATCH 05/10] drm/tinydrm: Clean up tinydrm_spi_transfer()

Lechner Signed-off-by: Noralf Trønnes --- Acked-by: : David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 01/10] drm: Add SPI connector type

On 7/17/19 6:58 AM, Noralf Trønnes wrote: tinydrm drivers announce DRM_MODE_CONNECTOR_VIRTUAL for its SPI drivers. Stop lying and add a SPI connector type Cc: David Lechner Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner ___ dri-devel

Re: [PATCH 06/10] drm/tinydrm: Move tinydrm_spi_transfer()

o SPI code. Additionally move the mipi_dbi_spi_init() declaration to the other SPI functions. Cc: David Lechner Signed-off-by: Noralf Trønnes --- Acked-by: : David Lechner I assume that the comments here might have something to do with the issue[1] I raised a while back? Should I dust that

Re: [PATCH 07/10] drm/tinydrm: Move tinydrm_machine_little_endian()

On 7/17/19 6:58 AM, Noralf Trønnes wrote: The tinydrm helper is going away so move it into the only user mipi-dbi. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/mipi-dbi.c| 15 --- include/drm/tinydrm/tinydrm-helpers.h | 15 --- 2 files changed, 12

Re: [PATCH 09/10] drm/tinydrm/mipi-dbi: Add mipi_dbi_init_with_formats()

systems for this format. If I had more free time, I would like to look at adding grayscale support to DRM. Cc: David Lechner Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https

Re: [PATCH 10/10] drm/tinydrm: Move tinydrm_display_pipe_init() to mipi-dbi

On 7/17/19 6:58 AM, Noralf Trønnes wrote: tinydrm_display_pipe_init() has only one user now, so move it to mipi-dbi. Changes: - Remove drm_connector_helper_funcs.detect, it's always connected. - Store the connector and mode in mipi_dbi instead of it's own struct. Otherwise remove some leftover

Re: [1/3] RFT: drm/pl111: Support grayscale

On 7/23/19 8:37 AM, Linus Walleij wrote: Migrating the TI nspire calculators to use the PL111 driver for framebuffer requires grayscale support for the elder panel which uses 8bit grayscale only. DRM does not support 8bit grayscale framebuffers in memory, but by defining the bus format to be

Re: [PATCH 06/10] drm/tinydrm: Move tinydrm_spi_transfer()

On 7/25/19 9:16 AM, Noralf Trønnes wrote: Den 18.07.2019 14.14, skrev Noralf Trønnes: Den 17.07.2019 21.48, skrev David Lechner: On 7/17/19 6:58 AM, Noralf Trønnes wrote: This is only used by mipi-dbi drivers so move it there. The reason this isn't moved to the SPI subsystem

Re: [PATCH] drm/tilcdc: Switch to using GPIO descriptors

Jyri Sarha Cc: Tomi Valkeinen Cc: David Lechner Signed-off-by: Linus Walleij --- Reviewed-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4/5] drm/dsi: rename MIPI_DCS_SET_PARTIAL_AREA to MIPI_DCS_SET_PARTIAL_ROWS

On 10/22/19 5:09 AM, Jani Nikula wrote: The DCS command has been named SET_PARTIAL_ROWS in the DCS spec since v1.02, for more than a decade. Rename the enumeration to match the spec. Cc: David Lechner Cc: Vandita Kulkarni Signed-off-by: Jani Nikula --- I guess all of my documents are old

Re: [PATCH v2 1/4] drm/tiny/repaper: Make driver OF-independent

On 2/5/20 3:31 PM, Sam Ravnborg wrote: Hi David. Are you planning to pick this series and apply it? Unless I get any other info I plan to process it tomorrow. Sam I won't be able to do it before then, so please go ahead. ___ dri-devel

Re: [PATCH v1 3/4] drm/tiny/st7735r: Make driver OF-independent

On 1/22/20 4:54 AM, Andy Shevchenko wrote: There is one OF call in the driver that limits its area of use. Replace it to generic device_get_match_data() and get rid of OF dependency. Signed-off-by: Andy Shevchenko --- Acked-by: David Lechner

Re: [PATCH v1 4/4] drm/tiny/st7735r: No need to set ->owner for spi_register_driver()

On 1/22/20 4:54 AM, Andy Shevchenko wrote: The spi_register_driver() will set the ->owner member to THIS_MODULE. Signed-off-by: Andy Shevchenko --- Reviewed-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org ht

Re: [PATCH v1 2/4] drm/tiny/repaper: No need to set ->owner for spi_register_driver()

On 1/22/20 4:54 AM, Andy Shevchenko wrote: The spi_register_driver() will set the ->owner member to THIS_MODULE. Signed-off-by: Andy Shevchenko --- Reviewed-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org ht

Re: [PATCH v2 1/5] dt-bindings: display: sitronix, st7735r: Convert to DT schema

--- /dev/null +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml @@ -0,0 +1,65 @@ +# SPDX-License-Identifier: GPL-2.0-only +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/sitronix,st7735r.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sitronix ST7

Re: [PATCH 1/3] dt-bindings: display: sitronix, st7735r: Add Okaya rh128128t

On 1/2/20 8:46 AM, Sam Ravnborg wrote: Hi Geert. On Thu, Jan 02, 2020 at 03:12:44PM +0100, Geert Uytterhoeven wrote: Document support for the Okaya RH128128T display, which is a 128x128 1.44" TFT display driven by a Sitronix ST7715R TFT Controller/Driver. ST7715R and ST7735R are very similar.

Re: [PATCH 3/3] drm: tiny: st7735r: Add support for Okaya RH128128T

On 1/6/20 3:28 AM, Geert Uytterhoeven wrote: Hi Sam, On Sun, Jan 5, 2020 at 10:13 AM Sam Ravnborg wrote: Good to see we add more functionality to the smallest driver in DRM. The patch triggered a few comments - see below. Some comments relates to the original driver - and not your changes.

Re: [PATCH 23/44] drm/ili9225: Use devm_drm_dev_alloc

On 4/3/20 8:58 AM, Daniel Vetter wrote: Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: David Lechner --- Acked-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https

Re: [PATCH 18/44] drm/st7586: Use devm_drm_dev_alloc

On 4/3/20 8:58 AM, Daniel Vetter wrote: Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: David Lechner --- Acked-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https

Re: [PATCH 17/44] drm/st7735r: Use devm_drm_dev_alloc

On 4/3/20 8:58 AM, Daniel Vetter wrote: Already using devm_drm_dev_init, so very simple replacment. Aside: There was an oddity in the old code, we allocated priv but in the error path we've freed priv->dbidev ... Signed-off-by: Daniel Vetter Cc: David Lechner --- Acked-by: David Lech

Re: [PATCH 22/44] drm/ili9341: Use devm_drm_dev_alloc

On 4/3/20 8:58 AM, Daniel Vetter wrote: Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: "Noralf Trønnes" Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Eric Anholt Cc: David Lechner --- Acked-by: Dav

Re: [PATCH 7/8] drm/mipi-dbi: Remove ->enabled

that's the case, so filter that out too. Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: David Lechner --- Acked-by: David Lechner ___ dri-devel mailing list dri

Re: [PATCH 11/11] drm/tiny: drm_gem_simple_display_pipe_prepare_fb is the default

On 5/21/21 4:09 AM, Daniel Vetter wrote: Goes through all the drivers and deletes the default hook since it's the default now. Acked-by: David Lechner

Re: [PATCH v3 0/1] drm/tiny: add support for Waveshare 2inch LCD module

..df25e8e0deb1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5769,6 +5769,14 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F:Documentation/devicetree/bindings/display/sitronix,st7735r.yaml F:drivers/gpu/drm/tiny/st7735r.c +DRM DRIVER FOR SITRONIX ST7789V PANELS +M: David

Re: [PATCH 3/6] dt-bindings: display: sitronix,st7735r: Remove spi-max-frequency limit

ver driver that runs configuration commands at a low speed and only the pixel data at the maximum speed the configuration can't be messed up by transfer errors and the speed is only limited by the amount of pixel glitches that one is able to tolerate. Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner

Re: [PATCH 1/6] dt-bindings: display: sitronix, st7735r: Fix backlight in example

schema") Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner

Re: [PATCH 2/6] dt-bindings: display: sitronix,st7735r: Make reset-gpios optional

On 11/24/21 9:07 AM, Noralf Trønnes wrote: There are other ways than using a gpio to reset the controller so make this property optional. Signed-off-by: Noralf Trønnes --- Acked-by: David Lechner

Re: [PATCH 0/6] drm/tiny/st7735r: Match up with staging/fbtft driver

On 12/1/21 8:52 AM, Maxime Ripard wrote: Hi Noralf, On Tue, Nov 30, 2021 at 03:30:11PM +0100, Noralf Trønnes wrote: Den 29.11.2021 10.39, skrev Maxime Ripard: On Wed, Nov 24, 2021 at 04:03:07PM -0600, David Lechner wrote: On 11/24/21 9:07 AM, Noralf Trønnes wrote: I agree that it doesn't

Re: [PATCH 0/6] drm/tiny/st7735r: Match up with staging/fbtft driver

On 11/24/21 9:07 AM, Noralf Trønnes wrote: Hi, This patchset adds a missing piece for decommissioning the staging/fbtft/fb_st7735r.c driver namely a way to configure the controller from Device Tree. All fbtft drivers have builtin support for one display panel and all other panels using that

Re: [PATCH 7/7] drm/st7586: Use framebuffer dma-buf helpers

On 7/16/21 9:08 AM, Thomas Zimmermann wrote: Replace dma_buf_begin_cpu_access() with drm_gem_fb_begin_cpu_access(); same for _end_cpu_access(). Remove some boiler-plate code. No functional changes. Signed-off-by: Thomas Zimmermann --- Acked-by: David Lechner

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

On 1/25/22 11:57 AM, Noralf Trønnes wrote: Add a driver that will work with most MIPI DBI compatible SPI panels. This avoids adding a driver for every new MIPI DBI compatible controller that is to be used by Linux. The 'compatible' Device Tree property with a '.bin' suffix will be used to load a

Re: [PATCH v2 0/3] drm/panel: Add MIPI DBI compatible SPI driver

On 1/25/22 11:56 AM, Noralf Trønnes wrote: Hi, This patchset adds a driver that will work with most MIPI DBI compatible SPI panels out there. It's a follow up on 'drm/tiny/st7735r: Match up with staging/fbtft driver'[1] which aimed at making the st7735r driver work with all panels adding DT

Re: [PATCH 0/2] Add st7735s drm driver and Winstar panel

On 9/6/23 11:22 AM, Stefan x Nilsson wrote: Add a new driver for the Sitronix st7735s display controller together with a 0.96" 80x160 color TFT display by Winstar. The driver is very similar to the st7735r driver, but uses a different pipe_enable sequence and also allows for an optional

Re: [PATCH] dt-bindings: display: remove backlight node from panel examples

/20230724143152.ga3430423-r...@kernel.org/ Suggested-by: Rob Herring Signed-off-by: Luca Ceresoli --- Acked-by: David Lechner

Re: [PATCH] drm/st7735r: Fix module autoloading for Okaya RH128128T

28T") Signed-off-by: Javier Martinez Canillas --- Acked-by: David Lechner

Re: [PATCH v2 54/65] clk: da8xx: clk48: Switch to determine_rate

On 11/4/22 8:18 AM, Maxime Ripard wrote: The TI DA8xx USB0 clk48 clocks implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most likely

Re: [PATCH v2 22/65] clk: davinci: da8xx-cfgchip: Add a determine_rate hook

On 11/4/22 8:17 AM, Maxime Ripard wrote: The Davinci DA8xxx cfgchip "clk48" clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most

Re: [PATCH v2 21/65] clk: davinci: da8xx-cfgchip: Add a determine_rate hook

On 11/4/22 8:17 AM, Maxime Ripard wrote: The Davinci DA8xxx cfgchip mux clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most

<    1   2   3   >