Re: [PATCH 3/5] drm/dp/mst: change MST detection scheme

On 2017-01-25 05:46 PM, Alex Deucher wrote: > On Wed, Jan 25, 2017 at 1:32 PM, Harry Wentland <harry.wentl...@amd.com> > wrote: >> You mean rebase dal/dc on drm-next with these patches? > > This is a core MST fix, so it would be good to get upstream for all drivers

Re: [v3 PATCH 3/3] drm/amd/display: Switch to using atomic_helper for flip.

On 2017-01-28 09:26 PM, Andrey Grodzovsky wrote: > Swicth to use atomic helper. > Start using actual user's given target_vblank value for flip > instead of current value. > > v3: > Update for movig pflip flags to crtc_state > > Change-Id: I25dae6d8c29de5d022a42aa99a18a32674b56cda >

Re: [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

We'd like these in amdgpu as well. I've only skimmed the patch but it looks pretty good to me. Acked-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-01-29 12:41 AM, Shashank Sharma wrote: > CEA-861-F specs defines new 4k video modes to be used with > HDMI 2.0 EDIDs.

Re: [PATCH v2 4/9] drm: Add driver private objects to atomic state

On 2017-01-25 12:59 AM, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:32PM -0800, Dhinakaran Pandiyan wrote: >> It is necessary to track states for objects other than connector, crtc >> and plane for atomic modesets. But adding objects like DP MST link >> bandwidth to drm_atomic_state would

Re: [PATCH 3/5] drm/dp/mst: change MST detection scheme

You mean rebase dal/dc on drm-next with these patches? I'll see if I find some time today or tomorrow to do that. We'll probably need that anyways for our atomic rework. Do you still rebase amd-staging on drm-next? https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm-next looks a few

[PATCH 8/8] Revert "drm/amdgpu: Refactor flip into prepare submit and submit. (v3)"

This reverts commit cb341a319f7e66f879d69af929c3dadfc1a8f31e. --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 136 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 15 --- 2 files changed, 28 insertions(+), 123 deletions(-) diff --git

[PATCH 0/8] Refactor DC atomic commit and gamma

a few members to support DAL atomic refactor. drm/amd/display: Refactor atomic commit implementation. drm/amd/display: Refactor headless to use atomic commit. Harry Wentland (5): drm/amdgpu: Expose mode_config functions for DM drm/amd/display: Use amdgpu mode funcs statically drm/amd/display

[PATCH 4/8] drm/amd/display: Remove unused define from amdgpu_dm_types

Change-Id: Idfd0d0d6e537eddbc75378ba394b0f36bd89dd50 Signed-off-by: Harry Wentland <harry.wentl...@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.h b/drive

[PATCH 3/8] drm/amd/display: Use atomic helpers for gamma

We were using set_properties and gamma in a weird way. This change aligns the properties with other drivers and allows us to remove a private gamma flag and reuse atomic helpers for most of this. Change-Id: Ic74b692ee6c6d3e4fd938c6226e65b54075ff983 Signed-off-by: Harry Wentland <harry.we

[PATCH 2/8] drm/amd/display: Use amdgpu mode funcs statically

No need to assign them dynamically. This is much more readable. Change-Id: I2d8a356e8d916800c4553c4e9b19ce42f7f1c391 Signed-off-by: Harry Wentland <harry.wentl...@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-)

[PATCH 1/8] drm/amdgpu: Expose mode_config functions for DM

Signed-off-by: Harry Wentland <harry.wentl...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.h | 33 + 2 files changed, 35 insertions(+), 2 deletions(-) create mode 100644 drivers/gpu/drm/amd/

[PATCH 6/8] drm/amd/display: Refactor atomic commit implementation.

From: Andrey Grodzovsky Modify amdgpu_dm_atomic_comit to implement atomic_comit_tail hook. Unify Buffer objects allocation and dealocation for surface updates and page flips. Simplify wait for fences and target_vbank logic for non blockiing commit. Remove hacky update

[PATCH 7/8] drm/amd/display: Refactor headless to use atomic commit.

From: Andrey Grodzovsky Headless mode set needs to be synchronized against outstanding nonblocking commits. This achieved by building atomic state and commiting it. Change-Id: Ie5e778afb33dd5c303a169216a7bb8c2d857037e Signed-off-by: Andrey Grodzovsky

[PATCH 5/8] drm/amdgpu: Add a few members to support DAL atomic refactor.

From: Andrey Grodzovsky Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h

Re: [PATCH v2] drm/amd/dc: resource: fix semicolon.cocci warnings (fwd)

Thanks for these fixes. I'll merge them. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-02-14 04:47 AM, Christian König wrote: Am 14.02.2017 um 07:21 schrieb Julia Lawall: Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC:

Re: [PATCH] drm/amd/dc: fix semicolon.cocci warnings

Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-02-14 01:14 AM, Julia Lawall wrote: Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland <harry.wentl...@amd.com> Signed-off-by: Julia Lawall <julia.law...@lip6

Re: [PATCH] drm/amd/dc: fix semicolon.cocci warnings

Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-02-14 01:13 AM, Julia Lawall wrote: Remove unneeded semicolons. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland <harry.wentl...@amd.com> Signed-off-by: Julia Lawall <julia.law...@lip6

Re: [PATCH] drm/amd/dc: hw_sequencer: fix semicolon.cocci warnings

Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-02-14 01:19 AM, Julia Lawall wrote: Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland <harry.wentl...@amd.com> Signed-off-by: Julia Lawall <julia.law...@lip6

Re: [PATCH 0/8] Refactor DC atomic commit and gamma

On 2017-02-14 04:30 PM, Daniel Vetter wrote: On Fri, Feb 10, 2017 at 11:26:22AM -0500, Harry Wentland wrote: Resending with CC to dri-devel as per Alex's suggestions. This might be of interest to a wider audience. These patches are first steps of addressing some of the problems in DC's atomic

[PATCH] drm: expand cea861 mode timing table

Bumping this one up again. This patch is fairly contained and is a pre-requisite for drivers that want 4k at 60 mode support on HDMI. -Harry On 2016-05-13 06:44 PM, Eric Yang wrote: > This patch expand the cea861 mode timing table to include vic 65 > to 107. This allows more modes to be

[PATCH] drm: disable deep color when EDID violates spec

On 2017-01-10 03:10 PM, Alex Deucher wrote: > On Tue, Jan 10, 2017 at 3:02 PM, Ernst Sjöstrand wrote: >> I kindof assume DP is the default connection these days and with Freesync >> you use >> DP or course, but this question was specifically for HDMI. >> I guess this patch doesn't affect deep

[PATCH] drm: disable deep color when EDID violates spec

On 2017-01-10 03:41 PM, Harry Wentland wrote: > On 2017-01-10 03:10 PM, Alex Deucher wrote: >> On Tue, Jan 10, 2017 at 3:02 PM, Ernst Sjöstrand >> wrote: >>> I kindof assume DP is the default connection these days and with >>> Freesync >>> y

Re: [PATCH 0/4] Allow ASYNC flip with atomic helpers.

On 2017-01-16 03:39 PM, Laurent Pinchart wrote: Hi Andrey, Thank you for the patches. On Monday 16 Jan 2017 10:44:54 Andrey Grodzovsky wrote: This series is a folow-up on https://patchwork.kernel.org/patch/9501787/ The first patch makes changes to atomic helpers to allow for drives with

Re: [PATCH 5/5] drm/amd/display: Allow HDMI capabilities over DVI connector (DC)

On 2017-02-24 07:14 PM, Jeff Smith wrote: Signed-off-by: Jeff Smith --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c

Re: [PATCH 4/5] drm/amd/display: Add HDMI Stereo 3D (DC) support

On 2017-02-24 07:14 PM, Jeff Smith wrote: Signed-off-by: Jeff Smith --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_types.c| 32 -- .../display/dc/dce110/dce110_timing_generator.c| 4 --- 2 files changed, 23 insertions(+), 13 deletions(-) diff

[PATCH 0/5] Handle Link Training Failure during modeset

, should another driver need it it shouldn't be hard to pull that out. Patch 1: Reviewed-by: Harry Wentland Patch 2-5: Acked-by: Harry Wentland Harry On 2016-11-09 11:42 PM, Manasi Navare wrote: > Link training failure is handled by lowering the link rate first > until it reaches the m

[PATCH 0/5] Fixes for MST (daisy-chain and 4k tiles)

A couple of MST fixes to bugs in the framework that we encountered when testing with - three-display daisy-chain configurations - 4k tiled displays Andrey Grodzovsky (1): drm/dp/mst: Reverse order of MST enable and clearing VC payload table. Harry Wentland (2): drm: Add

[PATCH 2/5] drm/dp/mst: Calculate MST PBN with 31.32 fixed point

Our PBN value overflows the 20 bits integer part of the 20.12 fixed point. We need to use 31.32 fixed point to avoid this. This happens with display clocks larger than 293122 (at 24 bpp), which we see with the Sharp (and similar) 4k tiled displays. Signed-off-by: Harry Wentland Reviewed

[PATCH 3/5] drm/dp/mst: change MST detection scheme

e made from it. Notification will be send from topology discovery/update work item. Signed-off-by: Mykola Lysenko Reviewed-by: Harry Wentland Acked-by: Alex Deucher --- drivers/gpu/drm/drm_dp_mst_topology.c | 37 ++- 1 file changed, 19 insertions(+), 18 del

[PATCH 4/5] drm/dp/mst: move GUID storage from mgr, port to only mst branch

stream request, it fails because 2nd MST branch GUID is not available. New Implementation: only create GUID for MST branch and save it within Branch. Signed-off-by: Hersen Wu Reviewed-by: Harry Wentland Acked-by: Alex Deucher --- drivers/gpu/drm/drm_dp_mst_topology.

[PATCH 5/5] drm/dp/mst: Reverse order of MST enable and clearing VC payload table.

From: Andrey Grodzovsky <andrey.grodzov...@amd.com> On DELL U3014 if you clear the table before enabling MST it sometimes hangs the receiver. Signed-off-by: Andrey Grodzovsky Reviewed-by: Harry Wentland Acked-by: Alex Deucher --- drivers/gpu/drm/drm_dp_mst_topology.c | 12 ++---

[PATCH 1/5] drm: Add drm_fixp_from_fraction and drm_fixp2int_ceil

-by: Harry Wentland Reviewed-by: Alex Deucher --- include/drm/drm_fixed.h | 54 +++-- 1 file changed, 52 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_fixed.h b/include/drm/drm_fixed.h index d639049a613d..16e725c42422 100644 --- a/include/drm

[PATCH] drm/dp/mst: deallocate payload on port destruction

cation request to branch device of found port. For this mstb and port kref's are used in reversed order to track when port and branch memory could be freed. Added additional functions to find appropriate mstb as described above. Signed-off-by: Mykola Lysenko Reviewed-by: Harry Wentland --- drivers/g

[RFC] Using DC in amdgpu for upcoming GPU

We propose to use the Display Core (DC) driver for display support on AMD's upcoming GPU (referred to by uGPU in the rest of the doc). In order to avoid a flag day the plan is to only support uGPU initially and transition to older ASICs gradually. The DC component has received extensive testing

[RFC] Using DC in amdgpu for upcoming GPU

Hi Daniel, just a quick clarification in-line about "validation" inside atomic_commit. On 2016-12-08 04:59 AM, Daniel Vetter wrote: > Hi Harry, > > On Wed, Dec 07, 2016 at 09:02:13PM -0500, Harry Wentland wrote: >> We propose to use the Display Core (DC) driver for di

[RFC] Using DC in amdgpu for upcoming GPU

On 2016-12-12 02:22 AM, Daniel Vetter wrote: > On Wed, Dec 07, 2016 at 09:02:13PM -0500, Harry Wentland wrote: >> Current version of DC: >> >> * >> https://cgit.freedesktop.org/~agd5f/linux/tree/drivers/gpu/drm/amd/display?h=amd-staging-4.7 >> >>

[RFC] Using DC in amdgpu for upcoming GPU

n 8 December 2016 at 12:02, Harry Wentland wrote: >> We propose to use the Display Core (DC) driver for display support on >> AMD's upcoming GPU (referred to by uGPU in the rest of the doc). In order to >> avoid a flag day the plan is to only support uGPU initially and transit

[RFC] Using DC in amdgpu for upcoming GPU

On 2016-12-11 03:28 PM, Daniel Vetter wrote: > On Wed, Dec 07, 2016 at 09:02:13PM -0500, Harry Wentland wrote: >> We propose to use the Display Core (DC) driver for display support on >> AMD's upcoming GPU (referred to by uGPU in the rest of the doc). In order to >> avoi

[RFC] Using DC in amdgpu for upcoming GPU

but ... >>> >>> On 13 December 2016 at 01:49, Harry Wentland >>> wrote: >>>> On 2016-12-11 09:57 PM, Dave Airlie wrote: >>>>> On 8 December 2016 at 12:02, Harry Wentland >>>>> wrote: >>>>> Sharing code

[PATCH 06/13] drm: Convert all helpers to drm_connector_list_iter

n_use(struct drm_encoder *encoder) > { > struct drm_connector *connector; > + struct drm_connector_list_iter conn_iter; > struct drm_device *dev = encoder->dev; > > /* > @@ -99,9 +100,15 @@ bool drm_helper_encoder_in_use(struct drm_encoder > *encode

[PATCH 07/13] drm: Clean up connectors by unreferencing them

> } > + drm_connector_list_iter_put(_iter); > + WARN_ON(!list_empty(>mode_config.connector_list)); > > list_for_each_entry_safe(property, pt, >mode_config.property_list, >head) { > Reviewed-by: Harry Wentland Harry

[PATCH] drm: Convert all helpers to drm_connector_list_iter

Reviewed-by: Harry Wentland: On 2016-12-15 10:58 AM, Daniel Vetter wrote: > Mostly nothing special (except making sure that really all error paths > and friends call iter_put). > > v2: Don't forget the raw connector_list walking in > drm_helper_move_panel_connectors_to

[PATCH v2 14/26] drm/amd/dal: Add clock source HW programming

Adds pixel clock programming and functionality to power down clock sources. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../drm/amd/dal/dc/dce110/dce110_clock_source.c| 1162 .../drm/amd/dal/dc/dce110/dce110_clock_source.h| 64 ++ 2 files changed

[PATCH v2 13/26] drm/amd/dal: Add encoder HW programming

Responsible for programming back-end of display path, such as DIG, UNIPHY, DP, DAC, and DVO. Supports: - DisplayPort (single stream) - HDMI - DVI - eDP Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../drm/amd/dal/dc/dce110/dce110_link_encoder.c| 1927

[PATCH v2 15/26] drm/amd/dal: Add timing generator HW programming

Adds ability to validate and program timings, enable, disable, and blank CRTCs, and get CRTC status information. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../amd/dal/dc/dce110/dce110_timing_generator.c| 1864 .../amd/dal/dc/dce110

[PATCH v2 16/26] drm/amd/dal: Add surface HW programming

Adds watermark, DMIF, and surface programming. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../gpu/drm/amd/dal/dc/dce110/dce110_mem_input.c | 965 + .../gpu/drm/amd/dal/dc/dce110/dce110_mem_input.h | 117 +++ 2 files changed, 1082 insertions(+) create

[PATCH v2 17/26] drm/amd/dal: Add framebuffer compression HW programming

Adds framebuffer compression programming. Currently unused. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../gpu/drm/amd/dal/dc/dce110/dce110_compressor.c | 886 + .../gpu/drm/amd/dal/dc/dce110/dce110_compressor.h | 84 ++ 2 files changed, 970 insertions

[PATCH v2 19/26] drm/amd/dal: Add output pixel processing HW programming

Adds programming for color space conversion (CSC), regamma, and formatter. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/dce110/dce110_opp.c | 272 +++ drivers/gpu/drm/amd/dal/dc/dce110/dce110_opp.h | 143 ++ drivers/gpu/drm/amd/dal/dc/dce110

[PATCH v2 18/26] drm/amd/dal: Add input pixel processing HW programming

Adds programming of cursor and input gamma. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/dce110/dce110_ipp.c | 65 ++ drivers/gpu/drm/amd/dal/dc/dce110/dce110_ipp.h | 100 +++ .../gpu/drm/amd/dal/dc/dce110/dce110_ipp_cursor.c | 256

[PATCH v2 20/26] drm/amd/dal: Add transform & scaler HW programming

Adds scaler, viewport, gamut remap, and pixel depth programming. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../gpu/drm/amd/dal/dc/dce110/dce110_transform.c | 91 +++ .../gpu/drm/amd/dal/dc/dce110/dce110_transform.h | 87 +++ .../amd/dal/dc/dce110

[PATCH v2 21/26] drm/amd/dal: Add Carrizo HW sequencer and resource

-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/dce110/Makefile | 15 + .../drm/amd/dal/dc/dce110/dce110_hw_sequencer.c| 1658 .../drm/amd/dal/dc/dce110/dce110_hw_sequencer.h| 36 + .../gpu/drm/amd/dal/dc/dce110

[PATCH v2 22/26] drm/amd/dal: Add Tonga/Fiji HW sequencer and resource

Enables HW programming on Tonga and Fiji (DCE 10) ASICs. This mostly re-uses DCE 11 programming code with minor exceptions and using DCE 10 register offsets. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/dce100/Makefile | 23 + .../drm/amd/dal

[PATCH v2 26/26] drm/amdgpu: Use dal driver for Carrizo, Tonga, and Fiji

Start to use dal by default on Carrizo, Tonga, and Fiji ASICs. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Kconfig | 3 + drivers/gpu/drm/amd/amdgpu/Makefile| 17 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 10 +- drivers/gpu

[PATCH v2 23/26] drm/amd/dal: Add empty encoder programming for virtual HW

Adds empty encoder HW programming functions to support enablement of virtual pipes (i.e. pipes without actual display output). Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/virtual/Makefile| 9 ++ .../drm/amd/dal/dc/virtual

[PATCH v2 25/26] drm/amd/dal: Adding amdgpu_dm for dal

Implements DRM's atomic KMS interfaces using DC. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/amdgpu_dm/Makefile | 17 + drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm.c | 1468 +++ drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm.h

[PATCH v2 01/26] drm/amd/dal: Add dal headers

Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dal_services.h | 266 ++ drivers/gpu/drm/amd/dal/dal_services_types.h | 62 ++ drivers/gpu/drm/amd/dal/dc/dc.h| 462 ++ drivers/gpu/drm/amd/dal/dc

[PATCH v2 07/26] drm/amd/dal: BIOS Parser

Wrapper to access Video BIOS command and data tables Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/bios/Makefile | 26 + drivers/gpu/drm/amd/dal/dc/bios/bios_parser.c | 5029 drivers/gpu/drm/amd/dal/dc/bios

[PATCH v2 24/26] drm/amd/dal: Add display core

display HW - dc_interrupt_set/ack - set and ack interrupts - etc. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/Makefile | 28 + drivers/gpu/drm/amd/dal/dc/core/dc.c | 932 +++ drivers/gpu/drm/amd/dal/dc/core

[PATCH v2 12/26] drm/amd/dal: Bandwidth calculations

Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/calcs/Makefile | 10 + drivers/gpu/drm/amd/dal/dc/calcs/bandwidth_calcs.c | 3941 drivers/gpu/drm/amd/dal/dc/calcs/bw_fixed.c| 300 ++ drivers/gpu/drm/amd/dal/dc/calcs

[PATCH 08/29] drm/amd/dal: I2C Aux Manager

Hi Rob, that's a good point. We'll see if we can use DRM and existing amdgpu code for i2c/aux and rip this one out. Cheers, Harry On 2016-02-11 03:19 PM, Rob Clark wrote: > On Thu, Feb 11, 2016 at 12:19 PM, Harry Wentland > wrote: >> Implements low-level communication layer over

[PATCH 00/29] Enabling new DAL display driver for amdgpu on Carrizo and Tonga

Hi Rob, thanks for the heads-up for this. We're definitely interested in contributing to proposed new frameworks. I'm not sure we want to tightly couple userspace with hardware, though. Your proposal seems to assume that user mode is responsible for knowing how many planes any given

[PATCH 00/29] Enabling new DAL display driver for amdgpu on Carrizo and Tonga

Hi Jerome, some of the kernel API is abstracted to allow testing of this driver in user space for pre- and post-silicon validation. An alternative that we've considered is implementing the kernel functions in user space. That's definitely an option. We're definitely open to push things into

[PATCH 00/29] Enabling new DAL display driver for amdgpu on Carrizo and Tonga

as provided by HW team >> 15k includes >> 6k amdgpu_dm >> 8k dc/core >> >> About 14k of those are blank lines (we have a habit of leaving lots of blank >> space) and 16k are comments. >> >> Cheers, >> Harry >> >> __

[PATCH v3 00/26] Enabling new DAL display driver for amdgpu on Carrizo and Tonga

Deucher's drm-next-4.6-wip tree. Harry Wentland (26): drm/amd/dal: Add dal headers drm/amd/dal: Add DAL Basic Types and Logger drm/amd/dal: Fixed point arithmetic drm/amd/dal: Asic Capabilities drm/amd/dal: GPIO (General Purpose IO) drm/amd/dal: Adapter Service drm/amd/dal: BIOS Parser

[PATCH v3 05/26] drm/amd/dal: GPIO (General Purpose IO)

v3 changes: - expose I2C through i2c_adapter and route dal i2c calls through this Manages all DCE GPIO pins. The pins are represented as generic IO handles as well as handles dedicated for certain functions, such as DDC, HPD, and DVO. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher

[PATCH v3 26/26] drm/amdgpu: Use dal driver for Carrizo, Tonga, and Fiji

Start to use dal by default on Carrizo, Tonga, and Fiji ASICs. v3 changes: - rebase on Alex's latest drm-next-4.6-wip - export some functions to share with DAL - remove has_dal_support macro and move logic into amdgpu_device_has_dal_support Signed-off-by: Harry Wentland Reviewed-by: Alex

[PATCH v3 25/26] drm/amd/dal: Adding amdgpu_dm for dal

name cleanup - expose I2C through i2c_adapter and route dal i2c calls through this Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/amdgpu_dm/Makefile | 17 + drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm.c | 1271 ++ drivers/gpu/drm/amd/dal

[PATCH v3 24/26] drm/amd/dal: Add display core

display HW - dc_interrupt_set/ack - set and ack interrupts - etc. v3 changes: - minor dm_helpers name cleanup - expose I2C through i2c_adapter and route dal i2c calls through this Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/Makefile | 28

[PATCH v3 07/26] drm/amd/dal: BIOS Parser

Wrapper to access Video BIOS command and data tables v3 changes: - expose I2C through i2c_adapter and route dal i2c calls through this Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/bios/Makefile | 26 + drivers/gpu/drm/amd/dal/dc/bios

[PATCH v3 01/26] drm/amd/dal: Add dal headers

v3 changes: - expose I2C through i2c_adapter and route dal i2c calls through this Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dal_services.h | 266 ++ drivers/gpu/drm/amd/dal/dal_services_types.h | 62 ++ drivers/gpu/drm/amd/dal/dc

[PATCH] drm: fix missing reference counting decrease

This looks good but we should probably do the same for all return paths when reference for port has been acquired. Please see attached patch. Thanks, Harry On 2016-02-01 11:08 AM, Insu Yun wrote: > In drm_dp_mst_allocate_vcpi, it returns true in two paths, > but in one path, there is no

[PATCH 00/29] Enabling new DAL display driver for amdgpu on Carrizo and Tonga

. Andrey Grodzovsky (1): drm/amd/dal: Force bw programming for DCE 10 until we start calculate BW. Harry Wentland (27): drm/amd/dal: Add dal headers drm/amd/dal: Add DAL Basic Types and Logger drm/amd/dal: Fixed point arithmetic drm/amd/dal: Asic Capabilities drm/amd/dal: GPIO (General

[PATCH 02/29] drm/amd/dal: Add DAL Basic Types and Logger

- Logging functionality This patch adds Kconfig options to enable the DAL display driver. - DRM_AMD_DAL - DRM_AMD_DAL_VBIOS_PRESENT - DRM_AMD_DAL_DCE11_0 - DRM_AMD_DAL_DCE10_0 - DEBUG_KERNEL_DAL Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/Kconfig

[PATCH 04/29] drm/amd/dal: Asic Capabilities

Add a generic way to manage display HW capabilities for different ASICs and implement it for Carrizo. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../gpu/drm/amd/dal/dc/asic_capability/Makefile| 35 .../amd/dal/dc/asic_capability/asic_capability.c | 190

[PATCH 03/29] drm/amd/dal: Fixed point arithmetic

Arithmetic operations on real numbers represented as fixed-point numbers. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/basics/Makefile | 2 +- drivers/gpu/drm/amd/dal/dc/basics/fixpt31_32.c | 692 + drivers/gpu/drm/amd/dal

[PATCH 05/29] drm/amd/dal: GPIO (General Purpose IO)

Manages all DCE GPIO pins. The pins are represented as generic IO handles as well as handles dedicated for certain functions, such as DDC, HPD, and DVO. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/gpio/Makefile | 32 + .../gpu/drm/amd/dal

[PATCH 06/29] drm/amd/dal: Adapter Service

Provides information about ASIC features and capabilities. Also provides access to ASIC resources such as VBIOS, GPIO and I2cAux Manager Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/adapter/Makefile| 24 + .../gpu/drm/amd/dal/dc/adapter

[PATCH 09/29] drm/amd/dal: IRQ Service

Interface to set and ack DCE interrupts. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/irq/Makefile| 21 ++ .../drm/amd/dal/dc/irq/dce110/irq_service_dce110.c | 389 + .../drm/amd/dal/dc/irq/dce110/irq_service_dce110.h

[PATCH 08/29] drm/amd/dal: I2C Aux Manager

Implements low-level communication layer over I2C and Aux lines using GPIO handles. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/i2caux/Makefile | 33 + drivers/gpu/drm/amd/dal/dc/i2caux/aux_engine.c | 567 drivers/gpu/drm/amd

[PATCH 10/29] drm/amd/dal: GPU

Encapsulates programming for HW blocks which are shared between display paths, such as clock sources. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/gpu/Makefile| 22 + .../gpu/drm/amd/dal/dc/gpu/dc_clock_generator.c| 92 ++ .../gpu/drm

[PATCH 14/29] drm/amd/dal: Add clock source HW programming

Adds pixel clock programming and functionality to power down clock sources. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../drm/amd/dal/dc/dce110/dce110_clock_source.c| 1162 .../drm/amd/dal/dc/dce110/dce110_clock_source.h| 64 ++ 2 files changed

[PATCH 11/29] drm/amd/dal: Audio

Responsible for programming the audio encoder in the display path. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/audio/Makefile | 22 + drivers/gpu/drm/amd/dal/dc/audio/audio.h | 195 ++ drivers/gpu/drm/amd/dal/dc/audio

[PATCH 13/29] drm/amd/dal: Add encoder HW programming

Responsible for programming back-end of display path, such as DIG, UNIPHY, DP, DAC, and DVO. Supports: - DisplayPort (single stream) - HDMI - DVI - eDP Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../drm/amd/dal/dc/dce110/dce110_link_encoder.c| 1927

[PATCH 15/29] drm/amd/dal: Add timing generator HW programming

Adds ability to validate and program timings, enable, disable, and blank CRTCs, and get CRTC status information. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../amd/dal/dc/dce110/dce110_timing_generator.c| 1864 .../amd/dal/dc/dce110

[PATCH 17/29] drm/amd/dal: Add framebuffer compression HW programming

Adds framebuffer compression programming. Currently unused. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../gpu/drm/amd/dal/dc/dce110/dce110_compressor.c | 886 + .../gpu/drm/amd/dal/dc/dce110/dce110_compressor.h | 84 ++ 2 files changed, 970 insertions

[PATCH 16/29] drm/amd/dal: Add surface HW programming

Adds watermark, DMIF, and surface programming. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../gpu/drm/amd/dal/dc/dce110/dce110_mem_input.c | 965 + .../gpu/drm/amd/dal/dc/dce110/dce110_mem_input.h | 117 +++ 2 files changed, 1082 insertions(+) create

[PATCH 19/29] drm/amd/dal: Add output pixel processing HW programming

Adds programming for color space conversion (CSC), regamma, and formatter. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/dce110/dce110_opp.c | 272 +++ drivers/gpu/drm/amd/dal/dc/dce110/dce110_opp.h | 143 ++ drivers/gpu/drm/amd/dal/dc/dce110

[PATCH 18/29] drm/amd/dal: Add input pixel processing HW programming

Adds programming of cursor and input gamma. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/dce110/dce110_ipp.c | 65 ++ drivers/gpu/drm/amd/dal/dc/dce110/dce110_ipp.h | 100 +++ .../gpu/drm/amd/dal/dc/dce110/dce110_ipp_cursor.c | 256

[PATCH 20/29] drm/amd/dal: Add transform & scaler HW programming

Adds scaler, viewport, gamut remap, and pixel depth programming. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../gpu/drm/amd/dal/dc/dce110/dce110_transform.c | 91 +++ .../gpu/drm/amd/dal/dc/dce110/dce110_transform.h | 87 +++ .../amd/dal/dc/dce110

[PATCH 22/29] drm/amd/dal: Add Tonga/Fiji HW sequencer and resource

Enables HW programming on Tonga and Fiji (DCE 10) ASICs. This mostly re-uses DCE 11 programming code with minor exceptions and using DCE 10 register offsets. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/dce100/Makefile | 23 + .../drm/amd/dal

[PATCH 23/29] drm/amd/dal: Add empty encoder programming for virtual HW

Adds empty encoder HW programming functions to support enablement of virtual pipes (i.e. pipes without actual display output). Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/virtual/Makefile| 9 ++ .../drm/amd/dal/dc/virtual

[PATCH 21/29] drm/amd/dal: Add Carrizo HW sequencer and resource

-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/dce110/Makefile | 15 + .../drm/amd/dal/dc/dce110/dce110_hw_sequencer.c| 1658 .../drm/amd/dal/dc/dce110/dce110_hw_sequencer.h| 36 + .../gpu/drm/amd/dal/dc/dce110

[PATCH 25/29] drm/amd/dal: Adding amdgpu_dm for dal

Implements DRM's atomic KMS interfaces using DC. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/amdgpu_dm/Makefile | 17 + drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm.c | 1470 +++ drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm.h

[PATCH 27/29] drm/amd/dal: Correctly interpret rotation as bit set

Signed-off-by: Harry Wentland Reviewed-by: Mykola Lysenko --- drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_types.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_types.c b/drivers/gpu/drm/amd/dal/amdgpu_dm

[PATCH 28/29] drm/amd/dal: fix flip clean-up state

From: Mykola Lysenko <mykola.lyse...@amd.com> Get on par with buffer management changes made in base driver Signed-off-by: Mykola Lysenko Acked-by: Harry Wentland --- drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm.c | 10 -- drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_types.

[PATCH 29/29] drm/amd/dal: Force bw programming for DCE 10 until we start calculate BW.

From: Andrey Grodzovsky <andrey.grodzov...@amd.com> Signed-off-by: Andrey Grodzovsky Acked-by: Jordan Lazare Reviewed-by: Harry Wentland --- .../drm/amd/dal/dc/dce100/dce100_hw_sequencer.c| 28 -- .../gpu/drm/amd/dal/dc/dce100/dce100_resource.c| 3 ++- 2

[PATCH 26/29] drm/amdgpu: Use dal driver for Carrizo, Tonga, and Fiji

Start to use dal by default on Carrizo, Tonga, and Fiji ASICs. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Kconfig | 3 + drivers/gpu/drm/amd/amdgpu/Makefile| 17 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 10 +- drivers/gpu

[PATCH 01/29] drm/amd/dal: Add dal headers

Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dal_services.h | 266 ++ drivers/gpu/drm/amd/dal/dal_services_types.h | 62 ++ drivers/gpu/drm/amd/dal/dc/dc.h| 462 ++ drivers/gpu/drm/amd/dal/dc

[PATCH 12/29] drm/amd/dal: Bandwidth calculations

Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/calcs/Makefile | 10 + drivers/gpu/drm/amd/dal/dc/calcs/bandwidth_calcs.c | 3941 drivers/gpu/drm/amd/dal/dc/calcs/bw_fixed.c| 300 ++ drivers/gpu/drm/amd/dal/dc/calcs

[PATCH 07/29] drm/amd/dal: BIOS Parser

Wrapper to access Video BIOS command and data tables Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/bios/Makefile | 26 + drivers/gpu/drm/amd/dal/dc/bios/bios_parser.c | 5029 drivers/gpu/drm/amd/dal/dc/bios

  1   2   3   4   5   6   7   8   9   10   >