Re: [PATCH v3 2/3] drm/msm/dpu: simplify clocks handling

2022-01-19 Thread Jessica Zhang
implementation is unchanged for now. Signed-off-by: Dmitry Baryshkov Tested on: Qualcomm RB3 (debian, sdm845), Qualcomm RB5 (debian, qrb5165) Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/Makefile | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 24 ++- drivers

Re: [Freedreno] [PATCH v3 1/3] drm/msm: move utility functions from msm_drv.c

2022-01-19 Thread Jessica Zhang
On 1/19/2022 2:16 PM, Dmitry Baryshkov wrote: Move clock/IO/hrtimer utility functions from msm_drv.c to new msm_io_utils.c file. Signed-off-by: Dmitry Baryshkov Tested on: Qualcomm RB3 (debian, sdm845), Qualcomm RB5 (debian, qrb5165) Reviewed-by: Jessica Zhang --- drivers/gpu/drm

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dpu: simplify clocks handling

2022-01-18 Thread Jessica Zhang
.h b/drivers/gpu/drm/msm/dp/dp_parser.h index 3172da089421..094b39bfed8c 100644 --- a/drivers/gpu/drm/msm/dp/dp_parser.h +++ b/drivers/gpu/drm/msm/dp/dp_parser.h @@ -10,7 +10,7 @@ #include #include -#include "dpu_io_util.h" +#include "dp_clk_util.h" #include "

Re: [PATCH] drm/msm/dpu: Remove commit and its uses in dpu_crtc_set_crc_source()

2021-10-27 Thread Jessica Zhang
y: Nathan Chancellor Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index 2523e829f485..967245b8cc02 100644 --- a/drivers/gpu/drm/msm/

Re: [PATCH v2 2/2] drm/msm/dpu: Remove dynamic allocation from atomic context

2021-10-25 Thread Jessica Zhang
r DPU") Signed-off-by: Rob Clark Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index 0a

Re: [PATCH 2/2] drm/msm/dpu: Remove dynamic allocation from atomic context

2021-10-22 Thread Jessica Zhang
expansion of macro ‘static_assert’     192 |  static_assert(ARRAY_SIZE(crcs) == ARRAY_SIZE(crtc_state->mixers));    |  ^ Can be fixed by moving the static_assert() before `crtc_state = ...` Thanks, Jessica Zhang /* Skip first 2 frames in case of "uncooked"

Re: [PATCH 1/2] drm/msm/dpu: Remove impossible NULL check

2021-10-22 Thread Jessica Zhang
On 10/22/2021 10:20 AM, Rob Clark wrote: From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1

[PATCH] drm/msm: Fix potential NULL dereference in DPU

2021-10-20 Thread Jessica Zhang
Add NULL checks in KMS CRTC funcs to avoid potential NULL dereference. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Reported-by: Dan Carpenter Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 8 drivers/gpu/drm/msm/disp/dpu1/

[PATCH] drm/msm/dsi: fix wrong type in msm_dsi_host

2021-10-20 Thread Jessica Zhang
Change byte_clk_rate, pixel_clk_rate, esc_clk_rate, and src_clk_rate from u32 to unsigned long, since clk_get_rate() returns an unsigned long. Fixes: a6bcddbc2ee1 ("drm/msm: dsi: Handle dual-channel for 6G as well") Reported-by: Dan Carpenter Signed-off-by: Jessica Zhang --- drive

[PATCH] drm/msm: Fix potential NULL dereference in DPU SSPP

2021-10-20 Thread Jessica Zhang
Move initialization of sblk in _sspp_subblk_offset() after NULL check to avoid potential NULL pointer dereference. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Reported-by: Dan Carpenter Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 8 +

Re: [bug report] drm/msm: Add SDM845 DPU support

2021-10-19 Thread Jessica Zhang
^ Got it. I'll take care of the null pointer issues, but planning to address the `(void)pe` issue in this patch: https://patchwork.freedesktop.org/patch/456592/ Thanks, Jessica Zhang You should file a bug report with your compiler devs instead of adding these sorts of stateme

[PATCH v2] drm/msm/dpu: Add CRC support for DPU

2021-10-19 Thread Jessica Zhang
-by: Jessica Zhang [1] Skipped on RB5 due to issue related to DPMS. Planning to upload a fix for this in the future. --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 153 +++- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h| 19 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 56

Re: [bug report] drm/msm/dp: add debugfs support to DP driver

2021-10-19 Thread Jessica Zhang
debug->link->phy_params.p_level); 191 if (dp_debug_check_buffer_overflow(rc, _size, )) 192 goto error; 193 --> 194 if (copy_to_user(user_buff, buf, len)) This function does not take "count" into consideration so it can end u

Re: [bug report] drm/msm: dsi: Handle dual-channel for 6G as well

2021-10-18 Thread Jessica Zhang
On 10/16/2021 12:35 PM, Dan Carpenter wrote: On Fri, Oct 15, 2021 at 12:34:20PM -0700, Jessica Zhang wrote: Hey Dmitry, On 10/15/2021 11:24 AM, Dmitry Baryshkov wrote: On Fri, 15 Oct 2021 at 04:43, Jessica Zhang wrote: Hey Dan, On 10/1/2021 5:31 AM, Dan Carpenter wrote: Hello Sean Paul

Re: [bug report] drm/msm: dsi: Handle dual-channel for 6G as well

2021-10-15 Thread Jessica Zhang
Hey Dmitry, On 10/15/2021 11:24 AM, Dmitry Baryshkov wrote: On Fri, 15 Oct 2021 at 04:43, Jessica Zhang wrote: Hey Dan, On 10/1/2021 5:31 AM, Dan Carpenter wrote: Hello Sean Paul, The patch a6bcddbc2ee1: "drm/msm: dsi: Handle dual-channel for 6G as well" from Jul 25, 2

Re: [bug report] drm/msm: dsi: Handle dual-channel for 6G as well

2021-10-15 Thread Jessica Zhang
On 10/15/2021 1:12 AM, Dan Carpenter wrote: On Thu, Oct 14, 2021 at 06:43:22PM -0700, Jessica Zhang wrote: Hey Dan, On 10/1/2021 5:31 AM, Dan Carpenter wrote: Hello Sean Paul, The patch a6bcddbc2ee1: "drm/msm: dsi: Handle dual-channel for 6G as well" from Jul 25, 2

Re: [bug report] drm/msm: dsi: Handle dual-channel for 6G as well

2021-10-14 Thread Jessica Zhang
c:2380 msm_dsi_host_power_on() warn: missing error code 'ret' Is there a specific .config you're using (that's not the default mainline defconfig)? If so, can you please share it? Thanks, Jessica Zhang regards, dan carpenter

Re: [PATCH] drm/msm/dpu: Add CRC support for DPU

2021-10-13 Thread Jessica Zhang
On 10/11/2021 7:01 PM, Dmitry Baryshkov wrote: On 12/10/2021 02:41, Jessica Zhang wrote: Add CRC support to DPU, which is currently not supported by this driver. Only supports CRC for CRTC for now, but will extend support to other blocks later on. Tested on Qualcomm RB3 (debian, sdm845

[PATCH] drm/msm/dpu: Add CRC support for DPU

2021-10-11 Thread Jessica Zhang
Add CRC support to DPU, which is currently not supported by this driver. Only supports CRC for CRTC for now, but will extend support to other blocks later on. Tested on Qualcomm RB3 (debian, sdm845) Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 169

<    2   3   4   5   6   7