Describe some expected behavior of the AMD DM color mgmt programming.
Reviewed-by: Harry Wentland
Signed-off-by: Melissa Wen
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_color.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display
LUT programming and better understand each
step, detach atomic regamma programming from the crtc colocr updating
code.
Reviewed-by: Harry Wentland
Signed-off-by: Melissa Wen
---
.../amd/display/amdgpu_dm/amdgpu_dm_color.c | 55 ---
1 file changed, 35 insertions(+), 20 deletions
).
v2:
- update crtc color mgmt if regamma TF differs between states (Joshua)
- map inverse EOTF to DC transfer function (Melissa)
v3:
- update AMDGPU TF list
v4:
- update comment regarding regamma behavior
Reviewed-by: Harry Wentland
Signed-off-by: Joshua Ashton
Co-developed-by: Melissa Wen
From: Joshua Ashton
Otherwise this is just initialized to 0. This needs to actually have a
value so that compute_curve can work for PQ EOTF.
Reviewed-by: Harry Wentland
Signed-off-by: Joshua Ashton
Co-developed-by: Melissa Wen
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display
From: Joshua Ashton
We should reset a plane state if at least one of the color management
properties differs from old and new state.
Reviewed-by: Harry Wentland
Signed-off-by: Joshua Ashton
Co-developed-by: Melissa Wen
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/amdgpu_dm
Enable usage of predefined transfer func in addition to shaper 1D LUT.
That means we can save some complexity by just setting a predefined
curve, instead of programming a custom curve when preparing color space
for applying 3D LUT.
Reviewed-by: Harry Wentland
Signed-off-by: Melissa Wen
instead of # of entries
Reviewed-by: Harry Wentland
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
.../amd/display/amdgpu_dm/amdgpu_dm_color.c | 102 +-
2 files changed, 99 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd
-off-by: Joshua Ashton
Co-developed-by: Melissa Wen
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 5 +
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 19 +
.../amd/display/amdgpu_dm/amdgpu_dm_color.c | 21 +++
.../amd
-dimension
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 18 +++
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 9
.../amd/display/amdgpu_dm/amdgpu_dm_color.c | 14 +++
.../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 23
to identity (Pekka)
- define the right TFs for BT.709 (Pekka and Harry)
- add comment about AMD TF coefficients
Suggested-by: Harry Wentland
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 27 +---
.../amd/display/amdgpu_dm/amdgpu_dm_color.c | 67
On 08/07, Maíra Canal wrote:
> This patch exposes the accumulated amount of active time per client
> through the fdinfo infrastructure. The amount of active time is exposed
> for each V3D queue: BIN, RENDER, CSD, TFU and CACHE_CLEAN.
>
> In order to calculate the amount of active time per client,
On 08/07, Maíra Canal wrote:
> The previous patch exposed the accumulated amount of active time per
> client for each V3D queue. But this doesn't provide a global notion of
> the GPU usage.
>
> Therefore, provide the accumulated amount of active time for each V3D
> queue (BIN, RENDER, CSD, TFU
| chromium-browse
>
Hi Maíra,
Nice job!
Overall LGTM but I prefer to have an ack from Chema before applying it.
I left some comments regarding documentation for future users.
With this, you can add my r-b in the next version:
Reviewed-by: Melissa Wen
Thanks,
Melissa
>
gree on the behaviour of a KMS property, then that
> property is useless for generic userspace.
>
>
> Thanks,
> pq
>
>
> > On Tuesday, 22 August 2023, Pekka Paalanen
> > wrote:
> > > On Thu, 10 Aug 2023 15:02:59 -0100
> > > Melissa Wen wrote:
>
On 08/22, Pekka Paalanen wrote:
> On Thu, 10 Aug 2023 15:03:11 -0100
> Melissa Wen wrote:
>
> > dc->caps.color.mpc.gamut_remap says there is a post-blending color block
> > for gamut remap matrix for DCN3 HW family and newer versions. However,
> > those drivers
On 08/22, Pekka Paalanen wrote:
> On Thu, 10 Aug 2023 15:02:59 -0100
> Melissa Wen wrote:
>
> > The next patch adds pre-blending degamma to AMD color mgmt pipeline, but
> > pre-blending degamma caps (DPP) is currently in use to provide DRM CRTC
> > atomic degamma o
On 08/22, Pekka Paalanen wrote:
> On Thu, 10 Aug 2023 15:02:47 -0100
> Melissa Wen wrote:
>
> > Instead of relying on color block names to get the transfer function
> > intention regarding encoding pixel's luminance, define supported
> > Electro-Optical Transfer Fu
he IGT repo. So, reintroduce the reverted code.
>
> Link:
> https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/commit/cb77add45011b129e21f3cb2a4089a73dde56179
> Signed-off-by: Hamza Mahfooz
Reviewed-by: Melissa Wen
Thanks!
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amd
On 04/21, Harry Wentland wrote:
>
>
> On 2022-04-21 10:37, Melissa Wen wrote:
> > Hi all,
> >
> > I'm examining how DRM color management properties (degamma, ctm, gamma)
> > are applied to AMD display drivers. As far I could understand thanks
> &
On 04/21, Harry Wentland wrote:
>
>
> On 2022-04-21 15:20, Melissa Wen wrote:
> > On 04/21, Harry Wentland wrote:
> > >
> > >
> > > On 2022-04-21 10:37, Melissa Wen wrote:
> > > > Hi all,
> > > >
> > &g
Hi all,
I'm examining how DRM color management properties (degamma, ctm, gamma)
are applied to AMD display drivers. As far I could understand thanks
Nicholas documentation on amdgpu_dm/amdgpu_dm_color, DC drivers have
per-plane color correction features:
* - Input gamma LUT (de-normalized)
* -
On 04/25, Juan A. Suárez wrote:
> On Sun, 2022-04-24 at 19:35 +0100, Colin Ian King wrote:
> > In the unlikely event that pointer perfmon is null the WARN_ON return
> > path
> > occurs after the pointer has already been deferenced. Fix this by
> > only
> > dereferencing perfmon after it has been
On 11/06, Maíra Canal wrote:
> I've been contributing to V3D with improvements, reviews, testing and
> debugging. Therefore, add myself as a co-maintainer of the V3D driver.
>
> Signed-off-by: Maíra Canal
Acked-by: Melissa Wen
> ---
> MAINTAINERS | 1 +
> 1 file
On 05/12, Maxime Ripard wrote:
> On Fri, 29 Apr 2022 18:33:30 -0100, Melissa Wen wrote:
> > I've been contributing to v3d through improvements, reviews, testing,
> > debugging, etc. So, I'm adding myself as a co-maintainer of the V3D
> > driver.
> >
> >
>
On 04/15, Tales Lelo da Aparecida wrote:
> Do not exit quietly from compose_plane. If any plane has an invalid
> map, propagate the error value upwards. While here, add log messages
> for the invalid index.
>
> Signed-off-by: Tales Lelo da Aparecida
> ---
> drivers/gpu/drm/vkms/vkms_composer.c
On 05/09, Melissa Wen wrote:
> O 05/09, Melissa Wen wrote:
> > On 05/03, Maxime Ripard wrote:
> > > When doing an asynchronous page flip (PAGE_FLIP ioctl with the
> > > DRM_MODE_PAGE_FLIP_ASYNC flag set), the current code waits for the
> > > possible GPU
Check the value of per_pixel_alpha to decide whether the Coverage pixel
blend mode is applicable or not.
Fixes: 76818cdd11a2 ("drm/amd/display: add Coverage blend mode for overlay
plane")
Reported-by: kernel test robot
Reported-by: Dan Carpenter
Signed-off-by: Melissa Wen
---
drive
On 06/28, Harry Wentland wrote:
>
>
> On 6/19/22 18:31, Melissa Wen wrote:
> > Add 3D LUT for gammar correction using a 3D lookup table. The position
> > in the color correction pipeline where 3D LUT is applied depends on hw
> > design, being after CTM or gamma. If j
On 06/27, Ville Syrjälä wrote:
> On Sun, Jun 19, 2022 at 09:31:03PM -0100, Melissa Wen wrote:
> > Add 3D LUT for gammar correction using a 3D lookup table. The position
> > in the color correction pipeline where 3D LUT is applied depends on hw
> > design, being after CTM or
On 06/28, Harry Wentland wrote:
>
>
> On 2022-06-19 18:30, Melissa Wen wrote:
> > Hi,
> >
> > I've been working on a proposal to add 3D LUT interface to DRM CRTC
> > color mgmt, that means new **after-blending** properties for color
> > correction. As I'
On 06/06, Maxime Ripard wrote:
> Hi,
>
> On Thu, May 12, 2022 at 09:44:42AM -0100, Melissa Wen wrote:
> > On 05/09, Melissa Wen wrote:
> > > O 05/09, Melissa Wen wrote:
> > > > On 05/03, Maxime Ripard wrote:
> > > > > Wh
On 06/03, Peter Robinson wrote:
> This is a follow up from my v4 patchset. The power management pieces have
> been split out to a separate independent set of patches by Stefan [1]. This
> version 5 of the DRM patches are independent and given the V3D driver has
> been upstream for some time the
On 06/08, Javier Martinez Canillas wrote:
> Hello Florian,
>
> On 6/8/22 11:26, Florian Fainelli wrote:
> >
> >
> > On 6/3/2022 11:26 AM, Peter Robinson wrote:
> >> This is a follow up from my v4 patchset. The power management pieces have
> >> been split out to a separate independent set of
On 06/09, Stefan Wahren wrote:
> Hi Melissa,
>
> Am 08.06.22 um 14:51 schrieb Melissa Wen:
> > On 06/03, Peter Robinson wrote:
> > > This is a follow up from my v4 patchset. The power management pieces have
> > > been split out to a separate indepe
On 06/08, Javier Martinez Canillas wrote:
> Hello Melissa,
>
> On 6/8/22 17:51, Melissa Wen wrote:
>
> [snip]
>
> >>>
> >>> I can take the last 3 patches through the Broadcom ARM SoC pull request,
> >>> but the first three should probably
nd all attempts ended up disabling the
auto suspend option somehow. Keeping in mind how long this has been
unresolved, I agree to clean it now as we continue to investigate the
issue.
Acked-by: Melissa Wen
>
> Signed-off-by: Nicolas Saenz Julienne
> Signed-off-by: Peter Robins
A_RESV_USAGE_READ,
> );
> + if (ret)
> + return ret;
> +
> + /* If there's no fence, complete the page flip immediately */
> + if (!fence) {
> + vc4_async_page_flip_fence_complete
On 04/15, Tales Lelo da Aparecida wrote:
> Fix a copypasta error. The caller of compose_plane() already checks
> primary_composer->map. In contrast, plane_composer->map is never
> verified here before handling.
>
> Fixes: 7938f4218168 ("dma-buf-map: Rename to iosys-map")
> Reviewed-by: André
On 04/04, Igor Torrente wrote:
> Summary
> ===
> This series of patches refactor some vkms components in order to introduce
> new formats to the planes and writeback connector.
>
> Now in the blend function, the plane's pixels are converted to ARGB16161616
> and then blended together.
>
>
be exposed by a DRM per-plane property in the future.
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +-
.../amd/display/amdgpu_dm/amdgpu_dm_color.c | 153 +++---
drivers/gpu/drm/amd/display/dc
AMDGPU DM maps DRM color management properties (degamma, ctm and gamma)
to DC color correction entities. Part of this mapping is already
documented as code comments and can be converted as kernel docs.
Signed-off-by: Melissa Wen
---
.../gpu/amdgpu/display/display-manager.rst| 9
by the driver according to its color capabilities.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/drm_atomic_state_helper.c | 3 ++
drivers/gpu/drm/drm_atomic_uapi.c | 14 +-
drivers/gpu/drm/drm_color_mgmt.c | 58 +++
drivers/gpu/drm/drm_fb_helper.c
a discussion[1] in the amd-gfx mailing list.
[1]
https://lore.kernel.org/amd-gfx/20220422142811.dm6vtk6v64jcw...@mail.igalia.com/
Signed-off-by: Melissa Wen
---
.../amdgpu/display/dcn2_cm_drm_current.svg| 1370 +++
.../amdgpu/display/dcn3_cm_drm_current.svg| 1528
ene...@ideasonboard.com/
[2]
https://github.com/vsyrjala/linux/commit/4d28e8ddf2a076f30f9e5bdc17cbb4656fe23e69
[3]
https://lore.kernel.org/amd-gfx/20220505220744.3sex7ka2ha2vc...@mail.igalia.com/
Melissa Wen (5):
Documentation/amdgpu_dm: Add DM color correction documentation
Documentation/amdgpu/disp
Shaper LUT is used to shape the contect after blending, i.e.,
de-linearize space before applying 3D LUT color correction. In the next
patch, we are adding 3D LUT property to DRM color mgmt.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/drm_atomic_state_helper.c | 4 +++
drivers/gpu/drm
On 06/10, Javier Martinez Canillas wrote:
> Hello Melissa,
>
> On 6/10/22 13:05, Melissa Wen wrote:
> > On 06/08, Javier Martinez Canillas wrote:
>
> [snip]
>
> >
> > Hi Javier,
> >
> > Thanks for waiting a little.
> >
> > Ste
. This series doesn't cover
recent drivers dcn32/314.
Thanks Guenter, Maíra, Siqueira and Alex for all inputs on this
debugging process. Let me know your thoughts on this approach.
Melissa
[1] https://lore.kernel.org/amd-gfx/20220618232737.2036722-1-li...@roeck-us.net/
Melissa Wen (5):
drm/amd
/powerpc64-linux-ld: failed to merge
target specific data of file
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn316/dcn316_resource.o
[1] https://lore.kernel.org/amd-gfx/20220716195144.342960-1-m...@igalia.com/
Reported-by: Guenter Roeck
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc
Many lines of code in dcn31_resource_construct are wrapped by DC_FP
macro to protect FPU operations; however, there is no FPU in this
region. Therefore, just remove the wrapper for clarity.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 6 --
1 file
hard float,
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn30/dcn30_clk_mgr.o
uses soft float
Therefore, remove the -mno-gnu-attribute flag for dcn30/powerpc and move
FPU-associated code to DML folder.
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/dc/clk_mgr/Makefile | 6
float,
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.o
uses soft float
Therefore, remove the -mno-gnu-attribute flag for dcn301/powerpc and
move FPU-associated code to DML folder.
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/dc/clk_mgr/Makefile | 6
float,
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr.o uses
soft float
Therefore, remove the -mno-gnu-attribute flag for dcn21/powerpc and move
FPU-associated code to DML folder.
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/dc/clk_mgr/Makefile | 6 -
.../amd
On 07/17, Tales Lelo da Aparecida wrote:
> On 16/07/2022 19:25, Melissa Wen wrote:
> > Describe structs and enums used to set blend mode properties to MPC
> > blocks. Some pieces of information are already available as code
> > comments, and were just formatted.
On 07/17, Tales Lelo da Aparecida wrote:
> On 16/07/2022 19:25, Melissa Wen wrote:
> > AMD GPU display manager (DM) maps DRM pixel blend modes (None,
> > Pre-multiplied, Coverage) to MPC hw blocks through blend configuration
> > options. Describe relevant elements and how
On 07/17, Tales Lelo da Aparecida wrote:
> On 16/07/2022 19:25, Melissa Wen wrote:
> > AMDGPU DM maps DRM color management properties (degamma, ctm and gamma)
> > to DC color correction entities. Part of this mapping is already
> > documented as code comments and can be con
Although dcn31_update_soc_for_wm_a() is only called in dml/dcn31/dcn31_fpu by
dc->res_pool->funcs->update_soc_for_wm_a(dc, context), it's declared in
dcn31_resource that is not FPU protected. Move this function to dcn31_fpu
file as part of the work to isolate FPU code.
Signed-off-by: Me
a discussion[1] in the amd-gfx mailing list.
[1]
https://lore.kernel.org/amd-gfx/20220422142811.dm6vtk6v64jcw...@mail.igalia.com/
v2:
- remove redundant comments (Harry)
- fix typo (Harry)
Signed-off-by: Melissa Wen
---
.../amdgpu/display/dcn2_cm_drm_current.svg| 1370
AMD GPU display manager (DM) maps DRM pixel blend modes (None,
Pre-multiplied, Coverage) to MPC hw blocks through blend configuration
options. Describe relevant elements and how to set and test them to get
the expected DRM blend mode on DCN hw.
Signed-off-by: Melissa Wen
---
.../gpu/amdgpu
/-/issues/1734
[2] https://gitlab.freedesktop.org/drm/amd/-/issues/1769
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h | 91 +
1 file changed, 77 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
b/drivers/gpu/drm
me know any misleading information.
[1] https://lore.kernel.org/amd-gfx/20220619223104.667413-1-m...@igalia.com/
[2] https://lore.kernel.org/amd-gfx/20220329201835.2393141-1-m...@igalia.com/
[3]
https://lore.kernel.org/amd-gfx/7a95d6a4-bc2f-b0e8-83f8-8cc5b7559...@amd.com/
Melissa Wen (4
AMDGPU DM maps DRM color management properties (degamma, ctm and gamma)
to DC color correction entities. Part of this mapping is already
documented as code comments and can be converted as kernel docs.
v2:
- rebase to amd-staging-drm-next
Reviewed-by: Harry Wentland
Signed-off-by: Melissa Wen
On 07/25, Magali Lemes wrote:
>
> On 7/25/22 16:42, André Almeida wrote:
> > Hi Magali,
> >
> > Às 15:15 de 25/07/22, Magali Lemes escreveu:
> > > As "dcn3_15_soc" and "dcn3_16_soc" are of type "struct
> > > _vcs_dpi_soc_bounding_box_st", change their types accordingly.
> > >
> > I can see that
On 07/25, Magali Lemes wrote:
> Add missing headers to solve the following warnings from sparse:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:656:17:
> warning: symbol 'ddr4_wm_table_gs' was not declared. Should it be static?
>
O 07/13, Alex Deucher wrote:
> On Wed, Jul 13, 2022 at 7:09 PM Guenter Roeck wrote:
> >
> > On Wed, Jul 13, 2022 at 05:20:40PM -0400, Alex Deucher wrote:
> > > >
> > > > The problem is not the FPU operations, but the fact that soft-float
> > > > and hard-float compiled code is linked together.
On 07/17, Maíra Canal wrote:
> The igt_check_drm_format_min_pitch() function had a lot of
> KUNIT_EXPECT_* calls, all of which ended up allocating and initializing
> various test assertion structures on the stack.
>
> This behavior was producing -Wframe-larger-than warnings on PowerPC, i386,
>
ed-by: kernel test robot
> Reported-by: Guenter Roeck
> Signed-off-by: Maíra Canal
> Tested-by: Guenter Roeck
> Reviewed-by: André Almeida
Applied to drm-misc-next
Thanks,
Melissa
> ---
> v1 -> v2:
> - Add Guenter's Tested-by tag.
> - Add André's Reviewed-by tag.
&
3d_perfmon_open_file(struct v3d_file_priv *v3d_priv)
> {
> mutex_init(_priv->perfmon.lock);
> - idr_init(_priv->perfmon.idr);
> + idr_init_base(_priv->perfmon.idr, 1);
Reviewed-by: Melissa Wen
Thanks
> }
>
> static int v3d_perfmon_idr_del(int id, void *elem, void *data)
> --
> 2.36.1
>
signature.asc
Description: PGP signature
On 07/26, Magali Lemes wrote:
> On 7/25/22 20:38, Melissa Wen wrote:
>
> > On 07/25, Magali Lemes wrote:
> > > On 7/25/22 16:42, André Almeida wrote:
> > > > Hi Magali,
> > > >
> > > > Às 15:15 de 25/07/22, Magali Lemes escreveu:
> &g
I've been contributing to v3d through improvements, reviews, testing,
debugging, etc. So, I'm adding myself as a co-maintainer of the V3D
driver.
Signed-off-by: Melissa Wen
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9b2b0dc44506
On 05/03, Maxime Ripard wrote:
> The BCM2711 has a separate driver for the v3d, and thus we can't call
> into any of the driver entrypoints that rely on the v3d being there.
>
> Let's add a bunch of checks and complain loudly if that ever happen.
>
> Signed-off-by: Maxime Ripard
> ---
>
On 05/03, Maxime Ripard wrote:
> When doing an asynchronous page flip (PAGE_FLIP ioctl with the
> DRM_MODE_PAGE_FLIP_ASYNC flag set), the current code waits for the
> possible GPU buffer being rendered through a call to
> vc4_queue_seqno_cb().
>
> On the BCM2835-37, the GPU driver is part of the
On 05/03, Maxime Ripard wrote:
> Prior to the BCM2711/RaspberryPi4, the GPU was a part of the display
> components of the SoC. It was thus a part of the vc4 driver.
>
> However, with the BCM2711, it got split out and thus the v3d driver was
> created. The vc4 driver now only handles the display
O 05/09, Melissa Wen wrote:
> On 05/03, Maxime Ripard wrote:
> > When doing an asynchronous page flip (PAGE_FLIP ioctl with the
> > DRM_MODE_PAGE_FLIP_ASYNC flag set), the current code waits for the
> > possible GPU buffer being rendered through a call to
&
already a little confusing. After addressing
dma_resv_get_singleton usage, this series is:
Reviewed-by: Melissa Wen
> Maxime
>
> Maxime Ripard (14):
> drm/vc4: plane: Prevent async update if we don't have a dlist
> drm/vc4: Consolidate Hardware Revision Check
> drm/vc4: bo: Re
On 04/22, Harry Wentland wrote:
>
>
> On 2022-04-22 10:28, Melissa Wen wrote:
> > On 04/21, Harry Wentland wrote:
> > >
> > >
> > > On 2022-04-21 15:20, Melissa Wen wrote:
> > > > On 04/21, Harry Wentland wrote:
> > > &
On 08/24, Simon Ser wrote:
> This series adds support for DRM_MODE_PAGE_FLIP_ASYNC for atomic
> commits, aka. "immediate flip" (which might result in tearing).
> The feature was only available via the legacy uAPI, however for
> gaming use-cases it may be desirable to enable it via the atomic
>
On 08/19, Igor Torrente wrote:
> This commit is the groundwork to introduce new formats to the planes and
> writeback buffer. As part of it, a new buffer metadata field is added to
> `vkms_writeback_job`, this metadata is represented by the `vkms_frame_info`
> struct.
>
> Also adds two new
t; Minor improvements(Pekka Paalanen).
> V3: Changes the code to blend the planes all at once. This improves
> performance, memory consumption, and removes much of the weirdness
> of the V2(Pekka Paalanen and me).
> Minor improvements(Pekka Paalanen and me).
> V4: Rebase the
t
> composition. Thus, vkms_frame_info is a better name to represent
> this.
>
> V5: Fix a commit message typo(Melissa Wen).
>
> Reviewed-by: Melissa Wen
> Signed-off-by: Igor Torrente
> ---
> drivers/gpu/drm/vkms/vkms_composer.c | 87 ++--
&g
reciprocal is also true).
Hi Igor,
I missed it after taking some weeks off.
The entire series LGTM.
I pointed out some nitpicks, but I'll handle when applying to
drm-misc-next.
The series is:
Reviewed-by: Melissa Wen
Thank you,
Melissa
>
> Tests
> =
> This patch se
lying the patch below. I appreciate if you can test.
I didn't check with mips and xtensa, but I guess it works in the same
way.
Igor,
it would be good if you double-check the calculation and compare to your
previous results.
Thanks,
Melissa
---
From 0853d85c0b9d6108f916665ff55efa079f28bc53
On 09/07, Sudip Mukherjee wrote:
> Hi Melissa,
>
> On Wed, Sep 7, 2022 at 6:05 PM Melissa Wen wrote:
> >
> > On 09/06, Sudip Mukherjee wrote:
> > > On Tue, Sep 6, 2022 at 4:59 PM Sudip Mukherjee (Codethink)
> > > wrote:
> > > >
> > >
On 09/05, Igor Torrente wrote:
> Summary
> ===
> This series of patches refactor some vkms components in order to introduce
> new formats to the planes and writeback connector.
>
> Now in the blend function, the plane's pixels are converted to ARGB16161616
> and then blended together.
>
>
On 08/22, Igor Matheus Andrade Torrente wrote:
> Hi Melissa,
>
> On 8/20/22 07:51, Melissa Wen wrote:
> > On 08/19, Igor Torrente wrote:
> > > Currently the blend function only accepts XRGB_ and ARGB_
> > > as a color input.
> > >
> >
On 08/22, Igor Matheus Andrade Torrente wrote:
> On 8/22/22 16:01, Melissa Wen wrote:
> > On 08/22, Igor Matheus Andrade Torrente wrote:
> > > Hi Melissa,
> > >
> > > On 8/20/22 07:51, Melissa Wen wrote:
> > > > On 08/19, Igor Torrente wrote:
>
On 08/22, Igor Matheus Andrade Torrente wrote:
> Hi Mellisa,
>
> On 8/20/22 08:00, Melissa Wen wrote:
> > On 08/19, Igor Torrente wrote:
> > > Changes the name of this struct to a more meaningful name.
> > > A name that represents better what this struc
m_shadow_plane_state *shadow_plane_state;
> struct drm_framebuffer *fb = new_state->fb;
> struct vkms_frame_info *frame_info;
> - u32 fmt = fb->format->format;
> + u32 fmt;
>
> if (!new_state->crtc || !fb)
> return;
>
> +
ormat")
Tested-by: Sudip Mukherjee (v1)
Reviewed-by: Alex Deucher (v1)
Reported-by: Sudip Mukherjee
Reported-by: kernel test robot
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_formats.c | 53 +++--
1 file changed, 19 insertions(+), 34 deletions(-)
On 09/09, Igor Matheus Andrade Torrente wrote:
> Hi Mellisa,
>
> Thanks for the patch fixing my mistakes.
>
> On 9/9/22 08:41, Melissa Wen wrote:
> > Replace vkms_formats macros for fixed-point operations with functions
> > from drm/drm_fixed.h to do the same job
On 04/13, Daniel Vetter wrote:
On Wed, 13 Apr 2022 at 01:36, Abhinav Kumar wrote:
>
> Hi Daniel
>
> On 4/8/2022 9:04 PM, Abhinav Kumar wrote:
> >
> >
> > On 4/7/2022 4:12 PM, Rob Clark wrote:
> >> On Thu, Apr 7, 2022 at 3:59 PM Abhinav Kumar
> >> wrote:
> >>>
> >>> Hi Rob and Daniel
> >>>
>
ernel test robot
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_formats.c | 53 +++--
1 file changed, 19 insertions(+), 34 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_formats.c
b/drivers/gpu/drm/vkms/vkms_formats.c
index 300abb4d1dfe..ddcd3cfee
On 09/07, Sudip Mukherjee wrote:
> On Wed, Sep 7, 2022 at 8:23 PM Melissa Wen wrote:
> >
> > On 09/07, Sudip Mukherjee wrote:
> > > Hi Melissa,
> > >
> > > On Wed, Sep 7, 2022 at 6:05 PM Melissa Wen wrote:
> > > >
> > > > On 09/0
On 08/14, Maíra Canal wrote:
> Hi Mikhail
>
> Looks like this use-after-free problem was introduced on
> 90af0ca047f3049c4b46e902f432ad6ef1e2ded6. Checking this patch it seems
> like: if amdgpu_cs_vm_handling return r != 0, then it will unlock
> bo_list_mutex inside the function
gt; - mutex_unlock(>bo_list->bo_list_mutex);
> + if (r)
> return r;
> - }
>
> r = amdgpu_sync_fence(>job->sync, bo_va->last_pt_update);
> - if (r) {
> - mutex_unlock(>bo_list->bo_list_mutex);
> + if (r)
> return r;
> - }
Nice catch, Maíra!
Reviewed-by: Melissa Wen
> }
>
> r = amdgpu_vm_handle_moved(adev, vm);
> --
> 2.37.2
>
signature.asc
Description: PGP signature
(Tales)
Signed-off-by: Melissa Wen
Reviewed-by: Harry Wentland
Reviewed-by: Tales Aparecida
---
.../gpu/amdgpu/display/display-manager.rst| 9 ++
.../amd/display/amdgpu_dm/amdgpu_dm_color.c | 109 +-
2 files changed, 90 insertions(+), 28 deletions(-)
diff --git
://lore.kernel.org/amd-gfx/7a95d6a4-bc2f-b0e8-83f8-8cc5b7559...@amd.com/
Melissa Wen (4):
Documentation/amdgpu_dm: Add DM color correction documentation
Documentation/amdgpu/display: add DC color caps info
drm/amd/display: add doc entries for MPC blending configuration
Documentation/gpu/amdgpu
AMD GPU display manager (DM) maps DRM pixel blend modes (None,
Pre-multiplied, Coverage) to MPC hw blocks through blend configuration
options. Describe relevant elements and how to set and test them to get
the expected DRM blend mode on DCN hw.
v2:
- add ref tag (Tales)
Signed-off-by: Melissa
typos (Tales)
- describe missing struct parameters (Tales and Siqueira)
Co-developed-by: Harry Wentland
Signed-off-by: Harry Wentland
Signed-off-by: Melissa Wen
Reviewed-by: Tales Aparecida
---
.../amdgpu/display/dcn2_cm_drm_current.svg| 1370 +++
.../amdgpu/display
/-/issues/1734
[2] https://gitlab.freedesktop.org/drm/amd/-/issues/1769
v2:
- fix typos (Tales)
- add MPCC to MPC entry in the glossary
Signed-off-by: Melissa Wen
Reviewed-by: Tales Aparecida
---
.../gpu/amdgpu/display/dc-glossary.rst| 2 +-
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
On 08/17, Mikhail Gavrilov wrote:
> On Mon, Aug 15, 2022 at 3:37 PM Mikhail Gavrilov
> wrote:
> >
> > Thanks, I tested this patch.
> > But with this patch use-after-free problem happening in another place:
>
> Does anyone have an idea why the second use-after-free happened?
> From the trace I
301 - 400 of 684 matches
Mail list logo
