(+)
Reviewed-by: Abhinav Kumar
functional change, so you could have retained by R-b, but here it is
again,
Reviewed-by: Abhinav Kumar
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 119f3ea50a7c..cf7d769ab3b9 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encod
/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
I think we also need
Fixes: 5a9d50150c2c ("drm/msm/dpu: shift IRQ indices by 1")
With that,
Reviewed-by: Abhinav Kumar
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
b/drivers/gpu/dr
On 5/9/2024 10:52 AM, Barnabás Czémán wrote:
CTLs on older qualcomm SOCs like msm8953 and msm8996 has not got interrupts,
so better to skip CTL irq callback register/unregister
make dpu_ctl_cfg be able to define without intr_start.
Thanks for the patch.
Have msm8953 and msm8996 migrated
== ===
Is it really optional - can you build the driver without it?
True, we cannot build the driver now without it. So we should be
dropping the optional tag.
With that addressed,
Reviewed-by: Abhinav Kumar
On 5/8/2024 3:41 PM, Doug Anderson wrote:
Hi,
On Fri, May 3, 2024 at 11:15 AM Dmitry Baryshkov
wrote:
@@ -941,6 +948,7 @@ def main():
parser = argparse.ArgumentParser()
parser.add_argument('--rnn', type=str, required=True)
parser.add_argument('--xml', type=str,
On 5/8/2024 1:43 AM, Jani Nikula wrote:
On Tue, 07 May 2024, Abhinav Kumar wrote:
Since commit 5acf49119630 ("drm/msm: import gen_header.py script from Mesa"),
compilation is broken on machines having python versions older than 3.9
due to dependency on argparse.BooleanOpti
On 5/8/2024 2:17 AM, Jon Hunter wrote:
Building the kernel with python3 versions earlier than v3.9 fails with ...
Traceback (most recent call last):
File "drivers/gpu/drm/msm/registers/gen_header.py", line 970, in
main()
File "drivers/gpu/drm/msm/registers/gen_header.py",
cf49119630 ("drm/msm: import gen_header.py script from Mesa")
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/registers/gen_header.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/registers/gen_header.py
b/drivers/gpu/drm/msm/registers
On 5/3/2024 5:02 PM, Dmitry Baryshkov wrote:
On Sat, 4 May 2024 at 01:38, Abhinav Kumar wrote:
On 5/3/2024 1:20 PM, Dmitry Baryshkov wrote:
On Fri, 3 May 2024 at 22:42, Abhinav Kumar wrote:
On 5/3/2024 11:15 AM, Dmitry Baryshkov wrote:
In order to validate drm/msm register
On 5/3/2024 1:20 PM, Dmitry Baryshkov wrote:
On Fri, 3 May 2024 at 22:42, Abhinav Kumar wrote:
On 5/3/2024 11:15 AM, Dmitry Baryshkov wrote:
In order to validate drm/msm register definition files against schema,
reuse the nodebugfs build step. The validation entry is guarded
On 5/3/2024 11:15 AM, Dmitry Baryshkov wrote:
In order to validate drm/msm register definition files against schema,
reuse the nodebugfs build step. The validation entry is guarded by
the EXPERT Kconfig option and we don't want to enable that option for
all the builds.
Signed-off-by: Dmitry
/gen_header.py | 14 +++---
3 files changed, 27 insertions(+), 4 deletions(-)
Looks reasonable to me, only developers need to worry about or fix the
xml files
Reviewed-by: Abhinav Kumar
changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Abhinav Kumar
/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 3 ---
1 file changed, 3 deletions(-)
Yes, I agree with this, even though I did think earlier that intf master
flush was sufficient , I cross-checked the docs and this is the right way.
Reviewed-by: Abhinav Kumar
On 4/19/2024 7:33 PM, Dmitry Baryshkov wrote:
Since commit 3c74682637e6 ("drm/msm/mdp4: move resource allocation to
the _probe function") the mdp4_kms data is allocated during probe. It is
an error to destroy it during mdp4_kms_init(), as the data is still
referenced by the drivers's data and
On 4/21/2024 3:35 PM, Dmitry Baryshkov wrote:
On Sat, Apr 20, 2024 at 04:02:00PM -0700, Abhinav Kumar wrote:
On 4/19/2024 7:33 PM, Dmitry Baryshkov wrote:
MSM display drivers provide kms structure allocated during probe().
Don't clean up priv->kms field in case of an error. Otherw
On 4/21/2024 3:35 PM, Dmitry Baryshkov wrote:
On Sat, Apr 20, 2024 at 04:02:00PM -0700, Abhinav Kumar wrote:
On 4/19/2024 7:33 PM, Dmitry Baryshkov wrote:
MSM display drivers provide kms structure allocated during probe().
Don't clean up priv->kms field in case of an error. Otherw
oder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Indeed ! I should have caught this during review :(
Reviewed-by: Abhinav Kumar
On 4/19/2024 7:33 PM, Dmitry Baryshkov wrote:
MSM display drivers provide kms structure allocated during probe().
Don't clean up priv->kms field in case of an error. Otherwise probe
functions might fail after KMS probe deferral.
So just to understand this more, this will happen when master
| 2 +
11 files changed, 571 insertions(+), 708 deletions(-)
Reviewed-by: Abhinav Kumar
| 6 +-
drivers/gpu/drm/msm/disp/mdp_format.h | 39
drivers/gpu/drm/msm/disp/mdp_kms.h | 4 +-
drivers/gpu/drm/msm/msm_drv.h | 4 --
9 files changed, 109 insertions(+), 89 deletions(-)
Reviewed-by: Abhinav Kumar
On 4/19/2024 8:06 PM, Dmitry Baryshkov wrote:
On Sat, 20 Apr 2024 at 06:05, Abhinav Kumar wrote:
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote:
Lift mode_config limits set by the DPU driver to the actual FB limits as
handled by the dpu_plane.c.
Signed-off-by: Dmitry Baryshkov
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote:
Lift mode_config limits set by the DPU driver to the actual FB limits as
handled by the dpu_plane.c.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
| 3 ---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 4 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4 ++--
3 files changed, 4 insertions(+), 7 deletions(-)
Reviewed-by: Abhinav Kumar
On 4/19/2024 6:34 PM, Dmitry Baryshkov wrote:
On Fri, Apr 19, 2024 at 05:14:01PM -0700, Abhinav Kumar wrote:
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote:
Move a call to dpu_format_populate_plane_sizes() to the atomic_check
step, so that any issues with the FB layout can be reported
On 4/19/2024 6:26 PM, Dmitry Baryshkov wrote:
On Fri, Apr 19, 2024 at 04:43:20PM -0700, Abhinav Kumar wrote:
On 3/19/2024 6:21 AM, Dmitry Baryshkov wrote:
The msm_kms_funcs::check_modified_format() callback is not used by the
driver. Drop it completely.
Signed-off-by: Dmitry Baryshkov
(layout->plane_pitch[0] << 16) &
494 0x);
495 ystride1 = (ystride1 & 0x) |
496 ((layout->plane_pitch[2] << 16) &
497 0x);
498 }
Seems correct, but was just curious
Reviewed-by: Abhinav Kumar
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote:
Move a call to dpu_format_populate_plane_sizes() to the atomic_check
step, so that any issues with the FB layout can be reported as early as
possible.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12
+++---
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h| 8 +++-
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 --
4 files changed, 45 insertions(+), 27 deletions(-)
Reviewed-by: Abhinav Kumar
| 19 ---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 3 +++
2 files changed, 7 insertions(+), 15 deletions(-)
Reviewed-by: Abhinav Kumar
On 3/19/2024 6:21 AM, Dmitry Baryshkov wrote:
The msm_kms_funcs::check_modified_format() callback is not used by the
driver. Drop it completely.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 45 -
On 4/19/2024 2:21 PM, Dmitry Baryshkov wrote:
On Sat, 20 Apr 2024 at 00:06, Abhinav Kumar wrote:
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote:
MDP4 and MDP5 drivers enumerate supported formats each time the plane is
created. In preparation to merger of MDP DPU format databases, define
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote:
MDP4 and MDP5 drivers enumerate supported formats each time the plane is
created. In preparation to merger of MDP DPU format databases, define
precise formats list, so that changes to the database do not cause the
driver to add unsupported format
On 4/10/2024 7:38 PM, Dmitry Baryshkov wrote:
On Thu, 11 Apr 2024 at 02:54, Abhinav Kumar wrote:
On 4/10/2024 2:12 PM, Dmitry Baryshkov wrote:
On Wed, Apr 10, 2024 at 01:18:42PM -0700, Abhinav Kumar wrote:
On 4/10/2024 1:16 PM, Dmitry Baryshkov wrote:
On Wed, 10 Apr 2024 at 23:00
-
drivers/gpu/drm/msm/msm_fb.c | 2 +-
drivers/gpu/drm/msm/msm_kms.h| 4
8 files changed, 4 insertions(+), 11 deletions(-)
Reviewed-by: Abhinav Kumar
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote:
Finally remove duplication between DPU and generic MDP code by merging
DPU format lists to the MDP format database.
Signed-off-by: Dmitry Baryshkov
---
.../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +-
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote:
Instead of having a bool field alpha_enable, convert it to the
flag, this save space in the tables and allows us to handle all booleans
in the same way.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 12
| 12 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 2 +-
drivers/gpu/drm/msm/msm_drv.h | 4 ++--
4 files changed, 6 insertions(+), 14 deletions(-)
Reviewed-by: Abhinav Kumar
++---
drivers/gpu/drm/msm/msm_drv.h | 4 +-
7 files changed, 41 insertions(+), 47 deletions(-)
Reviewed-by: Abhinav Kumar
,\
- .chroma_sample = cs, \
Minor nit:
These two lines are only moving the locations of assignment so
unnecessary change?
Rest LGTM,
Reviewed-by: Abhinav Kumar
For validation, are you relying mostly on the CI here OR also other
internal
On 4/11/2024 11:41 AM, Abhinav Kumar wrote:
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote:
In preparation to merger of formats databases, pull format flag
definitions to msm_drv.h header, so that they are visibile to both dpu
and mdp drivers.
Signed-off-by: Dmitry Baryshkov
---
drivers
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote:
In preparation to merger of formats databases, pull format flag
definitions to msm_drv.h header, so that they are visibile to both dpu
and mdp drivers.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 98
On 4/10/2024 2:12 PM, Dmitry Baryshkov wrote:
On Wed, Apr 10, 2024 at 01:18:42PM -0700, Abhinav Kumar wrote:
On 4/10/2024 1:16 PM, Dmitry Baryshkov wrote:
On Wed, 10 Apr 2024 at 23:00, Abhinav Kumar wrote:
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote:
Instead of having DPU-specific
/drm/msm/disp/dpu1/dpu_hw_mdss.h | 16 +++-
2 files changed, 16 insertions(+), 18 deletions(-)
Reviewed-by: Abhinav Kumar
On 4/10/2024 1:16 PM, Dmitry Baryshkov wrote:
On Wed, 10 Apr 2024 at 23:00, Abhinav Kumar wrote:
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote:
Instead of having DPU-specific defines, switch to the definitions from
the mdp_common.xml.h file. This is the preparation for merged of DPU
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote:
Instead of having DPU-specific defines, switch to the definitions from
the mdp_common.xml.h file. This is the preparation for merged of DPU and
MDP format tables.
Adding MDP_***__ usages in DPU driver is quite confusing.
Can we align to a
(+)
Reviewed-by: Abhinav Kumar
file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Abhinav Kumar
,
Reviewed-by: Abhinav Kumar
On 4/5/2024 11:15 AM, Dmitry Baryshkov wrote:
On Fri, 5 Apr 2024 at 20:35, Abhinav Kumar wrote:
On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote:
Currently the MSM DSI driver looks for the next bridge during
msm_dsi_modeset_init(). If the bridge is not registered at that point,
this might
On 3/28/2024 7:40 AM, Bjorn Andersson wrote:
From: Bjorn Andersson
The dp_audio read and write operations uses members in struct dp_catalog
for passing arguments and return values. This adds unnecessary
complexity to the implementation, as it turns out after detangling the
logic that no
On 4/8/2024 2:12 PM, Dmitry Baryshkov wrote:
On Mon, 8 Apr 2024 at 22:43, Abhinav Kumar wrote:
On 4/7/2024 11:48 AM, Bjorn Andersson wrote:
On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote:
From: Kuogee Hsieh
[..]
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b
On 4/8/2024 2:13 PM, Dmitry Baryshkov wrote:
On Tue, 9 Apr 2024 at 00:08, Abhinav Kumar wrote:
On 4/8/2024 1:41 PM, Bjorn Andersson wrote:
On Mon, Apr 08, 2024 at 12:43:34PM -0700, Abhinav Kumar wrote:
On 4/7/2024 11:48 AM, Bjorn Andersson wrote:
On Fri, Apr 05, 2024 at 08:15:47PM
On 4/8/2024 1:41 PM, Bjorn Andersson wrote:
On Mon, Apr 08, 2024 at 12:43:34PM -0700, Abhinav Kumar wrote:
On 4/7/2024 11:48 AM, Bjorn Andersson wrote:
On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote:
From: Kuogee Hsieh
[..]
diff --git a/drivers/gpu/drm/msm/dp
On 4/7/2024 11:48 AM, Bjorn Andersson wrote:
On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote:
From: Kuogee Hsieh
[..]
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu/drm/msm/dp/dp_display.c
index d80f89581760..bfb6dfff27e8 100644
--- a/drivers/gpu/drm/msm/dp
Hi Helen
Gentle reminder on this.
If you are okay, we can land it via msm-next tree...
Thanks
Abhinav
On 4/1/2024 1:48 PM, Abhinav Kumar wrote:
After IGT migrating to dynamic sub-tests, the pipe prefixes
in the expected fails list are incorrect. Lets drop those
to accurately match
On 4/8/2024 1:55 AM, Aleksandr Mishin wrote:
In dpu_core_irq_callback_handler() callback function pointer is compared to
NULL,
but then callback function is unconditionally called by this pointer.
Fix this bug by adding conditional return.
Found by Linux Verification Center
- Fix the subject a little as well
Fixes: 542b37efc20e ("drm/msm/dp: Implement hpd_notify()")
Signed-off-by: Kuogee Hsieh
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/
consistently.
changes in v2:
- Fix the commit message to explain the scenario
- Fix the subject a little as well
Fixes: 542b37efc20e ("drm/msm/dp: Implement hpd_notify()")
Signed-off-by: Kuogee Hsieh
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_dis
On 3/28/2024 10:47 PM, Abhinav Kumar wrote:
On 3/28/2024 8:23 PM, Dmitry Baryshkov wrote:
On Fri, 29 Mar 2024 at 04:16, Abhinav Kumar
wrote:
On 3/28/2024 5:10 PM, Dmitry Baryshkov wrote:
On Fri, 29 Mar 2024 at 01:42, Abhinav Kumar
wrote:
On 3/28/2024 3:50 PM, Dmitry Baryshkov
ode
https://gitlab.freedesktop.org/drm/msm/-/commit/be1b7acb9291
Best regards,
--
Abhinav Kumar
On Wed, 06 Mar 2024 11:35:15 -0800, Abhinav Kumar wrote:
> Fix the typo in the name of dp_display_handle_port_status_changed().
>
>
Applied, thanks!
[1/1] drm/msm/dp: fix typo in dp_display_handle_port_status_changed()
(no commit info)
https://gitlab.freedesktop.or
e
> sense.
>
>
Applied, thanks!
[1/1] drm/msm/dpu: make error messages at dpu_core_irq_register_callback() more
sensible
https://gitlab.freedesktop.org/drm/msm/-/commit/8844f467d6a5
Best regards,
--
Abhinav Kumar
sm/-/commit/ee15c8bf5d77
Best regards,
--
Abhinav Kumar
cted
> value directly.
>
> [1] https://patchwork.freedesktop.org/series/119552/#rev2
>
> [...]
Applied, thanks!
[1/5] drm/msm/dpu: don't allow overriding data from catalog
https://gitlab.freedesktop.org/drm/msm/-/commit/4f3b77ae5ff5
Best regards,
--
Abhinav Kumar
but I missed that while migrating to drm_dbg wrappers.
>
>
Applied, thanks!
[1/1] drm/msm: Add newlines to some debug prints
https://gitlab.freedesktop.org/drm/msm/-/commit/c588f7d67044
Best regards,
--
Abhinav Kumar
sm/-/commit/e86750b01a15
Best regards,
--
Abhinav Kumar
On 4/5/2024 11:19 AM, Dmitry Baryshkov wrote:
On Fri, 5 Apr 2024 at 21:17, Abhinav Kumar wrote:
On 4/5/2024 11:16 AM, Dmitry Baryshkov wrote:
On Fri, 5 Apr 2024 at 20:20, Abhinav Kumar wrote:
On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote:
All the bridges that are being used
On 4/5/2024 11:16 AM, Dmitry Baryshkov wrote:
On Fri, 5 Apr 2024 at 20:20, Abhinav Kumar wrote:
On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote:
All the bridges that are being used with the MSM DSI hosts have been
converted to support DRM_BRIDGE_ATTACH_NO_CONNECTOR. Drop the fallback
code
On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote:
Currently the MSM DSI driver looks for the next bridge during
msm_dsi_modeset_init(). If the bridge is not registered at that point,
this might result in -EPROBE_DEFER, which can be problematic that late
during the device probe process. Move next
more?
If not, this LGTM
Reviewed-by: Abhinav Kumar
On 4/3/2024 1:04 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2024-04-03 12:58:50)
On 4/3/2024 12:51 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2024-03-29 12:50:35)
Currently qmp_combo_dp_power_on() always return 0 in regardless of
return value of cfg->configure_dp_phy(). This pa
On 4/3/2024 12:51 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2024-03-29 12:50:35)
Currently qmp_combo_dp_power_on() always return 0 in regardless of
return value of cfg->configure_dp_phy(). This patch propagate
return value of cfg->configure_dp_phy() all the way back to caller.
Is this
-by: Abhinav Kumar
---
drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
index 44a5c62dedad..b14d4e884971 100644
On 3/30/2024 9:49 AM, Marijn Suijten wrote:
On 2024-03-30 05:52:29, Dmitry Baryshkov wrote:
In case of CMD DSI panels, the vblank IRQ can be used outside of
irq_enable/irq_disable pair. This results in the following kind of
Can you clarify when exactly that is? Is it via
m/msm/dpu: stop using raw IRQ indices in the kernel
output")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Abhinav Kumar
Hi Doug
On 3/29/2024 4:07 PM, Doug Anderson wrote:
Hi,
On Sat, Feb 3, 2024 at 5:47 AM Dmitry Baryshkov
wrote:
Both dp_link_adjust_levels() and dp_ctrl_update_vx_px() limit swing and
pre-emphasis to 2, while the real maximum value for the sum of the
voltage swing and pre-emphasis is 3. Fix
nkmthtclfvmbz-9vol...@mail.gmail.com/
[2]
Link:
https://lore.kernel.org/lkml/20240307093727.1978126-1-colin.i.k...@gmail.com/
[3]
Signed-off-by: Miguel Ojeda
---
LGTM,
Reviewed-by: Abhinav Kumar
Add support for DP in USB3+DP combo phy")
Signed-off-by: Kuogee Hsieh
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
Thanks for the cleanup!
Reviewed-by: Abhinav Kumar
On 3/28/2024 8:23 PM, Dmitry Baryshkov wrote:
On Fri, 29 Mar 2024 at 04:16, Abhinav Kumar wrote:
On 3/28/2024 5:10 PM, Dmitry Baryshkov wrote:
On Fri, 29 Mar 2024 at 01:42, Abhinav Kumar wrote:
On 3/28/2024 3:50 PM, Dmitry Baryshkov wrote:
On Thu, 28 Mar 2024 at 23:21, Abhinav
On 3/28/2024 6:46 PM, Bjorn Andersson wrote:
On Thu, Mar 28, 2024 at 02:21:14PM -0700, Abhinav Kumar wrote:
On 3/28/2024 1:58 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2024-03-28 13:24:34)
+ Johan and Bjorn for FYI
On 3/28/2024 1:04 PM, Kuogee Hsieh wrote:
For internal HPD case
On 3/28/2024 5:10 PM, Dmitry Baryshkov wrote:
On Fri, 29 Mar 2024 at 01:42, Abhinav Kumar wrote:
On 3/28/2024 3:50 PM, Dmitry Baryshkov wrote:
On Thu, 28 Mar 2024 at 23:21, Abhinav Kumar wrote:
On 3/28/2024 1:58 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2024-03-28 13:24:34
On 3/28/2024 3:50 PM, Dmitry Baryshkov wrote:
On Thu, 28 Mar 2024 at 23:21, Abhinav Kumar wrote:
On 3/28/2024 1:58 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2024-03-28 13:24:34)
+ Johan and Bjorn for FYI
On 3/28/2024 1:04 PM, Kuogee Hsieh wrote:
For internal HPD case
On 3/28/2024 2:07 PM, Kuogee Hsieh wrote:
Currently qmp_combo_dp_power_on() always return 0 in regardless of
return value of cfg->configure_dp_phy(). This patch propagate
return value of cfg->configure_dp_phy() all the way back to caller.
This is good. But I am also thinking if we should
On 3/28/2024 1:58 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2024-03-28 13:24:34)
+ Johan and Bjorn for FYI
On 3/28/2024 1:04 PM, Kuogee Hsieh wrote:
For internal HPD case, hpd_event_thread is created to handle HPD
interrupts generated by HPD block of DP controller. It converts
HPD
().
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_display.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Fixes: 542b37efc20e ("drm/msm/dp: Implement hpd_notify()")
Looks right to me,
Reviewed-by: Abhinav Kumar
t;drm/msm/dpu: Add X1E80100 support")
I cross-checked all the entries and this looks right.
Thanks for fixing this.
Reviewed-by: Abhinav Kumar
On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
Generate DRM/MSM headers on the fly during kernel build. This removes a
need to push register changes to Mesa with the following manual
synchronization step. Existing headers will be removed in the following
commits (split away to ease reviews).
On 3/26/2024 3:25 PM, Dmitry Baryshkov wrote:
On Wed, 27 Mar 2024 at 00:19, Abhinav Kumar wrote:
On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
Import the gen_headers.py script from Mesa, commit FIXME. This script
will be used to generate MSM register files on the fly during
compilation
On 3/26/2024 2:52 PM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 23:39, Abhinav Kumar wrote:
On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote:
In order to stop patching the mdp5 headers, import definitions for the
writeback blocks. This part is extracted from the old Rob's patch.
Co
On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
Import the gen_headers.py script from Mesa, commit FIXME. This script
will be used to generate MSM register files on the fly during
compilation.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/registers/gen_header.py | 957
/dsi/mmss_cc.xml.h | 131 --
1 file changed, 131 deletions(-)
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/hdmi/qfprom.xml.h | 61 ---
1 file changed, 61 deletions(-)
Reviewed-by: Abhinav Kumar
On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote:
In order to stop patching the mdp5 headers, import definitions for the
writeback blocks. This part is extracted from the old Rob's patch.
Co-developed-by: Rob Clark
Signed-off-by: Rob Clark
Signed-off-by: Dmitry Baryshkov
---
On 3/26/2024 12:47 PM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 21:32, Abhinav Kumar wrote:
On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar wrote:
On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:05, Miguel
On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar wrote:
On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda
wrote:
Hi,
In today's next, I got:
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6
On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda
wrote:
Hi,
In today's next, I got:
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable
'out' set but not used [-Werror,-Wunused-but-set-variable]
`out` seems to be there since
--
2 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Abhinav Kumar
On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote:
The max_per_pipe_ib is a constant across all CRTCs and is read from the
catalog. Drop corresponding calculations and read the value directly at
icc_set_bw() time.
Suggested-by: Konrad Dybcio
Signed-off-by: Dmitry Baryshkov
---
1 - 100 of 1990 matches
Mail list logo
