Re: [PATCH] drm/exynos: hdmi: report safe 640x480 mode as a fallback when no EDID found

2024-05-14 Thread Inki Dae
; able to drive such mode, so report a safe 640x480 mode instead of nothing > in case of the EDID reading failure. > > This fixes the following issue observed on Trats2 board since commit > 13d5b040363c ("drm/exynos: do not return negative values from .get_modes()"): Applied

Re: [PATCH] gpu: drm: exynos: hdmi: eliminate uses of of_node_put()

2024-04-25 Thread Inki Dae
Good cleanup. Applied. :) Thanks, Inki Dae 2024년 4월 15일 (월) 오전 9:40, Shivani Gupta 님이 작성: > > Utilize the __free() cleanup handler within the hdmi_get_phy_io function > to automatically release the device node when it is out of scope. > This eliminates the manual invocation of

[GIT PULL] exynos-drm-next

2024-04-24 Thread Inki Dae
problem. Thanks, Inki Dae The following changes since commit 83221064c28a0f9fdc4f63ab4fce2e51bfe23315: Merge tag 'drm-xe-next-2024-04-23' of https://gitlab.freedesktop.org/drm/xe/kernel into drm-next (2024-04-24 10:51:29 +1000) are available in the Git repository at: git://git.kernel.org/pub

[GIT PULL] drm-misc-fixes

2024-01-26 Thread Inki Dae
to the drm-exynos tree. This pull request is based on the latest drm-misc-fixes branch of the drm-misc tree. Please kindly let me know if there is any problem. Thanks, Inki Dae [1] https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/1151 The following changes since commit

Inquiry regarding the use of the dim tool

2024-01-21 Thread Inki Dae
c-fixes`. [1] https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/569 [2] https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html I'm still not quite familiar with using the dim tool. I'm sure there must be some aspects I'm missing. Could I please get some help with this? Thanks, Inki Dae

[GIT PULL] exynos-drm-fixes

2024-01-21 Thread Inki Dae
Hi Dave and Daniel, Just several fixups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a: Linux 6.7 (2024-01-07 12:18:38 -0800) are available in the Git repository at: git

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2024-01-18 Thread Inki Dae
Really sorry for late. Will pick it up. Thanks, Inki Dae 2024년 1월 9일 (화) 오후 9:50, Daniel Vetter 님이 작성: > On Tue, Jan 09, 2024 at 09:47:20AM +0100, Michael Walle wrote: > > Hi, > > > > > > Inki, are you picking this up? Or if not, who will? > > > > >

Re: [PATCH] drm/exynos: gsc: minor fix for loop iteration in gsc_runtime_resume

2023-12-20 Thread Inki Dae
> > Fixes: 8b7d3ec83aba ("drm/exynos: gsc: Convert driver to IPP v2 core > API") > > Signed-off-by: Fedor Pchelkin > Reviewed-by: Marek Szyprowski > Applied. Thanks, Inki Dae > --- > > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 +- > > 1 file

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2023-12-20 Thread Inki Dae
el Walle > >> --- > >> Let me know wether this should be two commits each reverting one, but > >> both > >> commits appeared first in kernel 6.5. > > > > Are there any news? > > Inki, are you picking this up? Or if not, who will? > I can pick it up but it would be better to go to the drm-misc tree. If nobody cares about it then I will pick it up. :) acked-by : Inki Dae Thanks, Inki Dae

Re: [PATCH] drm/exynos: fix accidental on-stack copy of exynos_drm_plane

2023-12-14 Thread Inki Dae
. > > > > Fixes: 6f8ee5c21722 ("drm/exynos: fimd: Make plane alpha configurable") > > Signed-off-by: Arnd Bergmann > > > Reviewed-by: Marek Szyprowski > Thanks, Inki Dae > > > > --- > > drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 4

[PATCH] drm/exynos: fix incorrect type issue

2023-12-14 Thread Inki Dae
Fix incorrect type issue in fimd_commit() of exynos_drm_fimd.c module. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312140930.me9ywf8f-...@intel.com/ Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH] dt-bindings: display: samsung, exynos-mixer: Fix 'regs' typo

2023-12-13 Thread Inki Dae
2023년 12월 14일 (목) 오전 7:43, Rob Herring 님이 작성: > The correct property name is 'reg' not 'regs'. > Thanks, Inki Dae > Fixes: 68e89bb36d58 ("dt-bindings: display: samsung,exynos-mixer: convert > to dtschema") > Signed-off-by: Rob Herring > --- > .../bindings

Re: [PATCH v3 08/16] drm/exynos: Convert to platform remove callback returning void

2023-12-11 Thread Inki Dae
From: Uwe Kleine-König > > > Sent: Wednesday, November 29, 2023 1:55 AM > > > To: Inki Dae > > > Cc: linux-samsung-...@vger.kernel.org; Daniel Vetter ; > > > Jingoo Han ; Seung-Woo Kim ; > > > Kyungmin Park ; DRI mailing list > > de...@lists.freed

[GIT PULL] exynos-drm-next

2023-12-11 Thread Inki Dae
Hi Dave and Daniel, Just one fixup to shutdown relevant issue and two cleanups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit a2f8994c1001cfa48483a3afa3550016a3ab0a3e: Merge tag 'exynos-drm-next-for-v6.7-rc5' of git

[GIT PULL RESEND] exynos-drm-fixes

2023-12-06 Thread Inki Dae
Hi Dave and Daniel, Just resending you the previous pull request[1] after resolving the build warning. [1] https://lore.kernel.org/dri-devel/20231120225537.1270358-1-inki@samsung.com/ Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes

[PATCH v2] drm/exynos: fix a wrong error checking

2023-11-27 Thread Inki Dae
-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_dma.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dma.c b/drivers/gpu/drm/exynos/exynos_drm_dma.c index a971590b8132..e2c7373f20c6 100644 --- a/drivers/gpu/drm/exynos

Re: [GIT PULL] exynos-drm-fixes

2023-11-27 Thread Inki Dae
Hi Dave, 2023년 11월 24일 (금) 오전 10:14, Dave Airlie 님이 작성: > On Tue, 21 Nov 2023 at 09:00, Inki Dae wrote: > > > > Hi Dave and Daniel, > > > >Two fixups - fixing a potential error pointer dereference and wrong > >error checking. > Hi Inki, > > This

[GIT PULL] exynos-drm-fixes

2023-11-20 Thread Inki Dae
Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 98b1cc82c4affc16f5598d4fa14b1858671b2263: Linux 6.7-rc2 (2023-11-19 15:02:14 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos

Re: [PATCH v3 08/16] drm/exynos: Convert to platform remove callback returning void

2023-11-07 Thread Inki Dae
Hi, Sorry for late. There was a merge conflict so I fixed it manually and merged. And seems your patch description is duplicated so dropped duplicated one. Thanks, Inki Dae 2023년 11월 3일 (금) 오전 1:57, Uwe Kleine-König 님이 작성: > The .remove() callback for a platform driver returns an int wh

[PATCH] drm/exynos: fix a wrong error checking

2023-11-01 Thread Inki Dae
)), which doesn't provide a suitable error value. So check if 'mapping' is NULL, and if it is, return ERR_PTR(-ENODEV). This issue[1] was reported by Dan. [1] https://www.spinics.net/lists/dri-devel/msg418271.html Reported-by : Dan Carpenter Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos

Re: [RFT PATCH v2 09/12] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time

2023-10-10 Thread Inki Dae
Hi, 2023년 10월 6일 (금) 오후 10:51, Doug Anderson 님이 작성: > > Hi, > > On Thu, Oct 5, 2023 at 7:20 PM Inki Dae wrote: > > > > Thanks for testing. :) > > > > Acked-by : Inki Dae > > Inki: does that mean you'd like this to go through drm-misc? I'm happy > t

[GIT PULL] exynos-drm-fixes

2023-10-05 Thread Inki Dae
Hi Dave and Daniel, Just one fixup to a potential error pointer dereference. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 8a749fd1a8720d4619c91c8b6e7528c0a355c0aa: Linux 6.6-rc4 (2023-10-01 14:15:13 -0700) are available

Re: [PATCH] drm: exynos: dsi: Convert to platform remove callback returning void

2023-10-05 Thread Inki Dae
are converted, .remove_new() is renamed to .remove(). > > samsung_dsim_remove() returned 0 unconditionally. Make it return void > instead to convert the two related platform drivers to use > .remove_new(). > > Signed-off-by: Uwe Kleine-König It'd be better to go to drm-misc. Reviewed-by

Re: [RFT PATCH v2 09/12] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time

2023-10-05 Thread Inki Dae
Thanks for testing. :) Acked-by : Inki Dae 2023년 9월 22일 (금) 오후 3:00, Marek Szyprowski 님이 작성: > > > On 21.09.2023 21:26, Douglas Anderson wrote: > > Based on grepping through the source code this driver appears to be > > missing a call to drm_atomic_helper_shutdown() at

Re: [PATCH 2/5] drm/bridge: samsung-dsim: reread ref clock before configuring PLL

2023-09-05 Thread Inki Dae
ulating the PLL > configuration parameters. > > Signed-off-by: Michael Tretter > Reviewed-by: Inki Dae Acked-by: Inki Dae Thanks, Inki Dae --- > drivers/gpu/drm/bridge/samsung-dsim.c | 16 +--- > include/drm/bridge/samsung-dsim.h | 1 + > 2 files ch

Re: [PATCH 2/5] drm/bridge: samsung-dsim: reread ref clock before configuring PLL

2023-09-05 Thread Inki Dae
2023년 9월 4일 (월) 오후 8:05, Michael Tretter 님이 작성: > On Mon, 04 Sep 2023 13:38:33 +0900, Inki Dae wrote: > > 2023년 8월 29일 (화) 오전 12:59, Michael Tretter 님이 > 작성: > > > > > > > > The PLL reference clock may change at runtime. Thus, reading the clock >

Re: [PATCH 3/5] drm/bridge: samsung-dsim: update PLL reference clock

2023-09-03 Thread Inki Dae
e between 2MHz and 30MHz? To other I.MX and Exynos engineers, please do not merge this patch until two SoC platforms are tested correctly. Thanks, Inki Dae > > Signed-off-by: Michael Tretter > --- > drivers/gpu/drm/bridge/samsung-dsim.c | 15 +-- > 1 file changed, 13 ins

Re: [PATCH 2/5] drm/bridge: samsung-dsim: reread ref clock before configuring PLL

2023-09-03 Thread Inki Dae
/bridge/samsung,mipi-dsim.yaml It says, "DISM oscillator clock frequency. If absent, the clock frequency of sclk_mipi will be used instead." However, this patch makes the sclk_mipi to be used first. Thanks, Inki Dae > fout = samsung_dsim_pll_find_pms(dsi, fin, freq, , , ); >

Re: [PATCH 1/5] drm/bridge: samsung-dsim: add more mipi-dsi device debug information

2023-09-03 Thread Inki Dae
MIPI device attach step. > > > > Signed-off-by: Marco Felsch > > Signed-off-by: Michael Tretter > > Reviewed-by: Adam Ford #imx8mm-beacon > Tested-by: Adam Ford #imx8mm-beacon Reviewed-by: Inki Dae Acked-by: Inki Dae > > > --- > > drivers/gpu/drm

Re: [PATCH -next] drm/exynos: fix a potential error pointer dereference

2023-08-28 Thread Inki Dae
-ENODEV), > which can not be used directly. Fix this by checking the return value > before using it. > Applied. Thanks, Inki Dae > > Signed-off-by: Xiang Yang > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drive

[GIT PULL] exynos-drm-next

2023-08-09 Thread Inki Dae
Hi Dave and Daniel, Just one fixup and cleanup. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit d9aa1da9a8cfb0387eb5703c15bd1f54421460ac: Merge tag 'drm-intel-gt-next-2023-08-04' of git://anongit.freedesktop.org/drm/drm-intel

Re: [PATCH -next] drm/exynos: remove redundant of_match_ptr

2023-08-03 Thread Inki Dae
on CONFIG_OF, it's almost always > > better to leave out the of_match_ptr(), since the only thing it can > > possibly do is to save a few bytes of .text if a driver can be used both > > with and without it. Hence we remove of_match_ptr. > > > > Signed-off-by: Zhu Wang &

[GIT PULL] exynos-drm-fixes

2023-06-06 Thread Inki Dae
Hi Dave and Daniel, Just two fixups to Exynos vidi and g2d drivers. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 9561de3a55bed6bdd44a12820ba81ec416e705a7: Linux 6.4-rc5 (2023-06-04 14:04:27 -0400) are available in the Git

Re: [PATCH] drm/exynos: vidi: fix a wrong error return

2023-05-22 Thread Inki Dae
through > > the ictl system call - vidi_connection_ioctl - is used instead of fake > one - > > face_edid_info. > > In this case, ctx->raw_edid object needs to be released because > ctx->raw_edid > > object is allocated and the edid object sent by user is copied to the > ctx- > > >raw_edid by kmemdup(). :) > > yes... yes... I sent you another e-mail after this :) > I didn't check the second email you sent. :) Thanks, Inki Dae > Thanks, > Andi >

[PATCH] drm/exynos: vidi: fix a wrong error return

2023-05-18 Thread Inki Dae
Fix a wrong error return by dropping an error return. When vidi driver is remvoed, if ctx->raw_edid isn't same as fake_edid_info then only what we have to is to free ctx->raw_edid so that driver removing can work correctly - it's not an error case. Signed-off-by: Inki Dae --- drivers/g

Re: [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-05-16 Thread Inki Dae
ial thing but how about renaming it? I think the postfix, 'new', is a very generic word. I think you could introduce another patch for it if you think it's reasonable. Thanks, Inki Dae > the driver core doesn't (and cannot) cope for errors during remove. The > only effect of a non-zero return

[GIT PULL] exynos-drm-fixes

2023-05-15 Thread Inki Dae
Hi Dave and Daniel, Just one fixup to graphics 2d module for exynos. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit d8843eebbbd15b78c6a7745717b3705eca923b0f: Merge tag 'amd-drm-fixes-6.4-2023-05-11' of https

Re: [PATCH 18/53] drm/exynos: Convert to platform remove callback returning void

2023-05-15 Thread Inki Dae
returning zero in > the remove callback to the void returning variant. Could you please update exynos_drm_vidi.c also? Seems you missed. Thanks, Inki Dae > > Signed-off-by: Uwe Kleine-König > --- > drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 6 ++ > drivers/gpu/drm/exy

Re: [PATCH] drm/exynos: g2d: staticize stubs in header

2023-05-14 Thread Inki Dae
2023년 5월 15일 (월) 오후 1:13, Inki Dae 님이 작성: > > Hi Krzysztof, > > 2023년 5월 7일 (일) 오후 11:48, Krzysztof Kozlowski > 님이 작성: > > > > Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static > > inline: > > Same patch[1] was posted before so I picked u

Re: [PATCH] drm/exynos: g2d: staticize stubs in header

2023-05-14 Thread Inki Dae
finitions (kernel.org) Thanks, Inki Dae > > drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous > prototype for ‘g2d_open’ [-Wmissing-prototypes] > drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous > prototype for ‘g2d_close’ [-Wmissing-prototypes] >

[GIT PULL v2] exynos-drm-next

2023-04-17 Thread Inki Dae
Hi Dave and Daniel, Sorry for late. Just one patch series which converts Exynos's fbdev code to struct drm_client. Please let me know if there is any problem. Thanks, Inki Dae The following changes since commit e82c98f2ca439356d5595ba8c9cd782f993f6f8c: Merge tag 'amd-drm-next-6.4-2023

Re: [GIT PULL] exynos-drm-next

2023-04-16 Thread Inki Dae
Hi Daniel, 2023년 3월 29일 (수) 오후 2:39, 대인기 님이 작성: > > > > > -Original Message- > > From: Daniel Vetter > > Sent: Wednesday, March 29, 2023 2:31 AM > > To: Inki Dae > > Cc: airl...@linux.ie; dan...@ffwll.ch; dri-devel@lists.freedesktop.org; > >

[GIT PULL] exynos-drm-next

2023-03-27 Thread Inki Dae
as well. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 46f28427f6f824b6cff06fa025a55350b7de454a: Merge tag 'drm-rcar-next-20230325' of git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux into drm-next (2023-03-27 18:20:20

Re: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge

2023-03-27 Thread Inki Dae
Hi, 2023년 3월 27일 (월) 오후 11:08, Neil Armstrong 님이 작성: > On 23/03/2023 16:34, Fabio Estevam wrote: > > Hi Inki, > > > > On Mon, Mar 13, 2023 at 9:51 PM Inki Dae wrote: > > > >>> Could you please apply v16? > >> > >> > >> I am

Re: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge

2023-03-13 Thread Inki Dae
ledgment from the bridge maintainers. However, if there are no further comments until next week, I will proceed with the pull-request. Thanks, Inki Dae > Thanks >

[GIT PULL] exynos-drm-next

2023-01-29 Thread Inki Dae
the review yet. [1] https://lore.kernel.org/linux-arm-kernel/d4267645-448c-f702-fcc3-6c534d9ec...@denx.de/T/ Please let me know if there is any problem. Thanks, Inki Dae The following changes since commit 68de345e101ce9a24e5c8849e69dd0dba2e8c9b2: Merge tag 'drm-misc-next-2023-01-24' of git

Re: [PATCH 09/26] drm: exynos: Remove #ifdef guards for PM related functions

2022-11-20 Thread Inki Dae
ch. > > Signed-off-by: Paul Cercueil Acked-by : Inki Dae Thanks for cleanup, Inki Dae > --- > Cc: Inki Dae > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Krzysztof Kozlowski > Cc: Alim Akhtar > Cc: Jingoo Han > Cc: linux-arm-ker...@lists.infradead.org >

[GIT PULL] exynos-drm-next

2022-09-25 Thread Inki Dae
Hi Dave and Daniel, Sorry for late. Just one cleanup and fixup which corrects return type. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 320305923c88258ce50c75bf721e9bf2e420ab27: Merge tag 'du-next-20220907' of git://linuxtv.org

Re: [PATCH] drm/exynos: fix repeated words in comments

2022-08-24 Thread Inki Dae
ot;next next" is correct. :) As you said, "next next" could be reworded more clearly. As of now, the original sentence could make it confusing. Thanks, Inki Dae > Robin. > > > Signed-off-by: Jilin Yuan > > --- > > drivers/gpu/drm/exynos/exynos_dr

[GIT PULL] exynos-drm-next

2022-07-12 Thread Inki Dae
Hi Dave and Daniel, Just two cleanups which remove invalid maintainer info and one fixup for releasing resouce. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit c6a3d73592ae20f2f6306f823aa5121c83c88223: Merge tag 'drm-intel-gt-next

Re: [PATCH] drm/exynos: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2022-06-24 Thread Inki Dae
m_detect_hdmi_monitor() and use drm_display_info.is_hdmi > instead. > Applied. Thanks, Inki Dae > Signed-off-by: hongao > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exy

Re: Exynos vblank timeout issue

2022-06-21 Thread Inki Dae
Hi Martin, 2022년 6월 4일 (토) 오후 8:05, Martin Jücker 님이 작성: > > On Sat, Jun 04, 2022 at 01:05:39PM +0900, Inki Dae wrote: > > Hi Martin, > > > > Hi Inki, > > > What kind of panel does Galaxy Note 10.1 use? I guess it uses I80 > > panel which needs CPU-tr

[GIT PULL] exynos-drm-fixes

2022-06-14 Thread Inki Dae
Hi Dave and Daniel, Just two regression fixups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3: Linux 5.19-rc2 (2022-06-12 16:11:37 -0700) are available in the Git repository at: git

Re: Exynos vblank timeout issue

2022-06-03 Thread Inki Dae
works or not in exynos_dsi_te_irq_handler function of exynos_drm_dsi.c Thanks, Inki Dae 2022년 5월 27일 (금) 오전 8:34, Martin Jücker 님이 작성: > > Hello again, > > I tried to dig around a bit to unearth some more information. What I'm > seeing is that it works just fine in the beginning, pla

Re: [PATCH] drm/exynos: mic: Rework initialization

2022-05-15 Thread Inki Dae
misc-next together with the > rest of Exynos DSI to drm bridge rework patches. The commit-id, dd8b6803bc49, has already been merged to drm-next. Seems no need to go drm-misc-next. So I will merge it as a regression fix after the review, which will be merged to 5.19-rc series. Please let me kn

Re: [PATCH] drm/exynos: fix IS_ERR() vs NULL check in probe

2022-04-20 Thread Inki Dae
Hi, 22. 4. 12. 13:19에 Dan Carpenter 이(가) 쓴 글: > On Tue, Apr 12, 2022 at 10:01:20AM +0900, Inki Dae wrote: >> Hi Dan Carpenter. >> >> Same patch[1] was posted so I will pick it up. >> >> [1] >> https://protect2.fireeye.com/v1/url?k=94e9d569-f562c05f-9

Re: [PATCH] drm/exynos: fix IS_ERR() vs NULL check in probe

2022-04-11 Thread Inki Dae
Hi Dan Carpenter. Same patch[1] was posted so I will pick it up. [1] https://www.spinics.net/lists/arm-kernel/msg967488.html Thanks, Inki Dae 22. 4. 8. 19:21에 Dan Carpenter 이(가) 쓴 글: > The of_drm_find_bridge() does not return error pointers, it returns > NULL on error. >

[GIT PULL] exynos-drm-next for v5.18

2022-03-04 Thread Inki Dae
Hi Dave and Daniel, Just adding BGR pixel format support per a plane. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit fedc89821990013608bc210c9aef5bb33a1345a7: drm/exynos: Search for TE-gpio in DSI panel's node (2022-03-04 17:13

Re: [PATCH v3 RESEND 21/24] drm/exynos/decon5433: add local path support

2022-03-01 Thread Inki Dae
s DT schema checks. Let me know if other approach > (revert of DTS change) should be taken. > Sorry for late response. As of now, "dsd" is a dead property not used anywhere. This patch series makes real user not to work correctly due to ABI change. How about reverting it until this patch series is merged after fixing the real user problem? Thanks, Inki Dae > Best regards, > Krzysztof >

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

2022-02-28 Thread Inki Dae
Hi Martin, 22. 2. 25. 18:33에 Martin Jücker 이(가) 쓴 글: > Hello Inki, > > On Fri, Feb 25, 2022 at 12:52:56PM +0900, Inki Dae wrote: >> Hi Martin, >> >> 22. 2. 25. 08:27에 Martin Jücker 이(가) 쓴 글: >>> Hello Inki, >>> >>> On Thu, Feb 24, 20

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

2022-02-24 Thread Inki Dae
Hi Martin, 22. 2. 25. 08:27에 Martin Jücker 이(가) 쓴 글: > Hello Inki, > > On Thu, Feb 24, 2022 at 10:41:04AM +0900, Inki Dae wrote: >> Hi Martin. >> >> I found that exynos4 and 5 data sheet include documented same register. >> RGB_ORDER_E field of VIDCONx regist

[GIT PULL] exynos-drm-fixes for rc6

2022-02-24 Thread Inki Dae
Hi Dave and Daniel, Just fixups series. Ps. my previous git-pull request[1] isn't merged so I'm sending it again after rebasing on top of drm-fixes. Please kindly let me know if there is any problem. Thanks, Inki Dae [1] https://www.spinics.net/lists/dri-devel/msg333237.html

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

2022-02-23 Thread Inki Dae
register only. Sorry for late and thanks, Inki Dae 22. 1. 30. 07:01에 Martin Jücker 이(가) 쓴 글: > In the downstream kernels for exynos4 and exynos5 devices, there is an > undocumented register that controls the order of the RGB output. It can > be set to either normal order or reversed, whic

Re: [GIT PULL] exynos-drm-fixes

2022-02-22 Thread Inki Dae
Hi Dave, Seems you missed. Is there any issue? Thanks, Inki Dae 22. 2. 10. 20:07에 Inki Dae 이(가) 쓴 글: > Hi Dave and Daniel, > >Just two fixup series - one is to fix irq chaining issue and other is >regressions to TE-gpio handling. > > Please let me know if th

[GIT PULL] exynos-drm-fixes

2022-02-10 Thread Inki Dae
Hi Dave and Daniel, Just two fixup series - one is to fix irq chaining issue and other is regressions to TE-gpio handling. Please let me know if there is any problem. Thanks, Inki Dae The following changes since commit dfd42facf1e4ada021b939b4e19c935dcdd55566: Linux 5.17-rc3 (2022-02

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

2022-02-02 Thread Inki Dae
Hi Martin. Thanks for your contribution, Inki Dae 22. 1. 30. 07:01에 Martin Jücker 이(가) 쓴 글: > In the downstream kernels for exynos4 and exynos5 devices, there is an > undocumented register that controls the order of the RGB output. It can > be set to either normal order or revers

Re: [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node

2022-01-27 Thread Inki Dae
Hi, 22. 1. 25. 00:22에 Henrik Grimler 이(가) 쓴 글: > Hi Marek, > > On Mon, Jan 24, 2022 at 02:52:46PM +0100, Marek Szyprowski wrote: >> TE-gpio, if defined, is placed in the panel's node, not the parent DSI >> node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and >> pass proper

Re: [PATCH] drm/exynos: Don't fail if no TE-gpio is defined for DSI driver

2022-01-23 Thread Inki Dae
Hi Marek, Thanks for fixing it. Inki Dae. 22. 1. 21. 19:00에 Marek Szyprowski 이(가) 쓴 글: > TE-gpio is optional and if it is not found then gpiod_get_optional() > returns NULL. In such case the code will continue and try to convert NULL > gpiod to irq what in turn fails. Th

Re: [PATCH] Revert "drm: exynos: dsi: Convert to bridge driver"

2022-01-18 Thread Inki Dae
Hi, 22. 1. 17. 오후 6:55에 Robert Foss 이(가) 쓴 글: > Hi Inki, > > On Fri, 14 Jan 2022 at 02:18, Inki Dae wrote: >> >> Hi Robert, >> >> 22. 1. 12. 오후 7:05에 Robert Foss 이(가) 쓴 글: >>> Thank you again for catching this and submitting a revert. >>> >

Re: [PATCH 0/5] drm/exynos: Use platform_get_irq*() variants to fetch IRQ's

2022-01-14 Thread Inki Dae
ce() was agreed based on > the discussion [0]. > > [0] https://patchwork.kernel.org/project/linux-renesas-soc/ > patch/20211209001056.29774-1-prabhakar.mahadev-lad...@bp.renesas.com/ > Applied. Thanks, Inki Dae > Cheers, > Prabhakar > > Lad Prabhakar (5): > drm/exynos/exyn

Re: [PATCH 2/5] drm/exynos: mixer: Use platform_get_irq() to get the interrupt

2022-01-14 Thread Inki Dae
ll call -EPROBE_DEFER like below so it must be no problem :), in exynos_drm_platform_probe function component_master_add_with_match() in component_master_add_with_match function try_to_bring_up_master() Thanks, Inki Dae > > Cheers, > Prabhakar > --- > drivers/gpu/drm/exynos/exynos_mi

Re: [PATCH] Revert "drm: exynos: dsi: Convert to bridge driver"

2022-01-13 Thread Inki Dae
ge conflict may happen on drm-next because drm-misc-next has this patch set exynos-drm-next tree doesn't include. Leaving this patch history in drm-misc-next is correct? Thanks, Inki Dae

[GIT PULL] exynos-drm-next

2021-12-21 Thread Inki Dae
Hi Dave and Daniel, Just four cleanups such as replacing the use of legacy interface, implementing generic gem mmap, fixing a build warning and dropping unnecessary code. Please let me know if there is any problem. Thanks, Inki Dae The following changes since commit

[PATCH] drm/exynos: drop the use of label from exynos_dsi_register_te_irq

2021-11-30 Thread Inki Dae
://www.spinics.net/lists/dri-devel/msg323803.html Reported-by: kernel test robot Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c

Re: [PATCH 1/3] drm/exynox: Implement mmap as GEM object function

2021-11-09 Thread Inki Dae
lgtm, but would still be good if exynos maintainers would > ack/review/test it. But if you don't get anything within 2 weeks here's Sorry for late. Confirmed working well on Odroid board, and had a review. Applied. https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/log/?h=exy

Re: [PATCH] drm/exynos: Replace legacy gpio interface for gpiod interface

2021-11-09 Thread Inki Dae
Hi, 21. 11. 2. 오전 11:20에 Maíra Canal 이(가) 쓴 글: > Considering the current transition of the GPIO subsystem, remove all > dependencies of the legacy GPIO interface (linux/gpio.h and linux > /of_gpio.h) and replace it with the descriptor-based GPIO approach. > Applied. Thanks, Inki D

Re: [PATCH 1/3] drm/exynox: Implement mmap as GEM object function

2021-11-08 Thread Inki Dae
Hi, Really sorry for late. I saw this patch in my mailbox just before. Seems I missed it due to a typo, exynox. I will review and apply this patch ASAP. Thanks, Inki Dae 21. 11. 8. 오후 7:28에 Thomas Zimmermann 이(가) 쓴 글: > Moving the driver-specific mmap code into a GEM object function all

Re: [PATCH v2 06/13] drm/exynos: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-26 Thread Inki Dae
21. 10. 27. 오전 7:28에 Inki Dae 이(가) 쓴 글: > Hi, > > 21. 10. 17. 오전 3:42에 Claudio Suarez 이(가) 쓴 글: >> Once EDID is parsed, the monitor HDMI support information is available >> through drm_display_info.is_hdmi. Retriving the same information with >> drm_detect_hdmi_

Re: [PATCH v2 06/13] drm/exynos: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-26 Thread Inki Dae
rom EDID. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/gpu/drm/drm_edid.c?h=v5.14.14#n4725 Signed-off-by: Inki Dae Thanks, Inki Dae > DRM_DEV_DEBUG_KMS(hdata->dev, "%s : width[%d] x height[%d]\n", > (hd

[GIT PULL] exynos-drm-fixes

2021-09-28 Thread Inki Dae
Hi Dave, Just one clean up to use helper function. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f: Linux 5.15-rc1 (2021-09-12 16:28:37 -0700) are available in the Git repository at: git

Re: [PATCH] drm/exynos: Make use of the helper function devm_platform_ioremap_resource()

2021-09-15 Thread Inki Dae
21. 8. 31. 오후 4:49에 Cai Huoqing 이(가) 쓴 글: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > Picked it up. Thanks, Inki Dae > Signed-off-by: Cai Huoqing > --- > d

[GIT PULL] exynos-drm-next

2021-08-21 Thread Inki Dae
Hi Dave, Just two fixups - fixing one build warning and missing unlock, and one cleanup - replaceing atomic_t with refcount_t. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 397ab98e2d69cede8a28eab77a171983d14e: Merge tag

Re: [RFC PATCH 06/17] drm/exynos: dsi: Handle exynos specifics via driver_data

2021-08-17 Thread Inki Dae
Hi Laurent, 21. 8. 13. 오후 9:16에 Laurent Pinchart 이(가) 쓴 글: > Hi Inki, > > On Fri, Aug 13, 2021 at 03:50:56PM +0900, Inki Dae wrote: >> 21. 7. 26. 오전 2:25에 Sam Ravnborg 이(가) 쓴 글: >>> On Sun, Jul 04, 2021 at 02:32:19PM +0530, Jagan Teki wrote: >>>> Exynos DSI dr

Re: [RFC PATCH 06/17] drm/exynos: dsi: Handle exynos specifics via driver_data

2021-08-13 Thread Inki Dae
, I think MIPI DSI Driver - interrupt handler and probing order things are really specific to device driver - should be separated but we could share the control part of the device. I was busy with other projects so didn't care of Linux DRM world so there may be my missing something. Thanks,

Re: [PATCH -next] drm/exynos: g2d: fix missing unlock on error in g2d_runqueue_worker()

2021-07-25 Thread Inki Dae
Sorry for late and thanks for fixing it. Thanks, Inki Dae 2021년 6월 16일 수요일, Wei Yongjun 님이 작성: > Add the missing unlock before return from function g2d_runqueue_worker() > in the error handling case. > > Fixes: 445d3bed75de ("drm/exynos: use pm_runtime_resume_and_get()"

[GIT PULL] exynos-drm-next

2021-06-10 Thread Inki Dae
Hi Dave, Just two cleanups to replace pm_runtime_get_sync() with pm_runtime_resume_and_get(). Please kinkdly let me know if there is any problem. Thanks, Inki Dae The following changes since commit c707b73f0cfb1acc94a20389aecde65e6385349b: Merge tag 'amd-drm-next-5.14-2021-06-09

[PATCH v2] drm/exynos: use pm_runtime_resume_and_get()

2021-05-26 Thread Inki Dae
decreases the usage counter when it failed internally so it can avoid the reference leak. Changelog v1: - Fix an build error reported by kernel test robot of Intel. Signed-off-by: Inki Dae Reported-by: kernel test robot --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 7 +- drivers/gpu/drm

[PATCH] drm/exynos: use pm_runtime_resume_and_get()

2021-05-25 Thread Inki Dae
decreases the usage counter when it failed internally so it can avoid the reference leak. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 7 +- drivers/gpu/drm/exynos/exynos7_drm_decon.c| 7 +- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 7

Re: [PATCH v2] drm/exynos: Use pm_runtime_resume_and_get() to replace open coding

2021-05-24 Thread Inki Dae
s the > refcount even if it fails, which ususally leads to leaks. Tian Tao, could you update the description? Thanks, Inki Dae > > With that or similar added to the commit message: > > Reviewed-by: Daniel Vetter > >> >> Signed-off-by: Tian Tao >>

[GIT PULL] exynos-drm-fixes

2021-05-19 Thread Inki Dae
Hi Dave, Just one fixup to kerneldoc and two cleanups to drop redundant error messages. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit d07f6ca923ea0927a1024dfccafc5b53b61cfecc: Linux 5.13-rc2 (2021-05-16 15:27:44 -0700

Re: [PATCH 03/12] drm/exynos: Don't set allow_fb_modifiers explicitly

2021-04-20 Thread Inki Dae
done automatically as part of plane init, if drivers set the > modifier list correctly. Which is the case here. > > Signed-off-by: Daniel Vetter Acked-by: Inki Dae Thanks, Inki Dae > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park

[GIT PULL] exynos-drm-next

2021-03-30 Thread Inki Dae
if there is any problem. Thanks, Inki Dae [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next-history.git/commit/?id=cbe16f35bee6880becca6f20d2ebf6b457148552 The following changes since commit 99e5730dd2b11fedc890bbc9c803f69aad24e3ca: Merge tag 'irq-no-autoen-2021-03-25' of git

[GIT PULL] exynos-drm-fixes

2021-03-29 Thread Inki Dae
Hi Dave, Just one cleanup to drop unused header inclusion. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 09d78dde88ef95a27b54a6e450ee700ccabdf39d: Merge tag 'drm-msm-fixes-2021-02-25' of https://gitlab.freedesktop.org/drm/msm

Re: [PATCH] drm/exynos/decon5433: Clean up GPIO includes

2021-03-15 Thread Inki Dae
21. 3. 15. 오후 3:45에 tiantao (H) 이(가) 쓴 글: > > 在 2021/3/15 14:35, Inki Dae 写道: >> Hi Tian Tao, >> >> 21. 3. 2. 오후 12:03에 Tian Tao 이(가) 쓴 글: >>> remove the legacy GPIO headers but what it really >>> uses is since only gpio_desc structs are ever >&g

Re: [PATCH] drm/exynos/decon5433: Clean up GPIO includes

2021-03-15 Thread Inki Dae
Hi Tian Tao, 21. 3. 2. 오후 12:03에 Tian Tao 이(가) 쓴 글: > remove the legacy GPIO headers but what it really > uses is since only gpio_desc structs are ever > referenced. This driver doesn't reference even linux/gpio/consumer.h so could you drop only of_gpio.h inclusion? Thanks,

[GIT PULL] exynos-drm-next

2020-11-30 Thread Inki Dae
Hi Dave, Just a new mode support for HDMI and two clenups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 22f8c80566c4a29a0d8b5ebf24aa1fd1679b39e5: Merge tag 'drm-misc-next-2020-11-18' of ssh://git.freedesktop.org/git/drm/drm

[GIT PULL] exynos-drm-fixes

2020-11-23 Thread Inki Dae
Hi Dave, Just one bug fix to a build error due to common framework dependency. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 6600f9d52213b5c3455481b5c9e61cf5e305c0e6: Merge tag 'drm-intel-fixes-2020-11-19' of git

Re: [PATCH 1/2] drm/exynos: depend on COMMON_CLK to fix compile tests

2020-11-22 Thread Inki Dae
/exynos_mixer.o: in > function `mixer_bind': > exynos_mixer.c:(.text+0x958): undefined reference to `clk_set_parent' > > Reported-by: kernel test robot > Signed-off-by: Krzysztof Kozlowski Picked it up. Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/Kconfig | 3 ++- &

Re: [PATCH v2 00/16] drm/exynos: Convert driver to drm bridge

2020-11-13 Thread Inki Dae
20. 11. 11. 오후 7:18에 Michael Tretter 이(가) 쓴 글: > On Wed, 11 Nov 2020 12:11:15 +0900, Inki Dae wrote: >> 20. 11. 11. 오후 12:04에 Inki Dae 이(가) 쓴 글: >>> 20. 11. 10. 오후 5:13에 Michael Tretter 이(가) 쓴 글: >>>> On Mon, 09 Nov 2020 12:15:39 +0900, Inki Dae wrote: >>>

Re: [PATCH v2 00/16] drm/exynos: Convert driver to drm bridge

2020-11-10 Thread Inki Dae
20. 11. 11. 오후 12:04에 Inki Dae 이(가) 쓴 글: > > > 20. 11. 10. 오후 5:13에 Michael Tretter 이(가) 쓴 글: >> On Mon, 09 Nov 2020 12:15:39 +0900, Inki Dae wrote: >>> 20. 9. 11. 오후 10:53에 Michael Tretter 이(가) 쓴 글: >>>> This is v2 of the series to convert the Exynos MI

  1   2   3   4   5   6   7   8   9   10   >