Re: [RFC PATCH 2/3] drm/tidss: Add support for display sharing

it was to crash. >> >> But it looks like it's not the main point of this series, so could you >> share some use-cases you're trying to address? >> > > The end use-case we have demonstrated right now with this series is a > proof-of-concept display cluster use-case where RTOS boots early on MCU core > (launched at bootloader stage) and initializes the display (using the global > common0 register space and irq) and starts displaying safety tell-tales on one > plane, and once Linux boots up on application processor, > Linux (using common1 register space and irq) controls the other plane with GPU > rendering using a QT based application. And yes, we also support the scenario > where Linux crashes but RTOS being the DSS master and in control of DSS power, > clock domain and global register space is not impacted by the crash. You mention 2 scenarios but are actually the same? Or did I misunderstand? In both cases the RTOS own the display pipeline and Linux can just display using a single plane. That's why I think that agree with Maxime, that a fwkms could be a simpler solution to your use case instead of adding all this complexity to the DSS driver. Yes, I understand the HW supports all this flexibility but there's no real use case yet (you mentioned that don't even have firmware for this single plane owned by the RTOS in the R5F case). The DT binding for a fwkms driver would be trivial, in fact maybe we might even leverage simpledrm for this case and not require a new driver at all. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] drm/fbdev-dma: Clean up deferred I/O

Thomas Zimmermann > Cc: Javier Martinez Canillas > Cc: Maarten Lankhorst > Cc: Maxime Ripard > --- > drivers/gpu/drm/drm_fbdev_dma.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] drm/fbdev-shmem: Clean up deferred I/O

Thomas Zimmermann writes: Hello Thomas, > Call fb_deferred_io_cleanup() upon destroying the framebuffer > device. Releases the internal memory. > > Signed-off-by: Thomas Zimmermann > Fixes: 150f431a0831 ("drm/fbdev: Add fbdev-shmem") > Cc: Thomas Zimmermann &g

Re: [PATCH] drm: use "0" instead of "" for deprecated driver date

98e8 ("drm: deprecate driver date") > Signed-off-by: Jani Nikula > --- It's a pity that libdrm can't cope with the empty string, using 0 makes sense. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: simpledrm, running display servers, and drivers replacing simpledrm while the display server is running

er-space bugs for me and doing anything in the kernel is papering over the real problem IMO. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] drm: deprecate driver date

I never understood the value of it and so this patch makes sense to me. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] drm/panthor: Add defer probe for firmware load

Steven Price writes: > Hi Javier, > > On 25/04/2024 10:22, Javier Martinez Canillas wrote: >> Steven Price writes: >> >> Hello Steven, >> >>> On 13/04/2024 12:49, Andy Yan wrote: >>>> From: Andy Yan >>>&g

Re: [PATCH] drm/panthor: Add defer probe for firmware load

lper function) that changes the request firmare behaviour to return -EPROBE_DEFER instead of -ENOENT. Since as you mentioned, this isn't specific to panthor and an issue that I also faced with the powervr driver. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 29/43] drm/renesas/rz-du: Use fbdev-dma

Biju Das > Tested-by: Biju Das > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 19/43] drm/virtio: Use fbdev-shmem

Cc: Chia-I Wu > Tested-by: Dmitry Osipenko > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 21/43] drm/fbdev-dma: Implement damage handling and deferred I/O

Thomas Zimmermann writes: > Hi > > Am 16.04.24 um 14:18 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> [...] >>> +static int drm_fbdev_dma_fb_mmap(struct fb_info *info, struct >>> vm_area_struct *vma) >>> +{ >

Re: [PATCH v2 43/43] drm/fbdev: Clean up fbdev documentation

c: Jonathan Corbet > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 42/43] drm/fbdev-generic: Convert to fbdev-ttm

for loongson. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 36/43] drm/tiny/ili9486: Use fbdev-dma

--- > drivers/gpu/drm/tiny/ili9486.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 35/43] drm/tiny/ili9341: Use fbdev-dma

> Cc: Kamlesh Gurudasani > --- > drivers/gpu/drm/tiny/ili9341.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 33/43] drm/tiny/ili9163: Use fbdev-dma

> --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 32/43] drm/tiny/hx8357d: Use fbdev-dma

> --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 31/43] drm/rockchip: Use fbdev-dma

t; Cc: Sandy Huang > Cc: "Heiko Stübner" > Cc: Andy Yan > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 27/43] drm/panel/panel-ilitek-9341: Use fbdev-dma

ermann > Cc: Neil Armstrong > Cc: Jessica Zhang > Cc: Sam Ravnborg > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 26/43] drm/mediatek: Use fbdev-dma

Cc: Chun-Kuang Hu > Cc: Philipp Zabel > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 24/43] drm/imx/lcdc: Use fbdev-dma

c: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > --- > drivers/gpu/drm/imx/lcdc/imx-lcdc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 23/43] drm/hisilicon/kirin: Use fbdev-dma

Xinliang Liu > Cc: Tian Tao > Cc: Xinwei Kong > Cc: Sumit Semwal > Cc: Yongqin Liu > Cc: John Stultz > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Javier Martinez Canillas -- Be

Re: [PATCH v2 08/43] drm/fbdev: Add fbdev-shmem

o only look at that if info->screen_size is not set ? > > The fbdev core doesn't use smem_len AFAICT. But smem_len is part of the > fbdev UAPI, so I set it. I assume that programs use it to go to the end > of the framebuffer memory. > I see. Makes sense. > Best regards > Thomas > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 21/43] drm/fbdev-dma: Implement damage handling and deferred I/O

tecombine(vma->vm_page_prot); I noticed that some drivers do: vma->vm_page_prot = pgprot_writecombine(vm_get_page_prot(vma->vm_flags)); I see that vm_get_page_prot() is a per-architecture function, but I don't know about the implications of getting the pgprot_t from th

Re: [PATCH v2 20/43] drm/vkms: Use fbdev-shmem

t; > Cc: Haneen Mohammed > Cc: Daniel Vetter > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 18/43] drm/udl: Use fbdev-shmem

- > drivers/gpu/drm/udl/udl_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2 17/43] drm/tiny/simpledrm: Use fbdev-shmem

Thomas Zimmermann writes: > Implement fbdev emulation with fbdev-shmem. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Thomas Zimmermann > Cc: Javier Martinez Canillas > --- &g

Re: [PATCH v2 16/43] drm/tiny/ofdrm: Use fbdev-shmem

Thomas Zimmermann writes: > Implement fbdev emulation with fbdev-shmem. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Thomas Zimmermann > Cc: Javier Martinez Canillas > --- &g

Re: [PATCH v2 14/43] drm/tiny/cirrus: Use fbdev-shmem

Thomas Zimmermann writes: > Implement fbdev emulation with fbdev-shmem. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Ma

Re: [PATCH v2 13/43] drm/solomon: Use fbdev-shmem

Thomas Zimmermann writes: > Implement fbdev emulation with fbdev-shmem. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Javier Martinez Canillas > --- Reviewed-by: Javier Martinez C

Re: [PATCH v2 08/43] drm/fbdev: Add fbdev-shmem

ect's > SHMEM pages. Fbdev's deferred-I/O mechanism updates the hardware state > on write operations. > > v2: > - use drm_driver_legacy_fb_format() (Geert) > > Signed-off-by: Thomas Zimmermann > --- Patch looks good to me. Reviewed-by: Javier Martinez Canillas Just a cou

Re: [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS

y: Neil Armstrong > > I think we'll need maxime or thomas ack to apply this via drm-misc-next > I don't think you need an explicit ack for them to commit it: https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html#merge-criteria BTW, the patch looks good to me as well. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] drm: remove unused header gma_drm.h

Jani Nikula writes: > gma_drm.h has become an empty, unused header. Remove. > > Cc: Patrik Jakobsson > Signed-off-by: Jani Nikula > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus

Signed-off-by: Thomas Zimmermann > Fixes: 8813e86f6d82 ("fbdev: Remove default file-I/O implementations") > Cc: Thomas Zimmermann > Cc: Javier Martinez Canillas > Cc: Daniel Vetter > Cc: Helge Deller > Cc: Sam Ravnborg > Cc: Arnd Bergmann > Cc: Geert Uytterho

Re: drm/tiny: QUESTION: What to use instead of drm_simple_display_pipe ?

> Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Frankenstrasse 146, 90461 Nuernberg, Germany > GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman > HRB 36809 (AG Nuernberg) > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 07/43] fbdev/deferred-io: Provide get_page hook in struct fb_deferred_io

's fbdev emulation with GEM-shemem buffer GEM-shmem > objects. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 06/43] fbdev/deferred-io: Always call get_page() for framebuffer pages

seful for DRM's > fbdev emulation. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 05/43] fbdev/deferred-io: Test smem_start for I/O memory

Thomas Zimmermann writes: > Test smem_start before looking up pages from its value. Return > NULL if it is unset. This will result in a SIGBUS signal. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas

Re: [PATCH 01/43] drm/fbdev-generic: Do not set physical framebuffer address

> > > on dedicated ARM configs. No functional change is expected. >> > > >> > > Signed-off-by: Thomas Zimmermann >> > > Fixes: a5b44c4adb16 ("drm/fbdev-generic: Always use shadow buffering") >> > > Cc: Thomas Zimmermann &g

Re: [PATCH 04/43] fbdev/deferred-io: Test screen_buffer for vmalloc'ed memory

Thomas Zimmermann writes: > Framebuffers in virtual memory are available via screen_buffer. Use > it instead of screen_base and avoid the type casting. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas

Re: [PATCH 03/43] fbdev/deferred-io: Clean up pageref on lastclose

t; --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 02/43] fbdev/deferred-io: Move pageref setup into separate helper

pageref structs. The > setup of the various fields happens when the pageref is required. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 01/43] drm/fbdev-generic: Do not set physical framebuffer address

y or just cares about the phyisical start address ? > Signed-off-by: Thomas Zimmermann > Fixes: a5b44c4adb16 ("drm/fbdev-generic: Always use shadow buffering") > Cc: Thomas Zimmermann > Cc: Javier Martinez Canillas > Cc: Zack Rusin > Cc: Maarten Lankhorst > Cc: Ma

Re: [PATCH] drm/shmem-helper: Remove duplicate include

Javier Martinez Canillas writes: > Jiapeng Chong writes: > >> ./drivers/gpu/drm/drm_gem_shmem_helper.c: linux/module.h is included more >> than once. >> >> Reported-by: Abaci Robot >> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=

Re: [PATCH] Revert "drm/udl: Add ARGB8888 as a format"

. Userspace needs to be fixed to accept > XRGB. > > [1] https://lore.kernel.org/r/60dc7697-d7a0-4bf4-a22e-32f1bbb79...@suse.de > > Signed-off-by: Douglas Anderson > --- > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [RESEND v3 2/2] drm: Add CONFIG_DRM_WERROR

nd on COMPILE_TEST > > Reviewed-by: Hamza Mahfooz # v1 > Signed-off-by: Jani Nikula > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] drm/tidss: Use dev_err_probe() over dev_dbg() when failing to probe the port

before I forget. > --- Makes sense to me and I agree that's useful to have that information there. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] drm: Remove drm_num_crtcs() helper

this helper would be needed. Your patch makes sense to me. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] MAINTAINERS: Update drm.git URL

On Mon, Feb 26, 2024 at 5:13 PM Maxime Ripard wrote: > > On Mon, Feb 26, 2024 at 04:43:04PM +0100, Javier Martinez Canillas wrote: > > Maxime Ripard writes: > > > > Hello Maxime, > > > > > Now that the main DRM tree has moved to Gitlab, adjust the

Re: [PATCH] MAINTAINERS: Update drm.git URL

oint to the git://anongit.freedesktop.org/drm/drm-misc tree ? Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2] drm/tegra: Remove existing framebuffer only if we support display

this is drm-misc-fixes material. Since the tegra DRM will remove simple{fb,drm} for Tegra234, even when the driver does not support display on that platform, leaving the system with no display output at all. Are you going to push this patch or is going to be done by Thierry? > Best regards > Thomas > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2] drm/tegra: Remove existing framebuffer only if we support display

clear DRIVER_MODESET and DRIVER_ATOMIC feature bits > > Signed-off-by: Thierry Reding > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 01/10] backlight: Match backlight device against struct fb_info.bl_dev

Thomas Zimmermann writes: > Hi > > Am 20.02.24 um 10:17 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >> Hello Thomas, >> >>> Framebuffer drivers for devices with dedicated backlight are supposed >>> to set struct fb_in

Re: [PATCH 10/10] backlight: Add controls_device callback to struct backlight_ops

and easier to understand what it does. But not strong opinion on that, Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 09/10] fbdev/ssd1307fb: Remove struct backlight_ops.check_fb

Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 08/10] fbdev/ssd1307fb: Init backlight before registering framebuffer

g the backlight device. So like > in all other backlight drivers, we now give the backlight device a > generic name without the fbdev index. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 07/10] fbdev/sh_mobile_lcdc_fb: Remove struct backlight_ops.check_fb

Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 06/10] backlight/pwm-backlight: Remove struct backlight_ops.check_fb

. > > Signed-off-by: Thomas Zimmermann > Cc: "Uwe Kleine-König" > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 05/10] backlight/aat2870-backlight: Remove struct backlight.check_fb

Thomas Zimmermann writes: > The driver's implementation of check_fb always returns true, which > is the default if no implementation has been set. So remove the code > from the driver. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Bes

Re: [PATCH 04/10] hid/hid-picolcd: Remove struct backlight_ops.check_fb

tively, you could include a preparatory patch to fix the HID_PICOLCD_BACKLIGHT config symbol dependencies. Other than that, Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 03/10] hid/hid-picolcd: Fix initialization order

Thomas Zimmermann writes: > For drivers that support backlight, LCD and fbdev devices, fbdev has > to be initialized last. See documentation for struct fbinfo.bl_dev. > > Signed-off-by: Thomas Zimmermann > Cc: "Bruno Prémont" > --- Reviewed-by: Javier Martinez

Re: [PATCH 02/10] auxdisplay/ht16k33: Remove struct backlight_ops.check_fb

s Zimmermann > Cc: Robin van der Gracht > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 01/10] backlight: Match backlight device against struct fb_info.bl_dev

ENABLED(CONFIG_FB_BACKLIGHT) > + else if (info->bl_dev && info->bl_dev != bd) If the driver doesn't provide a struct backlight_ops .check_fb callback, I think that having an info->bl_dev should be mandatory ? Or at least maybe there should be a warning if info->bl_dev

Re: [PATCH] drm/dp: Don't attempt AUX transfers when eDP panels are not powered

problems to those of us in ChromeOS. > Maybe +Javier would be interested in providing a Tested-by? > I do have a SC7180 based HP X2 Chromebook and could test your patch (not today but I could do it early next week), although I haven't followed so if you could please let me know what exactly do you want me to verify. AFAIU the problem is that the fwupd daemon tries to scan DP busses even if the panel is turned off and that's what takes a lot of time (due retries), and your patch makes the driver to bail out immediately ? If that's the case, I guess that just starting fwupd daemon with an without your patch while the panel is turned off could be a good test ? > [1] https://crrev.com/c/5277322 > [2] https://crrev.com/c/5277736 > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] drm: ci: use clk_ignore_unused for apq8016

lab.freedesktop.org/drm/msm/-/jobs/54990475 > > Fixes: 0119c894ab0d ("drm: Add initial ci/ subdirectory") > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Javier Martinez Canillas > drivers/gpu/drm/ci/test.yml | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [PATCH] fbdev/sh7760fb: allow modular build

h7760fb: Depend on FB=y") > Suggested-by: Geert Uytterhoeven > Signed-off-by: Randy Dunlap > Cc: Thomas Zimmermann > Cc: Javier Martinez Canillas > Cc: John Paul Adrian Glaubitz > Cc: Sam Ravnborg > Cc: Helge Deller > Cc: linux-fb...@vger.kernel.org > Cc: dri-d

Re: [PATCH] fbdev: Restrict FB_SH_MOBILE_LCDC to SuperH

se platforms have been converted to the SH-Mobile DRM > driver, using DT. > > Suggested-by: Arnd Bergmann > Signed-off-by: Geert Uytterhoeven > --- > Commit f402f7a02af6956d is in staging-next (next-20240129 and later). > --- Makes senes to me. Acked-by: Javier Martinez Ca

Re: [PATCH 2/8] video: Provide screen_info_get_pci_dev() to find screen_info's PCI device

Thomas Zimmermann writes: > Hi > > Am 29.01.24 um 12:04 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >>> Add screen_info_get_pci_dev() to find the PCI device of an instance >>> of screen_info. Does nothing on systems without

Re: [PATCH 8/8] fbdev/efifb: Remove framebuffer relocation tracking

. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 7/8] firmware/sysfb: Update screen_info for relocated EFI framebuffers

Javier Martinez Canillas writes: > Thomas Zimmermann writes: > >> On ARM PCI systems, the PCI hierarchy might be reconfigured during >> boot and the firmware framebuffer might move as a result of that. >> The values in screen_info will then be invalid. >> >>

Re: [PATCH 7/8] firmware/sysfb: Update screen_info for relocated EFI framebuffers

> covers the framebuffer") for more information. > > Signed-off-by: Thomas Zimmermann > --- [...] > #if defined(CONFIG_PCI) Shouldn't this be && !defined(CONFIG_X86) ? Or maybe && defined(CONFIG_ARM64), although I don't know if the same also applies to other EF

Re: [PATCH 6/8] fbdev/efifb: Do not track parent device status

Thomas Zimmermann writes: > There will be no EFI framebuffer device for disabled parent devices > and thus we never probe efifb in that case. Hence remove the tracking > code from efifb. > > Signed-off-by: Thomas Zimmermann > --- Nice cleanup. Reviewed-by: Javier Martinez C

Re: [PATCH 5/8] firmware/sysfb: Create firmware device only for enabled PCI devices

IBIOS_SUCCESSFUL) > + return false; > + if (!(command & PCI_COMMAND_MEMORY)) > + return false; > + return true; > +#else > + // Getting here without PCI support is probably a bug. > + return false; Should we warn before return in this case ? Revi

Re: [PATCH 4/8] fbdev/efifb: Remove PM for parent device

y: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 3/8] firmware/sysfb: Set firmware-framebuffer parent device

+#include > #include > #include > #include > @@ -72,6 +73,8 @@ EXPORT_SYMBOL_GPL(sysfb_disable); > static __init int sysfb_init(void) > { > const struct screen_info *si = _info; > + struct device *parent = NULL; > + struct pci_dev *pparent; M

Re: [PATCH 2/8] video: Provide screen_info_get_pci_dev() to find screen_info's PCI device

t; + I would just drop the ret variable and assign the screen_info_resources() return value to numres. I think that makes the code easier to follow. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 1/8] video: Add helpers for decoding screen_info

aces. > > Signed-off-by: Thomas Zimmermann > --- Thanks for doing this! It's quite useful to have these helpers, since as you mention the screen_info data decoding is complex and the variables used to store the video type and modes are confusing / misleading. Reviewed-by: Javier Martinez Cani

Re: [PATCH] Revert "drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync"

ab.freedesktop.org/drm/intel/-/issues/10133 > Signed-off-by: Thomas Zimmermann > Cc: Javier Martinez Canillas > Cc: Thorsten Leemhuis > Cc: Jani Nikula > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] drm/Makefile: Move tiny drivers before native drivers

losely: Huacai Chen proposed a > fix and asked a earlier reporter to test it, but afaics heard nothing back: > > https://lore.kernel.org/all/CAAhV-H5eXM7FNzuRCMthAziG_jg75XwQV3grpw=sdyj-9gx...@mail.gmail.com/ > It's not a fix but a debug patch for the patch author to get more info ? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] Documentation/gpu: Reference articles on Linux graphics stack

Thomas Zimmermann writes: > Add two articles on LWN about the Linux graphics stack to DRM's > list of external references. The articles document the graphics > output as a whole, including the kernel side. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier

Re: [PATCH v1 4/4] backlight: hx8357: Utilise temporary variable for struct device

Andy Shevchenko writes: > We have a temporary variable to keep pointer to struct device. > Utilise it inside the ->probe() implementation. > > Signed-off-by: Andy Shevchenko > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v1 3/4] backlight: hx8357: Make use of dev_err_probe()

Andy Shevchenko writes: > Simplify the error handling in probe function by switching from > dev_err() to dev_err_probe(). > > Signed-off-by: Andy Shevchenko > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v1 2/4] backlight: hx8357: Move OF table closer to its consumer

.compatible = "himax,hx8369", > + .data = hx8369_lcd_init, > + }, > + {} While at it, maybe add the { /* sentinel */ } convention to the last entry ? Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v1 1/4] backlight: hx8357: Make use of device properties

mean, before it was clear what was stored in match->data. But after you changes, what is returned by the device_get_match_data() function is opaque and you need to look at the typedef hx8357_init to figure that out. No strong opinion though and I see other drivers doing the same (but no other driver in drivers/video/backlight). Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] drm/imagination: Defer probe if requested firmware is not available

Daniel Vetter writes: > On Tue, Jan 09, 2024 at 02:48:42PM +0100, Javier Martinez Canillas wrote: >> Daniel Vetter writes: >> >> Hello Sima, >> >> Thanks for your feedback. >> >> > On Tue, Jan 09, 2024 at 01:05:59PM +0100, Javier Martinez

Re: [PATCH] drm/imagination: Defer probe if requested firmware is not available

Daniel Vetter writes: Hello Sima, Thanks for your feedback. > On Tue, Jan 09, 2024 at 01:05:59PM +0100, Javier Martinez Canillas wrote: >> The device is initialized in the driver's probe callback and as part of >> that initialization, the required firmware is loaded.

[PATCH] drm/imagination: Defer probe if requested firmware is not available

: f99f5f3ea7ef ("drm/imagination: Add GPU ID parsing and firmware loading") Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/imagination/pvr_device.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i

Re: [PATCH RFC v2 08/11] ARM: dts: DRA7xx: Add device tree entry for SGX GPU

Andrew Davis writes: > Add SGX GPU device entry to base DRA7x dtsi file. > > Signed-off-by: Andrew Davis > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH RFC v2 07/11] ARM: dts: AM437x: Add device tree entry for SGX GPU

Andrew Davis writes: > Add SGX GPU device entry to base AM437x dtsi file. > > Signed-off-by: Andrew Davis > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH RFC v2 06/11] ARM: dts: AM33xx: Add device tree entry for SGX GPU

Andrew Davis writes: > Add SGX GPU device entry to base AM33xx dtsi file. > > Signed-off-by: Andrew Davis > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH RFC v2 05/11] ARM: dts: omap5: Add device tree entry for SGX GPU

Andrew Davis writes: > Add SGX GPU device entry to base OMAP5 dtsi file. > > Signed-off-by: Andrew Davis > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH RFC v2 04/11] ARM: dts: omap4: Add device tree entry for SGX GPU

Andrew Davis writes: > Add SGX GPU device entry to base OMAP4 dtsi file. > > Signed-off-by: Andrew Davis > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH RFC v2 03/11] ARM: dts: omap3: Add device tree entry for SGX GPU

Andrew Davis writes: > Add SGX GPU device entries to base OMAP3 dtsi files. > > Signed-off-by: Andrew Davis > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img, powervr to img, powervr-rogue

Maxime? After a adding a commit message and Suggested-by tag: Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH] vt: remove superfluous CONFIG_HW_CONSOLE

ONSOLE. > > Signed-off-by: Lukas Bulwahn > --- Makes sense to me. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 4/4] fbdev/hyperv_fb: Do not clear global screen_info

y: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 3/4] firmware/sysfb: Clear screen_info state after consuming it

ned-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 2/4] fbdev/hyperv_fb: Remove firmware framebuffers with aperture helpers

nd uses the range for removing the firmware framebuffer. For > GEN2 VMBUS devices no range can be detected, so the driver clears all > firmware framebuffers. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 1/4] drm/hyperv: Remove firmware framebuffers with aperture helper

homas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v2] drm: Move drm_set_preferred_mode() helper from drm_edid to drm_modes

Javier Martinez Canillas writes: > The helper is generic, it doesn't use the opaque EDID type struct drm_edid > and is also used by drivers that only support non-probeable displays such > as fixed panels. > > These drivers add a list of modes using drm_mode_probed_add

  1   2   3   4   5   6   7   8   9   10   >