On 4/29/2024 10:12 AM, Sui Jingfeng wrote:
The else clause after the ruturn clause is not useful.
Hi Sui,
Spelling nit: ruturn --> return
Besides that,
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/panel/panel-ilitek-ili934
On 4/4/2024 3:08 AM, Dmitry Baryshkov wrote:
Use .init_load_uA part of the bulk regulator API instead of calling
register_set_load() manually.
Hi Dmitry,
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/panel/panel-novatek
On 4/17/2024 9:29 AM, David Wronek wrote:
Add support for the 2560x1600@90Hz OLED panel by EDO bundled with a
Raydium RM69380 controller, as found on the Lenovo Xiaoxin Pad Pro 2021.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: David Wronek
Hi David,
Acked-by: Jessica Zhang
Thanks
t_gpio;
+ bool prepared;
Hi David,
IIRC there's no need for a driver-specific panel::prepared after commit
d2aacaf0.
Thanks,
Jessica Zhang
+};
+
+static inline
+struct rm69380_panel *to_rm69380_panel(struct drm_panel *panel)
+{
+ return container_of(panel, struct rm69380_panel,
-by: Jessica Zhang
Thanks,
Jessica Zhang
Fixes: f4dea1aaa9a1 ("drm/dsi: add helpers for DSI compression mode and PPS
packets")
Reviewed-by: Marijn Suijten
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/drm_mipi_dsi.c | 6 +++---
include/drm/drm_mipi_dsi.h | 6 +++---
2 files
river")
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Jessica Zhang
---
drivers/gpu/drm/panel/panel-novatek-nt36672e.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c
b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c
index cb
On 4/4/2024 3:07 AM, Dmitry Baryshkov wrote:
The DSI device for the panel was registered by the DSI host, so it is an
error to unregister it from the panel driver. Drop the call to
mipi_dsi_device_unregister().
Hi Dmitry,
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
Fixes
/fileadmin/pdf/produkte/TFT-Displays/Innolux/G121X1-L03_Datasheet.pdf
[2]
https://www.distec.de/fileadmin/pdf/produkte/TFT-Displays/Innolux/G121XCE-L01_Datasheet.pdf
Hi Marek,
Acked-by: Jessica Zhang
Thanks,
Jessica Zhang
Signed-off-by: Marek Vasut
---
Cc: Conor Dooley
Cc: Daniel Vetter
documentation [1] section 6.1 INPUT SIGNAL
TIMING SPECIFICATIONS.
[1]
https://www.distec.de/fileadmin/pdf/produkte/TFT-Displays/Innolux/G121X1-L03_Datasheet.pdf
Hi Marek,
Acked-by: Jessica Zhang
Thanks,
Jessica Zhang
Signed-off-by: Marek Vasut
---
Cc: Conor Dooley
Cc: Daniel Vetter
Cc
://www.distec.de/fileadmin/pdf/produkte/TFT-Displays/Innolux/G121X1-L03_Datasheet.pdf
Hi Marek,
Acked-by: Jessica Zhang
Thanks,
Jessica Zhang
Fixes: f8fa17ba812b ("drm/panel: simple: Add support for Innolux G121X1-L03")
Signed-off-by: Marek Vasut
---
Cc: Conor Dooley
Cc: Daniel Vetter
On 3/25/2024 6:49 AM, Chris Morgan wrote:
From: Chris Morgan
The GameForce Chi is a handheld device with a 3.5" 640x480 ST7703 based
display panel.
Hi Chris,
Acked-by: Jessica Zhang
Thanks,
Jessica Zhang
Signed-off-by: Chris Morgan
---
drivers/gpu/drm/panel/panel-sitronix-s
On 3/23/2024 12:40 AM, Prasad Pandit wrote:
On Fri, 22 Mar 2024 at 20:54, Jessica Zhang wrote:
Seems that this also happens in 2 other Kconfig entries. Can you replace those
as well?
* Yes, I've sent a revised patch.
Acked, thanks!
Thank you.
---
- Prasad
On 3/23/2024 12:39 AM, Prasad Pandit wrote:
From: Prasad Pandit
Replace unicode multiplication character with an ascii x.
It helps Kconfig parsers to read file without error.
Hi Prasad,
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
Fixes: 25205087df1f ("drm/panel: Add d
,
Jessica Zhang
Fixes: 25205087df1f ("drm/panel: Add driver for JDI LPM102A188A")
Signed-off-by: Prasad Pandit
---
drivers/gpu/drm/panel/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 8f
.
Other DSI drivers might handle this differently, so add the flag.
Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek
LTK050H3148W-CTA6 variant")
Signed-off-by: Heiko Stuebner
Hi Heiko,
Acked-by: Jessica Zhang
Thanks,
Jessica Zhang
---
drivers/gpu/drm/p
On 3/18/2024 9:17 AM, Nathan Morrisson wrote:
Add support for the POWERTIP PH128800T006-ZHC01 10.1" (1280x800)
LCD-TFT panel.
Signed-off-by: Nathan Morrisson
Hi Nathan,
Acked-by: Jessica Zhang
Thanks,
Jessica Zhang
---
drivers/gpu/drm/panel/panel-simple.c
}
+ } else if (p->aux->wait_hpd_asserted) {
Hi Doug,
Acked-by: Jessica Zhang
Thanks,
Jessica Zhang
ret = p->aux->wait_hpd_asserted(p->aux, HPD_MAX_US);
- if (ret)
+ if (ret) {
dev_warn(dev, "Controller error waiting fo
it to other counts leading to
bogus values.
On the other hand, many of the struct drm_panel_funcs .get_modes() hooks
do return negative error codes, so handle them gracefully instead of
propagating further.
Return 0 for no modes, whatever the reason.
Cc: Neil Armstrong
Cc: Jessica Zhang
Cc: Sam
On 2/29/2024 9:23 AM, Adam Green wrote:
On 26/02/2024 21:29, Jessica Zhang wrote:
> Got it. Was the shorter sleep time breaking the display and is it
> required for the new panel to work?
>
> Thanks,
>
> Jessica Zhang
Hi Jessica,
I will be submitting a v3 s
On 2/9/2024 3:17 PM, Richard Acayan wrote:
On Thu, Feb 08, 2024 at 05:34:57PM -0800, Jessica Zhang wrote:
On 2/8/2024 4:16 PM, Richard Acayan wrote:
The S6E3FA7 display controller is enabled in every Pixel 3a (non-XL)
variant. Add the driver for it, generated by
linux-mdss-dsi-panel-driver
ward.
Hi Maxime and Daniel,
For our current sim panel requirements, we can go with implementing the
configfs first then add ebpf if requirements get more complex.
Thanks,
Jessica Zhang
Maxime
On 2/23/2024 5:45 AM, Jérémie Dautheribes wrote:
Add support for Crystal Clear Technology CMT430B19N00 4.3" 480x272
TFT-LCD panel.
Signed-off-by: Jérémie Dautheribes
Hi Jérémie,
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
---
drivers/gpu/drm/panel/panel-simple.c
On 2/22/2024 9:47 AM, Adam Green wrote:
On 22/02/2024 17:14, Jessica Zhang wrote:
Hi Adam,
Just wondering, why the change to 120 here?
Thanks,
Jessica Zhang
Hi,
The 120ms is taken from the datasheet specification for the controller
as maximum time it takes for the display to reset
ies);
if (ret < 0)
return ret;
- msleep(20);
+ msleep(120);
Hi Adam,
Just wondering, why the change to 120 here?
Thanks,
Jessica Zhang
gpiod_set_value(st7701->reset, 1);
msleep(150);
@@ -875,6 +931,105 @@ static const struct st7701_panel_desc kd50t
ot; as has been done for many
other DSI panels.
Fixes: 9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts at
modeset")
Signed-off-by: Douglas Anderson
Hi Doug,
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
---
This of course gets into debates about getting
Stuebner
Hi Heiko,
Acked-by: Jessica Zhang
Thanks,
Jessica Zhang
---
.../drm/panel/panel-leadtek-ltk500hd1829.c| 196 ++
1 file changed, 196 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c
b/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829
panel.
Signed-off-by: Heiko Stuebner
Hi Heiko,
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
---
.../drm/panel/panel-leadtek-ltk500hd1829.c| 73 ---
1 file changed, 47 insertions(+), 26 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c
b
-by: Jessica Zhang
Thanks,
Jessica Zhang
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 91 +++
1 file changed, 91 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
index b55bafd1a8be..939ba05c9b58 100644
iver for the Samsung S6E3FA7 panel.
+ *
+ * Copyright (c) 2022-2024, The Linux Foundation. All rights reserved.
Hi Richard,
Not really sure about the copyright dates -- since this is a completely
new file to this tree, wouldn't the year be just 2024?
The rest LGTM.
Thanks,
Jessica Z
On 2/5/2024 1:26 AM, Raphael Gallais-Pou wrote:
Push horizontal front porch and vertical back porch blanking limit.
This allows to get a 60 fps sharp.
Signed-off-by: Raphael Gallais-Pou
Hi Raphael,
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
---
drivers/gpu/drm/panel/panel
by the positive edge it makes sense
to add it here.
Signed-off-by: Raphael Gallais-Pou
Hi Raphael,
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
---
drivers/gpu/drm/panel/panel-simple.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel
The DSI host needs to be enabled for the panel to be initialized in
prepare(). Ensure this happens by setting prepare_prev_first.
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/panel/panel-visionox-r66451.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel
The current maintainer (Harigovindan P) is no longer reachable through
the listed email. Update maintainers list to be Abhinav and I.
Signed-off-by: Jessica Zhang
---
Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
The DSI host must be enabled for the panel to be initialized in
prepare(). Set the prepare_prev_first flag to guarantee this.
Signed-off-by: Jessica Zhang
---
To: Neil Armstrong
To: Sam Ravnborg
To: David Airlie
To: Daniel Vetter
To: Jessica Zhang
To: Maarten Lankhorst
To: Maxime Ripard
On 2/1/2024 2:17 PM, Konrad Dybcio wrote:
The .prepare callback contains the init sequence, so the DSI host *must*
be enabled at that point. Set the prepare_prev_first flag to ensure that.
Signed-off-by: Konrad Dybcio
Hi Konrad,
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
S.pdf
Signed-off-by: Primoz Fiser
Signed-off-by: Yannic Moog
Hi Yannic,
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
---
drivers/gpu/drm/panel/panel-simple.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c
b/driver
Add new APIs to register a simulated panel.
For drivers that want to support a simulated panel, they must call
mipi_dsi_host_register_sim_panel().
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/drm_mipi_dsi.c | 30 ++
include/drm/drm_mipi_dsi.h | 1 +
2 files
Introduce the sim_panel_enabled module parameter.
When set, this parameter will force DSI to select the simulated panel
instead of the physical panel.
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/msm/dsi/dsi.c | 4
drivers/gpu/drm/msm/dsi/dsi_host.c| 9 -
drivers
Add a driver for simulating panels. This module also supports a mode
parameter for users to specify a custom mode. If no custom mode is set,
it will fall back to a custom, hard-coded mode.
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/panel/Kconfig| 9 ++
drivers/gpu/drm/panel
Add separate bridge and drm_panel API for getting the simulated panel.
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/bridge/panel.c | 24
drivers/gpu/drm/drm_panel.c| 33 +
include/drm/drm_bridge.h | 1 +
include/drm
(such as configuring DSC, dual DSI, etc.).
---
Jessica Zhang (4):
drm/panel: add driver for simulated panel
drm/dsi: Add API to register simulated DSI panel
drm/panel: Introduce simulated panel bridge API
drm/msm/dsi: Add simulated panel support
drivers/gpu/drm/bridge/panel.c
On 1/12/2024 6:00 AM, Jianhua Lu wrote:
After commit e6c0de5f4450 ("drm/msm/dpu: try multirect based on mdp clock
limits")
merged, 120Hz is working on xiaomi,elish panels, so feature it.
Signed-off-by: Jianhua Lu
Reviewed-by: Jessica Zhang
---
drivers/gpu/drm/panel/pan
On 1/8/2024 1:59 AM, Ritesh Kumar wrote:
Add support for the 1080x2408 Novatek NT36672E video mode
DSI panel driver.
Signed-off-by: Ritesh Kumar
Reviewed-by: Jessica Zhang
---
v2: Fixed review comments from Krzysztof
- renamed the panel driver file to reflect
tself LGTM, but in case you have to put out a new revision,
can you please use the "drm/panel: :" prefix format that
other drm/panel commits use?
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
Signed-off-by: Keith Zhao
Signed-off-by: Shengyang Chen
---
drivers/gpu/drm/panel
mipi_dsi_dcs_write_seq(dsi, 0x00, 0xFF, 0x87, 0x12, 0x34, 0x44, 0x44,
+ 0x44, 0x44, 0x98, 0x04, 0x98, 0x04, 0x0F,
+ 0x00, 0x00, 0xC1);
Hi Manuel,
(I'm assuming the `0x00` here is not MIPI_DCS_NOP)
Reviewed-by: Jes
On 1/3/2024 6:17 AM, chenguanxi11...@163.com wrote:
From: Chen Haonan
dev_err_probe() can check if the error code is -EPROBE_DEFER
and can return the error code, replacing dev_err() with it
simplifies the code.
Signed-off-by: Chen Haonan
Reviewed-by: Jessica Zhang
---
drivers/gpu
On 12/25/2023 6:26 AM, chenguanxi11...@163.com wrote:
From: Chen Haonan
dev_err_probe() can check if the error code is -EPROBE_DEFER
and can return the error code, replacing dev_err() with it
simplifies the code.
Signed-off-by: Chen Haonan
Reviewed-by: Jessica Zhang
---
drivers/gpu
.
Signed-off-by: Artur Weber
Hi Artur,
With Henrik's suggestion to add the Fixes tag,
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
---
drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-samsung
er correctly, commit d2aacaf07395bd798373cbec6af05fff4147aff3
should have introduced prepared/enabled do the drm_panel struct.
Thanks,
Jessica Zhang
+
+ struct mipi_dsi_device *dsi;
+
+ struct regulator *power;
+ struct gpio_desc *enable;
+ struct gpio_desc *reset;
+
+ enum d
+#include
+
+struct boe_th101mb31ig002 {
+ struct drm_panel panel;
+ bool enabled;
+ bool prepared;
Hi Manuel,
If I remember correctly, commit
d2aacaf07395bd798373cbec6af05fff4147aff3 should have introduced
prepared/enabled do the drm_panel struct.
Thanks,
Jessica Zhan
On 12/19/2023 6:48 PM, yang.gua...@zte.com.cn wrote:
From: Yang Guang
dev_err_probe() can check if the error code is -EPROBE_DEFER
and can return the error code, replacing dev_err() with it
simplifies the code.
Signed-off-by: Chen Haonan
Reviewed-by: Jessica Zhang
Thanks,
Jessica
_util")
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 6 +++---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 4 ++--
d
Set the input_sel bit for encoders as it was missed in the initial
implementation.
Reported-by: Rob Clark
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39
Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface")
Signed-off-by: Jessica Zhang
---
drivers/g
-fixup-v1-0-585c54cd0...@quicinc.com
---
Jessica Zhang (2):
drm/msm/dpu: Set input_sel bit for INTF
drm/msm/dpu: Drop enable and frame_count parameters from
dpu_hw_setup_misr()
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4
On 12/13/2023 1:20 PM, Dmitry Baryshkov wrote:
On Wed, 13 Dec 2023 at 22:51, Jessica Zhang wrote:
Set the input_sel bit for encoders as it was missed in the initial
implementation.
Reported-by: Rob Clark
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39
Fixes: 91143873a05d (&quo
Set the input_sel bit for encoders as it was missed in the initial
implementation.
Reported-by: Rob Clark
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39
Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface")
Signed-off-by: Jessica Zhang
---
drivers/g
:
- Switched patch order
- Changed input_sel parameter from bool to u8
- Link to v1:
https://lore.kernel.org/r/20231130-encoder-fixup-v1-0-585c54cd0...@quicinc.com
---
Jessica Zhang (2):
drm/msm/dpu: Set input_sel bit for INTF
drm/msm/dpu: Drop enable and frame_count parameters from
_util")
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 6 +++---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 4 ++--
d
On 12/13/2023 1:00 PM, Abhinav Kumar wrote:
On 12/13/2023 12:51 PM, Jessica Zhang wrote:
Drop the enable and frame_count parameters from dpu_hw_setup_misr() as
they
are always set to the same values.
In addition, replace MISR_FRAME_COUNT_MASK with MISR_FRAME_COUNT as
frame_count
_util")
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 6 +++---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 4 ++--
d
Set the input_sel bit for encoders as it was missed in the initial
implementation.
Reported-by: Rob Clark
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39
Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface")
Signed-off-by: Jessica Zhang
---
drivers/g
-585c54cd0...@quicinc.com
---
Jessica Zhang (2):
drm/msm/dpu: Set input_sel bit for INTF
drm/msm/dpu: Drop enable and frame_count parameters from
dpu_hw_setup_misr()
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++--
drivers/gpu
On 12/2/2023 11:54 AM, Dmitry Baryshkov wrote:
On 01/12/2023 23:29, Abhinav Kumar wrote:
On 11/30/2023 11:36 PM, Dmitry Baryshkov wrote:
On Fri, 1 Dec 2023 at 03:31, Jessica Zhang
wrote:
Set the input_sel bit for encoders as it was missed in the initial
implementation.
Reported
DSI_MODE_VIDEO_BURST as part of the mode_flags for the dsi host.
Fixes: 93e82bb4de01 ("drm/bridge: synopsys: dw-mipi-dsi: Fix hcomponent lbcc for
burst mode")
Signed-off-by: Farouk Bouabid
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
---
drivers/gpu/drm/panel/panel-leadtek-
On 11/30/2023 11:39 PM, Dmitry Baryshkov wrote:
On Fri, 1 Dec 2023 at 03:31, Jessica Zhang wrote:
This series drops the frame_count and enable parameters (as they're always
set to the same value). It also sets input_sel=0x1 for INTF.
Signed-off-by: Jessica Zhang
---
Jessica Zhang (2
any of
the regexes: 'pinctrl-[0-9]+'
From schema:
Documentation/devicetree/bindings/display/panel/panel-simple.yaml
```
Fixes: 310abcea76e9 ("dt-bindings: display: convert simple lg panels to DT
Schema")
Signed-off-by: David Heidelberg
Acked-by: Jessica Zhang
---
v2: added
: 'pinctrl-[0-9]+'
From schema:
Documentation/devicetree/bindings/display/panel/panel-simple.yaml
```
Hi David,
Would "Fixes: 310abcea76e9 ("dt-bindings: display: convert simple lg
panels to DT Schema")" be appropriate here?
Thanks,
Jessica Zhang
Signed-off-
G0_DATABUS_WIDEN;
Hi Jonathan,
Now that widebus is enabled for video mode, I think you can also drop
the TODO here [1]. Other than that, this LGTM.
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
[1]
https://elixir.bootlin.com/linux/v6.7-rc3/source/drivers/gpu/drm/msm/dsi
_dsi.h
index c9df0407980c..3e32fa52d94b 100644
--- a/include/drm/drm_mipi_dsi.h
+++ b/include/drm/drm_mipi_dsi.h
@@ -193,6 +193,7 @@ struct mipi_dsi_device {
unsigned long hs_rate;
unsigned long lp_rate;
struct drm_dsc_config *dsc;
Any reason for not putting thi
On 7/29/2023 6:19 PM, Dmitry Baryshkov wrote:
There is little point in disabling QoS on plane destruction: it happens
during DPU device destruction process, after which there will be no
running planes.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Jessica Zhang
---
drivers/gpu/drm/msm
on encoder destruction.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Jessica Zhang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 50 +
1 file changed, 10 insertions(+), 40 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
b/drivers/gpu/drm/msm
On 7/29/2023 6:19 PM, Dmitry Baryshkov wrote:
It was noticed that dpu_kms_hw_init()'s error path contains several
labels which point to the same code path. Replace all of them with a
single label.
Suggested-by: Konrad Dybcio
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Jessica Zhang
On 8/16/2023 12:27 AM, Dmitry Baryshkov wrote:
Hi Jessica,
On Tue, 15 Aug 2023 at 23:17, Jessica Zhang wrote:
On 7/29/2023 6:19 PM, Dmitry Baryshkov wrote:
Use devm_kzalloc to create MDP TOP structure. This allows us to remove
corresponding kfree and drop dpu_hw_mdp_destroy() function
Set the input_sel bit for encoders as it was missed in the initial
implementation.
Reported-by: Rob Clark
Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface")
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/39
Signed-off-by: Jessica Zhang
---
drivers/g
_util")
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 6 +++---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 4 ++--
drivers/gpu/drm/msm/disp/dpu1/d
This series drops the frame_count and enable parameters (as they're always
set to the same value). It also sets input_sel=0x1 for INTF.
Signed-off-by: Jessica Zhang
---
Jessica Zhang (2):
drm/msm/dpu: Drop enable and frame_count parameters from
dpu_hw_setup_misr()
drm/msm/dpu: Set
the panel in reset status after it is unprepared,
this does not happen.
Fixes: 5b6603360c12 ("drm/panel: add panel driver for Elida KD35T133 panels")
Signed-off-by: Chris Morgan
Reviewed-by: Jessica Zhang
---
drivers/gpu/drm/panel/panel-elida-kd35t133.c | 2 ++
1 file changed, 2
On 11/16/2023 7:17 AM, Chris Morgan wrote:
On Wed, Nov 15, 2023 at 01:38:11PM -0800, Jessica Zhang wrote:
On 11/15/2023 7:26 AM, Chris Morgan wrote:
From: Chris Morgan
For devices like the Anbernic RG351M and RG351P the panel is wired to
an always on regulator. When the device suspends
of these panels are identical in
size (70x57) it is possible future panels may not be.
Tested on my RG351V, RG353P, RG353V, and RK2023.
Signed-off-by: Chris Morgan
Reviewed-by: Jessica Zhang
---
.../gpu/drm/panel/panel-newvision-nv3051d.c | 55 +++
1 file changed, 44
Reviewed-by: Jessica Zhang
---
drivers/gpu/drm/panel/panel-newvision-nv3051d.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c
b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c
index 79de6c886292..c44c6945662f 100644
--- a/drivers/gpu/drm/p
->reset_gpio, 1);
+
Hi Chris,
Is this to address a suspend/resume issue similar to what was done here [1]?
If so, I think maybe this can go as a separate Fixes patch.
Thanks,
Jessica Zhang
[1] https://patchwork.freedesktop.org/patch/567670/?series=126479=1
regulator_disable(ctx-&
to drop shutdown().
Thanks,
Jessica Zhang
[1] d2aacaf07395 ("drm/panel: Check for already prepared/enabled in
drm_panel")
Signed-off-by: Chris Morgan
---
drivers/gpu/drm/panel/panel-elida-kd35t133.c | 28
1 file changed, 28 deletions(-)
diff --git a/d
On 11/15/2023 7:26 AM, Chris Morgan wrote:
From: Chris Morgan
Stop calling drm_connector_set_orientation_from_panel() as its now
called by the panel bridge directly when it is initialized.
Signed-off-by: Chris Morgan
Reviewed-by: Jessica Zhang
---
drivers/gpu/drm/panel/panel-elida
the panel in reset status after it is unprepared,
this does not happen.
Hi Chris,
LGTM, though if this is fixing something maybe we can add
Fixes: 5b6603360c12 ("drm/panel: add panel driver for Elida KD35T133
panels")
Signed-off-by: Chris Morgan
Reviewed-by: Jessica Zhang
Thanks
On 11/15/2023 7:26 AM, Chris Morgan wrote:
From: Chris Morgan
The comments at the top of the driver state the panel size incorrectly
as 5.5" instead of 3.5".
Signed-off-by: Chris Morgan
Reviewed-by: Jessica Zhang
---
drivers/gpu/drm/panel/panel-elida-kd35t133.c | 2 +
On 11/6/2023 9:35 AM, Jessica Zhang wrote:
On 11/4/2023 6:02 AM, Helen Koike wrote:
Hi Jessica,
On 10/10/2023 19:25, Jessica Zhang wrote:
Recently, we've registered a Gitlab runner for a Qualcomm RB5 device
that will be
hosted and maintained in Qualcomm labs.
This series will add
or example [1]:
Fixes: 01d6c3578379 ("drm/syncobj: add support for timeline point wait v8")
Signed-off-by: Erik Kurzinger
<...>
Thanks,
Jessica Zhang
[1]
https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes=101c9f637efa1655f55876644d4439e552267527
Thanks
O
On 11/4/2023 6:02 AM, Helen Koike wrote:
Hi Jessica,
On 10/10/2023 19:25, Jessica Zhang wrote:
Recently, we've registered a Gitlab runner for a Qualcomm RB5 device
that will be
hosted and maintained in Qualcomm labs.
This series will add a corresponding CI job for testing SM8250 devices
state before the
lcm_reset pin is pulled high.
Was this fixing some panel issue? If so, maybe we can add
Fixes: 6069b66cd962 ("drm/panel: support for STARRY 2081101QFH032011-53G
MIPI-DSI panel")
Otherwise, with the commit msg fix, this looks good to me:
Reviewed-by: Jessica Zhan
On 11/2/2023 11:19 AM, Clayton Craft wrote:
This panel is found on laptops e.g., variants of the Thinkpad X13s.
Configuration was collected from the panel's EDID.
Signed-off-by: Clayton Craft
LGTM
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
---
V2: renamed to "*_mode&q
[1] https://patchwork.freedesktop.org/patch/30/
Tested-by: Jessica Zhang # SC7280
Fixes: bfcc3d8f94f4 ("drm/msm/dp: support setting the DP subconnector type")
Reviewed-by: Abhinav Kumar
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/dp/dp_drm.c | 3 +++
1 file changed, 3
he DP subconnector type")
Signed-off-by: Abel Vesa
Signed-off-by: Dmitry Baryshkov
Tested-by: Jessica Zhang # SC7280
---
drivers/gpu/drm/msm/dp/dp_display.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/g
,
Reviewed-by: Jessica Zhang
Thanks,
Jessica Zhang
Signed-off-by: John Watts
---
.../gpu/drm/panel/panel-newvision-nv3052c.c | 24 ---
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
b/drivers/gpu/drm/panel/panel
it easier to extend.
Otherwise, can you change the name to "*_mode"? Seems to me that almost
all other panels with a single mode have the name as "*_mode" with the
only exception being a carry-over from older panel-simple.c code.
Thanks,
Jessica Zhang
+ .clock = 15776
On 10/20/2023 8:02 AM, Chris Morgan wrote:
On Thu, Oct 19, 2023 at 10:22:24AM -0700, Jessica Zhang wrote:
On 10/18/2023 9:18 AM, Chris Morgan wrote:
From: Chris Morgan
Refactor the driver to add support for the powkiddy,rk2023-panel
panel. This panel is extremely similar to the rg353p
to configure the alpha value for the solid fill color.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 38 ---
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/drm_atomic_state_helper.c | 1 +
drivers/gpu/drm/drm_atomic_uapi.c | 4 ++
drivers/gpu/drm/drm_blend.c | 94 +++
drivers/gpu/drm/drm_plane.c | 19 +--
include/drm/drm_blend.h
Currently framebuffer checks happen directly in
drm_atomic_plane_check(). Move these checks into their own helper
method.
Reviewed-by: Dmitry Baryshkov
Acked-by: Harry Wentland
Acked-by: Sebastian Wick
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/drm_atomic.c | 130
lid_fill_blob) checks to helper method
(Dmitry)
- Fixed dropped 'const' warning
- Added helper to convert color fill to BGR888 (Rob)
- Fixed indentation issue (Dmitry)
- Added support for solid fill on planes of varying sizes
---
Jessica Zhang (10):
drm: Introduce pixel_source DRM plane proper
Add solid_fill property data to the atomic plane state dump.
Reviewed-by: Dmitry Baryshkov
Acked-by: Harry Wentland
Acked-by: Sebastian Wick
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/drm_atomic.c | 4
drivers/gpu/drm/drm_plane.c | 8
include/drm/drm_plane.h | 3
1 - 100 of 619 matches
Mail list logo
