Re: [PATCH v4 09/11] drm/msm/A6XX: Add a flag to allow preemption to submitqueue_create

2024-09-20 Thread Rob Clark
On Fri, Sep 20, 2024 at 9:54 AM Akhil P Oommen wrote: > > On Tue, Sep 17, 2024 at 01:14:19PM +0200, Antonino Maniscalco wrote: > > Some userspace changes are necessary so add a flag for userspace to > > advertise support for preemption when creating the submitqueue. > > > > When this flag is not s

Re: [PATCH v4 00/11] Preemption support for A7XX

2024-09-20 Thread Rob Clark
cure preempt context > > > > - NOP out postamble to disable it instantly > > > > - Only emit pwrup reglist once > > > > - Document bv_rptr_addr > > > > - Removed unused A6XX_PREEMPT_USER_RECORD_SIZE > > > > - Set name on preempt record buf

Re: [PATCH 1/3] drm/msm/a6xx: Add support for A663

2024-09-20 Thread Akhil P Oommen
On Wed, Sep 18, 2024 at 12:31:55AM +0300, Dmitry Baryshkov wrote: > On Wed, Sep 18, 2024 at 02:08:41AM GMT, Akhil P Oommen wrote: > > From: Puranam V G Tejaswi > > > > Add support for Adreno 663 found on sa8775p based platforms. > > > > Signed-off-by: Puranam V G Tejaswi > > Signed-off-by: Akhi

Re: [PATCH v4 00/11] Preemption support for A7XX

2024-09-20 Thread Akhil P Oommen
g/r/20240905-preemption-a750-t-v3-0-fd947699f...@gmail.com > > > > Changes in v3: > > - Added documentation about preemption > > - Use quirks to determine which target supports preemption > > - Add a module parameter to force disabling or enabling preemption > >

Re: [PATCH v4 10/11] drm/msm/A6xx: Enable preemption for A750

2024-09-20 Thread Akhil P Oommen
On Tue, Sep 17, 2024 at 01:14:20PM +0200, Antonino Maniscalco wrote: > Initialize with 4 rings to enable preemption. > > For now only on A750 as other targets require testing. > > Add the "preemption_enabled" module parameter to override this for other > A7xx targets. > > Signed-off-by: Antonino

Re: [PATCH v4 09/11] drm/msm/A6XX: Add a flag to allow preemption to submitqueue_create

2024-09-20 Thread Akhil P Oommen
On Tue, Sep 17, 2024 at 01:14:19PM +0200, Antonino Maniscalco wrote: > Some userspace changes are necessary so add a flag for userspace to > advertise support for preemption when creating the submitqueue. > > When this flag is not set preemption will not be allowed in the middle > of the submitted

Re: [PATCH v4 08/11] drm/msm/A6xx: Add traces for preemption

2024-09-20 Thread Akhil P Oommen
On Tue, Sep 17, 2024 at 01:14:18PM +0200, Antonino Maniscalco wrote: > Add trace points corresponding to preemption being triggered and being > completed for latency measurement purposes. > > Signed-off-by: Antonino Maniscalco > Tested-by: Neil Armstrong # on SM8650-QRD Reviewed-by: Akhil P Oom

Re: [PATCH v4 07/11] drm/msm/A6xx: Use posamble to reset counters on preemption

2024-09-20 Thread Akhil P Oommen
On Tue, Sep 17, 2024 at 01:14:17PM +0200, Antonino Maniscalco wrote: > Use the postamble to reset perf counters when switching between rings, > except when sysprof is enabled, analogously to how they are reset > between submissions when switching pagetables. > > Signed-off-by: Antonino Maniscalco

Re: [PATCH v4 05/11] drm/msm/A6xx: Implement preemption for A7XX targets

2024-09-20 Thread Akhil P Oommen
On Tue, Sep 17, 2024 at 01:14:15PM +0200, Antonino Maniscalco wrote: > This patch implements preemption feature for A6xx targets, this allows > the GPU to switch to a higher priority ringbuffer if one is ready. A6XX > hardware as such supports multiple levels of preemption granularities,

Re: [PATCH] drm/panel: elida-kd35t133: transition to mipi_dsi wrapped functions

2024-09-20 Thread Dmitry Baryshkov
On Tue, Sep 17, 2024 at 12:47:10PM GMT, Tejas Vipin wrote: > Changes the elida-kd35t133 panel to use multi style functions for > improved error handling. > > Signed-off-by: Tejas Vipin > --- > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 107 --- > 1 file changed, 45 insertions

Re: [PATCH -next v2] drm/msm: Remove unneeded semicolon

2024-09-20 Thread Dmitry Baryshkov
On Wed, Sep 18, 2024 at 10:33:57AM GMT, Yang Li wrote: > ./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon > > This patch removes an unneeded semicolon after a switch statement in the > pll_get_post_div function. Adding a semicolon after a switch statement is &

Re: [PATCH] drm/fsl-dcu: Remove redundant dev_err()

2024-09-20 Thread Dmitry Baryshkov
On Wed, Sep 18, 2024 at 03:48:41PM GMT, Chen Ni wrote: > There is no need to call the dev_err() function directly to print a > custom message when handling an error from platform_get_irq() function > as it is going to display an appropriate error message in case of a > failure. > > Signed-off-by:

Re: [PATCH v4 2/4] drm/bridge: add Microchip DSI controller support for sam9x7 SoC series

2024-09-20 Thread Dmitry Baryshkov
On Wed, Sep 18, 2024 at 04:01:17PM GMT, Manikandan Muralidharan wrote: > Add the Microchip's DSI controller wrapper driver that uses > the Synopsys DesignWare MIPI DSI host controller bridge. > > Signed-off-by: Manikandan Muralidharan > --- > changes in v4: > - Fixed issues reported by kernel tes

Re: [PATCH v4 00/11] Preemption support for A7XX

2024-09-20 Thread Akhil P Oommen
gt; https://lore.kernel.org/r/20240905-preemption-a750-t-v3-0-fd947699f...@gmail.com > > > > > > Changes in v3: > > > - Added documentation about preemption > > > - Use quirks to determine which target supports preemption > > > - Add a module parameter to fo

Re: [PATCH] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs

2024-09-20 Thread Qianqiang Liu
Hi, I simplified the C reproducer as follows: #include #include #include #include #include #include #include #include struct param { uint8_t type; struct tiocl_selection ts; }; int main() { write(1, "executing program\n", sizeof("executing program\n") - 1);

Re: [PATCH v1] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-20 Thread Dmitry Baryshkov
On Fri, Sep 20, 2024 at 01:27:54PM GMT, Pin-yen Lin wrote: > On Thu, Sep 19, 2024 at 10:58 AM wrote: > > > > From: Hermes Wu > > > > Fix HDCP CTS items on UNIGRAF DPR-100. > > > > Signed-off-by: Hermes Wu > > Reviewed-by: Pin-yen Lin For the sake

Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

2024-09-20 Thread Dmitry Baryshkov
On Thu, Sep 19, 2024 at 02:45:48PM GMT, Manikandan Muralidharan wrote: > Add support for Microchip AC69T88A 5 inch TFT LCD 800x480 > Display module with LVDS interface.The panel uses the Sitronix > ST7262 800x480 Display driver AC69T88A seems to be a module name, rather than a panel name. What is

Re: [PATCH v2] drm/amdgpu: add dce6 drm_panic support

2024-09-20 Thread Jocelyn Falempe
On 17/09/2024 15:21, Alex Deucher wrote: On Mon, Aug 12, 2024 at 2:10 AM Lu Yao wrote: Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Lu Yao Patch looks good to me. Any chance you want to

Re: [PATCH v2 2/2] drm/bridge: it6505: Add MCCS support

2024-09-20 Thread Dmitry Baryshkov
On Fri, Sep 20, 2024 at 04:24:51PM GMT, Hermes Wu wrote: > From: Hermes Wu > > add AUX-I2C functionality to support MCCS > > Signed-off-by: Hermes Wu > --- > drivers/gpu/drm/bridge/ite-it6505.c | 209 ++-- > 1 file changed, 200 insertions(+), 9 deletions(-) > All my co

Re: [PATCH v2 1/2] drm/bridge: it6505: HDCP CTS fail on repeater

2024-09-20 Thread Dmitry Baryshkov
On Fri, Sep 20, 2024 at 04:24:50PM GMT, Hermes Wu wrote: > From: Hermes Wu > > Fix HDCP CTS items on UNIGRAF DPR-100 > > Signed-off-by: Hermes Wu All my comments from v1 (except for the Changes-Id trailers) seem to apply as well. > --- > drivers/gpu/drm/bridge/ite-it6505.c | 152

Re: [PATCH v2 0/2] drm/bridge: it6505: update dp aux function

2024-09-20 Thread Dmitry Baryshkov
On Fri, Sep 20, 2024 at 04:24:49PM GMT, Hermes Wu wrote: > From: Hermes Wu > > This series change aux function to support MCCS and fix HDCP CTS It is v2, but where is the changelog? Also please give reviewers some time and don't next revisions too quickly. Last, but not least, new series = new

Re: [PATCH v1 2/2] drm/bridge: it6505: Add MSSC suport

2024-09-20 Thread Dmitry Baryshkov
On Fri, Sep 20, 2024 at 04:24:47PM GMT, Hermes Wu wrote: > From: "Hermes.Wu" > > add AUX-I2C functionality to support MCCS. Same comment regarding the commit message. > > Change-Id: I63e1a0e5da67526f89f35605a82944be67dee8ac No Gerrit > Signed-off-by: Hermes Wu > --- > drivers/gpu/drm/brid

Re: [PATCH v1 1/2] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-20 Thread Dmitry Baryshkov
On Fri, Sep 20, 2024 at 04:24:46PM GMT, Hermes Wu wrote: > From: allen chen > > Fix HDCP CTS items on UNIGRAF DPR-100. Fix how? What was broken? Please describe the reasoning for the change. Also if it a fix, please use Fixes tags as required. If you have further questions, see Documentation/pro

Re: [PATCH v2 3/5] drm/imx/ipuv3: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-20 Thread Philipp Zabel
On Do, 2024-09-12 at 16:30 +0800, Jinjie Ruan wrote: > disable_irq() after request_irq() still has a time gap in which > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will > disable IRQ auto-enable when request IRQ. > > Fixes: 47b1be5c0f4e ("staging: imx/drm: request irq only after a

Re: [PATCH v5 2/4] drm: Expose wedge recovery methods

2024-09-20 Thread Andy Shevchenko
+Cc: Kees On Fri, Sep 20, 2024 at 02:18:19PM +0300, Raag Jadav wrote: > On Thu, Sep 19, 2024 at 04:45:28PM +0300, Andy Shevchenko wrote: > > On Thu, Sep 19, 2024 at 11:38:50AM +0300, Raag Jadav wrote: > > > On Thu, Sep 19, 2024 at 10:38:51AM +0300, Jani Nikula wrote: ... > > > Anyway, would you

Re: [PATCH v4 01/18] drm/atomic-helper: Introduce lane remapping support to bridges

2024-09-20 Thread Dmitry Baryshkov
On Sat, Aug 31, 2024 at 09:06:39PM GMT, Stephen Boyd wrote: > Add support to the DRM atomic logic to support lane remapping between > bridges, encoders and connectors. Typically lane mapping is handled > statically in firmware, e.g. on DT we use the data-lanes property to > assign lanes when connec

Re: [PATCH 1/2] drm/sched: add WARN_ON and BUG_ON to drm_sched_fini

2024-09-20 Thread Philipp Stanner
On Fri, 2024-09-20 at 12:33 +0200, Christian König wrote: > Am 20.09.24 um 10:57 schrieb Philipp Stanner: > > On Wed, 2024-09-18 at 15:39 +0200, Christian König wrote: > > > Tearing down the scheduler with jobs still on the pending list > > > can > > > lead to use after free issues. Add a warning i

Re: [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags

2024-09-20 Thread Steven Price
On 20/09/2024 11:28, Liviu Dudau wrote: > Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags") > the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed, > but the patch failed to make the changes for the panthor driver. > When user space opens th

Re: [PATCH v2 RESEND 1/5] drm: panthor: expose some fw information through the query ioctl

2024-09-20 Thread Mihail Atanassov
Hi Daniel, On 21/08/2024 15:37, Daniel Almeida wrote: This is of interest to userspace, and similar in nature to the GPU and CSIF information we already return in the query ioctl. Signed-off-by: Daniel Almeida --- drivers/gpu/drm/panthor/panthor_device.h | 3 +++ drivers/gpu/drm/panthor/pa

Re: [PATCH v2 2/5] drm/imx/dcss: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-20 Thread Laurentiu Palcu
On Thu, Sep 12, 2024 at 04:30:17PM +0800, Jinjie Ruan wrote: > disable_irq() after request_irq() still has a time gap in which > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will > disable IRQ auto-enable when request IRQ. > > Fixes: 9021c317b770 ("drm/imx: Add initial support for D

Re: [PATCH v2 1/5] drm/imx: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-20 Thread Laurentiu Palcu
drm/imx: Add initial support for DCSS on iMX8MQ") > Signed-off-by: Jinjie Ruan I think the commit subject should start with drm/imx/dcss. Not sure if this is worth another patch set just for that. I suppose the commiter could fix it before pushing. Other than that: Reviewed-by: Laurent

Re: [PATCH v4 6/8] backlight: led-backlight: add devlink to supplier LEDs

2024-09-20 Thread Luca Ceresoli
Hello Daniel, On Thu, 19 Sep 2024 14:43:23 +0200 Daniel Thompson wrote: > On Tue, Sep 17, 2024 at 10:53:10AM +0200, Luca Ceresoli wrote: > > led-backlight is a consumer of one or multiple LED class devices, but no > > devlink is created for such supplier-producer relationship. One consequence >

Re: [PATCH 2/6] drm/exynos: exynos7_drm_decon: fix suspended condition in decon_commit()

2024-09-20 Thread Krzysztof Kozlowski
On 19/09/2024 17:11, Kaustabh Chakraborty wrote: > decon_commit() gets called during atomic_enable. At this stage, DECON is > suspended, and thus the function refuses to run. Fix the suspended > condition checking in decon_commit(). > > Signed-off-by: Kaustabh Chakraborty > --- If this is a fix,

Re: [PATCH 6/6] dt-bindings: display: samsung,exynos7-decon: add exynos7870 compatible

2024-09-20 Thread Krzysztof Kozlowski
On 19/09/2024 17:20, Kaustabh Chakraborty wrote: > Add the compatible string of Exynos7870 to the existing list. > > Signed-off-by: Kaustabh Chakraborty ... and the DTS is ? Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH RESEND v8 1/2] drm/atomic: Let drivers decide which planes to async flip

2024-09-20 Thread Dmitry Baryshkov
On Tue, Aug 06, 2024 at 10:52:59AM GMT, André Almeida wrote: > Currently, DRM atomic uAPI allows only primary planes to be flipped > asynchronously. However, each driver might be able to perform async > flips in other different plane types. To enable drivers to set their own > restrictions on which

Re: [PATCH v2 09/10] drm: bridge: dw_hdmi: Update EDID during hotplug processing

2024-09-20 Thread Jonas Karlman
On 2024-09-20 09:04, neil.armstr...@linaro.org wrote: > On 19/09/2024 22:34, Jonas Karlman wrote: >> Hi Neil, >> >> On 2024-09-13 10:02, Neil Armstrong wrote: >>> On 08/09/2024 15:28, Jonas Karlman wrote: Update successfully read EDID during hotplug processing to ensure the connector dipl

Re: [PATCH v3 6/6] drm/amdgpu: use drm_file::name in task_info::process_desc

2024-09-20 Thread Christian König
Am 20.09.24 um 11:06 schrieb Pierre-Eric Pelloux-Prayer: If a drm_file name is set append it to the process name. This information is useful with the virtio/native-context driver: this allows the guest applications identifier to visible in amdgpu's output. The output in amdgpu_vm_info/amdgpu_ge

Re: [PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags

2024-09-20 Thread Boris Brezillon
On Fri, 20 Sep 2024 11:28:02 +0100 Liviu Dudau wrote: > Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags") > the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed, > but the patch failed to make the changes for the panthor driver. > Whe

Re: [PATCH v2 2/3] PCI: Allow extending VF BAR within original resource boundary

2024-09-20 Thread kernel test robot
linus/master v6.11 next-20240920] [cannot apply to pci/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://

Re: [PATCH v2 2/3] PCI: Allow extending VF BAR within original resource boundary

2024-09-20 Thread Ilpo Järvinen
On Fri, 20 Sep 2024, Michał Winiarski wrote: > VF MMIO resource reservation, either created by system firmware and > inherited by Linux PCI subsystem or created by the subsystem itself, > contains enough space to fit the BAR of all SR-IOV Virtual Functions > that can potentially be created (total

Re: [PATCH v5 2/4] drm: Expose wedge recovery methods

2024-09-20 Thread Raag Jadav
On Thu, Sep 19, 2024 at 04:45:28PM +0300, Andy Shevchenko wrote: > On Thu, Sep 19, 2024 at 11:38:50AM +0300, Raag Jadav wrote: > > On Thu, Sep 19, 2024 at 10:38:51AM +0300, Jani Nikula wrote: > > ... > > > Anyway, would you prefer strlcat instead? > > FYI: strl*() are subject to remove. They are

[PATCH v3 13/15] drm/rockchip: vop2: Add uv swap for cluster window

2024-09-20 Thread Andy Yan
From: Andy Yan The Cluster windows of upcoming VOP on rk3576 also support linear YUV support, we need to set uv swap bit for it. As the VOP2_WIN_UV_SWA register defined on rk3568/rk3588 is 0x, so this register will not be touched on these two platforms. Signed-off-by: Andy Yan --- (no

Re: [PATCH v2 2/3] PCI: Allow extending VF BAR within original resource boundary

2024-09-20 Thread kernel test robot
linus/master v6.11 next-20240920] [cannot apply to pci/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://

Re: [PATCH 1/2] drm/sched: add WARN_ON and BUG_ON to drm_sched_fini

2024-09-20 Thread Christian König
Am 20.09.24 um 10:57 schrieb Philipp Stanner: On Wed, 2024-09-18 at 15:39 +0200, Christian König wrote: Tearing down the scheduler with jobs still on the pending list can lead to use after free issues. Add a warning if drivers try to destroy a scheduler which still has work pushed to the HW. Di

[PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags

2024-09-20 Thread Liviu Dudau
Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags") the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed, but the patch failed to make the changes for the panthor driver. When user space opens the render node the WARN() added by the patch gets trigger

Re: [PATCH v2 2/3] PCI: Allow extending VF BAR within original resource boundary

2024-09-20 Thread Christian König
Am 20.09.24 um 00:35 schrieb Michał Winiarski: VF MMIO resource reservation, either created by system firmware and inherited by Linux PCI subsystem or created by the subsystem itself, contains enough space to fit the BAR of all SR-IOV Virtual Functions that can potentially be created (total VFs s

Re: [PATCH] drm: Link drm_rect.o into DRM core module

2024-09-20 Thread Ville Syrjälä
On Thu, Sep 19, 2024 at 08:53:43PM +0200, Thomas Zimmermann wrote: > Several places in drm.ko use struct drm_rect and its helpers. This > only works as the called interfaces are declared as static inline in > the header file. Fix the issue by linking drm_rect.o into drm.ko. Seems reasonable. Revie

Re: [PATCH v2 1/3] PCI: Add support for VF Resizable Bar extended cap

2024-09-20 Thread Christian König
es; + int bar_idx, size; + + pci_read_config_dword(pdev, pos + PCI_REBAR_CTRL, &ctrl); + bar_idx = ctrl & PCI_REBAR_CTRL_BAR_IDX; + res = pdev->resource + bar_idx; The variable res seems to be unused. In general I think you should

Re: [PATCH v2] drm/qxl: Add drm_panic support

2024-09-20 Thread Jocelyn Falempe
On 19/09/2024 09:12, Ryosuke Yasuoka wrote: QXL supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. It looks good to me. I think you just need to adjust some functions argument indentation (tab size is 8), see below. Best regards, -- Jocelyn

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-09-20 Thread Dmitry Baryshkov
On Sat, Aug 31, 2024 at 09:06:53PM GMT, Stephen Boyd wrote: > Add a DT graph binding to google,cros-ec-typec so that it can combine > DisplayPort (DP) and USB SuperSpeed (SS) data into a USB type-c endpoint > that is connected to the usb-c-connector node's SS endpoint. This also > allows us to conn

[PATCH v3 5/6] drm/amdgpu: make process_name a flexible array

2024-09-20 Thread Pierre-Eric Pelloux-Prayer
And rename it process_desc, since it will soon contain more than just the process_name. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c

[PATCH v3 2/6] drm: use drm_file name in fdinfo

2024-09-20 Thread Pierre-Eric Pelloux-Prayer
Add an optional drm-client-name field to drm fdinfo's output. Reviewed-by: Christian König Reviewed-by: Tvrtko Ursulin Signed-off-by: Pierre-Eric Pelloux-Prayer --- Documentation/gpu/drm-usage-stats.rst | 5 + drivers/gpu/drm/drm_file.c| 5 + 2 files changed, 10 insertions(

[PATCH v3 6/6] drm/amdgpu: use drm_file::name in task_info::process_desc

2024-09-20 Thread Pierre-Eric Pelloux-Prayer
If a drm_file name is set append it to the process name. This information is useful with the virtio/native-context driver: this allows the guest applications identifier to visible in amdgpu's output. The output in amdgpu_vm_info/amdgpu_gem_info looks like this: pid:12255Process:glxgears/te

[PATCH v3 4/6] drm/amdgpu: alloc and init vm::task_info from first submit

2024-09-20 Thread Pierre-Eric Pelloux-Prayer
This will allow to use flexible array to store the process name and other information. This also means that process name will be determined once and for all, instead of at each submit. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 15 +-- 1 f

[PATCH v3 3/6] drm/amdgpu: delay the use of amdgpu_vm_set_task_info

2024-09-20 Thread Pierre-Eric Pelloux-Prayer
At this point the vm is locked so we safely modify it without risk of concurrent access. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/driver

[PATCH v3 1/6] drm: add DRM_SET_NAME ioctl

2024-09-20 Thread Pierre-Eric Pelloux-Prayer
Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debugging. This is similar to the existing DMA_BUF_SET_NAME ioctl. Access to name is protected by a mutex, and the 'clients' debugfs file has been updated to print it. Userspace M

[PATCH v3 0/6] DRM_SET_NAME ioctl

2024-09-20 Thread Pierre-Eric Pelloux-Prayer
v3 changelog: * Added DRM_NAME_MAX_LEN instead of using NAME_MAX * Fixed Tvrtko & Christian comments on patch 1 * Added R-b tags to patch 2 * Following Christian' suggestion patch 3 became 4 patches: - amdgpu_task_info::process_name is now a flexible array - amdgpu_vm::task_info is

Re: [PATCH 1/2] drm/sched: add WARN_ON and BUG_ON to drm_sched_fini

2024-09-20 Thread Philipp Stanner
On Wed, 2024-09-18 at 15:39 +0200, Christian König wrote: > Tearing down the scheduler with jobs still on the pending list can > lead to use after free issues. Add a warning if drivers try to > destroy a scheduler which still has work pushed to the HW. Did you have time yet to look into my propose

[PATCH v2 1/2] drm/bridge: it6505: HDCP CTS fail on repeater

2024-09-20 Thread Hermes Wu
From: Hermes Wu Fix HDCP CTS items on UNIGRAF DPR-100 Signed-off-by: Hermes Wu --- drivers/gpu/drm/bridge/ite-it6505.c | 152 ++-- 1 file changed, 101 insertions(+), 51 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c

Re: [PATCH v2 1/3] PCI: Add support for VF Resizable Bar extended cap

2024-09-20 Thread kernel test robot
linus/master v6.11 next-20240919] [cannot apply to pci/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://

[PATCH v1 2/2] drm/bridge: it6505: Add MSSC suport

2024-09-20 Thread Hermes Wu
From: "Hermes.Wu" add AUX-I2C functionality to support MCCS. Change-Id: I63e1a0e5da67526f89f35605a82944be67dee8ac Signed-off-by: Hermes Wu --- drivers/gpu/drm/bridge/ite-it6505.c | 209 ++-- 1 file changed, 200 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v1 1/2] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-20 Thread Hermes Wu
From: allen chen Fix HDCP CTS items on UNIGRAF DPR-100. Change-Id: I03f0758779f73164c8ae2fdf61e41dc693e27605 Change-Id: Ib7a8fabaeccd56d3bd7c8adc7384a363b0f7b88d Signed-off-by: Hermes Wu --- drivers/gpu/drm/bridge/ite-it6505.c | 152 ++-- 1 file changed, 101 insertions

[PATCH v2 2/2] drm/bridge: it6505: Add MSSC suport

2024-09-20 Thread Hermes Wu
From: "Hermes.Wu" Add AUX i2c funtion for MCCS Change-Id: Ia8952f3cde4d9610d6f8a0c3915fc6ffefc6da22 Signed-off-by: Hermes Wu --- drivers/gpu/drm/bridge/ite-it6505.c | 209 ++-- 1 file changed, 200 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it

[PATCH v1 0/2] drm/bridge: it6505: update dp aux function

2024-09-20 Thread Hermes Wu
From: "Hermes.Wu" This series change aux function to support MCCS and fix HDCP CTS Hermes.Wu (1): drm/bridge: it6505: Add MSSC suport allen chen (1): drm/bridge: it6505: HDCP CTS fail on repeater items drivers/gpu/drm/bridge/ite-it6505.c | 343 +++- 1 file change

[PATCH v2 2/2] drm/bridge: it6505: Add MCCS support

2024-09-20 Thread Hermes Wu
From: Hermes Wu add AUX-I2C functionality to support MCCS Signed-off-by: Hermes Wu --- drivers/gpu/drm/bridge/ite-it6505.c | 209 ++-- 1 file changed, 200 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it650

[PATCH v2 0/2] drm/bridge: it6505: update dp aux function

2024-09-20 Thread Hermes Wu
From: Hermes Wu This series change aux function to support MCCS and fix HDCP CTS Hermes Wu (2): drm/bridge: it6505: HDCP CTS fail on repeater drm/bridge: it6505: Add MCCS support drivers/gpu/drm/bridge/ite-it6505.c | 343 +++- 1 file changed, 292 insertions(+), 51 d

[PATCH v3 00/15] VOP Support for rk3576

2024-09-20 Thread Andy Yan
From: Andy Yan Thanks for the basic work from Collabora, I can bringup a HDMI display out on rk3576. PATCH 1 is a carryover from the working when add support for rk3588, is very usefull when some people want me help debug some issue online, so I really hope it can be merged at

[PATCH v3 15/15] drm/rockchip: vop2: Add support for rk3576

2024-09-20 Thread Andy Yan
From: Andy Yan VOP2 on rk3576: Three video ports: VP0 Max 4096x2160 VP1 Max 2560x1600 VP2 Max 1920x1080 2 4K Cluster windows with AFBC/RFBC, line RGB and YUV 4 Esmart windows with line RGB/YUV support: Esmart0/1: 4K Esmart2/3: 2k, or worked together as a single 4K plane at shared line buffer mod

[PATCH v3 14/15] dt-bindings: display: vop2: Add rk3576 support

2024-09-20 Thread Andy Yan
From: Andy Yan Add vop found on rk3576, the main difference between rk3576 and the previous vop is that each VP has its own interrupt line. Signed-off-by: Andy Yan --- Changes in v3: - ordered by soc name - Add description for newly added interrupt Changes in v2: - Add dt bindings .../bind

[PATCH v3 12/15] drm/rockchip: vop2: Set plane possible crtcs by possible vp mask

2024-09-20 Thread Andy Yan
From: Andy Yan In the upcoming VOP of rk3576, a window cannot attach to all Video Ports, we introduce a possible_vp_mask for every window to indicate which Video Ports this window can attach to. Signed-off-by: Andy Yan --- (no changes since v1) drivers/gpu/drm/rockchip/rockchip_drm_vop2.c |

[PATCH v3 11/15] drm/rockchip: vop2: Register the primary plane and overlay plane separately

2024-09-20 Thread Andy Yan
From: Andy Yan In the upcoming VOP of rk3576, a Window cannot attach to all Video Ports, so make sure all VP find it's suitable primary plane, then register the remain windows as overlay plane will make code easier. Signed-off-by: Andy Yan --- Changes in v3: - Add comments for why we should t

[PATCH v3 10/15] drm/rockchip: vop2: Introduce vop hardware version

2024-09-20 Thread Andy Yan
From: Andy Yan There is a version number hardcoded in the VOP VERSION_INFO register, and the version number increments sequentially based on the production order of the SOC. So using this version number to distinguish different VOP features will simplify the code. Signed-off-by: Andy Yan ---

[PATCH v3 09/15] drm/rockchip: vop2: Support for different layer selet configuration between VPs

2024-09-20 Thread Andy Yan
From: Andy Yan In the upcoming VOP for rk3576, every VP has it's own LAYER_SEL register, and the configuration value of each VP for the same window maybe different, so extend the layer_sel_id to array, let it can descption the layer select configuration value for different VP. Signed-off-by: And

[PATCH v3 08/15] drm/rockchip: vop2: Add platform specific callback

2024-09-20 Thread Andy Yan
From: Andy Yan The VOP interface mux, overlay, background delay cycle configuration of different SOC are much different. Add platform specific callback ops to let the core driver look cleaner and more refined. Signed-off-by: Andy Yan --- (no changes since v2) Changes in v2: - Add platform sp

[PATCH v3 06/15] drm/rockchip: vop2: include rockchip_drm_drv.h

2024-09-20 Thread Andy Yan
From: Andy Yan Move rockchip_drm_drv.h in rockchip_drm_vop2.h to fix the follow sparse warning: ARCH=arm64 LLVM=1 make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' mrproper defconfig all -j12 drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse: warning: symbol 'vop2_platform_driver'

[PATCH v3 07/15] drm/rockchip: vop2: Support 32x8 superblock afbc

2024-09-20 Thread Andy Yan
From: Andy Yan This is the only afbc format supported by the upcoming VOP for rk3576. Add support for it. Signed-off-by: Andy Yan --- (no changes since v2) Changes in v2: - split it from main patch add support for rk3576 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 17

[PATCH v3 05/15] drm/rockchip: vop2: Fix the windows switch between different layers

2024-09-20 Thread Andy Yan
From: Andy Yan Every layer of vop2 should bind a window, and we also need to make sure that this window is not used by other layer. 0x5 is a reserved layer sel value on rk3568, but it will select Cluster3 on rk3588, configure unused layers to 0x5 will lead alpha blending error on rk3588. When

[PATCH v3 04/15] drm/rockchip: vop2: Fix the mixer alpha setup for layer 0

2024-09-20 Thread Andy Yan
From: Andy Yan The alpha setup should start from the second layer, the current calculation starts incorrectly from the first layer, a negative offset will be obtained in the following formula: offset = (mixer_id + zpos - 1) * 0x10 Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") Signed-off

[PATCH v3 03/15] drm/rockchip: vop2: Fix cluster windows alpha ctrl regsiters offset

2024-09-20 Thread Andy Yan
From: Andy Yan The phy_id of cluster windws are not increase one for each window. Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") Signed-off-by: Andy Yan Tested-by: Derek Foreman --- (no changes since v1) drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 18 +- 1 file cha

[PATCH v3 02/15] drm/rockchip: Set dma mask to 64 bit

2024-09-20 Thread Andy Yan
From: Andy Yan The vop mmu support translate physical address upper 4 GB to iova below 4 GB. So set dma mask to 64 bit to indicate we support address > 4GB. This can avoid warnging message like this on some boards with DDR > 4 GB: rockchip-drm display-subsystem: swiotlb buffer is full (sz: 2662

[PATCH v3 01/15] drm/rockchip: vop2: Add debugfs support

2024-09-20 Thread Andy Yan
From: Andy Yan /sys/kernel/debug/dri/vop2/summary: dump vop display state /sys/kernel/debug/dri/vop2/regs: dump whole vop registers /sys/kernel/debug/dri/vop2/active_regs: only dump the registers of activated modules Signed-off-by: Andy Yan Reviewed-by: Sascha Hauer --- (no changes since v1

[PATCH v3 00/15] VOP Support for rk3576

2024-09-20 Thread Andy Yan
From: Andy Yan Thanks for the basic work from Collabora, I can bringup a HDMI display out on rk3576. PATCH 1 is a carryover from the working when add support for rk3588, is very usefull when some people want me help debug some issue online, so I really hope it can be merged at

[PATCH v3 00/15] VOP Support for rk3576

2024-09-20 Thread Andy Yan
From: Andy Yan Thanks for the basic work from Collabora, I can bringup a HDMI display out on rk3576. PATCH 1 is a carryover from the working when add support for rk3588, is very usefull when some people want me help debug some issue online, so I really hope it can be merged at

[PATCH v3 00/15] VOP Support for rk3576

2024-09-20 Thread Andy Yan
From: Andy Yan Thanks for the basic work from Collabora, I can bringup a HDMI display out on rk3576. PATCH 1 is a carryover from the working when add support for rk3588, is very usefull when some people want me help debug some issue online, so I really hope it can be merged at

[PATCH 5/6] drm/exynos: exynos7_drm_decon: add driver data and support for Exynos7870

2024-09-20 Thread Kaustabh Chakraborty
Add support for Exynos 7870 DECON in the Exynos 7 DECON driver. Some Exynos 7 series SoCs (Exynos 7580 onwards) have different register values. In order to address such changes, include a driver data struct (named decon_data) so that correct base addresses and shift values can be provided. Signed

[PATCH v1 2/2] drm/bridge: it6505: Add MSSC suport

2024-09-20 Thread Hermes Wu
From: "Hermes.Wu" add AUX-I2C functionality to support MCCS. Change-Id: I63e1a0e5da67526f89f35605a82944be67dee8ac Signed-off-by: Hermes Wu --- drivers/gpu/drm/bridge/ite-it6505.c | 209 ++-- 1 file changed, 200 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/dr

Re: RESEND Re: [RFC PATCH] dma-buf/dma-fence: Use a successful read_trylock() annotation for dma_fence_begin_signalling()

2024-09-20 Thread Thomas Hellström
critical section itself doesn't block and could not cause a > > > > > > deadlock. > > > > > > > > > > > > So use a successful read_trylock() annotation instead for > > > > > > dma_fence_begin_signalling(). That will make sure that th

[PATCH v1 1/2] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-20 Thread Hermes Wu
From: allen chen Fix HDCP CTS items on UNIGRAF DPR-100. Change-Id: I03f0758779f73164c8ae2fdf61e41dc693e27605 Change-Id: Ib7a8fabaeccd56d3bd7c8adc7384a363b0f7b88d Signed-off-by: Hermes Wu --- drivers/gpu/drm/bridge/ite-it6505.c | 152 ++-- 1 file changed, 101 insertions

[PATCH v1 0/2] drm/bridge: it6505: update dp aux function

2024-09-20 Thread Hermes Wu
From: "Hermes.Wu" This series change aux function to support MCCS and fix HDCP CTS Hermes.Wu (1): drm/bridge: it6505: Add MSSC suport allen chen (1): drm/bridge: it6505: HDCP CTS fail on repeater items drivers/gpu/drm/bridge/ite-it6505.c | 343 +++- 1 file change

[PATCH 6/6] dt-bindings: display: samsung, exynos7-decon: add exynos7870 compatible

2024-09-20 Thread Kaustabh Chakraborty
Add the compatible string of Exynos7870 to the existing list. Signed-off-by: Kaustabh Chakraborty --- .../devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml| 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/samsung/sa

[PATCH 2/6] drm/exynos: exynos7_drm_decon: fix suspended condition in decon_commit()

2024-09-20 Thread Kaustabh Chakraborty
decon_commit() gets called during atomic_enable. At this stage, DECON is suspended, and thus the function refuses to run. Fix the suspended condition checking in decon_commit(). Signed-off-by: Kaustabh Chakraborty --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +- 1 file changed, 1 insertion

[PATCH 0/6] Samsung Exynos 7870 DECON driver support

2024-09-20 Thread Kaustabh Chakraborty
This patch series aims at adding support for Exynos7870's DECON in the Exynos7 DECON driver. It introduces a driver data struct so that support for DECON on other SoCs can be added to it in the future. It also fixes a few bugs in the driver, such as functions recieving bad pointers. Test

[PATCH 1/6] drm/exynos: exynos7_drm_decon: fix uninitialized crtc reference in functions

2024-09-20 Thread Kaustabh Chakraborty
decon_clear_channels() and decon_wait_for_vblank() accept a pointer to struct exynos_drm_crtc. However, these functions are called when the crtc is still uninitialized. Moreover, both functions use the pointer to retrieve and use struct decon_context, which is initialized. Modify the functions to

[PATCH 3/6] drm/exynos: exynos7_drm_decon: fix ideal_clk by converting it to Hz

2024-09-20 Thread Kaustabh Chakraborty
The clkdiv values are incorrect as ideal_clk is in kHz and the clock rate of vclk is in Hz. Multiply 1000 to ideal_clk to bring it to Hz. Signed-off-by: Kaustabh Chakraborty --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 4/6] drm/exynos: exynos7_drm_decon: properly clear channels during bind

2024-09-20 Thread Kaustabh Chakraborty
The DECON channels are not cleared properly as the windows aren't shadow protected. When accompanied with an IOMMU, it pagefaults, and the kernel panics. Implement shadow protect/unprotect, along with a standalone update, for channel clearing to properly take effect. Signed-off-by: Kaustabh Chakr

Re: [PATCH v1 2/4] acpi/x86: s2idle: handle screen off/on calls outside of suspend sequence

2024-09-20 Thread Antheas Kapenekakis
Hi, as noted in the cover letter, I think the connection to DRM is a red herring. The Display off callback in Windows is always called 5 seconds after the screen turns off due to inactivity or instantly if the user presses the power button. Likewise, Display on is called when the display is about

Re: [PATCH v1 1/2] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-20 Thread Pin-yen Lin
Hi Hermes, On Thu, Sep 19, 2024 at 5:20 PM Hermes Wu wrote: > > From: allen chen > > Fix HDCP CTS items on UNIGRAF DPR-100. > > Change-Id: I03f0758779f73164c8ae2fdf61e41dc693e27605 > > Change-Id: Ib7a8fabaeccd56d3bd7c8adc7384a363b0f7b88d Remove the Change-Id's as

Re: [PATCH v2 09/10] drm: bridge: dw_hdmi: Update EDID during hotplug processing

2024-09-20 Thread neil . armstrong
On 19/09/2024 22:34, Jonas Karlman wrote: Hi Neil, On 2024-09-13 10:02, Neil Armstrong wrote: On 08/09/2024 15:28, Jonas Karlman wrote: Update successfully read EDID during hotplug processing to ensure the connector diplay_info is always up-to-date. Signed-off-by: Jonas Karlman --- v2: No ch

Re: [PATCH v1 2/2] drm/bridge: it6505: Add MSSC suport

2024-09-20 Thread Pin-yen Lin
it6505_aux_do_transfer(struct it6505 > *it6505, > size_t size, enum aux_cmd_reply *reply) > { > int i, ret_size, ret = 0, request_size; > - struct device *dev = &it6505->client->dev; The drm-misc/drm-misc-next doe

Re: [PATCH] drm/amdgpu: Fix typo "acccess" and improve the comment style here

2024-09-19 Thread Christian König
Am 20.09.24 um 04:27 schrieb WangYuli: There are some spelling mistakes of 'acccess' in comments which should be instead of 'access'. And the comment style should be like this: /* * Text * Text */ Suggested-by: Christian König Link: https://lore.kernel.org/all/f75fbe30-528e-404f-97e

  1   2   3   4   5   6   7   8   9   10   >