Re: [PATCH v6 1/4] drm: Introduce device wedged event

2024-09-23 Thread Jani Nikula
On Mon, 23 Sep 2024, Andy Shevchenko wrote: > On Mon, Sep 23, 2024 at 05:35:23PM +0300, Raag Jadav wrote: >> On Mon, Sep 23, 2024 at 11:38:55AM +0300, Andy Shevchenko wrote: >> > On Mon, Sep 23, 2024 at 09:28:23AM +0530, Raag Jadav wrote: > > ... > >> > > +extern const char *const wedge_recovery_o

Re: [PATCH 1/6] fbcon: Make cursor_blink=0 work when configured before fb devices appear

2024-09-23 Thread Helge Deller
recent fbcon changes.... So, it's not a problem of your patch series. The whole interface is a bit of a mess. But I don't really see why anyone would want to use this on a per-fb device basis anyway. Either you want blinking stuff and extra power draw, or you don't. I think there

Re: [PATCH 1/6] fbcon: Make cursor_blink=0 work when configured before fb devices appear

2024-09-23 Thread Ville Syrjälä
On Mon, Sep 23, 2024 at 11:04:55PM +0200, Helge Deller wrote: > On 9/23/24 17:57, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently setting cursor_blink attribute to 0 before any fb > > devices are around does absolutely nothing. When fb devices appear > > and fbcon becomes active the

Re: [PATCH v2] drm/panel: elida-kd35t133: transition to mipi_dsi wrapped functions

2024-09-23 Thread Jessica Zhang
On 9/23/2024 5:25 AM, Tejas Vipin wrote: Changes the elida-kd35t133 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin Hi Tejas, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- Changes in v2: - Changed mipi_dsi_dcs_write to mipi_dsi_d

Re: [PATCH 1/6] fbcon: Make cursor_blink=0 work when configured before fb devices appear

2024-09-23 Thread Helge Deller
On 9/23/24 17:57, Ville Syrjala wrote: From: Ville Syrjälä Currently setting cursor_blink attribute to 0 before any fb devices are around does absolutely nothing. When fb devices appear and fbcon becomes active the cursor starts blinking. Fix the problem by recoding the desired state of the att

Re: [PATCH v2 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas panel timing

2024-09-23 Thread Jessica Zhang
On 9/23/2024 6:42 AM, Zhaoxiong Lv wrote: In MTK chips, if the system starts suspending before the DRM runtime resume has not completed, there is a possibility of a black screen after waking the machine. Reduce the disable delay resolves this issue, Hi Zhaoxiong, Do you mean "if the system

[PATCH v2 6/6] fbcon: Use 'bool' where appopriate

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Use 'bool' type where it makes more sense than 'int'. v2: Rebase due to corrected 'fbcon_cursor_blink' initial value Acked-by: Helge Deller Signed-off-by: Ville Syrjälä --- drivers/video/fbdev/core/fbcon.c | 23 --- 1 file changed, 12 insertions(+), 11

[PATCH v2 3/6] fbcon: fbcon_cursor_noblink -> fbcon_cursor_blink

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Invert fbcon_cursor_noblink into fbcon_cursor_blink so that: - it matches the sysfs attribute exactly - avoids having to do these NOT operations all over the place v2: Set the initial value to 1 to keep the same default behaviour (Helge) Cc: Helge Deller Signed-off-by:

Re: [PATCH v7 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-09-23 Thread Adrián Larumbe
On 23.09.2024 10:07, Steven Price wrote: >On 21/09/2024 00:43, Adrián Larumbe wrote: >> Enable calculations of job submission times in clock cycles and wall >> time. This is done by expanding the boilerplate command stream when running >> a job to include instructions that compute said times right

Re: [PATCH v6 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-09-23 Thread Adrián Larumbe
Hi Steve, On 23.09.2024 09:55, Steven Price wrote: >On 20/09/2024 23:36, Adrián Larumbe wrote: >> Hi Steve, thanks for the review. > >Hi Adrián, > >> I've applied all of your suggestions for the next patch series revision, so >> I'll >>

Re: [PATCH 3/6] fbcon: fbcon_cursor_noblink -> fbcon_cursor_blink

2024-09-23 Thread Ville Syrjälä
On Mon, Sep 23, 2024 at 09:46:03PM +0200, Helge Deller wrote: > On 9/23/24 17:57, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Invert fbcon_cursor_noblink into fbcon_cursor_blink so that: > > - it matches the sysfs attribute exactly > > - avoids having to do these NOT operations all over t

Re: [PATCH] drm/nouveau/i2c: rename aux.c and aux.h to auxch.c and auxch.h

2024-09-23 Thread Szőke Benjamin
0.c index 7d417f6a816e..5afc1bf8e798 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padgm200.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/padgm200.c @@ -22,7 +22,7 @@ * Authors: Ben Skeggs */ #include "pad.h" -#include "aux.h" +#include "auxch.h" #include "bus.h" static void @Ben Skeggs When it will be merged? Your hints was done and ready in this renaming patch.

Re: [PATCH 3/3] arm64: dts: qcom: sa8775p: Add gpu and gmu nodes

2024-09-23 Thread Akhil P Oommen
hader_link label in the DTSI file and then > reference it instead of using the subnode again. > > > + firmware-name = "qcom/sa8775p/a663_zap.mbn"; > > + }; > > +}; > > Separate patch, please. > > > + > > &i2c11 { > &g

Re: [PATCH 0/3] DRM/MSM: Support for Adreno 663 GPU

2024-09-23 Thread Akhil P Oommen
u sharing Vulkan CTS results? No. As of now there are no plans to run CTS. -Akhil > > > > > Patch (1) & (2) for Rob Clark and Patch (3) for Bjorn > > > > [0] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31211 > > > > To: Rob Clark >

Re: [PATCH 1/3] drm/msm/a6xx: Add support for A663

2024-09-23 Thread Akhil P Oommen
> > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > > @@ -541,6 +541,12 @@ static void a6xx_calc_ubwc_config(struct adreno_gpu > > *gpu) > > gpu->ubwc_config.macrotile_mode = 1; > > } > > > > + if (adreno_is_a663(gpu)) { > > +

Re: [PATCH 4/6] fbcon: fbcon_is_inactive() -> fbcon_is_active()

2024-09-23 Thread Helge Deller
On 9/23/24 17:57, Ville Syrjala wrote: From: Ville Syrjälä Invert fbcon_is_inactive() into fbcon_is_active(). Much easier on the poor brain when you don't have to do dobule negations all over the place. Agreed. Acked-by: Helge Deller Signed-off-by: Ville Syrjälä --- drivers/video/fbdev

Re: [PATCH 3/6] fbcon: fbcon_cursor_noblink -> fbcon_cursor_blink

2024-09-23 Thread Helge Deller
On 9/23/24 17:57, Ville Syrjala wrote: From: Ville Syrjälä Invert fbcon_cursor_noblink into fbcon_cursor_blink so that: - it matches the sysfs attribute exactly - avoids having to do these NOT operations all over the place Signed-off-by: Ville Syrjälä --- drivers/video/fbdev/core/fbcon.c |

Re: [PATCH 6/6] fbcon: Use 'bool' where appopriate

2024-09-23 Thread Helge Deller
On 9/23/24 17:57, Ville Syrjala wrote: From: Ville Syrjälä Use 'bool' type where it makes more sense than 'int'. Signed-off-by: Ville Syrjälä Looks good. Acked-by: Helge Deller Helge --- drivers/video/fbdev/core/fbcon.c | 23 --- 1 file changed, 12 insertions(+),

Re: [PATCH v4 09/11] drm/msm/A6XX: Add a flag to allow preemption to submitqueue_create

2024-09-23 Thread Akhil P Oommen
On Fri, Sep 20, 2024 at 10:29:44AM -0700, Rob Clark wrote: > On Fri, Sep 20, 2024 at 9:54 AM Akhil P Oommen > wrote: > > > > On Tue, Sep 17, 2024 at 01:14:19PM +0200, Antonino Maniscalco wrote: > > > Some userspace changes are necessary so add a flag for userspace to > > > advertise support for p

Re: [PATCH 5/6] fbcon: Introduce get_{fg,bg}_color()

2024-09-23 Thread Helge Deller
On 9/23/24 17:57, Ville Syrjala wrote: From: Ville Syrjälä Make the code more legible by adding get_{fg,bg}_color() which hide the obscure 'is_fg' parameter of get_color() from the caller. Signed-off-by: Ville Syrjälä Nice cleanup. Acked-by: Helge Deller --- drivers/video/fbdev/core/f

Re: [PATCH v3 1/6] drm: add DRM_SET_NAME ioctl

2024-09-23 Thread Dmitry Osipenko
On 9/23/24 21:09, Dmitry Osipenko wrote: >> Sure, I can do that if others prefer this way too. > Note that in the other email I suggested to use strndup_user(), that > will remove the name-length limitation, but then the name var will > remain to be a string pointer. To me best option would be to r

Re: [PATCH v3 1/6] drm: add DRM_SET_NAME ioctl

2024-09-23 Thread Dmitry Osipenko
On 9/23/24 19:29, Pierre-Eric Pelloux-Prayer wrote: ... >>> @@ -78,12 +78,13 @@ static int drm_clients_info(struct seq_file *m, >>> void *data) >>>   kuid_t uid; >>>     seq_printf(m, >>> -   "%20s %5s %3s master a %5s %10s\n", >>> +   "%20s %5s %3s master a %5s %10s %20s\n"

Re: [PATCH] dt-bindings: lcdif: Add support for specifying display with timings

2024-09-23 Thread Marek Vasut
On 9/23/24 3:57 PM, Lukasz Majewski wrote: Up till now the fsl,lcdif.yaml was requiring the "port" property as a must have to specify the display interface on iMX devices. However, it shall also be possible to specify the display only with passing its timing parameters (h* and v* ones) via "disp

Re: [PATCH v3 1/6] drm: add DRM_SET_NAME ioctl

2024-09-23 Thread Pierre-Eric Pelloux-Prayer
Hi Dmitry, Le 23/09/2024 à 12:28, Dmitry Osipenko a écrit : On 9/20/24 12:06, Pierre-Eric Pelloux-Prayer wrote: Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debugging. This is similar to the existing DMA_BUF_SET_NAME ioctl

[PATCH v7 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-09-23 Thread Alex Lanzano
Add support for the monochrome Sharp Memory LCDs. Co-developed-by: Mehdi Djait Signed-off-by: Mehdi Djait Signed-off-by: Alex Lanzano Reviewed-by: Dmitry Baryshkov --- MAINTAINERS | 6 + drivers/gpu/drm/tiny/Kconfig| 20 + drivers/gpu/drm/tiny/Makefile

[PATCH v7 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-09-23 Thread Alex Lanzano
Add device tree bindings for the monochrome Sharp Memory LCD Co-developed-by: Mehdi Djait Signed-off-by: Mehdi Djait Signed-off-by: Alex Lanzano Reviewed-by: Krzysztof Kozlowski --- .../bindings/display/sharp,ls010b7dh04.yaml | 92 +++ 1 file changed, 92 insertions(+) creat

[PATCH v7 0/2] Add driver for Sharp Memory LCD

2024-09-23 Thread Alex Lanzano
This patch series add support for the monochrome Sharp Memory LCD panels. This series is based off of the work done by Mehdi Djait. References: https://lore.kernel.org/dri-devel/71a9dbf4609dbba46026a31f60261830163a0b99.1701267411.git.mehdi.dj...@bootlin.com/ https://www.sharpsde.com/fileadmin

[PATCH 6/6] fbcon: Use 'bool' where appopriate

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Use 'bool' type where it makes more sense than 'int'. Signed-off-by: Ville Syrjälä --- drivers/video/fbdev/core/fbcon.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/

[PATCH 4/6] fbcon: fbcon_is_inactive() -> fbcon_is_active()

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Invert fbcon_is_inactive() into fbcon_is_active(). Much easier on the poor brain when you don't have to do dobule negations all over the place. Signed-off-by: Ville Syrjälä --- drivers/video/fbdev/core/fbcon.c | 30 +++--- 1 file changed, 15 insertio

[PATCH 5/6] fbcon: Introduce get_{fg,bg}_color()

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Make the code more legible by adding get_{fg,bg}_color() which hide the obscure 'is_fg' parameter of get_color() from the caller. Signed-off-by: Ville Syrjälä --- drivers/video/fbdev/core/fbcon.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-

[PATCH 3/6] fbcon: fbcon_cursor_noblink -> fbcon_cursor_blink

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Invert fbcon_cursor_noblink into fbcon_cursor_blink so that: - it matches the sysfs attribute exactly - avoids having to do these NOT operations all over the place Signed-off-by: Ville Syrjälä --- drivers/video/fbdev/core/fbcon.c | 8 1 file changed, 4 insertions(+

[PATCH 2/6] fbcon: Add sysfs attributes before registering the device

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Currently fbcon adds the attributes after registering the device, which means the attributes may not be there by the time udev gets the ADD uevent. Fix the race by switching over to device_create_with_groups(). With this one can reliably turn off the power wasting cursor blin

[PATCH 1/6] fbcon: Make cursor_blink=0 work when configured before fb devices appear

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Currently setting cursor_blink attribute to 0 before any fb devices are around does absolutely nothing. When fb devices appear and fbcon becomes active the cursor starts blinking. Fix the problem by recoding the desired state of the attribute even if no fb devices are present

[PATCH 0/6] fbcon: Fix 'cursor_blink' sysfs attribute

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Make the 'cursor_blink' sysfs attribute actually usable from udev rules. I also took the opportinity to some cleanups t the code after getting annoyed by it. Ville Syrjälä (6): fbcon: Make cursor_blink=0 work when configured before fb devices appear fbcon: Add sysfs a

Re: [PATCH 3/3] drm/rockchip: vop: Split rk3288-vop into big and lit

2024-09-23 Thread Krzysztof Kozlowski
;> .data = &rk3188_vop }, >>> + { .compatible = "rockchip,rk3288-vop-big", >>> + .data = &rk3288_vop_big }, >> >> Hm... that's not really needed. Instead of having three compatibles, you >> could keep "rk3288-vop"

Re: [PATCH 1/2] drm/sched: add WARN_ON and BUG_ON to drm_sched_fini

2024-09-23 Thread Christian König
Am 20.09.24 um 15:26 schrieb Philipp Stanner: On Fri, 2024-09-20 at 12:33 +0200, Christian König wrote: Am 20.09.24 um 10:57 schrieb Philipp Stanner: On Wed, 2024-09-18 at 15:39 +0200, Christian König wrote: Tearing down the scheduler with jobs still on the pending list can lead to use after f

[PATCH] drm/v3d: Use v3d_perfmon_find(..)

2024-09-23 Thread Christian Gmeiner
From: Christian Gmeiner Replace the open coded v3d_perfmon_find(..) with the real thing. Signed-off-by: Christian Gmeiner --- drivers/gpu/drm/v3d/v3d_perfmon.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d_perfmon.c b/drivers/gpu/drm/v3d/v3d_

Re: [PATCH v6 1/4] drm: Introduce device wedged event

2024-09-23 Thread Andy Shevchenko
On Mon, Sep 23, 2024 at 05:35:23PM +0300, Raag Jadav wrote: > On Mon, Sep 23, 2024 at 11:38:55AM +0300, Andy Shevchenko wrote: > > On Mon, Sep 23, 2024 at 09:28:23AM +0530, Raag Jadav wrote: ... > > > +extern const char *const wedge_recovery_opts[]; > > > > It's not NULL terminated. How users wi

Re: [PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-23 Thread Tvrtko Ursulin
Ping Christian and Philipp - reasonably happy with v2? I think it's the only unreviewed patch from the series. Regards, Tvrtko On 16/09/2024 18:30, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sc

Re: [PATCH v6 1/4] drm: Introduce device wedged event

2024-09-23 Thread Raag Jadav
On Mon, Sep 23, 2024 at 11:38:55AM +0300, Andy Shevchenko wrote: > On Mon, Sep 23, 2024 at 09:28:23AM +0530, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > > useful especially in ca

[PATCH v6 10/11] drm/v3d: Add modparam for turning off Big/Super Pages

2024-09-23 Thread Maíra Canal
Add a modparam for turning off Big/Super Pages to make sure that if an user doesn't want Big/Super Pages enabled, it can disabled it by setting the modparam to false. Signed-off-by: Maíra Canal Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/v3d/v3d_drv.c | 7 +++ drivers/gpu/drm/v3d/v3d_

[PATCH v6 09/11] drm/v3d: Use gemfs/THP in BO creation if available

2024-09-23 Thread Maíra Canal
Although Big/Super Pages could appear naturally, it would be quite hard to have 1MB or 64KB allocated contiguously naturally. Therefore, we can force the creation of large pages allocated contiguously by using a mountpoint with "huge=within_size" enabled. Therefore, as V3D has a mountpoint with "h

[PATCH v6 08/11] drm/v3d: Support Big/Super Pages when writing out PTEs

2024-09-23 Thread Maíra Canal
The V3D MMU also supports 64KB and 1MB pages, called big and super pages, respectively. In order to set a 64KB page or 1MB page in the MMU, we need to make sure that page table entries for all 4KB pages within a big/super page must be correctly configured. In order to create a big/super page, we n

[PATCH v6 06/11] drm/gem: Create shmem GEM object in a given mountpoint

2024-09-23 Thread Maíra Canal
Create a function `drm_gem_shmem_create_with_mnt()`, similar to `drm_gem_shmem_create()`, that has a mountpoint as a argument. This function will create a shmem GEM object in a given tmpfs mountpoint. This function will be useful for drivers that have a special mountpoint with flags enabled. Sign

[PATCH v6 07/11] drm/v3d: Reduce the alignment of the node allocation

2024-09-23 Thread Maíra Canal
rk2). Therefore, this patch reduces the alignment of the node allocation to 4 kB, which will allow RPi users to explore the whole 4GB virtual address space provided by the hardware. Also, this patch allow users to fully run vkoverhead in the RPi 4/5, solving the issue reported in [1]. [1] https://github.

[PATCH v6 05/11] drm/v3d: Introduce gemfs

2024-09-23 Thread Maíra Canal
Create a separate "tmpfs" kernel mount for V3D. This will allow us to move away from the shmemfs `shm_mnt` and gives the flexibility to do things like set our own mount options. Here, the interest is to use "huge=", which should allow us to enable the use of THP for our shmem-backed objects. Signe

[PATCH v6 11/11] drm/v3d: Expose Super Pages capability

2024-09-23 Thread Maíra Canal
Add a new V3D parameter to expose the support of Super Pages to userspace. The userspace might want to know this information to apply optimizations that are specific to kernels with Super Pages enabled. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_drv.c | 3 +++ include/uapi/drm/v3d_dr

[PATCH v6 04/11] drm/gem: Create a drm_gem_object_init_with_mnt() function

2024-09-23 Thread Maíra Canal
For some applications, such as applications that uses huge pages, we might want to have a different mountpoint, for which we pass mount flags that better match our usecase. Therefore, create a new function `drm_gem_object_init_with_mnt()` that allow us to define the tmpfs mountpoint where the GEM

[PATCH v6 03/11] drm/v3d: Fix return if scheduler initialization fails

2024-09-23 Thread Maíra Canal
If the scheduler initialization fails, GEM initialization must fail as well. Therefore, if `v3d_sched_init()` fails, free the DMA memory allocated and return the error value in `v3d_gem_init()`. Signed-off-by: Maíra Canal Reviewed-by: Iago Toral Quiroga --- drivers/gpu/drm/v3d/v3d_gem.c | 3 ++-

[PATCH v6 02/11] drm/v3d: Flush the MMU before we supply more memory to the binner

2024-09-23 Thread Maíra Canal
We must ensure that the MMU is flushed before we supply more memory to the binner, otherwise we might end up with invalid MMU accesses by the GPU. Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+") Signed-off-by: Maíra Canal Reviewed-by: Iago Toral Quiroga --- d

[PATCH v6 00/11] drm/v3d: Enable Big and Super Pages

2024-09-23 Thread Maíra Canal
version didn't add any new features to the series. It only addresses comments from the reviewers. That said, I added one more patch to expose the Super Pages capability to user-space through V3D parameters. This series also introduces changes in the GEM helpers, in order to enable V3D to have

[PATCH v6 01/11] drm/v3d: Address race-condition in MMU flush

2024-09-23 Thread Maíra Canal
We must first flush the MMU cache and then, flush the TLB, not the other way around. Currently, we can see a race condition between the MMU cache and the TLB when running multiple rendering processes at the same time. This is evidenced by MMU errors triggered by the IRQ. Fix the MMU flush order by

Re: [PATCH] dma-buf: Add syntax highlighting to code listings in the document

2024-09-23 Thread Christian König
t 11:00 AM Tommy Chiang wrote: Kindly ping :) On Fri, Jan 19, 2024 at 11:33 AM Tommy Chiang wrote: This patch tries to improve the display of the code listing on The Linux Kernel documentation website for dma-buf [1] . Originally, it appears that it was attempting to escape the '*'

Re: [PATCH v1 2/2] drm/panel: boe-th101mb31ig002: Modify Starry panel timing

2024-09-23 Thread Dmitry Baryshkov
; > > > > > > > Same comment as the one that I've provided to the other patch, plus: > > > > > > > > On Sun, 15 Sept 2024 at 10:11, Zhaoxiong Lv > > > > wrote: > > > > > > > > > > In order to me

[PATCH v2 2/2] drm/panel: boe-th101mb31ig002: Modify Starry panel timing

2024-09-23 Thread Zhaoxiong Lv
In MTK chips, if the system starts suspending before the DRM runtime resume has not completed, there is a possibility of a black screen after waking the machine. Reduce the disable delay resolves this issue, The "backlight_off_to_display_off_delay_ms" was added between "backlight off" and "disp

[PATCH v2 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas panel timing

2024-09-23 Thread Zhaoxiong Lv
In MTK chips, if the system starts suspending before the DRM runtime resume has not completed, there is a possibility of a black screen after waking the machine. Reduce the disable delay resolves this issue, The "backlight_off_to_display_off_delay_ms" was added between "backlight off" and "disp

[PATCH v2 0/2] Modify the timing of three panels

2024-09-23 Thread Zhaoxiong Lv
Modify the power-off sequence of the Kingdisplay/Starry/Melfas panel. Changes between V2 and V1: - PATCH 1/2: Modify the commit message -Modify the value of backlight_off_to_display_off_delay_ms. - PATCH 2/2: Modify the commit message. -Delete the value of

Re: [PATCH v1 2/2] drm/panel: boe-th101mb31ig002: Modify Starry panel timing

2024-09-23 Thread zhaoxiong lv
On Mon, Sep 23, 2024 at 8:07 PM Dmitry Baryshkov wrote: > > On Mon, Sep 23, 2024 at 05:22:20PM GMT, zhaoxiong lv wrote: > > On Mon, Sep 16, 2024 at 1:15 PM Dmitry Baryshkov > > wrote: > > > > > > Same comment as the one that I've provided to the other

Re: [PATCH v1 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas panel timing

2024-09-23 Thread zhaoxiong lv
; and "display off" to prevent "display off" from being > > executed when the backlight is not fully powered off, which may cause > > a white screen. However, we removed this > > "backlight_off_to_display_off_delay_ms" and found that this situation > &g

[PATCH v1 1/1] drm/mediatek: dp: Add sdp path reset

2024-09-23 Thread Liankun Yang
When using type-c to type-c to connect to the monitor, the sound plays normally. If you unplug the type-c and connect the type-c to hdmi dongle to the monitor, there will be noise. By capturing the audio data, it is found that the data position is messy, and there is no error in the data. Through

[PATCH v5 1/1] drm/mediatek: Fix get efuse issue for MT8188 DPTX

2024-09-23 Thread Liankun Yang
cchino Del Regno Signed-off-by: Liankun Yang --- Changes in V5: - No change. Per suggestion from the previous thread: https://patchwork.kernel.org/project/linux-mediatek/patch/20240905124041.3658-1-liankun.y...@mediatek.com/ Changes in V4: - Remove excess newlines. Per suggestion from the previ

Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-23 Thread Mark Brown
On Sat, Sep 21, 2024 at 01:00:52PM +, Winkler, Tomas wrote: > > On Thu, Sep 19, 2024 at 09:54:24AM +, Winkler, Tomas wrote: > > > > On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin wrote: > > Just do normal open coded allocations, the reference counting is just > > obscure. > T

Re: [PATCH v2] drm/panel: elida-kd35t133: transition to mipi_dsi wrapped functions

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 05:55:58PM GMT, Tejas Vipin wrote: > Changes the elida-kd35t133 panel to use multi style functions for > improved error handling. > > Signed-off-by: Tejas Vipin > --- > Changes in v2: > - Changed mipi_dsi_dcs_write to mipi_dsi_dcs_write_buffer_multi > - Cleaned up

Re: [PATCH] fbdev: pxa3xx-gcu: Convert comma to semicolon

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 02, 2024 at 03:57:24PM GMT, Chen Ni wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Chen Ni > --- > drivers/video/fbdev/pxa3xx-gcu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best

[PATCH v2] drm/panel: elida-kd35t133: transition to mipi_dsi wrapped functions

2024-09-23 Thread Tejas Vipin
Changes the elida-kd35t133 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- Changes in v2: - Changed mipi_dsi_dcs_write to mipi_dsi_dcs_write_buffer_multi - Cleaned up error handling Link to v1: https://lore.kernel.org/all/20240917071710.125

Re: [PATCH v2 0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

2024-09-23 Thread Dmitry Baryshkov
> >>>>>>>>>>>> DSI lanes > >>>>>>>>>>>> are not set up early enough by the DSI host, the driver > >>>>>>>>>>>> would break > >>>>>>>>>>>> with

Re: [PATCH] drm: writeback: Introduce drm managed helpers

2024-09-23 Thread Dmitry Baryshkov
writeback_connector_init or drm_writeback_connector_init_with_encoder. > > > Both of the function uses drm_connector_init and drm_encoder_init, but > > > there is no way to properly clean those structure from outside. By using > > > drm managed variants, we can ensure that the writeback connec

Re: [PATCH v1 2/2] drm/panel: boe-th101mb31ig002: Modify Starry panel timing

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 05:22:20PM GMT, zhaoxiong lv wrote: > On Mon, Sep 16, 2024 at 1:15 PM Dmitry Baryshkov > wrote: > > > > Same comment as the one that I've provided to the other patch, plus: > > > > On Sun, 15 Sept 2024 at 10:11, Zhaoxiong Lv > >

Re: [PATCH v1 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas panel timing

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 05:22:11PM GMT, zhaoxiong lv wrote: > On Mon, Sep 16, 2024 at 1:11 PM Dmitry Baryshkov > wrote: > > > > On Sun, 15 Sept 2024 at 10:10, Zhaoxiong Lv > > wrote: > > > > > > In order to meet the timing, remove the delay between "backlight off" > > > and "display off" > > > >

Re: [PATCH] drm: Consistently use struct drm_mode_rect for FB_DAMAGE_CLIPS

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 09:58:14AM GMT, Thomas Zimmermann wrote: > FB_DAMAGE_CLIPS is a plane property for damage handling. Its UAPI > should only use UAPI types. Hence replace struct drm_rect with > struct drm_mode_rect in drm_atomic_plane_set_property(). Both types > are identical in practice, so

Re: [PATCH v3 3/3] drm/bridge: it6505: Add MCCS support

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 05:48:29PM GMT, Hermes Wu wrote: > From: Hermes Wu > > Changes in v3: > -remove non used definition for aux i2x cmd reply > > Add Aux-I2C functionality to support MCCS. > > Signed-off-by: Hermes Wu > --- > drivers/gpu/drm/bridge/ite-it6505.c | 174

Re: [PATCH v3 2/3] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-23 Thread Dmitry Baryshkov
>> it6505 must read DRP-100 KSV FIFO by FIFO mode. > >> it6505 should restart HDCP within 5s if KSV not ready. > > > >Still not readable. > > > >English text, please. Split the patch to fix one issue at a time. > >Describe the _reason_ for the change. Annotat

Re: [PATCH v3 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 05:01:50PM GMT, Soutrik Mukhopadhyay wrote: > The Qualcomm SA8775P platform comes with 2 DisplayPort controllers > for each mdss, having different base offsets than the previous > SoCs. The support for all 4 DPTX have been added here, and > validation of MDSS0 DPTX0 and DPTX

Re: [PATCH v3 3/5] phy: qcom: edp: Add support for eDP PHY on SA8775P

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 05:01:48PM GMT, Soutrik Mukhopadhyay wrote: > Add support for eDP PHY v5 found on the Qualcomm SA8775P platform. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Soutrik Mukhopadhyay > --- > v2: Fixed review comments from Dmitry > - Reused edp_swing_hbr_rbr and ed

Re: [PATCH v3 2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 05:01:47PM GMT, Soutrik Mukhopadhyay wrote: > In order to support different HW versions, introduce aux_cfg array > to move v4 specific aux configuration settings. > > Signed-off-by: Soutrik Mukhopadhyay > --- > v2: Fixed review comments from Bjorn and Dmitry > - Made

RE: [PATCH v6 08/12] drm/i915/spi: add spi device for discrete graphics

2024-09-23 Thread Usyskin, Alexander
> Subject: Re: [PATCH v6 08/12] drm/i915/spi: add spi device for discrete > graphics > > On Mon, 16 Sep 2024, Alexander Usyskin > wrote: > > diff --git a/drivers/gpu/drm/i915/i915_drv.h > b/drivers/gpu/drm/i915/i915_drv.h > > index 39f6614a0a99..b9d4f9be5355 100644

[PATCH v3 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

2024-09-23 Thread Soutrik Mukhopadhyay
The Qualcomm SA8775P platform comes with 2 DisplayPort controllers for each mdss, having different base offsets than the previous SoCs. The support for all 4 DPTX have been added here, and validation of MDSS0 DPTX0 and DPTX1 have been conducted. Signed-off-by: Soutrik Mukhopadhyay --- v2: No chan

[PATCH v3 2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings

2024-09-23 Thread Soutrik Mukhopadhyay
In order to support different HW versions, introduce aux_cfg array to move v4 specific aux configuration settings. Signed-off-by: Soutrik Mukhopadhyay --- v2: Fixed review comments from Bjorn and Dmitry - Made aux_cfg array as const. v3: Fixed review comments from Dmitry - Used a

[PATCH v3 3/5] phy: qcom: edp: Add support for eDP PHY on SA8775P

2024-09-23 Thread Soutrik Mukhopadhyay
Add support for eDP PHY v5 found on the Qualcomm SA8775P platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Soutrik Mukhopadhyay --- v2: Fixed review comments from Dmitry - Reused edp_swing_hbr_rbr and edp_swing_hbr2_hbr3 for v5. v3: No change --- drivers/phy/qualcomm/phy-qcom-edp

[PATCH v3 1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p

2024-09-23 Thread Soutrik Mukhopadhyay
Add compatible string for the supported eDP PHY on sa8775p platform. Reviewed-by: Krzysztof Kozlowski Acked-by: Krzysztof Kozlowski Signed-off-by: Soutrik Mukhopadhyay --- v2: No change v3: No change --- Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 + 1 file changed, 1 inserti

[PATCH v3 4/5] dt-bindings: display: msm: dp-controller: document SA8775P compatible

2024-09-23 Thread Soutrik Mukhopadhyay
Add compatible string for the DisplayPort controller found on the Qualcomm SA8775P platform. Signed-off-by: Soutrik Mukhopadhyay --- v2: No change v3: No change --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentatio

[PATCH v3 0/5] Add support for DisplayPort on SA8775P platform

2024-09-23 Thread Soutrik Mukhopadhyay
This series adds support for the DisplayPort controller and eDP PHY v5 found on the Qualcomm SA8775P platform. --- v2: Fixed review comments from Dmitry and Bjorn - Made aux_cfg array as const. - Reused edp_swing_hbr_rbr and edp_swing_hbr2_hbr3 for v5. v3: Fixed review comments fr

Re: [PATCH v3 1/6] drm: add DRM_SET_NAME ioctl

2024-09-23 Thread Dmitry Osipenko
On 9/23/24 13:28, Dmitry Osipenko wrote: ... >> /** >> diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h >> index 16122819edfe..f5e92e4f909b 100644 >> --- a/include/uapi/drm/drm.h >> +++ b/include/uapi/drm/drm.h >> @@ -1024,6 +1024,13 @@ struct drm_crtc_queue_sequence { >> __u64 us

Re: [PATCH v3 4/6] drm/amdgpu: alloc and init vm::task_info from first submit

2024-09-23 Thread Tvrtko Ursulin
On 20/09/2024 10:06, Pierre-Eric Pelloux-Prayer wrote: This will allow to use flexible array to store the process name and other information. This also means that process name will be determined once and for all, instead of at each submit. But the pid and others can still change? By design?

Re: [PATCH] drm/panthor: Fix race when converting group handle to group object

2024-09-23 Thread Liviu Dudau
On Mon, Sep 23, 2024 at 11:34:06AM +0100, Steven Price wrote: > XArray provides it's own internal lock which protects the internal array > when entries are being simultaneously added and removed. However there > is still a race between retrieving the pointer from the XArray and > incrementing the r

RE: [PATCH v3 2/3] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-23 Thread Hermes.Wu
gt;> DUT must check BSTATUS when receive CP_IRQ. >> DUT must enable encryption when R0' is ready. >> DUT must retry V' check 3 times. >> it6505 must read DRP-100 KSV FIFO by FIFO mode. >> it6505 should restart HDCP within 5s if KSV not ready. > >Still not re

Re: [PATCH] drm/panthor: Fix race when converting group handle to group object

2024-09-23 Thread Boris Brezillon
On Mon, 23 Sep 2024 11:34:06 +0100 Steven Price wrote: > XArray provides it's own internal lock which protects the internal array > when entries are being simultaneously added and removed. However there > is still a race between retrieving the pointer from the XArray and > incrementing the refere

[PATCH] drm/panthor: Fix race when converting group handle to group object

2024-09-23 Thread Steven Price
XArray provides it's own internal lock which protects the internal array when entries are being simultaneously added and removed. However there is still a race between retrieving the pointer from the XArray and incrementing the reference count. To avoid this race simply hold the internal XArray lo

Re: [PATCH v3 1/6] drm: add DRM_SET_NAME ioctl

2024-09-23 Thread Dmitry Osipenko
On 9/20/24 12:06, Pierre-Eric Pelloux-Prayer wrote: > Giving the opportunity to userspace to associate a free-form > name with a drm_file struct is helpful for tracking and debugging. > > This is similar to the existing DMA_BUF_SET_NAME ioctl. > > Access to name is protected by a mutex, and the '

Re: [PATCH v3 3/6] drm/amdgpu: delay the use of amdgpu_vm_set_task_info

2024-09-23 Thread Tvrtko Ursulin
On 20/09/2024 10:06, Pierre-Eric Pelloux-Prayer wrote: At this point the vm is locked so we safely modify it without risk of concurrent access. To which particular lock this is referring to and does this imply previous placement was unsafe? Regards, Tvrtko Signed-off-by: Pierre-Eric Pel

Re: [PATCH v7 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-09-23 Thread Steven Price
On 23/09/2024 11:18, Boris Brezillon wrote: > On Mon, 23 Sep 2024 10:07:14 +0100 > Steven Price wrote: > >>> +static struct dma_fence * >>> +queue_run_job(struct drm_sched_job *sched_job) >>> +{ >>> + struct panthor_job *job = container_of(sched_job, struct panthor_job, >>> base); >>> + stru

Re: [PATCH v7 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-09-23 Thread Boris Brezillon
On Mon, 23 Sep 2024 10:07:14 +0100 Steven Price wrote: > > +static struct dma_fence * > > +queue_run_job(struct drm_sched_job *sched_job) > > +{ > > + struct panthor_job *job = container_of(sched_job, struct panthor_job, > > base); > > + struct panthor_group *group = job->group; > > + stru

Re: [PATCH v3 2/3] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-23 Thread Dmitry Baryshkov
cive CP_IRQ. > DUT must enable encription when R0' is ready. > DUT must retry V' check 3 times. > it6505 must read DRP-100 KSV FIFO by FIFO mode. > it6505 should restart HDCP within 5s if KSV not ready. Still not readable. English text, please. Split the patch to fix one issue at a

Re: [PATCH v3 1/3] drm/bridge: it6505: fix AUX read use aux fifo

2024-09-23 Thread Dmitry Baryshkov
CMD_AUX_I2C_EDID_READ = 0xB, > + > + /* KSV list read using AUX native read with FIFO */ > + CMD_AUX_GET_KSV_LIST = 0x10, Don't mix two changes in a single patch. There should be one patch fixing FIFO_MAX_SIDE (and then it should have Fixes tag) and another patch adding CMD_AUX_GET_K

Re: [PATCH v3 1/6] drm: add DRM_SET_NAME ioctl

2024-09-23 Thread Tvrtko Ursulin
On 20/09/2024 10:06, Pierre-Eric Pelloux-Prayer wrote: Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debugging. This is similar to the existing DMA_BUF_SET_NAME ioctl. Access to name is protected by a mutex, and the 'clien

[PATCH v3 2/3] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-23 Thread Hermes Wu
From: Hermes Wu Changes in v3: -add detials about fail item and changes. Fix HDCP CTS fail items on UNIGRAF DRP-100 DUT must Support 127 devices. DUT must check BSTATUS when recive CP_IRQ. DUT must enable encription when R0' is ready. DUT must retry V' check 3 times. it6505 must read DRP-100

Re: [PATCH] drm/msm/hdmi: drop pll_cmp_to_fdata from hdmi_phy_8998

2024-09-23 Thread Dmitry Baryshkov
On Sun, Sep 22, 2024 at 12:14:48AM GMT, Dmitry Baryshkov wrote: > The pll_cmp_to_fdata() was never used by the working code. Drop it to > prevent warnings with W=1 and clang. > > Reported-by: Jani Nikula > Closes: > https://lore.kernel.org/dri-devel/3553b1db35665e6ff08592e35eb438a574d1ad65.17259

Re: [PATCH] drm: writeback: Introduce drm managed helpers

2024-09-23 Thread Louis Chauvet
rm_connector_init and drm_encoder_init, but > > there is no way to properly clean those structure from outside. By using > > drm managed variants, we can ensure that the writeback connector is > > properly cleaned. > > > > This patch introduce drmm_writeback_conn

Re: [PATCH 1/2] drm/panthor: Add csg_priority to panthor_group

2024-09-23 Thread Steven Price
nthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -574,6 +574,13 @@ struct panthor_group { >*/ > int csg_id; > > + /** > + * @csg_id: Priority of the FW group slot. kerneldoc name is wrong: s/csg_id/csg_priority/ Otherwise th

Re: [PATCH 2/2] drm/panthor: Expose scheduler groups info in debugfs

2024-09-23 Thread Steven Price
On 18/09/2024 09:50, Mary Guillemard wrote: > This adds a new debugfs file named "sched_groups" allowing a user to > query information about all userspace clients scheduler groups. > > As we uses drm_device.filelist to achieve it, we also expose the > client_id with the task information to differe

  1   2   3   4   5   6   7   8   9   10   >