Re: [Dri-devel] Re: [Linux-fbdev-devel] DRM and pci_driver conversion

2003-10-24 Thread Linus Torvalds
[ Jeff: is that PCI ROM enable _really_ that complicated? Ouch. Or is there some helper function I missed? ] On Thu, 23 Oct 2003, Jon Smirl wrote: I don't think DRM drivers are doing things correctly yet. DRM is missing the code for marking PCI resources as being in use while DRM is using

Re: [Dri-devel] Radeon DRM memory layout transition

2003-10-24 Thread Ian Romanick
Jens Owen wrote: We can definitely remove the xf86drmCompat layer for XFree86 5.0. I believe it's well understood that major version changes will break existing binary interfaces. Oh goodie! There's a whole ton of crap that will get ripped out of lib/GL/glx/glx{cmds,ext}.c then! All of the

Re: [Dri-devel] Re: [Linux-fbdev-devel] DRM and pci_driver conversion

2003-10-24 Thread Eric Anholt
On Thu, 2003-10-23 at 16:23, Linus Torvalds wrote: [ Jeff: is that PCI ROM enable _really_ that complicated? Ouch. Or is there some helper function I missed? ] On Thu, 23 Oct 2003, Jon Smirl wrote: I don't think DRM drivers are doing things correctly yet. DRM is missing the code for

Re: [Dri-devel] Re: [Linux-fbdev-devel] DRM and pci_driver conversion

2003-10-24 Thread Linus Torvalds
On Thu, 23 Oct 2003, Jeff Garzik wrote: The mechanics aren't complicated, but I seem to recall there being a Real Good Reason why you want to leave it disabled 99% of the time. No, I don't recall that reason :( But my fuzzy memory seems to think that enable, grab a slice o 'rom,

Re: [Dri-devel] Re: [Linux-fbdev-devel] DRM and pci_driver conversion

2003-10-24 Thread Jon Smirl
Video drivers only enable the ROM long enough to get some values out it and then disable it. You don't want to leave ROMs enabled because there is some hardware that uses the same address decoder for ROM and RAM and you can't use them both at the same time. --- Jeff Garzik [EMAIL PROTECTED]

Re: [Dri-devel] Re: [Linux-fbdev-devel] DRM and pci_driver conversion

2003-10-24 Thread Jeff Garzik
On Fri, Oct 24, 2003 at 09:44:38AM -0700, Linus Torvalds wrote: So wouldn't it be nice if we just had those ten lines as a generic function like int pci_enable_rom(struct pci_device *dev) { ... int pci_disable_rom(..); Yes. Agreed, Jeff

Re: [Dri-devel] Re: [Linux-fbdev-devel] DRM and pci_driver conversion

2003-10-24 Thread Linus Torvalds
On Fri, 24 Oct 2003, Petr Vandrovec wrote: It would be nice if it works... For matrox hardware I have to map ROM over framebuffer (it is solution recommended by datasheet), as there is no way to get memory range allocated for ROM unless ROM was left enabled all the time. That's fine - it

Re: [Dri-devel] Re: [Linux-fbdev-devel] DRM and pci_driver conversion

2003-10-24 Thread Jon Smirl
PCI ROM enabale/disable has come up before on LKML. Russell made this comment about making the code more portable. --- Russell King [EMAIL PROTECTED] wrote: You should use pcibios_resource_to_bus() to convert a resource to a representation suitable for a BAR. http://lkml.org/lkml/2003/8/19/279

[Dri-devel] Re: new 2048 limit code...

2003-10-24 Thread Mike A. Harris
On Fri, 24 Oct 2003, Alex Deucher wrote: Unless anyone says otherwise, I'm going to remove this code. All it has done is generate complaints from MergedFB users. Apparently it doesn't hurt anything (ie. cause a crash) to leave direct rendering enabled if the virtual desktop is larger than 2048.