[PATCH 1/2] drm/fbdev: rework output polling to be back in the core. (v4)

2010-05-07 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com After thinking it over a lot it made more sense for the core to deal with the output polling especially so it can notify X. v2: drop plans for fake connector - per Michel's comments - fix X patch sent to xorg-devel, add intel polled/hpd setting, add initial

[patch -next] i915: remove unneeded null checks

2010-05-07 Thread Dan Carpenter
The encoder variable can never be null because it is used as loop cursor in a list_for_each_entry() loop. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index f6299bb..950dc8d 100644 ---

[patch -next] i915/intel_sdvo: remove unneeded null check

2010-05-07 Thread Dan Carpenter
The connector variable is used as the cursor in a list_for_each_entry() and it's always non-null so we don't need to check it. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index 42ceb15..179d146 100644 ---

Re: [patch] i915: missing unlock on error path

2010-05-07 Thread Jiri Slaby
On 05/07/2010 10:37 AM, Dan Carpenter wrote: There was a missing mutex_unlock(dev-struct_mutex) on this error path. Signed-off-by: Dan Carpenter erro...@gmail.com --- I thought Jiri sent this patch earlier but a google search for stanse struct_mutex i965_reset didn't find any patches, so

Re: drm_edid: potential range checking issue?

2010-05-07 Thread Dan Carpenter
Ping. This off-by-one overflow is still there in -next. I'm not sure how to fix it because both the declaraion and the use in add_detailed_modes() look deliberate. regards, dan carpenter On Sun, Mar 28, 2010 at 02:25:58PM +0300, Dan Carpenter wrote: Hi list, :) Just going through some

[patch] i915: missing unlock on error path

2010-05-07 Thread Dan Carpenter
There was a missing mutex_unlock(dev-struct_mutex) on this error path. Signed-off-by: Dan Carpenter erro...@gmail.com --- I thought Jiri sent this patch earlier but a google search for stanse struct_mutex i965_reset didn't find any patches, so I'm resending. diff --git

[patch -next] drm: dereferencing before checking for null

2010-05-07 Thread Dan Carpenter
The original code dereferences fb_helper_conn before verifying that it's non-null. Signed-off-by: Dan Carpenter erro...@gmail.com --- It's never null here actually. I could send a patch to remove the check instead if that's prefered. diff --git a/drivers/gpu/drm/drm_fb_helper.c

[patch -next] drm: off by one in drm_edid.c

2010-05-07 Thread Dan Carpenter
m == num_est3_modes is one past the end of the est3_modes[]. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 7188674..46447b0 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -1383,7 +1383,7 @@