Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-25 Thread Pavel Machek
On Thu 2015-01-29 14:11:25, Dave Airlie wrote: These two copy to/from VGA memory, however on the Silicon Motion SMI750 VGA card on a 64-bit system cause console corruption. This is due to the hw being buggy and not handling a 64-bit transaction correctly. We could try and create a 32-bit

Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-09 Thread Geert Uytterhoeven
On Mon, Feb 9, 2015 at 11:35 AM, Daniel Stone dan...@fooishbar.org wrote: On 5 February 2015 at 11:35, One Thousand Gnomes gno...@lxorguk.ukuu.org.uk wrote: If I'm not mistaken, that would be as simple as adding #define VT_BUF_HAVE_RW. #define scr_writew(val, addr) (*(addr) = (val))

Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-09 Thread One Thousand Gnomes
On Mon, 9 Feb 2015 11:00:55 + Daniel Stone dan...@fooishbar.org wrote: On 9 February 2015 at 10:49, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Mon, Feb 9, 2015 at 11:35 AM, Daniel Stone dan...@fooishbar.org wrote: On 5 February 2015 at 11:35, One Thousand Gnomes

Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-09 Thread Daniel Stone
On 9 February 2015 at 10:49, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Mon, Feb 9, 2015 at 11:35 AM, Daniel Stone dan...@fooishbar.org wrote: On 5 February 2015 at 11:35, One Thousand Gnomes gno...@lxorguk.ukuu.org.uk wrote: #if defined (CONFIG_SUPPORT_SHITE_VGA_ADAPTERS) #endif

Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-09 Thread Daniel Stone
On 5 February 2015 at 11:35, One Thousand Gnomes gno...@lxorguk.ukuu.org.uk wrote: If I'm not mistaken, that would be as simple as adding #define VT_BUF_HAVE_RW. #define scr_writew(val, addr) (*(addr) = (val)) #define scr_readw(addr) (*(addr)) to arch/x86/include/asm/vga.h.

Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-05 Thread Geert Uytterhoeven
On Tue, Feb 3, 2015 at 4:54 PM, One Thousand Gnomes gno...@lxorguk.ukuu.org.uk wrote: On Thu, 29 Jan 2015 15:40:33 -0800 Linus Torvalds torva...@linux-foundation.org wrote: On Wed, Jan 28, 2015 at 8:11 PM, Dave Airlie airl...@redhat.com wrote: Linus, this came up a while back I finally got

Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-05 Thread One Thousand Gnomes
If I'm not mistaken, that would be as simple as adding #define VT_BUF_HAVE_RW. #define scr_writew(val, addr) (*(addr) = (val)) #define scr_readw(addr) (*(addr)) to arch/x86/include/asm/vga.h. and stick an #if defined (CONFIG_SUPPORT_SHITE_VGA_ADAPTERS) #endif around that

Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-03 Thread One Thousand Gnomes
On Thu, 29 Jan 2015 15:40:33 -0800 Linus Torvalds torva...@linux-foundation.org wrote: On Wed, Jan 28, 2015 at 8:11 PM, Dave Airlie airl...@redhat.com wrote: Linus, this came up a while back I finally got some confirmation that it fixes those servers. I'm certainly ok with this. which

Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-01-29 Thread Linus Torvalds
On Wed, Jan 28, 2015 at 8:11 PM, Dave Airlie airl...@redhat.com wrote: Linus, this came up a while back I finally got some confirmation that it fixes those servers. I'm certainly ok with this. which way should it go in? The users are: - drivers/tty/vt/vt.c (Greg KH, tty layer) -

Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-01-29 Thread Greg Kroah-Hartman
On Thu, Jan 29, 2015 at 03:40:33PM -0800, Linus Torvalds wrote: On Wed, Jan 28, 2015 at 8:11 PM, Dave Airlie airl...@redhat.com wrote: Linus, this came up a while back I finally got some confirmation that it fixes those servers. I'm certainly ok with this. which way should it go in? The

Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-01-29 Thread Dave Airlie
On 30 January 2015 at 10:03, Linus Torvalds torva...@linux-foundation.org wrote: On Thu, Jan 29, 2015 at 3:57 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: I can take this through the tty tree, but can I put it in linux-next and wait for the 3.20 merge window to give people who

Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-01-29 Thread Linus Torvalds
On Thu, Jan 29, 2015 at 3:57 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: I can take this through the tty tree, but can I put it in linux-next and wait for the 3.20 merge window to give people who might notice a slow-down a chance to object? Yes. The problem only affects one (or a