Re: [patch] drm: sysfs files error handling

2010-03-30 Thread Dan Carpenter
On Sun, Mar 28, 2010 at 10:55:14PM +0200, Andi Kleen wrote: , Dan Carpenter wrote: In the original code we used j as an iterator but we used i as an index. - for (j = 0; j i; j++) - device_remove_file(connector-kdev, -connector_attrs[i]); I guess this

Re: [patch] drm: sysfs files error handling

2010-03-29 Thread Andi Kleen
, Dan Carpenter wrote: In the original code we used j as an iterator but we used i as an index. - for (j = 0; j i; j++) - device_remove_file(connector-kdev, -connector_attrs[i]); I guess this really should be a attribute group anyways? Typically when

[patch] drm: sysfs files error handling

2010-03-28 Thread Dan Carpenter
In the original code we used j as an iterator but we used i as an index. - for (j = 0; j i; j++) - device_remove_file(connector-kdev, - connector_attrs[i]); Smatch complained about that because i was potentially